GNU bug report logs - #35348
[PATCH] gnu: go@1.4: Update to 1.4-bootstrap-20171003.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35348 in the body.
You can then email your comments to 35348 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: go <at> 1.4: Update to 1.4-bootstrap-20171003.
Date: Sat, 20 Apr 2019 15:41:34 -0400

[Message part 1 (text/plain, inline)]

The Go bootstrap compiler in Guix currently includes a couple unnecessary workarounds for bugs which have already been fixed. This patch switches to using the bootstrap branch which is still maintained upstream.

-- 
Alex Griffin

[0001-gnu-go-1.4-Update-to-1.4-bootstrap-20171003.patch (text/x-patch, attachment)]

Message #8 received at 35348 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Alex Griffin" <a <at> ajgrf.com>, Leo Famulari <leo <at> famulari.name>
Cc: 35348 <at> debbugs.gnu.org
Subject: Re: [bug#35348] [PATCH] gnu: go <at> 1.4: Update to 1.4-bootstrap-20171003.
Date: Mon, 27 May 2019 16:29:59 +0200

Hello Alex,

"Alex Griffin" <a <at> ajgrf.com> skribis:

> The Go bootstrap compiler in Guix currently includes a couple unnecessary workarounds for bugs which have already been fixed. This patch switches to using the bootstrap branch which is still maintained upstream.

Leo, could you take a look at this patch?

  https://issues.guix.gnu.org/issue/35348

Thanks in advance,
Ludo’.

Message #11 received at 35348 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alex Griffin <a <at> ajgrf.com>
Cc: 35348 <at> debbugs.gnu.org
Subject: Re: [bug#35348] [PATCH] gnu: go <at> 1.4: Update to 1.4-bootstrap-20171003.
Date: Mon, 27 May 2019 13:33:02 -0400

[Message part 1 (text/plain, inline)]

On Sat, Apr 20, 2019 at 03:41:34PM -0400, Alex Griffin wrote:
> The Go bootstrap compiler in Guix currently includes a couple
> unnecessary workarounds for bugs which have already been fixed. This
> patch switches to using the bootstrap branch which is still maintained
> upstream.

Thanks for taking care of this!

How did you find this newer tarball? It doesn't appear at
<https://golang.org/dl/> or the Go GitHub page. Can you add a code
comment with a link and send a revised patch?

> From 4d784a54e5736d2eaeac2a6e9ed14c7d11598705 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a <at> ajgrf.com>
> Date: Sat, 20 Apr 2019 14:01:17 -0500
> Subject: [PATCH] gnu: go <at> 1.4: Update to 1.4-bootstrap-20171003.
> 
> * gnu/packages/golang.scm (go-1.4): Use the bootstrap branch that is
> still support upstream.
> [version]: Update to 1.4-bootstrap-20171003.
> [arguments]: Remove fix to timezone test which is now included upstream. Don't
> manually disable CGO because it is disabled by default. Manually enable test
> suite because future releases will disable tests by default.

LGTM.

I think the number of packages that will need to be rebuilt is small
enough that we can push this directly to the master branch, and this
update should not have any effect on the later compiler versions, but
did you check that major Go packages like mongo-tools, restic, and
Syncthing still build?

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 35348 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alex Griffin <a <at> ajgrf.com>
Cc: 35348 <at> debbugs.gnu.org
Subject: Re: [bug#35348] [PATCH] gnu: go <at> 1.4: Update to 1.4-bootstrap-20171003.
Date: Mon, 27 May 2019 13:38:02 -0400

[Message part 1 (text/plain, inline)]

On Mon, May 27, 2019 at 01:33:02PM -0400, Leo Famulari wrote:
> I think the number of packages that will need to be rebuilt is small
> enough that we can push this directly to the master branch, and this
> update should not have any effect on the later compiler versions, but
> did you check that major Go packages like mongo-tools, restic, and
> Syncthing still build?

I didn't realize you sent your patch so long ago... I will test these
things myself. But can you still let me know how you found the newer
tarball?

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 35348 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: "Leo Famulari" <leo <at> famulari.name>
Cc: 35348 <at> debbugs.gnu.org
Subject: Re: [bug#35348] [PATCH] gnu: go <at> 1.4: Update to 1.4-bootstrap-20171003.
Date: Mon, 27 May 2019 17:46:44 +0000

Hi Leo,

I found the tarball on [this page](https://golang.org/doc/install/source#go14). That's also the page to check for updates.

You can see the changes by looking at release-branch.go1.4 in git (https://github.com/golang/go/tree/release-branch.go1.4).

Thanks,
-- 
Alex Griffin

On Mon, May 27, 2019, at 5:38 PM, Leo Famulari wrote:
> On Mon, May 27, 2019 at 01:33:02PM -0400, Leo Famulari wrote:
> > I think the number of packages that will need to be rebuilt is small
> > enough that we can push this directly to the master branch, and this
> > update should not have any effect on the later compiler versions, but
> > did you check that major Go packages like mongo-tools, restic, and
> > Syncthing still build?
> 
> I didn't realize you sent your patch so long ago... I will test these
> things myself. But can you still let me know how you found the newer
> tarball?
> 
> Attachments:
> * signature.asc

Message #22 received at 35348-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alex Griffin <a <at> ajgrf.com>
Cc: 35348-done <at> debbugs.gnu.org
Subject: Re: [bug#35348] [PATCH] gnu: go <at> 1.4: Update to 1.4-bootstrap-20171003.
Date: Mon, 27 May 2019 14:27:25 -0400

[Message part 1 (text/plain, inline)]

On Mon, May 27, 2019 at 05:46:44PM +0000, Alex Griffin wrote:
> Hi Leo,
> 
> I found the tarball on [this page](https://golang.org/doc/install/source#go14). That's also the page to check for updates.
> 
> You can see the changes by looking at release-branch.go1.4 in git (https://github.com/golang/go/tree/release-branch.go1.4).

Thanks!

I added a comment and pushed your patch as
521d736ae97ef34f4e6136c7175a99c680c5ac95.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 35348-done <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: "Leo Famulari" <leo <at> famulari.name>
Cc: 35348-done <at> debbugs.gnu.org
Subject: Re: [bug#35348] [PATCH] gnu: go <at> 1.4: Update to 1.4-bootstrap-20171003.
Date: Wed, 29 May 2019 16:52:37 +0000

On Mon, May 27, 2019, at 6:27 PM, Leo Famulari wrote:
> I added a comment [...]

I don't know if it's worth another commit, but you misspelled "langauge" in your comment.

> and pushed your patch as 521d736ae97ef34f4e6136c7175a99c680c5ac95.

Thanks!
-- 
Alex Griffin

Message #28 received at 35348-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alex Griffin <a <at> ajgrf.com>
Cc: 35348-done <at> debbugs.gnu.org
Subject: Re: [bug#35348] [PATCH] gnu: go <at> 1.4: Update to 1.4-bootstrap-20171003.
Date: Fri, 31 May 2019 10:31:00 -0400

[Message part 1 (text/plain, inline)]

On Wed, May 29, 2019 at 04:52:37PM +0000, Alex Griffin wrote:
> I don't know if it's worth another commit, but you misspelled "langauge" in your comment.

Thanks, fixed in 9bc1de31348858278067a45c5965328677ee74d8

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.