GNU bug report logs - #35406
Build error for emacsclient on FreeBSD

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35406 in the body.
You can then email your comments to 35406 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josh Howard <jraitch <at> outlook.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Build error for emacsclient on FreeBSD
Date: Tue, 23 Apr 2019 23:26:05 +0000

It appears in a recent commit there was a change to emacsclient.c that breaks its ability to build on FreeBSD by using the euidaccess() function which doesn't exist on the platform.

CCLD     emacsclient
emacsclient.c:1475:11: warning: implicit declaration of function 'euidaccess' is
      invalid in C99 [-Wimplicit-function-declaration]
              && euidaccess (sockdirname, X_OK) == 0)
                 ^
1 warning generated.
/usr/bin/ld: error: undefined symbol: euidaccess
>>> referenced by emacsclient.c:1475
>>>               /tmp/emacsclient-a0b189.o:(set_local_socket)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake: *** [Makefile:399: emacsclient] Error 1

I'd propose it be switched to eaccess() which should be a synonym on Linux and makes it a bit more portable.

diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c
index 5871a18ce6..aac1b3c2b4 100644
--- a/lib-src/emacsclient.c
+++ b/lib-src/emacsclient.c
@@ -1472,7 +1472,7 @@ set_local_socket (char const *server_name)
          int sockdirnamelen = snprintf (sockdirname, sizeof sockdirname,
                                         "/run/user/%"PRIuMAX, id);
          if (0 <= sockdirnamelen && sockdirnamelen < sizeof sockdirname
-             && euidaccess (sockdirname, X_OK) == 0)
+             && eaccess (sockdirname, X_OK) == 0)
            message
              (true,
               ("%s: Should XDG_RUNTIME_DIR='%s' be in the environment?\n"

Message #8 received at 35406 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 35406 <at> debbugs.gnu.org, Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Josh Howard <jraitch <at> outlook.com>
Subject: Re: bug#35406: Build error for emacsclient on FreeBSD
Date: Wed, 24 Apr 2019 12:10:08 -0400

cc'ing the author of
http://lists.gnu.org/r/emacs-diffs/2019-04/msg00463.html

Josh Howard wrote:

> It appears in a recent commit there was a change to emacsclient.c that breaks its ability to build on FreeBSD by using the euidaccess() function which doesn't exist on the platform.
>
> CCLD     emacsclient
> emacsclient.c:1475:11: warning: implicit declaration of function 'euidaccess' is
>       invalid in C99 [-Wimplicit-function-declaration]
>               && euidaccess (sockdirname, X_OK) == 0)
>                  ^
> 1 warning generated.
> /usr/bin/ld: error: undefined symbol: euidaccess
>>>> referenced by emacsclient.c:1475
>>>>               /tmp/emacsclient-a0b189.o:(set_local_socket)
> cc: error: linker command failed with exit code 1 (use -v to see invocation)
> gmake: *** [Makefile:399: emacsclient] Error 1
>
> I'd propose it be switched to eaccess() which should be a synonym on Linux and makes it a bit more portable.
>
> diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c
> index 5871a18ce6..aac1b3c2b4 100644
> --- a/lib-src/emacsclient.c
> +++ b/lib-src/emacsclient.c
> @@ -1472,7 +1472,7 @@ set_local_socket (char const *server_name)
>           int sockdirnamelen = snprintf (sockdirname, sizeof sockdirname,
>                                          "/run/user/%"PRIuMAX, id);
>           if (0 <= sockdirnamelen && sockdirnamelen < sizeof sockdirname
> -             && euidaccess (sockdirname, X_OK) == 0)
> +             && eaccess (sockdirname, X_OK) == 0)
>             message
>               (true,
>                ("%s: Should XDG_RUNTIME_DIR='%s' be in the environment?\n"

Message #11 received at 35406 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Glenn Morris <rgm <at> gnu.org>, 35406 <at> debbugs.gnu.org
Cc: Josh Howard <jraitch <at> outlook.com>
Subject: Re: bug#35406: Build error for emacsclient on FreeBSD
Date: Wed, 24 Apr 2019 17:45:00 -0700

[Message part 1 (text/plain, inline)]

Josh Howard wrote:
> I'd propose it be switched to eaccess() which should be a synonym on Linux and makes it a bit more portable.
Sorry, I messed up. I should have used the POSIX-specified faccessat,
which has a Gnulib portability emulation for platforms lacking
faccessat. I installed the attached into master; please give it a try.

[euidaccess.patch (text/x-patch, attachment)]

Message #14 received at 35406 <at> debbugs.gnu.org (full text, mbox):

From: Josh Howard <jraitch <at> outlook.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>, Glenn Morris <rgm <at> gnu.org>,
 "35406 <at> debbugs.gnu.org" <35406 <at> debbugs.gnu.org>
Subject: Re: bug#35406: Build error for emacsclient on FreeBSD
Date: Thu, 25 Apr 2019 03:21:08 +0000

> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Sent: Wednesday, April 24, 2019 5:45 PM
> To: Glenn Morris; 35406 <at> debbugs.gnu.org
> Cc: Josh Howard
> Subject: Re: bug#35406: Build error for emacsclient on FreeBSD
> 
> Sorry, I messed up. I should have used the POSIX-specified faccessat,
> which has a Gnulib portability emulation for platforms lacking
> faccessat. I installed the attached into master; please give it a try.

Yep, this works fine. Thanks!

Message #19 received at 35406-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Josh Howard <jraitch <at> outlook.com>, Glenn Morris <rgm <at> gnu.org>,
 35406-done <at> debbugs.gnu.org
Subject: Re: bug#35406: Build error for emacsclient on FreeBSD
Date: Thu, 25 Apr 2019 15:15:58 -0700

On 4/24/19 8:21 PM, Josh Howard wrote:
>
> Yep, this works fine. Thanks!
>
Thanks for checking; closing the bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.