GNU bug report logs - #35467
[PATCH] Update Emacs packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35467 in the body.
You can then email your comments to 35467 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update Emacs packages
Date: Sun, 28 Apr 2019 01:48:05 +0200

[Message part 1 (text/plain, inline)]

See attached.

[Message part 2 (text/html, inline)]

[0002-gnu-emacs-avy-Update-to-4d52b5.patch (text/x-patch, attachment)]

[0001-gnu-emacs-hl-todo-Update-to-3.0.0.patch (text/x-patch, attachment)]

[0004-gnu-emacs-elfeed-Update-to-3.1.0.patch (text/x-patch, attachment)]

[0003-gnu-emacs-highlight-symbol-Update-to-7a789c.patch (text/x-patch, attachment)]

[0005-gnu-emacs-evil-nerd-commenter-Update-to-3.3.7.patch (text/x-patch, attachment)]

Message #8 received at 35467 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: 35467 <at> debbugs.gnu.org
Subject: [PATCH] Update Emacs packages.
Date: Sun, 5 May 2019 02:34:44 +0200

[Message part 1 (text/plain, inline)]

I forgot to lint, so I'm resubmitting these patches.

[Message part 2 (text/html, inline)]

[0001-gnu-emacs-highlight-symbol-Update-to-7a789c7.patch (text/x-patch, attachment)]

[0003-gnu-emacs-avy-Update-to-4d52b5c.patch (text/x-patch, attachment)]

[0005-gnu-emacs-evil-nerd-commenter-Update-to-3.3.7.patch (text/x-patch, attachment)]

[0002-gnu-emacs-hl-todo-Update-to-3.0.0.patch (text/x-patch, attachment)]

[0004-gnu-emacs-elfeed-Update-to-3.1.0.patch (text/x-patch, attachment)]

Message #11 received at 35467 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: "Brian Leung" <bkleung89 <at> gmail.com>
Cc: 35467 <at> debbugs.gnu.org
Subject: Re: [bug#35467] [PATCH] Update Emacs packages.
Date: Mon, 06 May 2019 17:01:24 +0200

Hi Brian,

thank you for these patches.

I have applied these files:

  0002-gnu-emacs-hl-todo-Update-to-3.0.0.patch
  0004-gnu-emacs-elfeed-Update-to-3.1.0.patch
  0005-gnu-emacs-evil-nerd-commenter-Update-to-3.3.7.patch

The other two patches update packages to unreleased versions, which we
usually avoid unless there’s a very good reason to pick a version
mid-release.

Could you tell us why the upgrades to emacs-highlight-symbol and
emacs-avy are needed?

--
Ricardo

Message #14 received at 35467 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>, 35467 <at> debbugs.gnu.org
Subject: Re: [bug#35467] [PATCH] Update Emacs packages.
Date: Mon, 20 May 2019 17:28:58 +0200

[Message part 1 (text/plain, inline)]

Friendly ping.

On Tue, May 14, 2019 at 1:36 AM Brian Leung <bkleung89 <at> gmail.com> wrote:

> Hi Ricardo,
>
> OK, it looks like emacs-avy received a version bump two days ago. I've
> modified the patches appropriately and rebased with Guix's latest master
> branch.
>
> Best,
> Brian
>
> On Mon, May 6, 2019 at 8:25 PM Brian Leung <bkleung89 <at> gmail.com> wrote:
>
>> Hi Ricardo,
>>
>> OK, I've made your suggested changes.
>>
>> For future reference, is it possible to edit a past commit message with
>> git fixup? I know how to edit the actual contents of past commits using git
>> fixup, but not their commit messages. For these two patches, I had to
>> manually make new commits.
>>
>> Best,
>> Brian
>>
>> On Mon, May 6, 2019 at 7:02 PM Ricardo Wurmus <rekado <at> elephly.net> wrote:
>>
>>>
>>> Hi Brian,
>>>
>>> > Thanks for your response. The release version of emacs-highlight-symbol
>>> > prints an occurrence count in the echo area upon hovering over a
>>> symbol,
>>> > which is annoying because it can drown out important messages from
>>> (say)
>>> > eldoc; this PR <https://github.com/nschum/highlight-symbol.el/pull/31
>>> >,
>>> > which is not included in the release version, fixes that. The last
>>> release
>>> > version of emacs-avy was from January 2016, and there have since been
>>> > slightly over 100 commits since then for various features and bug
>>> > fixes.
>>>
>>> I see.  It would be good to include this information as a comment so
>>> that people looking at this in the future understand why it was done.
>>>
>>> Please also change the commit message to state the actual version and
>>> not just a prefix of the commit hash.  Please use the version string
>>> that would be used by Guix (something like “1.2.3-1.cabbage”).
>>>
>>> --
>>> Ricardo
>>>
>>>

[Message part 2 (text/html, inline)]

[0001-gnu-emacs-highlight-symbol-Update-to-1.3.1-7a789c7.patch (text/x-patch, attachment)]

[0002-gnu-emacs-avy-Update-to-0.5.0.patch (text/x-patch, attachment)]

Message #17 received at 35467 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>, 35467 <at> debbugs.gnu.org
Subject: Re: [bug#35467] [PATCH] Update Emacs packages.
Date: Sat, 25 May 2019 06:50:34 +0200

[Message part 1 (text/plain, inline)]

I've added an update to emacs-lispy as well.

On Mon, May 20, 2019 at 5:28 PM Brian Leung <bkleung89 <at> gmail.com> wrote:

> Friendly ping.
>
> On Tue, May 14, 2019 at 1:36 AM Brian Leung <bkleung89 <at> gmail.com> wrote:
>
>> Hi Ricardo,
>>
>> OK, it looks like emacs-avy received a version bump two days ago. I've
>> modified the patches appropriately and rebased with Guix's latest master
>> branch.
>>
>> Best,
>> Brian
>>
>> On Mon, May 6, 2019 at 8:25 PM Brian Leung <bkleung89 <at> gmail.com> wrote:
>>
>>> Hi Ricardo,
>>>
>>> OK, I've made your suggested changes.
>>>
>>> For future reference, is it possible to edit a past commit message with
>>> git fixup? I know how to edit the actual contents of past commits using git
>>> fixup, but not their commit messages. For these two patches, I had to
>>> manually make new commits.
>>>
>>> Best,
>>> Brian
>>>
>>> On Mon, May 6, 2019 at 7:02 PM Ricardo Wurmus <rekado <at> elephly.net>
>>> wrote:
>>>
>>>>
>>>> Hi Brian,
>>>>
>>>> > Thanks for your response. The release version of
>>>> emacs-highlight-symbol
>>>> > prints an occurrence count in the echo area upon hovering over a
>>>> symbol,
>>>> > which is annoying because it can drown out important messages from
>>>> (say)
>>>> > eldoc; this PR <https://github.com/nschum/highlight-symbol.el/pull/31
>>>> >,
>>>> > which is not included in the release version, fixes that. The last
>>>> release
>>>> > version of emacs-avy was from January 2016, and there have since been
>>>> > slightly over 100 commits since then for various features and bug
>>>> > fixes.
>>>>
>>>> I see.  It would be good to include this information as a comment so
>>>> that people looking at this in the future understand why it was done.
>>>>
>>>> Please also change the commit message to state the actual version and
>>>> not just a prefix of the commit hash.  Please use the version string
>>>> that would be used by Guix (something like “1.2.3-1.cabbage”).
>>>>
>>>> --
>>>> Ricardo
>>>>
>>>>

[Message part 2 (text/html, inline)]

[0002-gnu-emacs-avy-Update-to-0.5.0.patch (text/x-patch, attachment)]

[0003-gnu-emacs-lispy-Update-to-0.27.0.patch (text/x-patch, attachment)]

[0001-gnu-emacs-highlight-symbol-Update-to-1.3.1-7a789c7.patch (text/x-patch, attachment)]

Message #22 received at 35467-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 35467-done <at> debbugs.gnu.org
Subject: Re: [bug#35467] [PATCH] Update Emacs packages.
Date: Sat, 25 May 2019 12:06:00 +0200

Hi Brian,

> I've added an update to emacs-lispy as well.

Thanks, I’ve pushed them with commit 7547648.

Note: there was a mistake in the version string for
emacs-highlight-symbol in the commit message, which I overlooked.  It
should have been 1.3-1.7a789c7, not 1.3.1-7a789c7.

--
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.