X-Loop: help-debbugs@HIDDEN Subject: [bug#35494] [PATCH] file-systems: Support the 'rel-atime' flag. Resent-From: Danny Milosavljevic <dannym@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Mon, 29 Apr 2019 18:57:02 +0000 Resent-Message-ID: <handler.35494.B.155656419419021 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 35494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 35494 <at> debbugs.gnu.org Cc: Danny Milosavljevic <dannym@HIDDEN> X-Debbugs-Original-To: guix-patches@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.155656419419021 (code B ref -1); Mon, 29 Apr 2019 18:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Apr 2019 18:56:34 +0000 Received: from localhost ([127.0.0.1]:39722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hLBS5-0004wi-3z for submit <at> debbugs.gnu.org; Mon, 29 Apr 2019 14:56:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dannym@HIDDEN>) id 1hLBS3-0004wU-Bl for submit <at> debbugs.gnu.org; Mon, 29 Apr 2019 14:56:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:33111) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <dannym@HIDDEN>) id 1hLBRv-00011T-F2 for submit <at> debbugs.gnu.org; Mon, 29 Apr 2019 14:56:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <dannym@HIDDEN>) id 1hLBRu-0002ja-FZ for guix-patches@HIDDEN; Mon, 29 Apr 2019 14:56:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <dannym@HIDDEN>) id 1hLBRs-000113-Bn for guix-patches@HIDDEN; Mon, 29 Apr 2019 14:56:22 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:53862) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <dannym@HIDDEN>) id 1hLBRo-00010G-OF for guix-patches@HIDDEN; Mon, 29 Apr 2019 14:56:18 -0400 Received: from dayas.3.home (178.112.141.112.wireless.dyn.drei.com [178.112.141.112]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 1A1B83360382; Mon, 29 Apr 2019 20:56:12 +0200 (CEST) From: Danny Milosavljevic <dannym@HIDDEN> Date: Mon, 29 Apr 2019 20:56:10 +0200 Message-Id: <20190429185610.14475-1-dannym@HIDDEN> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Tags: patch Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 85.13.145.193 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) * guix/build/syscalls.scm (MS_RELATIME): New variable. * gnu/build/file-systems.scm (mount-flags->bit-mask): Support it. * doc/guix.texi (File Systems): Document it. --- doc/guix.texi | 9 ++++++--- gnu/build/file-systems.scm | 2 ++ guix/build/syscalls.scm | 2 ++ 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index fcee57d9cd..20c9b570c9 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -10756,9 +10756,12 @@ corresponding device mapping established. This is a list of symbols denoting mount flags. Recognized flags include @code{read-only}, @code{bind-mount}, @code{no-dev} (disallow access to special files), @code{no-suid} (ignore setuid and setgid -bits), @code{no-atime} (do not update file access times), and @code{no-e= xec} -(disallow program execution). @xref{Mount-Unmount-Remount,,, libc, The = GNU C -Library Reference Manual}, for more information on these flags. +bits), @code{no-atime} (do not update file access times), +@code{rel-atime} (update file access time minimally), and +@code{no-exec} (disallow program execution). + +@xref{Mount-Unmount-Remount,,, libc, The GNU C Library Reference Manual}= , +for more information on these flags. =20 @item @code{options} (default: @code{#f}) This is either @code{#f}, or a string denoting mount options passed to t= he diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 8bb10d574d..06fdf0ccd8 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -577,6 +577,8 @@ corresponds to the symbols listed in FLAGS." (logior MS_NOEXEC (loop rest))) (('no-atime rest ...) (logior MS_NOATIME (loop rest))) + (('rel-atime rest ...) + (logior MS_RELATIME (loop rest))) (() 0)))) =20 diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm index 3316dc8dc5..5039003bcb 100644 --- a/guix/build/syscalls.scm +++ b/guix/build/syscalls.scm @@ -40,6 +40,7 @@ MS_NOEXEC MS_REMOUNT MS_NOATIME + MS_RELATIME MS_BIND MS_MOVE MS_STRICTATIME @@ -455,6 +456,7 @@ the returned procedure is called." (define MS_NOATIME 1024) (define MS_BIND 4096) (define MS_MOVE 8192) +(define MS_RELATIME 2097152) (define MS_STRICTATIME 16777216) =20 (define MNT_FORCE 1)
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Danny Milosavljevic <dannym@HIDDEN> Subject: bug#35494: Acknowledgement ([PATCH] file-systems: Support the 'rel-atime' flag.) Message-ID: <handler.35494.B.155656419419021.ack <at> debbugs.gnu.org> References: <20190429185610.14475-1-dannym@HIDDEN> X-Gnu-PR-Message: ack 35494 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 35494 <at> debbugs.gnu.org Date: Mon, 29 Apr 2019 18:57:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): guix-patches@HIDDEN If you wish to submit further information on this problem, please send it to 35494 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 35494: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35494 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: [bug#35494] [PATCH] file-systems: Support the 'rel-atime' flag. Resent-From: Tobias Geerinckx-Rice <me@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Mon, 29 Apr 2019 19:24:01 +0000 Resent-Message-ID: <handler.35494.B35494.155656583721735 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 35494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic <dannym@HIDDEN> Cc: 35494 <at> debbugs.gnu.org Received: via spool by 35494-submit <at> debbugs.gnu.org id=B35494.155656583721735 (code B ref 35494); Mon, 29 Apr 2019 19:24:01 +0000 Received: (at 35494) by debbugs.gnu.org; 29 Apr 2019 19:23:57 +0000 Received: from localhost ([127.0.0.1]:39772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hLBsa-0005eU-K6 for submit <at> debbugs.gnu.org; Mon, 29 Apr 2019 15:23:56 -0400 Received: from tobias.gr ([80.241.217.52]:41040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1hLBsW-0005eI-05 for 35494 <at> debbugs.gnu.org; Mon, 29 Apr 2019 15:23:55 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 2f0a468d; Mon, 29 Apr 2019 19:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:message-id:references:in-reply-to:date:mime-version :content-type; s=2018; i=me@HIDDEN; bh=XN8SnJ0DYRHdasn/9NkNhJ 8hIpQA9Td/ta7UpfBrS4U=; b=IztFcNlDVZNl4nSyOANII2t1vAm9M5M3uMYlhF A9/ESSGsEQKoj98aGQjaofFF2v4DP+duHi/QoSjBYlHmLnkd4nzKoDCNKUdGXL0B n4yvKr9r3X0En3etuc6To7J1JQu7S7ubGw5IWj9n96puscI6ENzjmC6Jrm9QVGLN niGAnRDS1iNOsLHMuWXZBbFMp1sFtCI1vZsSE84mIVx4sPEdi8F6TZaIe+Ao7nBc 5GIoHQr081AnA+TJGgTAFdmP4kGElf8K/wZHk2PL3B0g4j7FqJXbXntESGuNTtCU n6p9D7RuOCjhlgsSbgHcoTPFS01D3jFOl2DqmGL9HNXMTy+A== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 04e52bdb (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 29 Apr 2019 19:23:46 +0000 (UTC) From: Tobias Geerinckx-Rice <me@HIDDEN> Message-ID: <871s1kvcni.fsf@nckx> References: <20190429185610.14475-1-dannym@HIDDEN> In-reply-to: <20190429185610.14475-1-dannym@HIDDEN> Date: Mon, 29 Apr 2019 21:23:45 +0200 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Danny, Danny Milosavljevic wrote: > * guix/build/syscalls.scm (MS_RELATIME): New variable. > * gnu/build/file-systems.scm (mount-flags->bit-mask): Support=20 > it. > * doc/guix.texi (File Systems): Document it. > --- > doc/guix.texi | 9 ++++++--- > gnu/build/file-systems.scm | 2 ++ > guix/build/syscalls.scm | 2 ++ > 3 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/doc/guix.texi b/doc/guix.texi > index fcee57d9cd..20c9b570c9 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -10756,9 +10756,12 @@ corresponding device mapping=20 > established. > This is a list of symbols denoting mount flags. Recognized=20 > flags > include @code{read-only}, @code{bind-mount}, @code{no-dev}=20 > (disallow > access to special files), @code{no-suid} (ignore setuid and=20 > setgid > -bits), @code{no-atime} (do not update file access times), and=20 > @code{no-exec} > -(disallow program execution). @xref{Mount-Unmount-Remount,,,=20 > libc, The GNU C > -Library Reference Manual}, for more information on these flags. > +bits), @code{no-atime} (do not update file access times), > +@code{rel-atime} (update file access time minimally), and ^^^^^^^^^ That's a great way to explain it in 5 words, but note that there's=20 also =E2=80=98lazytime=E2=80=99 which does the same thing, only slightly le= ss so=20 :-) (How about adding that, too?) MHO: since we're adding a hyphen and not blindly following=20 upstream already, I think the symbol itself should be=20 =E2=80=98relative-atime=E2=80=99. Abbrevs r meh. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXMdPQQAKCRANsP+IT1Vt eVIlAQDyWSn8ndcW8bGQfDe/lwby6UebxPpHGVeqwYHcfYFhsgEA/WjB19Nw5RQt NAmk/JRIpk6jOWECa1nfn1RvNNnl+QY= =je61 -----END PGP SIGNATURE----- --=-=-=--
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.