GNU bug report logs - #35565
27.0.50; gnus-summary-widget-forward error with other frame

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35565 in the body.
You can then email your comments to 35565 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: 27.0.50; gnus-summary-widget-forward error with other frame
Date: Sat, 04 May 2019 19:05:47 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

[0001-Fix-Gnus-summary-widget-navigation-across-frames.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Since at least Emacs 24.4, the commands gnus-summary-widget-forward and
gnus-summary-widget-backward have been signalling an error in multiframe
configurations:

0. HOME=$(mktemp -d) emacs -Q
1. (progn (setq debug-on-error t
                gnus-select-method '(nntp "news.gwene.org"))
          (gnus-add-configuration
           '(article (frame 1.0
                            (summary 1.0 point frame-focus)
                            (article 1.0)))))
2. C-j
3. M-x gnus RET
4. s          [session only]
5. ^          [gnus-group-enter-server-mode]
6. n          [goto nntp:news.gwene.org]
7. RET        [gnus-server-read-server]
8. C-s gmane.emacs.devel RET
9. u          [gnus-browse-unsubscribe-current-group]
10. q         [gnus-browse-exit]
11. q         [gnus-server-exit]
12. RET 1 RET [gnus-group-select-group]
13. TAB       [gnus-summary-widget-forward]

Debugger entered--Lisp error: (wrong-type-argument window-live-p nil)
  select-window(nil)
  gnus-summary-widget-forward(1)
  funcall-interactively(gnus-summary-widget-forward 1)
  call-interactively(gnus-summary-widget-forward nil nil)
  command-execute(gnus-summary-widget-forward)

Is it okay to push the attached fix, which additionally simplifies the
subroutine gnus-get-buffer-window used by the two commands?

Thanks,

-- 
Basil

Gnus v5.13
In GNU Emacs 27.0.50 (build 14, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-05-04 built on thunk
Repository revision: b5376e0ebd7b62f00c1b64aef87cd8d96cfbc71a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12003000
System Description: Debian GNU/Linux buster/sid

Message #8 received at 35565 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: Katsumi Yamaoka <yamaoka <at> jpl.org>, 35565 <at> debbugs.gnu.org
Subject: Re: bug#35565: 27.0.50;
 gnus-summary-widget-forward error with other frame
Date: Sun, 05 May 2019 16:03:23 -0400

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Is it okay to push the attached fix, which additionally simplifies the
> subroutine gnus-get-buffer-window used by the two commands?

I have not tested the patch, but it does look reasonable to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 35565 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Katsumi Yamaoka <yamaoka <at> jpl.org>, 35565 <at> debbugs.gnu.org
Subject: Re: bug#35565: 27.0.50;
 gnus-summary-widget-forward error with other frame
Date: Sun, 05 May 2019 23:39:49 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> Is it okay to push the attached fix, which additionally simplifies the
>> subroutine gnus-get-buffer-window used by the two commands?
>
> I have not tested the patch, but it does look reasonable to me.

Thanks, I'll push in a few days if there are no objections before then.

-- 
Basil

Message #18 received at 35565-done <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Katsumi Yamaoka <yamaoka <at> jpl.org>, 35565-done <at> debbugs.gnu.org
Subject: Re: bug#35565: 27.0.50;
 gnus-summary-widget-forward error with other frame
Date: Sun, 12 May 2019 12:54:05 +0100

tags 35565 fixed
close 35565
quit

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>>
>>> Is it okay to push the attached fix, which additionally simplifies the
>>> subroutine gnus-get-buffer-window used by the two commands?
>>
>> I have not tested the patch, but it does look reasonable to me.
>
> Thanks, I'll push in a few days if there are no objections before then.

Done[1], so I'm closing this report.

[1: 571d802df3]: Fix Gnus summary widget navigation across frames
  2019-05-12 12:47:56 +0100
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=571d802df38cb1d3f93222f2977b766995616ac7

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.