GNU bug report logs - #35593
[PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35593 in the body.
You can then email your comments to 35593 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.
Date: Sun,  5 May 2019 23:43:54 +0200

Fixes <https://bugs.gnu.org/35582>.
Reported by sirgazil <sirgazil <at> zoho.com>.

* gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leading
zeroes.
---
 gnu/system/uuid.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/system/uuid.scm b/gnu/system/uuid.scm
index f13960c3e9..7204d163d0 100644
--- a/gnu/system/uuid.scm
+++ b/gnu/system/uuid.scm
@@ -175,7 +175,7 @@ ISO9660 UUID representation."
   "Convert FAT32/FAT16 UUID, a 4-byte bytevector, to its string representation."
   (let ((high  (bytevector-uint-ref uuid 0 %fat-endianness 2))
         (low (bytevector-uint-ref uuid 2 %fat-endianness 2)))
-    (format #f "~:@(~x-~x~)" low high)))
+    (format #f "~:@(~4,'0x-~4,'0x~)" low high)))
 
 (define %fat-uuid-rx
   (make-regexp "^([[:xdigit:]]{4})-([[:xdigit:]]{4})$"))

Message #10 received at 35593-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 35593-done <at> debbugs.gnu.org
Subject: Re: [bug#35593] [PATCH] uuid: Pad resulting FAT uuid string with
 leading zeroes.
Date: Thu, 09 May 2019 12:10:55 +0200

Hi Danny,

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> Fixes <https://bugs.gnu.org/35582>.
> Reported by sirgazil <sirgazil <at> zoho.com>.
>
> * gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leading
> zeroes.

Bah, I feel guilty: I pushed the same patch with a test as
6c5790a2faf8ffc401e43b13425a707394e40874, and only now do I notice that
you had fixed it too.  My apologies!

Perhaps in the future you should send the patch directly in the bug
report?  That would increase the likelihood that I’ll notice and won’t
duplicate work.

(Perhaps in the future I should also pay more attention to email…
tricky!)

Ludo’.

Message #13 received at 35593-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35593-done <at> debbugs.gnu.org
Subject: Re: [bug#35593] [PATCH] uuid: Pad resulting FAT uuid string with
 leading zeroes.
Date: Thu, 9 May 2019 14:46:04 +0200

[Message part 1 (text/plain, inline)]

Hi Ludo,

On Thu, 09 May 2019 12:10:55 +0200
Ludovic Courtès <ludo <at> gnu.org> wrote:

> > Fixes <https://bugs.gnu.org/35582>.
> > Reported by sirgazil <sirgazil <at> zoho.com>.
> >
> > * gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leading
> > zeroes.  
> 
> Bah, I feel guilty: I pushed the same patch with a test as
> 6c5790a2faf8ffc401e43b13425a707394e40874, and only now do I notice that
> you had fixed it too.  My apologies!

Don't worry.  It's good that someone fixes it, doesn't matter whether it's you
or me :)

> Perhaps in the future you should send the patch directly in the bug
> report?  That would increase the likelihood that I’ll notice and won’t
> duplicate work.

Sure!

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.