GNU logs - #35609, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#35609: 26.2; wdired-finish-edit clears find-dired listing
Resent-From: Alvaro Ramirez <alvaro@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 06 May 2019 21:20:05 +0000
Resent-Message-ID: <handler.35609.B.15571776029536 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 35609 <at> debbugs.gnu.org
User-agent: mu4e 1.2.0; emacs 26.2
From: Alvaro Ramirez <alvaro@HIDDEN>
Date: Fri, 03 May 2019 09:42:45 +0100
Message-ID: <m2a7g4udx6.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Editing a find-dired buffer (via wdired) clears the list of files after
saving changes.

Steps:

1. M-x find-dired RET
2. RET (empty or any find args should do)
3. C-x C-q (dired-toggle-read-only)
4. Rename any file.
5. C-c C-c (wdired-finish-edit)

Expected behavior: All files listed by find command should be listed in dired buffer.

Actual behavior: No files are listed.

More info: `revert-buffer-function' originally set by `find-dired' may
be lost by wdired when switching between wdired and dired mode.


In GNU Emacs 26.2 (build 1, x86_64-apple-darwin18.5.0, NS appkit-1671.40 Version 10.14.4 (Build 18E227))
 of 2019-05-03 built on taiyaki.local
Windowing system distributor 'Apple', version 10.3.1671
Recent messages:
find-dired *Find* finished.
Press C-c C-c when finished or C-c ESC to abort changes
Making completion list... [4 times]
user-error: Previous command was not a yank [2 times]
Quit [3 times]
Making completion list...
uncompressing wdired.el.gz...done
Mark saved where search started [2 times]
Mark set
Making completion list...

Configured using:
 'configure --disable-dependency-tracking --disable-silent-rules
 --enable-locallisppath=some/path/share/emacs/site-lisp
 --infodir=some/path/Cellar/emacs-plus/26.2/share/info/emacs
 --prefix=some/path/Cellar/emacs-plus/26.2 --with-xml2
 --without-dbus --with-gnutls --with-imagemagick --with-modules
 --with-rsvg --with-ns --disable-ns-self-contained'

Configured features:
JPEG RSVG IMAGEMAGICK GLIB NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS NS MODULES THREADS LCMS2

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr jka-compr thingatpt find-func emacsbug message
rmc puny format-spec rfc822 mml mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils dired-aux wdired shell
pcomplete comint ansi-color ring find-dired misearch multi-isearch
vc-git diff-mode easymenu easy-mmode map seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs elec-pair
time-date tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 221588 12374)
 (symbols 48 21417 1)
 (miscs 40 78 428)
 (strings 32 33343 1439)
 (string-bytes 1 907133)
 (vectors 16 37119)
 (vector-slots 8 753205 10098)
 (floats 8 52 262)
 (intervals 56 1173 16)
 (buffers 992 17))

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Alvaro Ramirez <alvaro@HIDDEN>
Subject: bug#35609: Acknowledgement (26.2; wdired-finish-edit clears
 find-dired listing)
Message-ID: <handler.35609.B.15571776029536.ack <at> debbugs.gnu.org>
References: <m2a7g4udx6.fsf@HIDDEN>
X-Gnu-PR-Message: ack 35609
X-Gnu-PR-Package: emacs
Reply-To: 35609 <at> debbugs.gnu.org
Date: Mon, 06 May 2019 21:20:05 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 35609 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
35609: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35609
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#35609: 26.2; wdired-finish-edit clears find-dired listing
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 09 Jul 2019 03:45:01 +0000
Resent-Message-ID: <handler.35609.B35609.156264386710909 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Alvaro Ramirez <alvaro@HIDDEN>
Cc: 35609 <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <m2a7g4udx6.fsf@HIDDEN>
Date: Tue, 09 Jul 2019 05:03:20 +0200
In-Reply-To: <m2a7g4udx6.fsf@HIDDEN> (Alvaro Ramirez's message of "Fri, 
 03 May 2019 09:42:45 +0100")
Message-ID: <87k1crewp3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Alvaro Ramirez <alvaro@HIDDEN> writes:

> Editing a find-dired buffer (via wdired) clears the list of files after
> saving changes.
>
> Steps:
>
> 1. M-x find-dired RET
> 2. RET (empty or any find args should do)
> 3. C-x C-q (dired-toggle-read-only)

In Emacs 27 (on GNU/Linux), it hangs there in

Debugger entered--Lisp error: (quit)
  looking-at("^. [0-9 \11]*[.,0-9]*[BkKMGTPEZY]?[ \11]*l[^:]")
  wdired-preprocess-symlinks()

So there's been further regressions in this area, I guess...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#35609: 26.2; wdired-finish-edit clears find-dired listing
In-Reply-To: <m2a7g4udx6.fsf@HIDDEN>
Resent-From: Stephen Berman <stephen.berman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 15 Jul 2019 10:55:02 +0000
Resent-Message-ID: <handler.35609.B35609.15631880921994 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Alvaro Ramirez <alvaro@HIDDEN>, 35609 <at> debbugs.gnu.org, Roland Winkler <winkler@HIDDEN>
From: Stephen Berman <stephen.berman@HIDDEN>
References: <m2a7g4udx6.fsf@HIDDEN> <87k1crewp3.fsf@HIDDEN>
Date: Mon, 15 Jul 2019 12:54:34 +0200
Message-ID: <87sgr7tvo5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Tue, 09 Jul 2019 05:03:20 +0200 Lars Ingebrigtsen <larsi@HIDDEN> wrot=
e:

> Alvaro Ramirez <alvaro@HIDDEN> writes:
>
>> Editing a find-dired buffer (via wdired) clears the list of files after
>> saving changes.
>>
>> Steps:
>>
>> 1. M-x find-dired RET
>> 2. RET (empty or any find args should do)
>> 3. C-x C-q (dired-toggle-read-only)
>
> In Emacs 27 (on GNU/Linux), it hangs there in
>
> Debugger entered--Lisp error: (quit)
>   looking-at("^. [0-9 \11]*[.,0-9]*[BkKMGTPEZY]?[ \11]*l[^:]")
>   wdired-preprocess-symlinks()
>
> So there's been further regressions in this area, I guess...

I don't have a fix for the find-dired listing being cleared, but the
hang is due to this change:

commit 249902d5ad5d3ae3e25323c23a2f442913729ceb
Author: Roland Winkler <winkler@HIDDEN>
Date:   Tue Jun 11 16:04:45 2019 -0500

    Allow refining the *Find* buffer of find-dired. (Bug#29513)

    * find-dired.el (find-dired-refine-function): New user variable.
    (find-dired-sentinel): Use it.  Simplify.
    (find-dired-sort-by-filename): New function.

Specifically, the change in find-dired-sentinel from this:

-		(insert "\n  find " state)
-		(forward-char -1)		;Back up before \n at end of STATE.
-		(insert " at " (substring (current-time-string) 0 19))

to this:

+                  (insert "\n  find "
+                          (substring state 0 -1) ; omit \n at end of STAT=
E.
+                          " at " (substring (current-time-string) 0 19))

Reverting this change (i.e. just these three lines) prevents the hang,
but it's not clear to me whether this was just meant to simplify the
code, as stated in the ChangeLog, or omitting the final newline is
needed for some find-dired use case.  Roland, can you elucidate?

However, independently of reverting or retaining the above lines, the
hang can also be prevented by changing wdired-preprocess-symlinks thus:

diff --git a/lisp/wdired.el b/lisp/wdired.el
index 0ccaaaca74..44f083bb7f 100644
=2D-- a/lisp/wdired.el
+++ b/lisp/wdired.el
@@ -677,8 +677,7 @@ wdired-preprocess-symlinks
 				 'rear-nonsticky '(read-only))
 	      (put-text-property (match-beginning 1)
 				 (match-end 1) 'read-only nil)))
-        (forward-line)
-	(beginning-of-line)))))
+        (forward-line)))))

 (defun wdired-get-previous-link (&optional old move)

These lines are at the end of a while (not (eobp)) loop and, unless I'm
overlooking something, prior to the change to find-dired-sentinel, the
use of beginning-of-line here was a noop, since forward-line always puts
point at BOL -- except when the buffer doesn't end with a newline, and
that's why the change to find-dired-sentinel caused the find-dired hang.
Thus, reverting the above three lines of the find-dired-sentinel change
makes beginning-of-line in wdired-preprocess-symlinks strictly a noop,
while retaining that change makes calling beginning-of-line harmful, so
in any case that call should removed.  Or does anyone see a problem with
that?

Steve Berman

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#35609: 26.2; wdired-finish-edit clears find-dired listing
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 15 Jul 2019 17:35:02 +0000
Resent-Message-ID: <handler.35609.B35609.156321204522437 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 35609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stephen Berman <stephen.berman@HIDDEN>
Cc: Alvaro Ramirez <alvaro@HIDDEN>, 35609 <at> debbugs.gnu.org, Roland Winkler <winkler@HIDDEN>
Received: via spool by 35609-submit <at> debbugs.gnu.org id=B35609.156321204522437
          (code B ref 35609); Mon, 15 Jul 2019 17:35:02 +0000
Received: (at 35609) by debbugs.gnu.org; 15 Jul 2019 17:34:05 +0000
Received: from localhost ([127.0.0.1]:48946 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hn4rU-0005pp-Lj
	for submit <at> debbugs.gnu.org; Mon, 15 Jul 2019 13:34:04 -0400
Received: from quimby.gnus.org ([80.91.231.51]:45916)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1hn4rQ-0005pL-Ee
 for 35609 <at> debbugs.gnu.org; Mon, 15 Jul 2019 13:34:03 -0400
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1hn4rE-0001eM-5Q; Mon, 15 Jul 2019 19:33:56 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <m2a7g4udx6.fsf@HIDDEN> <87k1crewp3.fsf@HIDDEN>
 <87sgr7tvo5.fsf@HIDDEN>
Date: Mon, 15 Jul 2019 19:33:46 +0200
In-Reply-To: <87sgr7tvo5.fsf@HIDDEN> (Stephen Berman's message of "Mon, 15
 Jul 2019 12:54:34 +0200")
Message-ID: <87muhfb3t1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Stephen Berman <stephen.berman@HIDDEN> writes: > -
 (forward-line)
 > - (beginning-of-line))))) > + (forward-line))))) > > (defun
 wdired-get-previous-link
 (&optional old move) > > These lines are at the end of a while (not (eobp))
 loop and, unless I [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stephen Berman <stephen.berman@HIDDEN> writes:

> -        (forward-line)
> -	(beginning-of-line)))))
> +        (forward-line)))))
>
>  (defun wdired-get-previous-link (&optional old move)
>
> These lines are at the end of a while (not (eobp)) loop and, unless I'm
> overlooking something, prior to the change to find-dired-sentinel, the
> use of beginning-of-line here was a noop, since forward-line always puts
> point at BOL -- except when the buffer doesn't end with a newline, and
> that's why the change to find-dired-sentinel caused the find-dired hang.
> Thus, reverting the above three lines of the find-dired-sentinel change
> makes beginning-of-line in wdired-preprocess-symlinks strictly a noop,
> while retaining that change makes calling beginning-of-line harmful, so
> in any case that call should removed.  Or does anyone see a problem with
> that?

Yes, I think you're right -- removing that beginning-of-line is the
correct thing, no matter what.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#35609: 26.2; wdired-finish-edit clears find-dired listing
Resent-From: "Roland Winkler" <winkler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 15 Jul 2019 18:38:02 +0000
Resent-Message-ID: <handler.35609.B35609.156321585822638 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 35609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Alvaro Ramirez <alvaro@HIDDEN>, Stephen Berman <stephen.berman@HIDDEN>, 35609 <at> debbugs.gnu.org
Received: via spool by 35609-submit <at> debbugs.gnu.org id=B35609.156321585822638
          (code B ref 35609); Mon, 15 Jul 2019 18:38:02 +0000
Received: (at 35609) by debbugs.gnu.org; 15 Jul 2019 18:37:38 +0000
Received: from localhost ([127.0.0.1]:49076 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hn5qz-0005t4-Ul
	for submit <at> debbugs.gnu.org; Mon, 15 Jul 2019 14:37:38 -0400
Received: from eggs.gnu.org ([209.51.188.92]:47904)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <winkler@HIDDEN>) id 1hn5qy-0005sm-4u
 for 35609 <at> debbugs.gnu.org; Mon, 15 Jul 2019 14:37:36 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:54007)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <winkler@HIDDEN>)
 id 1hn5qr-0001hM-V9; Mon, 15 Jul 2019 14:37:30 -0400
Received: from dyndsl-091-096-196-205.ewe-ip-backbone.de
 ([91.96.196.205]:46410 helo=regnitz)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <winkler@HIDDEN>)
 id 1hn5qr-0004Hp-8W; Mon, 15 Jul 2019 14:37:29 -0400
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <51165.94861.998973.23852@HIDDEN>
Date: Mon, 15 Jul 2019 13:37:17 -0500
From: "Roland Winkler" <winkler@HIDDEN>
In-Reply-To: <87muhfb3t1.fsf@HIDDEN>
References: <m2a7g4udx6.fsf@HIDDEN> <87k1crewp3.fsf@HIDDEN>
 <87sgr7tvo5.fsf@HIDDEN> <87muhfb3t1.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On Mon Jul 15 2019 Lars Ingebrigtsen wrote:
> Yes, I think you're right -- removing that beginning-of-line is the
> correct thing, no matter what.

Agreed.  (These parts of my recent changes were my attempt to
streamline / simplify these parts of the code.  If some part of my
new code doesn't do what it needs to do, it means that I overlooked
something.)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#35609: 26.2; wdired-finish-edit clears find-dired listing
Resent-From: Stephen Berman <stephen.berman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 16 Jul 2019 09:11:02 +0000
Resent-Message-ID: <handler.35609.B35609.156326822025896 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 35609
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: "Roland Winkler" <winkler@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 35609 <at> debbugs.gnu.org, Alvaro Ramirez <alvaro@HIDDEN>
Received: via spool by 35609-submit <at> debbugs.gnu.org id=B35609.156326822025896
          (code B ref 35609); Tue, 16 Jul 2019 09:11:02 +0000
Received: (at 35609) by debbugs.gnu.org; 16 Jul 2019 09:10:20 +0000
Received: from localhost ([127.0.0.1]:49624 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hnJTY-0006jc-G7
	for submit <at> debbugs.gnu.org; Tue, 16 Jul 2019 05:10:20 -0400
Received: from mout.gmx.net ([212.227.15.19]:55309)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1hnJTV-0006jJ-2h
 for 35609 <at> debbugs.gnu.org; Tue, 16 Jul 2019 05:10:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1563268200;
 bh=iUNHbw2RuZ5FvlA+ABtxskAXvxC70wf59iWIrpVXTIk=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=BLVIgbebuBHPSLq8J2E/GgddewCZM7c5KSjuvSFBfhJ2kxUI1htfOwz+5edoF7Cyz
 QibBDRRMLsw/HYCrGCj6oikszgylGndIeMpinyUgMh1nsYDAQLdfJT50K2cqdp5ofl
 zfUirO+P/yvwZGLqqS8SMChXNQrDKOc+wMaMcVmI=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-lfs84 ([84.61.247.220]) by mail.gmx.com (mrgmx001
 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MO77c-1hqajM0mUG-005bnb; Tue, 16
 Jul 2019 11:10:00 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
References: <m2a7g4udx6.fsf@HIDDEN> <87k1crewp3.fsf@HIDDEN>
 <87sgr7tvo5.fsf@HIDDEN> <87muhfb3t1.fsf@HIDDEN>
 <51165.94861.998973.23852@HIDDEN>
Date: Tue, 16 Jul 2019 11:09:55 +0200
In-Reply-To: <51165.94861.998973.23852@HIDDEN> (Roland Winkler's
 message of "Mon, 15 Jul 2019 13:37:17 -0500")
Message-ID: <87muhebb18.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:dobE9rplgO6HW/cn1KeUmExstprMyNfYD1j15PviZftLfUpJD95
 w4wGzfLf82QoVMHqJuLgRRIGYMjUs9msrZl6Ln9vTmisrA1+hGQ70or0wqGrp6MYsX8QVxh
 9Qqpe8KB96QkTGSgQWiEWeitutepkpjXjkjUxKaUW/tRev/zpXj8qjA3KZ3ugw2YnX9DhNV
 l8D+WLUXaqJLCiJJQPvFg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:kxl7QnGDZVA=:G4M5xzW3VDmNPRTIQcfYAD
 6bi2BJa6N1jiV6avF4sj4WvFwB9oHh9msnDBcm0AaXsHGw4slFeHEm+CZUaw9bbfaIHqXh+sm
 NINviemwcjLZEF/gdUALOTgQH9w1U6PbH0jmg7VuPzHi/4+PGKKQwd4jzNhOTq7kgXaYiiKCw
 F6etIvfLQQKr57vlohc/fmv2mXh3Dc5lz9l70SDy4H68TdF4uVhKx4yYTbgQjmPw8Qcb0Qm+H
 KNrtWWJDkOAIPttU1Mh0kGSw1OV/tgs8gFyTta2UuewYAbGB+8lmYPy85R7mKHv3w8Ww/bXcx
 A6DgBmIZjyfqfsfpsUFWTW7ZQ3A/0vmiyNh4xG2tyE/BsV4kbNX+fw+kurzskOcx0e7UgyxZN
 ymDyqvwEY4w4AsnxDkmrXN75bN8npuxMi+tK7KOlsSUJ5WJEOd6vmYyxD1cHkNAy/fn0/W1z1
 vCtLtsPDd05crJuV6rxrT1dpN8qiVbNNS5kkO4USwJknp6qZHCVtjZSQOK+ypX6N/2p8/o30B
 /3Lc/R1nvRV42LbRsFy/Y/44wcZLM2wmA+hUuuVr3hSojvFydNEIJvfzKCXqI7OkxbMVLCpHS
 qUNHWoJ35ioZvr576YYBnvze16HxxKrwW4lssb73vDl42AHKI8wof5Sv9JzVymEHM/bGqsVhA
 AC7VyMPVxEUvXOEz1yzI4bQY4fSZznu0i3A0hoJr3Hn7s9YVMcEkaaVP3TeE0xQKwGwKzcvQg
 qGfWVJ+Fgy4KTSHEidd9zrdixqgRWncn+0dVqhbxBbB14zkvXCQD9a5rUtCSdnjMLdn2AighX
 DJ1+XoRVvqslVy5ySpVmu0uJnxkA9w1j4hX/MJmqCpP5fRBdTHfVpHh9eiLfqJfaLdDhRMJPr
 hSMsdtY2iA6iB08CnPuDWMm6rDGT8liF1d9MOHDytboKS2pbCgDje7BdO3Dx4ot/0LUmuaBBR
 2DKNn4enDIoq5++2Ko8tL/5zl0fmW97JVF2Hs5X6CjqGIzxnqpbK0vz4luzJiXjBNyyE4L+Pf
 CcEGrGSejLeeu+0k4Exn44rOFguK42Nn2eBQie7gzRbThhvNjS3T9/b5ibPjvqZun1DlyYtay
 1T9md4Kq8VXu2z0mX7G7T0sFiJKzhO0AmPO
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Mon, 15 Jul 2019 13:37:17 -0500 "Roland Winkler" <winkler@HIDDEN> wrote:

> On Mon Jul 15 2019 Lars Ingebrigtsen wrote:
>> Yes, I think you're right -- removing that beginning-of-line is the
>> correct thing, no matter what.
>
> Agreed.  (These parts of my recent changes were my attempt to
> streamline / simplify these parts of the code.  If some part of my
> new code doesn't do what it needs to do, it means that I overlooked
> something.)

Ok, I pushed that change to master (288e83ae00).  I referenced this bug
thread but of course the bug should not be closed yet.

Steve Berman

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.