GNU bug report logs - #35653
[PATCH] gnu: Add rcm.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Josh Holland <josh@HIDDEN>; Keywords: patch; dated Thu, 9 May 2019 15:40:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 35653 <at> debbugs.gnu.org:


Received: (at 35653) by debbugs.gnu.org; 9 May 2019 17:59:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 09 13:59:49 2019
Received: from localhost ([127.0.0.1]:36351 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hOnKa-00016m-Ta
	for submit <at> debbugs.gnu.org; Thu, 09 May 2019 13:59:49 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56061)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <josh@HIDDEN>) id 1hOnKZ-00016N-0f
 for 35653 <at> debbugs.gnu.org; Thu, 09 May 2019 13:59:43 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id D5254245B9;
 Thu,  9 May 2019 13:59:37 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Thu, 09 May 2019 13:59:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inv.alid.pw; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding; s=mesmtp;
 bh=M0oKJ7OYCkmB2cmn4DGEeXLPNr18OYOsJ+/D/SEdVq8=; b=KmkbBSIu3Hl+
 QiUrupubTHnzrkG8+V7A26NXdXwr3mm2f6kasC3axeNfd0ihKEYP3uTCMJXH14Bd
 XNSVroGZolWjhVVN3GcRu+srVbCe1yfOfEKl3NEwrck/BSEFzG39see+H4vn8hoA
 KT0jMx9AWFkJ/0wTda2Be6bKcaoP4y4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=M0oKJ7OYCkmB2cmn4DGEeXLPNr18OYOsJ+/D/SEdV
 q8=; b=prjWTJjvq32bSXcaztHI5qsy1BvtUI3Br4Mh93wblJHBHX+xjYbg3y99l
 Twod/6LMvGgEAVTvG+uIz41zXwHZt9SaaHfHStyyV1WFLyX48CE2pvQYaDEpCwvE
 8/8YkvWNVorZMXfJ02zDkueiBINf4J5VU2hNK80Q5CyZhYNvotAU2N4c02NHZ7sW
 Aq8gjKKR8jdB9yDyKRyo0pgVeBU6CLXufl0i1eOLbcTHtehcSCtFL87bKuFmVY86
 bUbj/yqqwhEGXUFU5Xu22VJyK2XBGfh0xZoeJNypQY1pmnNPPaSU/ydMQ3lnRuVQ
 MFYLW8sJyqwzqYmE6cYmeG+iSki5Q==
X-ME-Sender: <xms:iWrUXFFIRcxhpRyh4uku9S4oXXUTOPb3LJbor93GQhh-fDU9QC00Kg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdehkecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenog
 fuuhhsphgvtghtffhomhgrihhnucdlgeelmdenfghrlhcuvffnffculdejmdenucfjughr
 pefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeflohhshhcujfholh
 hlrghnugcuoehjohhshhesihhnvhdrrghlihgurdhpfieqnecuffhomhgrihhnpehgihht
 hhhusgdrihhopdhgihhthhhusgdrtghomhdpghhnuhdrohhrghenucfkphepudeliedrhe
 dvrdekgedrvdeinecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhshhesihhnvhdrrghl
 ihgurdhpfienucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:iWrUXKch4GPT0FCvYO67K9w_AyPDT4C_UaiDEpjNuVaLQvNxS6DBHw>
 <xmx:iWrUXOly00Omy4hkeqTA2NOFLNfcvlx9BVALpaXOsHw6CT50tk6DHg>
 <xmx:iWrUXBrj14MmnMgzX6Ec50buTWPAHEqy4Lq7Zn6TmWlEbgibBwDDuQ>
 <xmx:iWrUXCQSvGReO1fBu2XkHeGhFiV4W0iUi_s5Rv5DR8QDng4zW5dorw>
Received: from localhost.localdomain
 (ip-26-84-52-196.southampton.uk.amsterdamresidential.com [196.52.84.26])
 by mail.messagingengine.com (Postfix) with ESMTPA id B78598005A;
 Thu,  9 May 2019 13:59:36 -0400 (EDT)
From: Josh Holland <josh@HIDDEN>
To: Danny Milosavljevic <dannym@HIDDEN>
Subject: [PATCH v2] gnu: Add rcm.
Date: Thu,  9 May 2019 18:59:16 +0100
Message-Id: <20190509175916.22479-2-josh@HIDDEN>
X-Mailer: git-send-email 2.21.0
In-Reply-To: <20190509175916.22479-1-josh@HIDDEN>
References: <20190509185256.309d9b63@HIDDEN>
 <20190509175916.22479-1-josh@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 35653
Cc: 35653 <at> debbugs.gnu.org, Josh Holland <josh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

* gnu/packages/rcm.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add rcm.scm.
---
 gnu/local.mk         |  1 +
 gnu/packages/rcm.scm | 62 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 gnu/packages/rcm.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 3f97397c4a..0789d74f78 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -398,6 +398,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/ragel.scm			\
   %D%/packages/rails.scm			\
   %D%/packages/ratpoison.scm			\
+  %D%/packages/rcm.scm				\
   %D%/packages/rdesktop.scm			\
   %D%/packages/rdf.scm				\
   %D%/packages/re2c.scm				\
diff --git a/gnu/packages/rcm.scm b/gnu/packages/rcm.scm
new file mode 100644
index 0000000000..c61626d114
--- /dev/null
+++ b/gnu/packages/rcm.scm
@@ -0,0 +1,62 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2019 Josh Holland <josh@HIDDEN>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages rcm)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix licenses)
+  #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages perl))
+
+(define-public rcm
+  (package
+    (name "rcm")
+    (version "1.3.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://thoughtbot.github.io/rcm/dist/rcm-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32 "1bqk7rrp1ckzvsvl9wghsr77m8xl3a7yc5gqdsisz492dx2j8mck"))))
+    (build-system gnu-build-system)
+    (arguments '(#:phases
+                 (modify-phases %standard-phases
+                   (add-after 'patch-source-shebangs 'patch-tests
+                     (lambda _
+                       (substitute* '("test/rcrc-tilde.t"
+                                      "test/rcdn-hooks-run-in-order.t"
+                                      "test/rcup-hooks-run-in-order.t")
+                         (("/bin/sh") (which "sh")))
+                       (substitute* "test/rcup-hooks.t"
+                         (("/usr/bin/env") (which "env")))
+                       #t)))
+                  #:parallel-tests? #f))
+    (native-inputs `(("perl" ,perl)
+                     ("python-cram" ,python-cram)))
+    (synopsis "Management suite for dotfiles")
+    (description "The rcm suite of tools is for managing dotfiles directories.  This is
+a directory containing all the @code{.*rc} files in your home directory
+(@code{.zshrc}, @code{.vimrc}, and so on). These files have gone by many
+names in history, such as “rc files” because they typically end in rc
+or “dotfiles” because they begin with a period.  This suite is useful
+for committing your rc files to a central repository to share, but it also
+scales to a more complex situation such as multiple source directories
+shared between computers with some host-specific or task-specific files.")
+    (license bsd-3)
+    (home-page "https://github.com/thoughtbot/rcm")))
-- 
2.21.0





Information forwarded to guix-patches@HIDDEN:
bug#35653; Package guix-patches. Full text available.

Message received at 35653 <at> debbugs.gnu.org:


Received: (at 35653) by debbugs.gnu.org; 9 May 2019 17:59:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 09 13:59:39 2019
Received: from localhost ([127.0.0.1]:36347 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hOnKV-00016V-JN
	for submit <at> debbugs.gnu.org; Thu, 09 May 2019 13:59:39 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:55947)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <josh@HIDDEN>) id 1hOnKS-00016G-Qn
 for 35653 <at> debbugs.gnu.org; Thu, 09 May 2019 13:59:38 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 3AF412464A;
 Thu,  9 May 2019 13:59:31 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Thu, 09 May 2019 13:59:31 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inv.alid.pw; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding; s=mesmtp; bh=f2w7v6dQy+
 GSkvkYFmHxgVbNYbOPHXJlmiBtgmTTyGg=; b=D8Uyr3M9f1LGG391qajONMwunS
 ujDQ5lNT3biQxyyfSl22U2cfckpp1eHGG78OSMFoWFJqXkFZEwJAN4ExNGqBHDBz
 FqTMJI1cNrb5EWtrP+vFiM5zRr4cN1aL8tjbngkMd+BLvvJeyA4IOX+bAJWY+EGk
 nCjdW7LoeHE/lCrwQ=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:date:from
 :in-reply-to:message-id:mime-version:references:subject:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm2; bh=f2w7v6dQy+GSkvkYFmHxgVbNYbOPHXJlmiBtgmTTyGg=; b=0VQYQFe+
 8xesOVXOchC6KH4oymL0lLhs4rVILGpy7I9264Ot4K5KpdZStjP/Bft5SDhRpWVk
 SMJvDTw5wksxZsT35aIdbj8ynCagtnJqgQh/CJs0j5Pz5T16FCHJz+sQgnBjcFwj
 EjhvjFWtQWInSqDIhZ1R9NTVxbq1tRi11/7ml56jI9Fml56vZRVOXaYUyhPIJlQ5
 u2O4v5UaqFBEzoIUyKAuQL6VI22JI4q5WrPIFGRbVFVUCHwdyUVPNZd0fXCBrv4C
 eeBFDkwxPFz0lgD1gyl/7VIVAbVJS59Fipr7ZF5Ygy/ePYYVrJWeIjUxbd3440u8
 YI34wsG4fjEG7Q==
X-ME-Sender: <xms:gmrUXEhAfgHiUQpv8OA_daIxDsr29y1fzqhvpYmHP05pgvpg99P8tg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdehkecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg
 hrlhcuvffnffculdeftddmnecujfgurhephffvufffkffojghfggfgsedtkeertdertddt
 necuhfhrohhmpeflohhshhcujfholhhlrghnugcuoehjohhshhesihhnvhdrrghlihgurd
 hpfieqnecukfhppeduleeirdehvddrkeegrddvieenucfrrghrrghmpehmrghilhhfrhho
 mhepjhhoshhhsehinhhvrdgrlhhiugdrphifnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:gmrUXD2BBlfp-i71Dl8ti_yNuGEAw4oWFNs0gnXACZoosC8QMXgw2g>
 <xmx:gmrUXNTIOICLlXw7pM8yuR9NZiv9ElAsYBPsRK6zmFOItbgg6iHVcg>
 <xmx:gmrUXDBVIqweoLyPhM1mz_pL5e2SF4wxJmn2lOaG9e2sslwsxFvxVg>
 <xmx:g2rUXEX1s4XRcjQxvCYQoElGidJiuBSfq6ciK3Dek-JXQnkFGx4J-A>
Received: from localhost.localdomain
 (ip-26-84-52-196.southampton.uk.amsterdamresidential.com [196.52.84.26])
 by mail.messagingengine.com (Postfix) with ESMTPA id E25828005C;
 Thu,  9 May 2019 13:59:29 -0400 (EDT)
From: Josh Holland <josh@HIDDEN>
To: Danny Milosavljevic <dannym@HIDDEN>
Subject: Re: [bug#35653] [PATCH] gnu: Add rcm.
Date: Thu,  9 May 2019 18:59:15 +0100
Message-Id: <20190509175916.22479-1-josh@HIDDEN>
X-Mailer: git-send-email 2.21.0
In-Reply-To: <20190509185256.309d9b63@HIDDEN>
References: <20190509185256.309d9b63@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 35653
Cc: 35653 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Danny Milosavljevic writes:
> Yes, and it's not so important in which module what is.

I'll just leave it in its own module for now then, and if a maintainer
wants to move it either when it's merged or later down the line that's
fine.

> From your description, try (#:parallel-tests? #f) instead of (#:tests? #f).

Oh of course, that makes perfect sense!  That fixes it and all the tests
pass now.

> Some test scripts still have /bin/sh

AFAICT the only one I'm not patching is `test/rcup-standalone.t` and
that's kind of a weird one, because it's testing the feature to output a
standalone shell script rather than run it.  Changing that would require
patching the rcup script itself and I don't think that's worth it,
especially as the script uses the bash default value syntax to allow
all the commands to be overriden.

If I'm still operating git send-email correctly, a new patch should be
attached with these changes, and a better commit message.  I also updated
`gnu/local.mk` because that seems to be a thing I forgot initially.

Thanks,
Josh






Information forwarded to guix-patches@HIDDEN:
bug#35653; Package guix-patches. Full text available.

Message received at 35653 <at> debbugs.gnu.org:


Received: (at 35653) by debbugs.gnu.org; 9 May 2019 16:53:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 09 12:53:06 2019
Received: from localhost ([127.0.0.1]:36244 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hOmI6-0005hb-OB
	for submit <at> debbugs.gnu.org; Thu, 09 May 2019 12:53:06 -0400
Received: from dd26836.kasserver.com ([85.13.145.193]:42074)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dannym@HIDDEN>) id 1hOmI4-0005hR-Dv
 for 35653 <at> debbugs.gnu.org; Thu, 09 May 2019 12:53:05 -0400
Received: from localhost (178.112.234.177.wireless.dyn.drei.com
 [178.112.234.177])
 by dd26836.kasserver.com (Postfix) with ESMTPSA id 2016633606E0;
 Thu,  9 May 2019 18:53:02 +0200 (CEST)
Date: Thu, 9 May 2019 18:52:56 +0200
From: Danny Milosavljevic <dannym@HIDDEN>
To: Josh Holland <josh@HIDDEN>
Subject: Re: [bug#35653] [PATCH] gnu: Add rcm.
Message-ID: <20190509185256.309d9b63@HIDDEN>
In-Reply-To: <20190509153834.26585-1-josh@HIDDEN>
References: <20190509153834.26585-1-josh@HIDDEN>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/Av=ZeD=PDYAokLEnAwUKH_v"; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 35653
Cc: 35653 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--Sig_/Av=ZeD=PDYAokLEnAwUKH_v
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu,  9 May 2019 16:38:34 +0100
Josh Holland <josh@HIDDEN> wrote:

> First, I wasn't sure whether it fits into an existing module already.
> I had a look through the contents of gnu/packages/ but I didn't see
> anything that really stuck out.  Perhaps it fits into shellutils?

Yes, and it's not so important in which module what is.  The module
name is not part of the package name anyway, so we are mostly using
it to manage compilation complexity (sigh).  Developers can find it
using "guix edit rcm" anyway.

I try not to introduce a new module for each package because it leads
to a lot of file header duplication, and at some point the comment/code
ratio is getting ridiculous--but, technically, even that would be fine.

> This may or may not be the right way to go about things; I'd appreciate
> some feedback on that.

Looks fine.

> If there are any ideas to solve the tests, or any other issues that need
> fixing, I'm happy to re-submit the patch.

> +    (arguments '(#:tests? #f))

=46rom your description, try (#:parallel-tests? #f) instead of (#:tests? #f).

Nice work!

Some test scripts still have /bin/sh

--Sig_/Av=ZeD=PDYAokLEnAwUKH_v
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlzUWugACgkQ5xo1VCww
uqVdXwgAizRGxTGeJCkRRAG8qyZhhIEbzg2LGJTwsP55F3PB+oU7sy/lr1FJDRi2
FoxiP9yu6UarZ0iDWFAkEJFj64cp5glcgmSZC81JQUy7qy0imy3WVIa8fQ3EfE1Q
dJGHdZxjI4HOwVTNHC/eyzsRSFShhStOuJ84kquez5zLoqnglblA+SOXNFgEAKwl
mvTFMRo7Wy2SyJ+98k245eoTEPBHaNKsnk62IAQMP6oN3pLsHp5nj+g34i0/DKaj
8AfKod4vG61UE9dX7mehTP2wZGIVXDiSzPfsOwG2PtbgPMTU8YP12YgZwjtL1nPe
9cDbxG/UH9fSVyGwyDUbgL5UCSLXQw==
=Lle4
-----END PGP SIGNATURE-----

--Sig_/Av=ZeD=PDYAokLEnAwUKH_v--




Information forwarded to guix-patches@HIDDEN:
bug#35653; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 9 May 2019 15:39:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 09 11:39:03 2019
Received: from localhost ([127.0.0.1]:36119 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hOl8Q-0007yf-CT
	for submit <at> debbugs.gnu.org; Thu, 09 May 2019 11:39:03 -0400
Received: from eggs.gnu.org ([209.51.188.92]:36083)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <josh@HIDDEN>) id 1hOl8N-0007y8-Hj
 for submit <at> debbugs.gnu.org; Thu, 09 May 2019 11:39:00 -0400
Received: from lists.gnu.org ([209.51.188.17]:51938)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <josh@HIDDEN>) id 1hOl8I-0001mI-DW
 for submit <at> debbugs.gnu.org; Thu, 09 May 2019 11:38:54 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50463)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <josh@HIDDEN>) id 1hOl8H-00040j-2a
 for guix-patches@HIDDEN; Thu, 09 May 2019 11:38:54 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW,
 URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <josh@HIDDEN>) id 1hOl8F-0001j7-Ni
 for guix-patches@HIDDEN; Thu, 09 May 2019 11:38:53 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:57831)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <josh@HIDDEN>) id 1hOl8F-0001hN-4u
 for guix-patches@HIDDEN; Thu, 09 May 2019 11:38:51 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 940DC23AA3;
 Thu,  9 May 2019 11:38:49 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Thu, 09 May 2019 11:38:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inv.alid.pw; h=
 from:to:cc:subject:date:message-id:mime-version:content-type
 :content-transfer-encoding; s=mesmtp; bh=rQ2Q5Jg9v/Walzaq/jsEFQi
 XocXsP8y1x2rQlBwSly0=; b=Hw6QRSqjfQ0PHKAZG0gVG6U5kVtpDHXm2tWgRV6
 c5cOTm8iGkEaIudFoveEX8M6q/DrdVWcJEb2hgnBhB5CPcQnZ2nfuxJFoqMyxRjN
 SqNTJwm7ru3ujwDtJMaagMAQ5jORPI2v3HBt8dcCtkwHf3NoBfiRMUFMC3PSe6h8
 Ia6I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:message-id:mime-version:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=rQ2Q5J
 g9v/Walzaq/jsEFQiXocXsP8y1x2rQlBwSly0=; b=J5NqdGDWW999d77uT23hr9
 6zTGb1/V1YD/SMiZSVhyVN+ONKS9TCz+V2Ez4DEULppYe8k625hYo8caksaYYZhJ
 WBbALZzewFYce/bVT5bKBGNw/YlSC4FmyYDdjnkMNPuOwfkeTu7vawusnZF2M8N7
 hFYcmvVzLGpreGiXwos3b8CkdtcNyMZp0nZTcrCwceulwJNVGgT0LiP9AWMaNqRN
 QJvZmIINoxvNTyOOJuwaAfINGGMFq2AEV35AYCWCE0cnHEgw2kkoN51ouR7fZch7
 MOQWksbLTuO6c1RoL6JqpID7dC5RM+YjGhLhByKtbY5/c24+79hCGs8SZpOooUVw
 ==
X-ME-Sender: <xms:iEnUXOpzKZ0yPsKAkoJOMRvotAcfqa78KMWhOjhkOvmYSTe0sdBTww>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigddvlecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecuogfuuhhsphgvtghtffhomhgrihhnucdlgeelmdenfg
 hrlhcuvffnffculddutddmnecujfgurhephffvufffkffogggtgfesthekredtredtjeen
 ucfhrhhomheplfhoshhhucfjohhllhgrnhguuceojhhoshhhsehinhhvrdgrlhhiugdrph
 ifqeenucffohhmrghinhepghhithhhuhgsrdhiohdpghhithhhuhgsrdgtohhmnecukfhp
 peduleeirdehvddrkeegrddvieenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhhse
 hinhhvrdgrlhhiugdrphifnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:iEnUXI9gBJ5q7lveTfooTrmFkr7iwamcd-4fbMp7KNHVc4c1AF8DkQ>
 <xmx:iEnUXE05Z_aDHoBEuMpA6lVjq-sMMhFmERoDOA9P2VsWT9eyVvgvBg>
 <xmx:iEnUXLBSr4kAVqdDH2EAZZEqWPdJU-ANeUNda6pXX6ZoGelEwqhslA>
 <xmx:iUnUXC8eTX4nr86FyKjc7nyljypfREHls2NXxuBk2u_VmZNqaZAaGg>
Received: from localhost.localdomain
 (ip-26-84-52-196.southampton.uk.amsterdamresidential.com [196.52.84.26])
 by mail.messagingengine.com (Postfix) with ESMTPA id 6232F8005C;
 Thu,  9 May 2019 11:38:48 -0400 (EDT)
From: Josh Holland <josh@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add rcm.
Date: Thu,  9 May 2019 16:38:34 +0100
Message-Id: <20190509153834.26585-1-josh@HIDDEN>
X-Mailer: git-send-email 2.21.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 66.111.4.29
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
Cc: Josh Holland <josh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

Hi,

Below is the first package definition I have written for Guix, defining
the dotfile management suite rcm[0].  I'm sure there are changes to be
made before it can be merged, and I did have a few issues while I was
writing it.  However, it does now build, install and run fine on my
local machine.

First, I wasn't sure whether it fits into an existing module already.
I had a look through the contents of gnu/packages/ but I didn't see
anything that really stuck out.  Perhaps it fits into shellutils?

Second, I had a lot of trouble with the test suite.  The first thing
that I had to solve was some hardcoded paths in the test cases, which
I solved with the following argument to `#:phases`:

(modify-phases %standard-phases
  (add-after 'patch-source-shebangs 'patch-tests
    (lambda _
      (substitute* '("test/rcrc-tilde.t"
                     "test/rcdn-hooks-run-in-order.t"
                     "test/rcup-hooks-run-in-order.t")
        (("/bin/sh") (which "sh")))
      (substitute* "test/rcup-hooks.t"
        (("/usr/bin/env") (which "env")))
      #t)))

This may or may not be the right way to go about things; I'd appreciate
some feedback on that.

However, I was still having issues with certain tests
(`test/rcup-hooks.t`, `test/rcdn-hooks.t` and possibly others)
non-deterministically failing trying to create and read /tmp/test files.
I'm not sure how to fix this, or even what's causing it: every time I
tried to reproduce it by hand the tests passed.  I assume that something
is deleting /tmp/test while the test is running but I'm not sure what.
In the end I just disabled the tests, since even passing XFAIL_TESTS
doesn't work as sometimes the tests just pass.

If there are any ideas to solve the tests, or any other issues that need
fixing, I'm happy to re-submit the patch.

Thanks,
Josh

[0]: http://thoughtbot.github.io/rcm/

-- >8 --
Subject: [PATCH] gnu: Add rcm.

* gnu/packages/rcm.scm (rcm): New variable.
---
 gnu/packages/rcm.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 gnu/packages/rcm.scm

diff --git a/gnu/packages/rcm.scm b/gnu/packages/rcm.scm
new file mode 100644
index 0000000000..180fff5ed9
--- /dev/null
+++ b/gnu/packages/rcm.scm
@@ -0,0 +1,33 @@
+(define-module (gnu packages rcm)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix licenses)
+  #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages perl))
+
+(define-public rcm
+  (package
+    (name "rcm")
+    (version "1.3.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://thoughtbot.github.io/rcm/dist/rcm-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32 "1bqk7rrp1ckzvsvl9wghsr77m8xl3a7yc5gqdsisz492dx2j8mck"))))
+    (build-system gnu-build-system)
+    (arguments '(#:tests? #f))
+    (native-inputs `(("perl" ,perl)
+                     ("python-cram" ,python-cram)))
+    (synopsis "Management suite for dotfiles")
+    (description "The rcm suite of tools is for managing dotfiles directories.  This is
+a directory containing all the @code{.*rc} files in your home directory
+(@code{.zshrc}, @code{.vimrc}, and so on). These files have gone by many
+names in history, such as “rc files” because they typically end in rc
+or “dotfiles” because they begin with a period.  This suite is useful
+for committing your rc files to a central repository to share, but it also
+scales to a more complex situation such as multiple source directories
+shared between computers with some host-specific or task-specific files.")
+    (license bsd-3)
+    (home-page "https://github.com/thoughtbot/rcm")))
-- 
2.21.0





Acknowledgement sent to Josh Holland <josh@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#35653; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 9 May 2019 18:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.