GNU bug report logs - #35656
[PATCH] services: mcron: Log to a file.

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Thu, 9 May 2019 17:41:01 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35656 in the body.
You can then email your comments to 35656 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#35656; Package guix-patches. (Thu, 09 May 2019 17:41:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Christopher Baines <mail <at> cbaines.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 09 May 2019 17:41:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: mcron: Log to a file.
Date: Thu,  9 May 2019 18:40:32 +0100
This makes it easier to read the output, as it's recorded in a file.

* gnu/services/mcron.scm (mcron-shepherd-services): Add #:log-file to
make-forkexec-constructor.
---
 gnu/services/mcron.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm
index 1b232b6cba..fd84589c19 100644
--- a/gnu/services/mcron.scm
+++ b/gnu/services/mcron.scm
@@ -121,7 +121,9 @@ files."
                         (cons* "GUILE_AUTO_COMPILE=0"
                                "PATH=/run/current-system/profile/bin"
                                (remove (cut string-prefix? "PATH=" <>)
-                                       (environ)))))
+                                       (environ)))
+
+                        #:log-file "/var/log/mcron.log"))
               (stop #~(make-kill-destructor))
 
               (actions
-- 
2.21.0





Information forwarded to guix-patches <at> gnu.org:
bug#35656; Package guix-patches. (Fri, 10 May 2019 13:10:02 GMT) Full text and rfc822 format available.

Message #8 received at 35656 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 35656 <at> debbugs.gnu.org
Subject: Re: [bug#35656] [PATCH] services: mcron: Log to a file.
Date: Fri, 10 May 2019 15:09:45 +0200
Hi,

Christopher Baines <mail <at> cbaines.net> skribis:

> This makes it easier to read the output, as it's recorded in a file.
>
> * gnu/services/mcron.scm (mcron-shepherd-services): Add #:log-file to
> make-forkexec-constructor.

Good idea, LGTM!

Ludo’.




Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Sun, 12 May 2019 23:15:01 GMT) Full text and rfc822 format available.

Notification sent to Christopher Baines <mail <at> cbaines.net>:
bug acknowledged by developer. (Sun, 12 May 2019 23:15:02 GMT) Full text and rfc822 format available.

Message #13 received at 35656-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35656-done <at> debbugs.gnu.org
Subject: Re: [bug#35656] [PATCH] services: mcron: Log to a file.
Date: Mon, 13 May 2019 00:14:26 +0100
[Message part 1 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> This makes it easier to read the output, as it's recorded in a file.
>>
>> * gnu/services/mcron.scm (mcron-shepherd-services): Add #:log-file to
>> make-forkexec-constructor.
>
> Good idea, LGTM!

I've pushed this to master now, thanks for taking a look :)
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 10 Jun 2019 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 322 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.