GNU bug report logs - #35661
[PATCH] doc: Fix typo.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35661 in the body.
You can then email your comments to 35661 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] doc: Fix typo.
Date: Thu, 09 May 2019 23:19:54 +0200

[Message part 1 (text/plain, inline)]

Hi Guix,

The documentation of 'shepherd-service' erroneously calls the
'requirement' field 'requirements'.  The attached patch fixes that.

I have also noticed that the 'auto-start?' field is not mentioned at
all.

Regards,

Diego

[0001-doc-Fix-typo.patch (text/x-patch, inline)]

From 635fa669c8d52afd2363c99bfa03b2315af29e74 Mon Sep 17 00:00:00 2001
From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Date: Thu, 9 May 2019 22:44:45 +0200
Subject: [PATCH] doc: Fix typo.

* doc/guix.texi (shepherd-service): 'requirement' instead of 'requirements'.
---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index df7208229c..f88fa827d4 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -25279,7 +25279,7 @@ These are the names that may be passed to @command{herd start},
 shepherd, The GNU Shepherd Manual}).  @xref{Slots of services, the
 @code{provides} slot,, shepherd, The GNU Shepherd Manual}, for details.
 
-@item @code{requirements} (default: @code{'()})
+@item @code{requirement} (default: @code{'()})
 List of symbols denoting the Shepherd services this one depends on.
 
 @cindex one-shot services, for the Shepherd
-- 
2.21.0

Message #10 received at 35661-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Cc: 35661-done <at> debbugs.gnu.org
Subject: Re: [bug#35661] [PATCH] doc: Fix typo.
Date: Sat, 11 May 2019 13:14:41 +0530

[Message part 1 (text/plain, inline)]

> The documentation of 'shepherd-service' erroneously calls the
> 'requirement' field 'requirements'.  The attached patch fixes that.

Thanks! I added a copyright header for you and pushed the patch.

> I have also noticed that the 'auto-start?' field is not mentioned at
> all.

Could you submit a patch fixing this?

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 35661 <at> debbugs.gnu.org (full text, mbox):

From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 35661 <at> debbugs.gnu.org
Subject: Re: [bug#35661] [PATCH] doc: Fix typo.
Date: Sat, 11 May 2019 17:45:31 +0200

Arun Isaac <arunisaac <at> systemreboot.net> writes:

>> The documentation of 'shepherd-service' erroneously calls the
>> 'requirement' field 'requirements'.  The attached patch fixes that.
>
> Thanks! I added a copyright header for you and pushed the patch.

Thanks!  I was not aware that removing a single character would warrant
the addition of a copyright header.  I have made less trivial changes in
the past and I have never added a copyright line.  Should I do something
about that?

Message #16 received at 35661 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Cc: 35661 <at> debbugs.gnu.org
Subject: Re: [bug#35661] [PATCH] doc: Fix typo.
Date: Sun, 12 May 2019 03:50:56 +0530

[Message part 1 (text/plain, inline)]

> I was not aware that removing a single character would warrant the
> addition of a copyright header.

I am not aware of any policy about this in the Guix project. But, I have
seen people do it both ways -- both adding and not adding copyright
headers for trivial changes. So, I generally add copyright headers for
all changes no matter how trivial.

> I have made less trivial changes in the past and I have never added a
> copyright line.  Should I do something about that?

I think you can ignore those instances. Even I have made trivial changes
before and not added a copyright header.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.