GNU bug report logs - #35663
27.0.50; Eldoc support for apply

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Michael Heerdegen <michael_heerdegen@HIDDEN>; dated Fri, 10 May 2019 00:12:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 35663 <at> debbugs.gnu.org:


Received: (at 35663) by debbugs.gnu.org; 26 Aug 2020 10:32:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 26 06:32:49 2020
Received: from localhost ([127.0.0.1]:37484 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kAsjY-0002Sc-Tk
	for submit <at> debbugs.gnu.org; Wed, 26 Aug 2020 06:32:49 -0400
Received: from quimby.gnus.org ([95.216.78.240]:53772)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1kAsjX-0002NI-0Q
 for 35663 <at> debbugs.gnu.org; Wed, 26 Aug 2020 06:32:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID
 :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=RGI40EJ/j0dF+XFl3td2jjJiyHGBKMb6V9EBk4RPrXY=; b=Fulu6354SBaWrrCO48vSmAdL4R
 fsys4TIl3DIrlf2QtOsKbD4W/+ovwIHHbF3AsFgKZt7GaCstz27Q+fXWycQ5yybRqMMs6Dp7JGaib
 b1g9nKY2YWaXVnDrDb4p5stm7DM6MhW7oEBr5gR0q7G3UxpKvYV0TFCbXAOIKbRPolog=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
 by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1kAsjO-0004Ic-6s; Wed, 26 Aug 2020 12:32:40 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#35663: 27.0.50; Eldoc support for apply
References: <871s17uq15.fsf@HIDDEN>
X-Now-Playing: Various's _Kaleidoscope (2)_: "Nat Birchall - Ancient World"
Date: Wed, 26 Aug 2020 12:32:36 +0200
In-Reply-To: <871s17uq15.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 10
 May 2019 02:11:34 +0200")
Message-ID: <87y2m11yuz.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > when
 editing something like > > (apply #'call-process > (car command) > nil >
 (if stderr-file (list t stderr-file) t) > nil > (append (cdr command) (list
 archive name))) > > eldoc support would be u [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 35663
Cc: 35663 <at> debbugs.gnu.org,
 =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> when editing something like
>
> (apply #'call-process
>   (car command)
>   nil
>   (if stderr-file (list t stderr-file) t)
>   nil
>   (append (cdr command) (list archive name)))
>
> eldoc support would be useful to see the argument names of
> 'call-process' instead of the signature of 'apply'.

Yeah, that would be really nice...  Some people might want to know what
the signature to apply is, though, but probably a lot fewer.

> @@ -1356,6 +1356,16 @@ elisp-eldoc-documentation-function
>  	  ((eq current-symbol (car current-fnsym))
>  	   (or (apply #'elisp-get-fnsym-args-string current-fnsym)
>  	       (elisp-get-var-docstring current-symbol)))
> +          ((and (memq (car current-fnsym) '(apply apply-partially))
> +                (< 1 (cadr current-fnsym))
> +                (let ((args (save-excursion

[...]

The patch no longer applies, because eldoc has been rewritten
substantially over the last year.  Is there any interest in resurrecting
this patch and getting it applied?  I've added Jo=C3=A3o to the Cc.

--=20
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#35663; Package emacs. Full text available.

Message received at 35663 <at> debbugs.gnu.org:


Received: (at 35663) by debbugs.gnu.org; 10 May 2019 11:41:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 10 07:41:35 2019
Received: from localhost ([127.0.0.1]:37356 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hP3uB-0005Xc-MY
	for submit <at> debbugs.gnu.org; Fri, 10 May 2019 07:41:35 -0400
Received: from mout.web.de ([212.227.17.12]:44183)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1hP3uA-0005XO-8C
 for 35663 <at> debbugs.gnu.org; Fri, 10 May 2019 07:41:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1557488487;
 bh=o7ylMFwm/xbj+I35EEdWFAAlU1A1PMOBFCg3sv0JUXM=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=Y6GPaQO7RgIbN7o4jDOXtJFBTUiKj/wblwex5gNOdr7EZU2JMv7CmRwd1uuvdlCgu
 V5KD+5mQZsMGgehPUrVyQ8/bOMJjIHqs4nI5cmF1xlXgyFAivu6kJEiXr5sODquOcz
 L5Bw1TOQAQnPg8qV0b4cmPNjeQkHyFI6H5AAgQq8=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([88.66.186.107]) by smtp.web.de (mrweb103
 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LvSLn-1ghN480HZb-010bhY; Fri, 10
 May 2019 13:41:27 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Noam Postavsky <npostavs@HIDDEN>
Subject: Re: bug#35663: 27.0.50; Eldoc support for apply
References: <871s17uq15.fsf@HIDDEN> <87d0krjfbd.fsf@HIDDEN>
 <87v9yitxnc.fsf@HIDDEN> <877eayk3ii.fsf@HIDDEN>
Date: Fri, 10 May 2019 13:41:25 +0200
In-Reply-To: <877eayk3ii.fsf@HIDDEN> (Noam Postavsky's message of "Fri, 10
 May 2019 06:28:05 -0400")
Message-ID: <87lfzetu3e.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:m7dMPjMD2qTQ4Le9YtENtUNbzPTCBGOVNJLV05RkqtXQPV/9pJc
 V11hufhFWiB4omgG6JdbhVM2AmXCNTcb0BZGSY0yyNka0ctIRfIYNLqKnsOFy/6/g39wfSE
 imnyT/UTn0G7V4HmOihFyu1v6F+K5kZC6WzOmg4RA7Ku9+BGkyIqeqJu05iEOK48jXR+UMk
 uniNgnFaBHBv/FhWMOpeA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:x3x+KOYT79A=:7/e4wTfz7M5jk+osvZZvYw
 YzvdJwv54NE4HVcf+R39kcUKd6HpawflSmeb/sFCGlEGGM/Smw5nW4Ff9oNidV+nYG3JHNvsw
 OBPhlTsBWylYb5LtC6LvFnqkBmJdQeBie9HHYGBFsS58ULqaX3hu8uPKFI1fSB2MB13VzawTI
 coiaC4Ai1brElKkAFHRGKHncbWdGjaU8/0XpTrJwigzJUGThMXOd0h0m9pVaUyXVO02F5Vnqe
 gmejua3RT+/wWKPD/oga+n8jIFCgVyw8aMmU2HFZm3yA6xGMIHEOE+IlovkE28RlZqcr+GH/i
 F/n5yCu4jZ6QheuWxaEdrN/WLcmU8KCfZCsO56L3Jn1dqtNJvwB84szUKnh0QVOn+sbUH2koE
 5B+3oAvySsRuzYIgYSSJ548oezNNEwCxijBFmDaz1gPGsFI4Z4l77HvZHdPyK9uFxvZKPj8l0
 ynCopQxu9no49tPpn2qY3bUPrEIUYKKprM7WxKmG4aox9rnoyz3dt+xHD0z5DyoYSmNJGP75r
 zoczfISm84g1DMMVPC/qaMkUN9HYGTPHucV+h6Dm9kuY5E9sPeZTwqfHd2SBvDl/+S1SzDLvn
 RpnyUC3vl0+ZwcGXsKAU2SIqp0LxSUNDeoZQr0vTr4SWHNisr9E+gHo8ISFfXVDV+OpY3TISl
 4WDpXZ9SdWPh5f8LiTk1IQEuqLieFX2lxbUUBMoqXDXTz1q67vZNbNHeRxsAh3cAE5aLYpqyx
 ye+CPtlinrBHkPtyXQ9WrPYYhHJfcTHMRAqOILmwgl9e0YOYEfrmi3EzZbPoDPhdRlr1yguZw
 NfANc4uK0HO9MhyLEx9NkH+EolebHh6Uep1uibQKTavshXqZ32pN4vi9R4UZvGjDtpyPicnn+
 lRO10SN2Eh4aD36s5Ts8UszbbSqPqHQhTmp4lgCjkK5uzLnI0dARpPLz+6iYL4B9T5f9ImNrM
 kAfSKk/AA/w==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 35663
Cc: 35663 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Noam Postavsky <npostavs@HIDDEN> writes:

> Hmm, maybe I mixed this is up with stepping into funcall/apply with
> edebug.

Probably.  We should also fix this.  I currently use this hack as
workaround:

(advice-add
 'edebug-instrument-callee :around
 (defun my-edebug-instrument-callee--around-ad (f)
   (condition-case nil
       (funcall f)
     (error
      (when (y-or-n-p "edebug-instrument-callee error - select a function by name?")
        (edebug-instrument-function
         (intern
          (completing-read
           "Function to instrument: " obarray #'fboundp t
           (when (looking-at "\(\\(?:funcall\\|apply\\|funcall-interactively\\) +\\(?:#?'\\)?\\(\\(?:\\sw\\|\\s_\\)+\\)[ \)]")
             (match-string 1))))))))))

I guess in unambiguous cases we can even omit prompting.

Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#35663; Package emacs. Full text available.

Message received at 35663 <at> debbugs.gnu.org:


Received: (at 35663) by debbugs.gnu.org; 10 May 2019 10:28:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 10 06:28:15 2019
Received: from localhost ([127.0.0.1]:37256 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hP2lD-0005vz-4B
	for submit <at> debbugs.gnu.org; Fri, 10 May 2019 06:28:15 -0400
Received: from mail-it1-f170.google.com ([209.85.166.170]:39276)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <npostavs@HIDDEN>) id 1hP2lA-0005vm-MY
 for 35663 <at> debbugs.gnu.org; Fri, 10 May 2019 06:28:13 -0400
Received: by mail-it1-f170.google.com with SMTP id 9so1114398itf.4
 for <35663 <at> debbugs.gnu.org>; Fri, 10 May 2019 03:28:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=WUMgXLr4e4FHYDe0Y5hqfra4TYdDqiSyNA4enthzutU=;
 b=uLm9+003vc8lnOhHXlTMBF+A37yyme8ozYhTu9n1TUdF/JmmJvdoqtQEptsJSGBUr5
 TMGM3DDkU1rSkcGZEhtwfrduboKLCzqFPimoWUQpM94xvnnmwx014Q44e+Dd6ENuwosC
 nGIZo+z7/9K69T+JbWY6e/EDouFLK5DAJkqa9CsXmXmG2+rK0/9qQXXGMM+mRCpCnxcb
 Ao0Wh0F3zu9f6Fs2HOayAcZ79lwyXvjjeislfkL8OiVA8mIJijlKZl87khwLuFtZWf/6
 dWZAeiuaIdklYlDFVq3syIXjAOqd9FWr8+fK5y3T7RY5e/HOwJlwqQHH0IxLXJAZ0PaC
 nNjg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=WUMgXLr4e4FHYDe0Y5hqfra4TYdDqiSyNA4enthzutU=;
 b=OUEJP20iEr+dmdN4FeHcS/SBMRWBaSgPZjqfBBVGjEhckPx3lwBopkRaX7xLjsQhdD
 /BbZvFVvJygXDDd7FJOUY8M3n5Dqenrn8m2r7SzcTq6kdfWVClvWwaaQnaV40fqcRzn0
 phKJiJDz5uChFqlAI9yFWEuyG1T2ligp78334mITQ+0urtCIc717Hv4jdqcWvTZNx9yD
 wPDvTlky0RuwUJyvTZtZ/1BJAEsWkVF10s9IM9Q4Qn/0LCuaiUQVpJtXid0SqVDOzQrM
 8XGyBoAKUgU1/CSuwx2TJIpEH/vCH5XL2v+JJfLhtfDVht/m/mjt9l/hy73pEZnm0gTc
 O3xA==
X-Gm-Message-State: APjAAAVEdHFDlXHtS96lks+4x6yKla/4LU/WfVjRVJSuvE+jVHhom0BT
 4Y03xeQItsrPPZhoMCDiAP1QhXEx
X-Google-Smtp-Source: APXvYqxeA0lPjDQJFqqzWRBjHOG0HvfcoiQhWu1ad2YDcgv2sm0Lc/SRLqJPSVd4y1+z+2YJl07Ipw==
X-Received: by 2002:a02:8585:: with SMTP id d5mr7497896jai.69.1557484086808;
 Fri, 10 May 2019 03:28:06 -0700 (PDT)
Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34])
 by smtp.gmail.com with ESMTPSA id
 h191sm3265546ith.5.2019.05.10.03.28.06
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 10 May 2019 03:28:06 -0700 (PDT)
From: Noam Postavsky <npostavs@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#35663: 27.0.50; Eldoc support for apply
References: <871s17uq15.fsf@HIDDEN> <87d0krjfbd.fsf@HIDDEN>
 <87v9yitxnc.fsf@HIDDEN>
Date: Fri, 10 May 2019 06:28:05 -0400
In-Reply-To: <87v9yitxnc.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 10
 May 2019 12:24:39 +0200")
Message-ID: <877eayk3ii.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 35663
Cc: 35663 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> Noam Postavsky <npostavs@HIDDEN> writes:
>
>> > +          ((and (memq (car current-fnsym) '(apply apply-partially))
>>
>> funcall too please? :)
>
> Why would you want to write something like (funcall #'fun arg ...) when
> FUN is a symbol?

Hmm, maybe I mixed this is up with stepping into funcall/apply with
edebug.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#35663; Package emacs. Full text available.

Message received at 35663 <at> debbugs.gnu.org:


Received: (at 35663) by debbugs.gnu.org; 10 May 2019 10:24:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 10 06:24:49 2019
Received: from localhost ([127.0.0.1]:37246 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hP2ht-0005mn-H4
	for submit <at> debbugs.gnu.org; Fri, 10 May 2019 06:24:49 -0400
Received: from mout.web.de ([212.227.15.14]:33067)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1hP2hr-0005ma-Ma
 for 35663 <at> debbugs.gnu.org; Fri, 10 May 2019 06:24:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1557483880;
 bh=SV4/MUkd5wZKo5qZbmBwxXIU52qdrolsA8lUEttDhvY=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=fj5JO6hfL2b+QreVzbz6nsZHHN0dUC6bSFtxNga3xHVZMarZvfpwqcka0IwjuWFw+
 xIhh64Ybglv997diCHqswyi9ESoXeZyxk/lm1PhWgDYT3W+xb7yaVAmF1qBonQ476Y
 S/HkhSpMc6244luj9UwHYaqGVXkU0bL7cyj/Aq5o=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([88.66.186.107]) by smtp.web.de (mrweb002
 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MK2FR-1hNff31dMT-001PFH; Fri, 10
 May 2019 12:24:40 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Noam Postavsky <npostavs@HIDDEN>
Subject: Re: bug#35663: 27.0.50; Eldoc support for apply
References: <871s17uq15.fsf@HIDDEN> <87d0krjfbd.fsf@HIDDEN>
Date: Fri, 10 May 2019 12:24:39 +0200
In-Reply-To: <87d0krjfbd.fsf@HIDDEN> (Noam Postavsky's message of "Thu, 09
 May 2019 20:58:30 -0400")
Message-ID: <87v9yitxnc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:ZlzQjacs7o+iA5na1eaePTHA6K5RYcOSCAXnjFlhuPl+wetDuKu
 p1MoCI5OyQdMJGTMoAVs2wp84RHrRddA4FTanpb6oW9F3VLSERyVM3wJ0Xh0ENnu3z/W2pp
 D66+luUKpnuNNAKnpNGJmKThFqw1+L5oifXupOobxhLW6/s8+xS2BKVLZl0338u6qUBSjU9
 HAy39j2loWbFIk3TKWsag==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:1/hfDuUecCg=:6OOslPuFG+OBnBJ0SPD68X
 RSYaL7ogjeKX1KbP9QJpLjRI1wpkD77SZGswn6lJWG5+InAcmcQjN5uud+TElXiRHo5p//hTl
 g+iC4EsH/Kvmnxt7a5zXC4dVsgV6D07Y6ggULeJNluTqhrdZfg4aS/CJNZAFw9Ak6RagHm2tN
 MvJ1IPyMGmrIDLrYYsRa6KusCFWxAtr0ocS/2SzfpMufA3Q3LL6hIj/399Wn17bD7W/L0mvLj
 0PeCwAS5dgj78kxATqroQdNchpZDdWRZh6jOVPX/FzAEGlWg+AOZ+yIisfSlQWx2w53ELDBiB
 PHO2PcFEmPUKfdM2A2xhh83Qsl8a7c7DiMimFhygjc3381+juLomB0P/s61ayzg1uFc1CwVOc
 /G+LswCw9/cGef74jDJ7I2fVmC3XLGK/OHx1plnAudImEqDM3lHWk5hMlai6d+DGn6lH5UzyT
 9JuR7ZWQ7TXuZBucD6KTmwEfekmcx6ucFvvywpzlamZ33/nclUUNrRjs/fmQuZCcyNpJWe1/U
 /8RO4pf0sLx5atA5Lr9bQpK260GGSarsJptcygolY85xlrWQNfaQM9xrTmf10Lko1pxvHMKSC
 9jTcSsQI3E+WTeDhgNNNgjxh+/ouL7InKwGvTqPO676r9gw7M2x4taOjzRfNKZlHmQKmpVmO1
 YE3j+bhcxvJRL3Wgsyqey1qXWeWEkdD5rDVXgU+0X7BaWfwx4cJEWzRwqeYtPSmV3nZACylqR
 nevIOa9q5mSzKkuwH39gNR+DtlWZdHlUa4mxDHL1Kjg1JB57c3sTjyo/gLowDZPIm8p/AKw9r
 Ifgg6KReXO/0L7p8bIpEHaDKhSpxY9lTqMoWcwinJ8cuYJkphb4Gdut4LT6z/nWWv5Te3Mck+
 7sdMgBtpY2Usae+k+I5IPB0hyTR1WVLPNoHZ3ViVX92yHgRQyH4rx8CCuY5Yp1UOzx7LIQP4f
 t6FJxhCEaPA==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 35663
Cc: 35663 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Noam Postavsky <npostavs@HIDDEN> writes:

> > +          ((and (memq (car current-fnsym) '(apply apply-partially))
>
> funcall too please? :)

Why would you want to write something like (funcall #'fun arg ...) when
FUN is a symbol?


Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#35663; Package emacs. Full text available.

Message received at 35663 <at> debbugs.gnu.org:


Received: (at 35663) by debbugs.gnu.org; 10 May 2019 00:58:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 09 20:58:40 2019
Received: from localhost ([127.0.0.1]:36748 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hOtrz-0006w7-Pa
	for submit <at> debbugs.gnu.org; Thu, 09 May 2019 20:58:39 -0400
Received: from mail-it1-f181.google.com ([209.85.166.181]:34627)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <npostavs@HIDDEN>) id 1hOtry-0006vs-2l
 for 35663 <at> debbugs.gnu.org; Thu, 09 May 2019 20:58:38 -0400
Received: by mail-it1-f181.google.com with SMTP id p18so6319454itm.1
 for <35663 <at> debbugs.gnu.org>; Thu, 09 May 2019 17:58:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=cHzHjlq46eqDNP0LJMvIxHcfNEk4/NGcQ0aOKee1uyc=;
 b=kiPyAPs6+oUoRFlY4K20dHUCQySjMPEdSc07AWAtTVHEpUPiKMm7SCo/GXzQvVXXVd
 BZATwQEs1pMDk3kyA4sh2tACt+wcDEDz11RztMPx/cZlpa1lqvdlffDChA2p4qlif4qj
 9LQpWCrq3yvibWjkNYJG6V1X4HxqJGSnxjXcV7Q3PLsW0nHOgazNFhkJ2hluk3E1TLZa
 /q9PTXYyIy9MciyMkjxM2BTQriyoQTX99tnE8eSyP59S23Mr2oebmHgrzQhXrl3QlhaJ
 /k/Nig7nJXFwE9/ZmYUWgxyGcUIvGk/0OUOZ0UQz72Y8RgpWSosbAbYaMrnP+HO/u1eG
 dtsA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=cHzHjlq46eqDNP0LJMvIxHcfNEk4/NGcQ0aOKee1uyc=;
 b=Eeg+OeoYTnjHzF49jD/ZWOcqWbJf/nt/UPHD7E7mI2e1O78225E0eTt7Ay8cBj3poF
 z3pyqM559HAzd5TBxBetMg3NiZ+XXCRkqabAL+8oF4K/ezdEYf+ZAWEx4/Sf0CHRBoEQ
 coGmfY3shDTFsZefUPKoTwt8oBpT1ynETQJ5gplWTngP2iG3ez0IPvBFVIDXn9kP40QX
 S8rPAJdppoXmc8VhfwkzUgXXyZlgINbXTD79E78cBMh6PbAa1nCY8dradMse3fzVuhB3
 xejkSv3FCQU35RUix5QBsz5kVGwVMrFrWhg/60XjUuS/Jl1NkP4fdq/p22SbIFetTurj
 vxLw==
X-Gm-Message-State: APjAAAX9NqN5MSWJOAf+ZCMG/rnldQePNWPuWRzqlGmng/e3jP/Jbq2R
 UXwkD/EmBK9ft7Q2jjYfYeunN8Gt
X-Google-Smtp-Source: APXvYqwSu9SwR8Gihp0O8jjkD6F2o8cUGxd8Ios/ZpG/KUGt4oxoDaZudPmkCW1I0UwQvA5H9h8caw==
X-Received: by 2002:a24:c585:: with SMTP id f127mr5989037itg.159.1557449912246; 
 Thu, 09 May 2019 17:58:32 -0700 (PDT)
Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34])
 by smtp.gmail.com with ESMTPSA id
 u194sm2046846ita.1.2019.05.09.17.58.31
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Thu, 09 May 2019 17:58:31 -0700 (PDT)
From: Noam Postavsky <npostavs@HIDDEN>
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Subject: Re: bug#35663: 27.0.50; Eldoc support for apply
References: <871s17uq15.fsf@HIDDEN>
Date: Thu, 09 May 2019 20:58:30 -0400
In-Reply-To: <871s17uq15.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 10
 May 2019 02:11:34 +0200")
Message-ID: <87d0krjfbd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 35663
Cc: 35663 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Michael Heerdegen <michael_heerdegen@HIDDEN> writes:

> Hello,
>
> when editing something like
>
> (apply #'call-process
>   (car command)
>   nil
>   (if stderr-file (list t stderr-file) t)
>   nil
>   (append (cdr command) (list archive name)))
>
> eldoc support would be useful to see the argument names of
> 'call-process' instead of the signature of 'apply'.

Yes, I've kind of wanted something like this for a while.  

> +          ((and (memq (car current-fnsym) '(apply apply-partially))

funcall too please? :)

> We could also make the displayed text more special to show that this is
> actually an 'apply' call and handle the last argument specially but I
> think it would be overkill to add so much code for this side case.

Yeah, and I doubt any sort of eldoc display would be of much use for the
last apply arg anyway.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#35663; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 10 May 2019 00:11:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 09 20:11:46 2019
Received: from localhost ([127.0.0.1]:36704 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hOt8c-0005mQ-Fr
	for submit <at> debbugs.gnu.org; Thu, 09 May 2019 20:11:46 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34236)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1hOt8a-0005mF-Vn
 for submit <at> debbugs.gnu.org; Thu, 09 May 2019 20:11:45 -0400
Received: from lists.gnu.org ([209.51.188.17]:35686)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <michael_heerdegen@HIDDEN>)
 id 1hOt8V-0000ek-Ns
 for submit <at> debbugs.gnu.org; Thu, 09 May 2019 20:11:39 -0400
Received: from eggs.gnu.org ([209.51.188.92]:48618)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1hOt8U-0005wR-J9
 for bug-gnu-emacs@HIDDEN; Thu, 09 May 2019 20:11:39 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
 RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1hOt8T-0000dX-Lq
 for bug-gnu-emacs@HIDDEN; Thu, 09 May 2019 20:11:38 -0400
Received: from mout.web.de ([212.227.15.14]:39819)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <michael_heerdegen@HIDDEN>)
 id 1hOt8T-0000ci-Ad
 for bug-gnu-emacs@HIDDEN; Thu, 09 May 2019 20:11:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
 s=dbaedf251592; t=1557447095;
 bh=5o1kU8QeKBpFFkIuf5MEsy4CZzF+//4+Z/ghxty/sOI=;
 h=X-UI-Sender-Class:From:To:Subject:Date;
 b=YR4JQ8qgA1WEEvvn5lrgq+SP73RxeFxVK2luK82LhgHcTATtYOPgFEmL2AsGGVF7D
 nKd3HIhguyknKYaPQTy3gR0UmrKUcRgYLUvdo+7b1zok1zjRJW1v3hh0AJKYSdLk0P
 xRNtO5+wmIfgs8/GISPKnUeiTP0oYbCWPh7+XRCw=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from drachen.dragon ([88.66.186.107]) by smtp.web.de (mrweb003
 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LkhAC-1goSO30eeq-00aR2q for
 <bug-gnu-emacs@HIDDEN>; Fri, 10 May 2019 02:11:35 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 27.0.50; Eldoc support for apply
Date: Fri, 10 May 2019 02:11:34 +0200
Message-ID: <871s17uq15.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K1:J027qUcIIN8SOFaMVWT8KK/q5wnqzjcY50f/mjgT8HxncKz/gbx
 TiSMZFXa8dw3Hbzv0OIsZHVdbsPT94m5P0+3/BNptRbsRkiMvccLSXxTvSvKZUO+I/kuPuY
 mMY51dCNUbP6gQCCK3BrKoPbTrNiFYyCwJJ5pNBmwRX0sLfNQcPXTYBUaIPaFkXg4TbYLxj
 L/edwApiBKsiO/OA/qpow==
X-UI-Out-Filterresults: notjunk:1;V03:K0:WbBS3FPqsYY=:mL56P4U+ShBDwsfTrM99/y
 E88M2aJjGV+ZpNj/9PR3EOWrQveSNRze9jF8Mv7iUswZ5UCYXTkzz4MVYFRc0LCpYgueMgNGn
 6GQ48Vq3WW3yDqe3zR9JmWjGBM5z4yxv/1M3Ljyz9d3GZFbA4w9NM6S4hBcIqKGcDZgr/91zu
 NSOrKGhMmMPMPDmgDblu7MtmvklOiqmMbGmYeI8B8SZ/eV5+fRGs4R0q9p/rkbZhNGhVrJ/qq
 CVqVvCvtWSpCCBTtKdL46+Y2E4aZRGsEQgiJycrliQitwJ8oBFVxR9Z4nzU3DvWvXJ+A2O4vX
 y2+qmt4V20y4QioFseALNlhi0STjXeaU+ZBvcX5GZ8ct0lWzI5+ZcnVqxH5Hm7i6F/uy1ZFK4
 efLDQhXB4YQi3foALxCBUK88eQYd05H0tqjtjjO5Sdh80trpEAEn9NKEuBTY8VzrivflbrGEj
 6AAd8sMUodBZP9igy5kF+zW4T4AYbuPuGishP5gGHXzhaHOdjfEDvmJZi05wIOERH563BaHO4
 oDaK+zbm8+5IyOXIzs/QraVyiPOkrHt8MQKe/KXzWfjhlJlqM6K52zslImZOf5gYktlFCr1Yw
 B4jRVt8riWCUhhql7ILIRB8h9epTvktKxXDdmqkuAp4GvEJK+MuFD0oR9D5PtV1Iid8xbQeY6
 LbINFJCFyJ7Sn2l51oEyOCy2Rqzqsps0eKv0p9Sxdlnxl3oYtaLynr/6eNvokBQJfxiH2CgNi
 o+Xpo8Q9g010YH6hUoB+BaRyglHKUas1j0ka5q75RNL9R+LSwfXYDYvIQIGyFSoA1BaBBqWDi
 32Rb8qhDW29E3sP+NoL7ovNE37Sf4CWcbF5p7CpwvmDIt47MjyP8K5plDS+DcmbPLzfRSI6Me
 UVxSWGsnxxPwsWGAIS6LEbLPIs7dJ1vTdLD1AgHz/KQlAWwQzHyqItr2nNRKBoyLu92odhJvK
 Rm8rv90sXSQ==
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 212.227.15.14
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain


Hello,

when editing something like

(apply #'call-process
  (car command)
  nil
  (if stderr-file (list t stderr-file) t)
  nil
  (append (cdr command) (list archive name)))

eldoc support would be useful to see the argument names of
'call-process' instead of the signature of 'apply'.

Would doing something like this be acceptable?


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-WIP-Make-eldoc-handle-apply-specially.patch
Content-Transfer-Encoding: quoted-printable

=46rom 5eb45fe4a22bb8d130e5318335439b11ef00623b Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Date: Fri, 10 May 2019 02:00:18 +0200
Subject: [PATCH] WIP: Make eldoc handle 'apply' specially

=2D--
 lisp/progmodes/elisp-mode.el | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index cb1b17b447..7631bc60b1 100644
=2D-- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -1356,6 +1356,16 @@ elisp-eldoc-documentation-function
 	  ((eq current-symbol (car current-fnsym))
 	   (or (apply #'elisp-get-fnsym-args-string current-fnsym)
 	       (elisp-get-var-docstring current-symbol)))
+          ((and (memq (car current-fnsym) '(apply apply-partially))
+                (< 1 (cadr current-fnsym))
+                (let ((args (save-excursion
+                              (let ((argument-index (- (elisp--beginning-=
of-sexp) 2)))
+                                (forward-sexp)
+                                (save-match-data
+                                  (and (looking-at (rx (* (or space "\n")=
) (or "`" "'" "#'")))
+                                       (goto-char (match-end 0))
+                                       (list (elisp--current-symbol) argu=
ment-index)))))))
+                  (and args (apply #'elisp-get-fnsym-args-string args))))=
)
 	  (t
 	   (or (elisp-get-var-docstring current-symbol)
 	       (apply #'elisp-get-fnsym-args-string current-fnsym))))))
=2D-
2.20.1


--=-=-=
Content-Type: text/plain


We could also make the displayed text more special to show that this is
actually an 'apply' call and handle the last argument specially but I
think it would be overkill to add so much code for this side case.  OTOH
the suggested patch above already feels like a big relief.


Michael.



--=-=-=--




Acknowledgement sent to Michael Heerdegen <michael_heerdegen@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#35663; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 26 Aug 2020 10:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.