GNU bug report logs - #35668
26.2; default value of `dired-omit-files'

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Fri, 10 May 2019 13:43:01 UTC

Severity: wishlist

Tags: fixed

Found in version 26.2

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35668 in the body.
You can then email your comments to 35668 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#35668; Package emacs. (Fri, 10 May 2019 13:43:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 10 May 2019 13:43:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.2; default value of `dired-omit-files'
Date: Fri, 10 May 2019 06:41:49 -0700 (PDT)
As mentioned in passing in bug #34911, I think the default value should
be this:

"\\`\\.?#\\|\\`\\.\\'\\|\\`\\.\\.\\'"

instead of this:

"^\\.?#\\|^\\.$\\|^\\.\\.$"


In GNU Emacs 26.2 (build 1, x86_64-w64-mingw32)
 of 2019-04-13
Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749
Windowing system distributor `Microsoft Corp.', version 10.0.17134
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#35668; Package emacs. (Sun, 12 May 2019 16:48:02 GMT) Full text and rfc822 format available.

Message #8 received at 35668 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 35668 <at> debbugs.gnu.org
Subject: Re: bug#35668: 26.2; default value of `dired-omit-files'
Date: Sun, 12 May 2019 12:47:44 -0400
[Message part 1 (text/plain, inline)]
Drew Adams <drew.adams <at> oracle.com> writes:

> As mentioned in passing in bug #34911, I think the default value should
> be this:
>
> "\\`\\.?#\\|\\`\\.\\'\\|\\`\\.\\.\\'"
>
> instead of this:
>
> "^\\.?#\\|^\\.$\\|^\\.\\.$"

Right, I'd also escape the "." with [], because so many backslashes make
my eyes hurt.

[0001-Fix-dired-omit-files-regexp-Bug-35668.patch (text/x-diff, inline)]
From 1be76f5272236d8238cf8a39ed96732478ea6e39 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs <at> gmail.com>
Date: Sun, 12 May 2019 12:42:35 -0400
Subject: [PATCH] Fix dired-omit-files regexp (Bug#35668)

* lisp/dired-x.el (dired-omit-files): Match beginning and of string,
rather than beginning of end of line.
---
 lisp/dired-x.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/dired-x.el b/lisp/dired-x.el
index defc541ddc..3b78ec47d9 100644
--- a/lisp/dired-x.el
+++ b/lisp/dired-x.el
@@ -159,7 +159,7 @@ (define-minor-mode dired-omit-mode
 
 (put 'dired-omit-mode 'safe-local-variable 'booleanp)
 
-(defcustom dired-omit-files "^\\.?#\\|^\\.$\\|^\\.\\.$"
+(defcustom dired-omit-files "\\`[.]?#\\|\\`[.][.]?\\'"
   "Filenames matching this regexp will not be displayed.
 This only has effect when `dired-omit-mode' is t.  See interactive function
 `dired-omit-mode' (\\[dired-omit-mode]) and variable
-- 
2.11.0


Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#35668; Package emacs. (Sun, 19 May 2019 14:38:01 GMT) Full text and rfc822 format available.

Message #11 received at 35668 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 35668 <at> debbugs.gnu.org
Subject: Re: bug#35668: 26.2; default value of `dired-omit-files'
Date: Sun, 19 May 2019 10:36:52 -0400
tags 35668 fixed
close 35668 27.1
quit

> Subject: [PATCH] Fix dired-omit-files regexp (Bug#35668)
>
> * lisp/dired-x.el (dired-omit-files): Match beginning and of string,
> rather than beginning of end of line.

Fixed typos in message and pushed to master.

d7c8196c96 2019-05-19T10:35:51-04:00 "Fix dired-omit-files regexp (Bug#35668)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d7c8196c96fd4bb732d1336305943feb3badf27c





Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Sun, 19 May 2019 14:38:03 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.1, send any further explanations to 35668 <at> debbugs.gnu.org and Drew Adams <drew.adams <at> oracle.com> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Sun, 19 May 2019 14:38:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 17 Jun 2019 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 286 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.