GNU bug report logs - #35720
[PATCH] gnu: Add chocolate-doom.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35720 in the body.
You can then email your comments to 35720 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Jakob L. Kreuze" <zerodaysfordays <at> sdf.lonestar.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add chocolate-doom.
Date: Mon, 13 May 2019 15:42:52 -0400

[Message part 1 (text/plain, inline)]

Patch adding a package for Chocolate Doom, which I felt was appropriate
as both Odamex and GZDoom are packaged in Guix.

Regards,
Jakob L. Kreuze

[0001-gnu-Add-chocolate-doom.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: guix-patches <at> gnu.org
Cc: 35720 <at> debbugs.gnu.org
Subject: Re: [bug#35720] [PATCH] gnu: Add chocolate-doom.
Date: Thu, 16 May 2019 16:03:43 -0400

Jakob L. Kreuze writes:

> Patch adding a package for Chocolate Doom, which I felt was appropriate
> as both Odamex and GZDoom are packaged in Guix.
>
> Regards,
> Jakob L. Kreuze

Hey Jakob!  Your patch looks good in general, though I haven't had a
chance to try building and running it yet.  Maybe just a couple of
things:

 - I think it would be "New variable" rather than "New variables" in the
   commit message.  Not that this is a big deal, and I could fix it.
 - It would be good to test if it can run with freedoom (a libre doom
   content replacement for doom that's functionaly similar).  My guess
   is that the one change would need to be adjusting where the default
   searched WAD path is.  freedoom and gzdoom both add a reference to
   /share/games/doom so I'm guessing that's how it's found.  However
   I'm not positive about that.

Looking good though in general!

Message #14 received at 35720 <at> debbugs.gnu.org (full text, mbox):

From: "Jakob L. Kreuze" <zerodaysfordays <at> sdf.lonestar.org>
To: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
Cc: 35720 <at> debbugs.gnu.org
Subject: Re: [bug#35720] [PATCH] gnu: Add chocolate-doom.
Date: Thu, 16 May 2019 19:21:24 -0400

[Message part 1 (text/plain, inline)]

Hey, Chris!

On Thu, May 16, 2019 at 04:03:43PM -0400, Christopher Lemmer Webber wrote:
>  - I think it would be "New variable" rather than "New variables" in
>    the commit message. Not that this is a big deal, and I could fix
>    it.

If I update the patch to address your second point, I can change it.
Otherwise, if you'd be willing to fix it when merging, that'd be great.

>  - It would be good to test if it can run with freedoom (a libre doom
>    content replacement for doom that's functionaly similar). My guess
>    is that the one change would need to be adjusting where the default
>    searched WAD path is. freedoom and gzdoom both add a reference to
>    /share/games/doom so I'm guessing that's how it's found. However
>    I'm not positive about that.

GZDoom adds a reference to /share/games/doom because it bundles a .pk3
file containing some port-specific things which ends up in the store,
and my understanding is that Freedoom updates DOOMWADDIR and DOOMWADPATH
to point to where the wads are in the profile, so I don't think patching
the search paths is necessary.

Thanks for reviewing this!

Jakob

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 35720-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: "Jakob L. Kreuze" <zerodaysfordays <at> sdf.lonestar.org>
Cc: 35720-done <at> debbugs.gnu.org
Subject: Re: [bug#35720] [PATCH] gnu: Add chocolate-doom.
Date: Fri, 24 May 2019 10:54:13 -0400

Jakob L. Kreuze writes:

> GZDoom adds a reference to /share/games/doom because it bundles a .pk3
> file containing some port-specific things which ends up in the store,
> and my understanding is that Freedoom updates DOOMWADDIR and DOOMWADPATH
> to point to where the wads are in the profile, so I don't think patching
> the search paths is necessary.
>
> Thanks for reviewing this!
>
> Jakob

At any rate, I discovered that the freedoom script actually *itself*
searches for a possible binary and launches it with the appropriate WAD
given as an argument, of which chocolate-doom is considered a valid
option.

So, seems good!  I pushed the patch to Guix master... chocolate-doom is
now part of Guix :)

Congrats on getting in your first package!  Great work, Jakob.
 - Chris

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.