GNU bug report logs -
#35741
[PATCH] gnu: Add libdbusmenu.
Previous Next
Reported by: Meiyo Peng <meiyo <at> riseup.net>
Date: Wed, 15 May 2019 05:10:02 UTC
Severity: normal
Tags: patch
Done: Ludovic Courtès <ludo <at> gnu.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35741 in the body.
You can then email your comments to 35741 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#35741
; Package
guix-patches
.
(Wed, 15 May 2019 05:10:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Meiyo Peng <meiyo <at> riseup.net>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Wed, 15 May 2019 05:10:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/gtk.scm (libdbusmenu): New variable.
---
gnu/packages/gtk.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 6e63ca6614..a885d35080 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -20,6 +20,7 @@
;;; Copyright © 2018 Alex Vong <alexvong1995 <at> gmail.com>
;;; Copyright © 2018 Arun Isaac <arunisaac <at> systemreboot.net>
;;; Copyright © 2018 Pierre Neidhardt <mail <at> ambrevar.xyz>
+;;; Copyright © 2019 Meiyo Peng <meiyo <at> riseup.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -1754,3 +1755,53 @@ popular spread sheet programs.")
shell scripts. Example of how to use @code{yad} can be consulted at
@url{https://sourceforge.net/p/yad-dialog/wiki/browse_pages/}.")
(license license:gpl3+)))
+
+(define-public libdbusmenu
+ (package
+ (name "libdbusmenu")
+ (version "16.04.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://launchpad.net/libdbusmenu/"
+ (version-major+minor version) "/" version
+ "/+download/libdbusmenu-" version ".tar.gz"))
+ (sha256
+ (base32 "12l7z8dhl917iy9h02sxmpclnhkdjryn08r8i4sr8l3lrlm4mk5r"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:configure-flags
+ '("--sysconfdir=/etc"
+ "--localstatedir=/var"
+ ;; The shebang of the generated test files should be patched before
+ ;; enabling tests.
+ "--disable-tests")
+ #:make-flags
+ `(,(string-append "typelibdir=" (assoc-ref %outputs "out")
+ "/lib/girepository-1.0"))
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'configure 'set-environment
+ (lambda _
+ (setenv "HAVE_VALGRIND_TRUE" "")
+ (setenv "HAVE_VALGRIND_FALSE" "#")
+ #t)))))
+ (inputs
+ `(("glib" ,glib)
+ ("gtk+" ,gtk+)
+ ("gtk+-2" ,gtk+-2)))
+ (native-inputs
+ `(("glib:bin" ,glib "bin")
+ ("gnome-doc-utils" ,gnome-doc-utils)
+ ("gobject-introspection" ,gobject-introspection)
+ ("intltool" ,intltool)
+ ("json-glib" ,json-glib)
+ ("pkg-config" ,pkg-config)
+ ("python" ,python-2)
+ ("vala" ,vala)))
+ (home-page "https://launchpad.net/libdbusmenu")
+ (synopsis "Library for passing menus over DBus")
+ (description "@code{libdbusmenu} passes a menu structure across DBus so
+that a program can create a menu simply without worrying about how it is
+displayed on the other side of the bus.")
+ (license (list license:gpl3 license:lgpl2.1 license:lgpl3))))
--
2.21.0
Reply sent
to
Ludovic Courtès <ludo <at> gnu.org>
:
You have taken responsibility.
(Mon, 20 May 2019 21:25:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Meiyo Peng <meiyo <at> riseup.net>
:
bug acknowledged by developer.
(Mon, 20 May 2019 21:25:02 GMT)
Full text and
rfc822 format available.
Message #10 received at 35741-done <at> debbugs.gnu.org (full text, mbox):
Hi!
Meiyo Peng <meiyo <at> riseup.net> skribis:
> * gnu/packages/gtk.scm (libdbusmenu): New variable.
Applied!
> + ;; The shebang of the generated test files should be patched before
> + ;; enabling tests.
> + "--disable-tests")
It would be nice if you could follow up with a patch to run the tests.
> + (license (list license:gpl3 license:lgpl2.1 license:lgpl3))))
In a subsequent patch, I clarified the licensing here, which is
dual-license LGPLv2.1 | LGPLv3 according to the header that can be seen
here:
https://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu/trunk.16.10/view/head:/libdbusmenu-glib/menuitem-private.h
Thanks,
Ludo’.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#35741
; Package
guix-patches
.
(Thu, 23 May 2019 02:05:01 GMT)
Full text and
rfc822 format available.
Message #13 received at 35741-done <at> debbugs.gnu.org (full text, mbox):
Hi Ludovic,
Ludovic Courtès writes:
> Meiyo Peng <meiyo <at> riseup.net> skribis:
>
>> * gnu/packages/gtk.scm (libdbusmenu): New variable.
>
> Applied!
>
>> + ;; The shebang of the generated test files should be patched before
>> + ;; enabling tests.
>> + "--disable-tests")
>
> It would be nice if you could follow up with a patch to run the tests.
Will try.
>> + (license (list license:gpl3 license:lgpl2.1 license:lgpl3))))
>
> In a subsequent patch, I clarified the licensing here, which is
> dual-license LGPLv2.1 | LGPLv3 according to the header that can be seen
> here:
>
> https://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu/trunk.16.10/view/head:/libdbusmenu-glib/menuitem-private.h
Good catch. But this project's license is weird.
According to: https://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu/trunk.16.10/view/head:/debian/copyright
#+begin_example
Files: *
Copyright: 2009-2010 Ted Gould <ted <at> canonical.com>, Canonical Ltd.
License: GPL-3
Files: libdbusmenu-{glib,gtk}/*
Copyright: 2009-2010 Ted Gould <ted <at> canonical.com>, Canonical Ltd.
License: LGPL-2.1 | LGPL-3
Files: libdbusmenu-glib/dbus-menu.xml
Copyright: 2009-2010 Ted Gould <ted <at> canonical.com>, Canonical Ltd.
Copyright: 2009-2010 Aurélien Gâteau <aurelien.gateau <at> canonical.com>
License: LGPL-2.1 | LGPL-3
Files: tools/{dbusmenu-bench,testapp/main.c}
Copyright: 2009-2010 Aurélien Gâteau <aurelien.gateau <at> canonical.com>
License: LGPL-2.1 | LGPL-3
Files: debian/*
Copyright: 2009-2010 Evgeni Golov <evgeni <at> debian.org>
Copyright: 2009-2010 Ted Gould <ted <at> canonical.com>, Canonical Ltd.
Copyright: 2009-2010 Sebastien Bacher <seb128 <at> ubuntu.com>
Copyright: 2009-2010 Ken VanDine <ken.vandine <at> canonical.com>
License: GPL-3
#+end_example
libdbusmenu-glib, libdbusmenu-gtk, and some files in tools are dual
licensed under LGPLv2.1 and LGPLv3. The rest files are licensed under
GPLv3. For example:
#+begin_example
https://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu/trunk.16.10/view/head:/tests/json-loader.c
https://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu/trunk.16.10/view/head:/tools/dbusmenu-dumper.c
#+end_example
So we should clarify it further.
--
Meiyo Peng
https://www.pengmeiyu.com/
Information forwarded
to
guix-patches <at> gnu.org
:
bug#35741
; Package
guix-patches
.
(Fri, 24 May 2019 15:30:03 GMT)
Full text and
rfc822 format available.
Message #16 received at 35741-done <at> debbugs.gnu.org (full text, mbox):
Hello,
Meiyo Peng <meiyo <at> riseup.net> skribis:
>>> + ;; The shebang of the generated test files should be patched before
>>> + ;; enabling tests.
>>> + "--disable-tests")
>>
>> It would be nice if you could follow up with a patch to run the tests.
>
> Will try.
Great.
> libdbusmenu-glib, libdbusmenu-gtk, and some files in tools are dual
> licensed under LGPLv2.1 and LGPLv3. The rest files are licensed under
> GPLv3. For example:
>
> #+begin_example
> https://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu/trunk.16.10/view/head:/tests/json-loader.c
> https://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu/trunk.16.10/view/head:/tools/dbusmenu-dumper.c
> #+end_example
>
> So we should clarify it further.
I’d argue that ‘license’ is about the license of what we install, so the
license of the tests or build scripts (say) doesn’t matter much, but
‘dbusmenu-dumper’ is presumably something we install. So I agree:
further clarification is welcome!
Thanks for explaining,
Ludo’.
Information forwarded
to
guix-patches <at> gnu.org
:
bug#35741
; Package
guix-patches
.
(Sat, 25 May 2019 02:02:01 GMT)
Full text and
rfc822 format available.
Message #19 received at 35741-done <at> debbugs.gnu.org (full text, mbox):
Hi Ludovic,
Ludovic Courtès writes:
> I’d argue that ‘license’ is about the license of what we install, so the
> license of the tests or build scripts (say) doesn’t matter much
OK.
--
Meiyo Peng
https://www.pengmeiyu.com/
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Sat, 22 Jun 2019 11:24:05 GMT)
Full text and
rfc822 format available.
This bug report was last modified 4 years and 302 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.