GNU bug report logs - #35743
guix import hackage: fails with mixed indentation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35743 in the body.
You can then email your comments to 35743 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: bug-guix <at> gnu.org
Subject: guix import hackage wai-app-static fails (comment syntax?)
Date: Wed, 15 May 2019 11:12:28 +0200

$ guix import hackage wai-app-static
Syntax error: unexpected token : (ghc-options (-Wall)) (at line 106, column 2)

The relevant extract of the cabal file is:

test-suite runtests
[…]
    build-depends:   base                      >= 4        && < 5
[…]
                   , mockery
                   -- , containers
  ghc-options:   -Wall

Presumably the double dash comment is tripping `guix import` up.

Message #8 received at 35743 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: 35743 <at> debbugs.gnu.org
Subject: indentation error
Date: Wed, 15 May 2019 11:21:42 +0200

I learned about `guix import hackage --stdin`, and it turns out the problem is with bad indentation in the cabal file. (The offending line is indented by two spaces instead of four spaces for the block before.) It’s unclear to me whether this is a “valid” cabal file as it is.

Message #11 received at 35743 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: 35743 <at> debbugs.gnu.org
Subject: fixed upstream
Date: Wed, 22 May 2019 09:27:44 +0200

This specific case has been fixed upstream, and should eventually
make it to hackage:

https://github.com/yesodweb/wai/pull/748

The issue does remain in the sense that `guix import` doesn’t parse
some such cabal files that `cabal` is happy with — mark done anyway?

Message #14 received at 35743 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: 35743 <at> debbugs.gnu.org
Subject: applies more widely
Date: Fri, 24 May 2019 17:28:01 +0200

The problem seems more wide-spread, so should probably be fixed within import/cabal.scm.

E.g. warp:

http://hackage.haskell.org/package/warp-3.2.27/warp.cabal
http://hackage.haskell.org/package/streaming-commons-0.2.1.0/streaming-commons.cabal

contain things along the following lines:

benchmark builder-to-bytestring-io
    ...
    build-depends:  base
                  , bytestring >= 0.10.2
                  , gauge
                  , deepseq
                  , streaming-commons

  if flag(use-bytestring-builder)
    build-depends:     bytestring < 0.10.2.0
                     , bytestring-builder

This kind of out-dented conditional seems not very rare.

Message #21 received at 35743-done <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Robert Vollmert <rob <at> vllmrt.net>
Cc: 35743-done <at> debbugs.gnu.org
Subject: Re: guix import hackage: fails with mixed indentation
Date: Sun, 3 Dec 2023 09:16:24 +0100

Hi,

> http://hackage.haskell.org/package/warp-3.2.27/warp.cabal
> http://hackage.haskell.org/package/streaming-commons-0.2.1.0/streaming-commons.cabal
> 
> contain things along the following lines:

these should be fixed by the patch in #67564.

Cheers,
Lars

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.