GNU bug report logs - #35749
[PATCH] services: sddm: fix root login failure issue.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Reza Alizadeh Majd <r.majd@HIDDEN>; Keywords: patch; dated Wed, 15 May 2019 14:26:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 35749 <at> debbugs.gnu.org:


Received: (at 35749) by debbugs.gnu.org; 21 May 2019 11:26:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 21 07:26:19 2019
Received: from localhost ([127.0.0.1]:38767 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hT2uR-00027Q-Ip
	for submit <at> debbugs.gnu.org; Tue, 21 May 2019 07:26:19 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34661)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <r.majd@HIDDEN>) id 1hT2uQ-00027E-3f
 for 35749 <at> debbugs.gnu.org; Tue, 21 May 2019 07:26:18 -0400
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 3619523C7C;
 Tue, 21 May 2019 07:26:12 -0400 (EDT)
Received: from imap5 ([10.202.2.55])
 by compute5.internal (MEProxy); Tue, 21 May 2019 07:26:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h=
 mime-version:message-id:in-reply-to:references:date:from:to:cc
 :subject:content-type:content-transfer-encoding; s=fm2; bh=yxDQZ
 in5O+ePvlDXtqOVH3QHowHETdjGVqiEw4oR22U=; b=TItlerWNykqthMixpEVkG
 g/xstX9A3x9ImNUBrk/QkcsEbopoV78RLIy8e/dJuac730AGi2IfBVDoGmg7OzKa
 3TlqSJzPTaJjKMWSNUuYiRrXWZA/NgZcWUDFxOWvtzxOcmk4f3+v87KABLVSlEl1
 xebIJdY8b2x2xtd01HZQxKvREynsuf7v8cCi86DJEevB7jeIWeQgENHrQDY5JC/K
 x6gB9rWSgdpefAqFM7VECnw2bkqkPI2BpvMUnHCAldovXmdmPglxJgM9f+aoaY4x
 LJABIdOnD7W+JyVpdgvBa0mmF44s0RB0lYxmoDAw2rk17npzztLjcyVTG3c0DvAx
 w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=yxDQZin5O+ePvlDXtqOVH3QHowHETdjGVqiEw4oR2
 2U=; b=au9DVIWhGpYlbt23oj3kDfq9lXVL/Mvb4xaoOj679j2Aq/y1fJBYWno5I
 oEHZj+gN5k+44sZPXhxzeYHcZOa1qw/8bNY2USUp89h3SZ+65+w9lDinROZ0i2U+
 jwJF3OMNSWkxywHbMW80ZOeqioXTs9thmR1sXt5vXVTFSRoAld1Q8WQU6w+pvPso
 k03SdVCA6q6P7JMwa9qs19y4l9jALGlZX7gBFNWtOygUlYcOh/T0RpEmM4WYdQ3o
 HrQbI0TTf7kEGuB/RY/bXz51rkBTE7FdITKNFu0sHEoVdDSALwR1KxgaOk34zBru
 45uib6yw30F5m6GigKRD0GLXuG23w==
X-ME-Sender: <xms:U-DjXH4dqgodsb-lAMDuGK5EZpkJ-178dM7aIA2Z1Rk08HssVKyUfg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddutddggedtucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedftfgv
 iigrucetlhhiiigruggvhhcuofgrjhgufdcuoehrrdhmrghjugesphgrnhhthhgvrhigrd
 horhhgqeenucfrrghrrghmpehmrghilhhfrhhomheprhdrmhgrjhgusehprghnthhhvghr
 gidrohhrghenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:U-DjXEnZtsd9-2yBk6sI00RXURafz0RJ6-eSo8yZ9No4317wpeaCmg>
 <xmx:U-DjXAoqDFC9HVMK5HnnY_-ITmFLkt3bUqBWCEzsxibQ6YFNVLq6qg>
 <xmx:U-DjXG1n1Dh3bxbIBiuw5rlmKBkKdU-tvhwq5YW4JNzxgLbFsZiFLw>
 <xmx:VODjXK2SgCcmL-dXO2qn5ZtrIlIiOhye7u6IK1Y0SZli49WQZKbQJw>
Received: by mailuser.nyi.internal (Postfix, from userid 501)
 id 66F4D31139; Tue, 21 May 2019 07:26:11 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.6-550-g29afa21-fmstable-20190520v1
Mime-Version: 1.0
Message-Id: <41a6a5e2-86cc-42d6-995e-a20c0217924e@HIDDEN>
In-Reply-To: <87y330omhs.fsf@HIDDEN>
References: <20190515141154.31832-1-r.majd@HIDDEN>
 <87y330omhs.fsf@HIDDEN>
Date: Tue, 21 May 2019 15:56:11 +0430
From: "Reza Alizadeh Majd" <r.majd@HIDDEN>
To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: [bug#35749] [PATCH] services: sddm: fix root login failure issue.
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 35749
Cc: 35749 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi,=20

> Could you send an updated patch that documents the =E2=80=98minimum-ui=
d=E2=80=99 field
> in doc/guix.texi, under =E2=80=98sddm-configuration=E2=80=99?

Is it possible to submit further changes to this patch, or I need to sub=
mit a new one with whole changes?=20

Thanks,=20
Reza




Information forwarded to guix-patches@HIDDEN:
bug#35749; Package guix-patches. Full text available.

Message received at 35749 <at> debbugs.gnu.org:


Received: (at 35749) by debbugs.gnu.org; 20 May 2019 21:16:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 20 17:16:27 2019
Received: from localhost ([127.0.0.1]:38169 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hSpdy-0001rw-JQ
	for submit <at> debbugs.gnu.org; Mon, 20 May 2019 17:16:26 -0400
Received: from eggs.gnu.org ([209.51.188.92]:38550)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1hSpdw-0001rj-Sl
 for 35749 <at> debbugs.gnu.org; Mon, 20 May 2019 17:16:25 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:60884)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
 id 1hSpdr-0007jB-OV; Mon, 20 May 2019 17:16:19 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57998 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1hSpdr-0001KO-Aa; Mon, 20 May 2019 17:16:19 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Reza Alizadeh Majd <r.majd@HIDDEN>
Subject: Re: [bug#35749] [PATCH] services: sddm: fix root login failure issue.
References: <20190515141154.31832-1-r.majd@HIDDEN>
Date: Mon, 20 May 2019 23:16:15 +0200
In-Reply-To: <20190515141154.31832-1-r.majd@HIDDEN> (Reza Alizadeh
 Majd's message of "Wed, 15 May 2019 18:41:54 +0430")
Message-ID: <87y330omhs.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 35749
Cc: 35749 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Reza Alizadeh Majd <r.majd@HIDDEN> skribis:

> * gnu/services/sddm.scm
>      (sdm-pam-service): set uid from config.
>      (sdm-autologin-pam-service): set uid from config.
>      (sdm-pam-services): pass sddm-configuration to sddm-pam-service and
> sddm-autologin-pam-service
> ---
>  gnu/services/sddm.scm | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)

Could you send an updated patch that documents the =E2=80=98minimum-uid=E2=
=80=99 field
in doc/guix.texi, under =E2=80=98sddm-configuration=E2=80=99?

Apart from that it LGTM.

Thanks for fixing this!

Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#35749; Package guix-patches. Full text available.

Message received at 35749 <at> debbugs.gnu.org:


Received: (at 35749) by debbugs.gnu.org; 15 May 2019 14:35:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 15 10:35:03 2019
Received: from localhost ([127.0.0.1]:53137 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hQuzn-0006c2-I3
	for submit <at> debbugs.gnu.org; Wed, 15 May 2019 10:35:03 -0400
Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:57401)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <r.majd@HIDDEN>) id 1hQuzl-0006bR-MD
 for 35749 <at> debbugs.gnu.org; Wed, 15 May 2019 10:35:02 -0400
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id 9CE274AD
 for <35749 <at> debbugs.gnu.org>; Wed, 15 May 2019 10:34:55 -0400 (EDT)
Received: from imap5 ([10.202.2.55])
 by compute5.internal (MEProxy); Wed, 15 May 2019 10:34:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h=
 mime-version:message-id:date:from:to:subject:content-type; s=
 fm2; bh=TB3RI/leGhNg2C8HjAhgFtnQBJ8MeUgCQiJyzizJj6Y=; b=HQqs9gZH
 DOGKp8EqdnIEK6du99Tv2BuF3mvci9eHHpKVoHuIhhpIHi1WnA4EOIbuJOZwMeHr
 4JPcZGcEvZnshiS98xMOPv9YAQNf2VrAzZumGXtoMECNCaqjnM4zA3hhSkDXUVBQ
 noDZBSDiUvKX8YZle4wsYPuWhAJglxWFiqyChW1fxNehnByoGLP3ahXoICVlCHeA
 jAnR57OnLOBUMbTG2DRfYSSvYHTYzblW+Ilv5+T7fBsl7C7DqC+LapXQSvKpb+3g
 lKX2eHj7HX8p0ud3XFd5M07A+YnFvtPdkOfSUrWm9iWB0MPHRs5J5FINk2UqPLXF
 dDSHprcpkPWtKw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:message-id
 :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender
 :x-me-sender:x-sasl-enc; s=fm2; bh=TB3RI/leGhNg2C8HjAhgFtnQBJ8Me
 UgCQiJyzizJj6Y=; b=roun99TKcVlbYma/8gc2iXGHkdKnlx1U39mADLH71iwpH
 0N9ThA3G6b5aK0pYtZakCHtI5ZaFy4V9kohGMYGX8miOGuPndCBd7h0UH6r6aGXh
 XxfMnhwLYSzNrarz7zAumJRIFG1e+FfPJF1mnbebs+YH3ss0A3bDiaCzby5F19SA
 Z9A+ulQamz9lCl9I8w31qVIQ6+Vj3e46kq0mabdyiJdtWyjcCDjZT28IjRYRHGqR
 C8zW1wSsEAl2U28XQaEtkVkaEf7HYzvPKimcVwX60o0coe769jag/K6koWwxpi33
 feQGU4BTasEMHtbQlSP6U4gMZlvs00lGigYr/U/AA==
X-ME-Sender: <xms:jiPcXJz_4v6vPnEfG56GZVZSWa-i6O0Q-Vx8vOUigvRW539_y3e3bQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleekgdejjecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesthdtredtre
 ertdenucfhrhhomhepfdftvgiirgcutehlihiirgguvghhucforghjugdfuceorhdrmhgr
 jhgusehprghnthhhvghrgidrohhrgheqnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrrd
 hmrghjugesphgrnhhthhgvrhigrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:jiPcXE7DnvXNoLZ6sTm0i8pTVSUXoRZwMy1JjIOwbz_G_ZsZrWQ-xQ>
 <xmx:jiPcXFfToIeXyLEn5Vx_6HtD_EE8hpJx529R1yQUffyF5qgayAt89Q>
 <xmx:jiPcXJ52DjNIeX16cdOXUSS-BNe6NsTv5jO1uKute6m4ZR83N2j1oQ>
 <xmx:jyPcXJ4-sBi_LKKnoxkz57o0WmZlilhju3WtOnO5muQNz6HkyaXiVw>
Received: by mailuser.nyi.internal (Postfix, from userid 501)
 id D0796310EF; Wed, 15 May 2019 10:34:54 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.6-541-gda5ca9a-fmstable-20190515v2
Mime-Version: 1.0
Message-Id: <aa45b334-f4fd-4b30-9c8c-4b1639781f46@HIDDEN>
Date: Wed, 15 May 2019 19:04:54 +0430
From: "Reza Alizadeh Majd" <r.majd@HIDDEN>
To: 35749 <at> debbugs.gnu.org
Subject: SDDM root login issue
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 35749
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

There was an issue for root login using SDDM, that was related to hard-coded uid  in sddm-pam-service. 
this patch set's the uid based on `minimum-uid` option in `sddm-configuration`.

Best, 
Reza




Information forwarded to guix-patches@HIDDEN:
bug#35749; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 15 May 2019 14:25:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 15 10:25:38 2019
Received: from localhost ([127.0.0.1]:53120 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hQuqg-0006Ls-7X
	for submit <at> debbugs.gnu.org; Wed, 15 May 2019 10:25:38 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45698)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <reza@HIDDEN>) id 1hQuqd-0006Le-OK
 for submit <at> debbugs.gnu.org; Wed, 15 May 2019 10:25:36 -0400
Received: from lists.gnu.org ([209.51.188.17]:40912)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <reza@HIDDEN>)
 id 1hQuqY-0005FD-IO
 for submit <at> debbugs.gnu.org; Wed, 15 May 2019 10:25:30 -0400
Received: from eggs.gnu.org ([209.51.188.92]:60080)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <reza@HIDDEN>) id 1hQuqX-0003Wa-F4
 for guix-patches@HIDDEN; Wed, 15 May 2019 10:25:30 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: *
X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,NO_DNS_FOR_FROM,
 RDNS_NONE autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <reza@HIDDEN>) id 1hQuqW-0005BL-EQ
 for guix-patches@HIDDEN; Wed, 15 May 2019 10:25:29 -0400
Received: from [5.230.148.152] (port=53337 helo=Rezas-MacBook-Pro-2.local)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <reza@HIDDEN>) id 1hQuqW-00055y-04
 for guix-patches@HIDDEN; Wed, 15 May 2019 10:25:28 -0400
Received: by Rezas-MacBook-Pro-2.local (Postfix, from userid 501)
 id E0EAD101AF85C0; Wed, 15 May 2019 18:42:37 +0430 (+0430)
From: Reza Alizadeh Majd <r.majd@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] services: sddm: fix root login failure issue.
Date: Wed, 15 May 2019 18:41:54 +0430
Message-Id: <20190515141154.31832-1-r.majd@HIDDEN>
X-Mailer: git-send-email 2.19.0
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Mac OS X  [generic] [fuzzy]
X-Received-From: 5.230.148.152
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Spam-Score: -1.9 (-)
X-Debbugs-Envelope-To: submit
Cc: Reza Alizadeh Majd <r.majd@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.9 (--)

* gnu/services/sddm.scm
     (sdm-pam-service): set uid from config.
     (sdm-autologin-pam-service): set uid from config.
     (sdm-pam-services): pass sddm-configuration to sddm-pam-service and
sddm-autologin-pam-service
---
 gnu/services/sddm.scm | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
index b433c59e12..b0e6d40260 100644
--- a/gnu/services/sddm.scm
+++ b/gnu/services/sddm.scm
@@ -175,7 +175,7 @@ Relogin=3D"              (if (sddm-configuration-relo=
gin? config)
 (define (sddm-etc-service config)
   (list `("sddm.conf" ,(sddm-configuration-file config))))
=20
-(define (sddm-pam-service)
+(define (sddm-pam-service config)
   "Return a PAM service for @command{sddm}."
   (pam-service
    (name "sddm")
@@ -190,7 +190,9 @@ Relogin=3D"              (if (sddm-configuration-relo=
gin? config)
      (pam-entry
       (control "required")
       (module "pam_succeed_if.so")
-      (arguments (list "uid >=3D 1000" "quiet")))
+      (arguments (list (string-append "uid >=3D "
+                                      (number->string (sddm-configuratio=
n-minimum-uid config)))
+                       "quiet")))
      ;; should be factored out into system-auth
      (pam-entry
       (control "required")
@@ -249,7 +251,7 @@ Relogin=3D"              (if (sddm-configuration-relo=
gin? config)
       (control "required")
       (module "pam_unix.so"))))))
=20
-(define (sddm-autologin-pam-service)
+(define (sddm-autologin-pam-service config)
   "Return a PAM service for @command{sddm-autologin}"
   (pam-service
    (name "sddm-autologin")
@@ -261,7 +263,9 @@ Relogin=3D"              (if (sddm-configuration-relo=
gin? config)
      (pam-entry
       (control "required")
       (module "pam_succeed_if.so")
-      (arguments (list "uid >=3D 1000" "quiet")))
+      (arguments (list (string-append "uid >=3D "
+                                      (number->string (sddm-configuratio=
n-minimum-uid config)))
+                       "quiet")))
      (pam-entry
       (control "required")
       (module "pam_permit.so"))))
@@ -282,9 +286,9 @@ Relogin=3D"              (if (sddm-configuration-relo=
gin? config)
       (module "sddm"))))))
=20
 (define (sddm-pam-services config)
-  (list (sddm-pam-service)
+  (list (sddm-pam-service config)
         (sddm-greeter-pam-service)
-        (sddm-autologin-pam-service)))
+        (sddm-autologin-pam-service config)))
=20
 (define %sddm-accounts
   (list (user-group (name "sddm") (system? #t))
--=20
2.19.0





Acknowledgement sent to Reza Alizadeh Majd <r.majd@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#35749; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 21 May 2019 11:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.