GNU bug report logs - #35788
[PATCH] gnu: libjit: add at 0.1.4

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35788 in the body.
You can then email your comments to 35788 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: atai <at> atai.org
To: guix-patches <at> gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH] gnu: libjit: add at 0.1.4
Date: Sat, 18 May 2019 01:06:49 -0700

From: Andy Tai <atai <at> atai.org>

---
 gnu/packages/libjit.scm | 72 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 gnu/packages/libjit.scm

diff --git a/gnu/packages/libjit.scm b/gnu/packages/libjit.scm
new file mode 100644
index 0000000000..4f35ff7de2
--- /dev/null
+++ b/gnu/packages/libjit.scm
@@ -0,0 +1,72 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2019 Li-cheng (Andy) Tai, atai <at> atai.org
+;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages libjit)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages admin)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages bash)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages flex)
+  #:use-module (gnu packages gcc)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages man)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages texinfo)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module (guix git-download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix utils)
+  #:use-module (ice-9 match)
+  #:use-module (srfi srfi-1))
+
+(define-public libjit
+  (let ((commit "554c9f5c750daa6e13a6a5cd416873c81c7b8226"))
+    (package
+    (name "libjit")
+    (version "0.1.4")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "http://git.savannah.gnu.org/cgit/libjit.git")
+                      (commit commit)))
+                (file-name (string-append name "-" version "-checkout"))
+                (sha256
+                 (base32
+                  "0p6wklslkkp3s4aisj3w5a53bagqn5fy4m6088ppd4fcfxgqkrcd"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("bison" ,bison)
+       ("flex" ,flex)
+       ("help2man" ,help2man)
+       ("gettext" ,gettext-minimal)
+       ("libtool" ,libtool)
+       ("makeinfo" ,texinfo)
+       ("pkg-config" ,pkg-config)))
+    (home-page "https://www.gnu.org/software/libjit/")
+    (synopsis "Generic Just-In-Time compiler library")
+    (description
+     "GNU libjit is a library that provides generic Just-In-Time compiler
+functionality independent of any particular bytecode, language, or
+runtime")
+    (license license:lgpl2.1+))))
-- 
2.20.1

Message #8 received at 35788 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: atai <at> atai.org
Cc: 35788 <at> debbugs.gnu.org
Subject: Re: [bug#35788] [PATCH] gnu: libjit: add at 0.1.4
Date: Tue, 21 May 2019 16:26:47 +0200

Hi Andy,

atai <at> atai.org skribis:

>  gnu/packages/libjit.scm | 72 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 72 insertions(+)
>  create mode 100644 gnu/packages/libjit.scm

Could you submit an updated patch that adds libjit to assembly.scm
instead?  Bonus point if you can provide a commit log that follows our
conventions.  :-)

Apart from these minor issues, the patch LGTM.

Thanks in advance!

Ludo’.

Message #11 received at 35788 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35788 <at> debbugs.gnu.org
Subject: Re: [bug#35788] [PATCH] gnu: libjit: add at 0.1.4
Date: Tue, 21 May 2019 07:34:34 -0700

[Message part 1 (text/plain, inline)]

Will do, thanks!

On Tue, May 21, 2019 at 7:26 AM Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi Andy,
>
> atai <at> atai.org skribis:
>
> >  gnu/packages/libjit.scm | 72 +++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 72 insertions(+)
> >  create mode 100644 gnu/packages/libjit.scm
>
> Could you submit an updated patch that adds libjit to assembly.scm
> instead?  Bonus point if you can provide a commit log that follows our
> conventions.  :-)
>
> Apart from these minor issues, the patch LGTM.
>
> Thanks in advance!
>
> Ludo’.
>


-- 
Andy Tai, atai <at> atai.org, Skype: licheng.tai, Line: andy_tai, WeChat:
andytai1010
Year 2019 民國108年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

[Message part 2 (text/html, inline)]

Message #14 received at 35788 <at> debbugs.gnu.org (full text, mbox):

From: atai <at> atai.org
To: 35788 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH] gnu: assembly: Add libjit
Date: Tue, 21 May 2019 22:29:46 -0700

From: Andy Tai <atai <at> atai.org>

* gnu/packages/assembly.scm (libjit): Add at 0.1.4
---
 gnu/packages/assembly.scm | 42 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/assembly.scm b/gnu/packages/assembly.scm
index 05c1a3f3de..8d65eb9f0e 100644
--- a/gnu/packages/assembly.scm
+++ b/gnu/packages/assembly.scm
@@ -24,11 +24,20 @@
 (define-module (gnu packages assembly)
   #:use-module (guix build-system gnu)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (gnu packages)
+  #:use-module (gnu packages admin)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages flex)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages man)
   #:use-module (gnu packages perl)
+  #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages python)
   #:use-module (gnu packages xml)
@@ -202,3 +211,36 @@ assembler, a C compiler and a linker.  The assembler uses Intel syntax
     (home-page "https://github.com/jbruchon/dev86")
     (supported-systems '("i686-linux" "x86_64-linux"))
     (license license:gpl2+)))
+
+(define-public libjit
+  (let ((commit "554c9f5c750daa6e13a6a5cd416873c81c7b8226"))
+    (package
+    (name "libjit")
+    (version "0.1.4")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "http://git.savannah.gnu.org/cgit/libjit.git")
+                      (commit commit)))
+                (file-name (string-append name "-" version "-checkout"))
+                (sha256
+                 (base32
+                  "0p6wklslkkp3s4aisj3w5a53bagqn5fy4m6088ppd4fcfxgqkrcd"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("bison" ,bison)
+       ("flex" ,flex)
+       ("help2man" ,help2man)
+       ("gettext" ,gettext-minimal)
+       ("libtool" ,libtool)
+       ("makeinfo" ,texinfo)
+       ("pkg-config" ,pkg-config)))
+    (home-page "https://www.gnu.org/software/libjit/")
+    (synopsis "Generic Just-In-Time compiler library")
+    (description
+     "GNU libjit is a library that provides generic Just-In-Time compiler
+functionality independent of any particular bytecode, language, or
+runtime")
+    (license license:lgpl2.1+))))
-- 
2.20.1

Message #19 received at 35788-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: atai <at> atai.org
Cc: 35788-done <at> debbugs.gnu.org
Subject: Re: [bug#35788] [PATCH] gnu: assembly: Add libjit
Date: Fri, 24 May 2019 17:52:18 +0200

[Message part 1 (text/plain, inline)]

Hi,

atai <at> atai.org skribis:

> From: Andy Tai <atai <at> atai.org>
>
> * gnu/packages/assembly.scm (libjit): Add at 0.1.4

Applied with the tiny changes below (synopsis suggested by ‘guix lint’,
URL fixed, and indentation adjusted).

Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/assembly.scm b/gnu/packages/assembly.scm
index 8d65eb9f0e..8cf5bcdaf5 100644
--- a/gnu/packages/assembly.scm
+++ b/gnu/packages/assembly.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2016 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2017, 2018, 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2019 Guy Fleury Iteriteka <hoonandon <at> gmail.com>
+;;; Copyright © 2019 Andy Tai <atai <at> atai.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -215,32 +216,32 @@ assembler, a C compiler and a linker.  The assembler uses Intel syntax
 (define-public libjit
   (let ((commit "554c9f5c750daa6e13a6a5cd416873c81c7b8226"))
     (package
-    (name "libjit")
-    (version "0.1.4")
+      (name "libjit")
+      (version "0.1.4")
       (source (origin
                 (method git-fetch)
                 (uri (git-reference
-                      (url "http://git.savannah.gnu.org/cgit/libjit.git")
+                      (url "https://git.savannah.gnu.org/r/libjit.git")
                       (commit commit)))
                 (file-name (string-append name "-" version "-checkout"))
                 (sha256
                  (base32
                   "0p6wklslkkp3s4aisj3w5a53bagqn5fy4m6088ppd4fcfxgqkrcd"))))
-    (build-system gnu-build-system)
-    (native-inputs
-     `(("autoconf" ,autoconf)
-       ("automake" ,automake)
-       ("bison" ,bison)
-       ("flex" ,flex)
-       ("help2man" ,help2man)
-       ("gettext" ,gettext-minimal)
-       ("libtool" ,libtool)
-       ("makeinfo" ,texinfo)
-       ("pkg-config" ,pkg-config)))
-    (home-page "https://www.gnu.org/software/libjit/")
-    (synopsis "Generic Just-In-Time compiler library")
-    (description
-     "GNU libjit is a library that provides generic Just-In-Time compiler
+      (build-system gnu-build-system)
+      (native-inputs
+       `(("autoconf" ,autoconf)
+         ("automake" ,automake)
+         ("bison" ,bison)
+         ("flex" ,flex)
+         ("help2man" ,help2man)
+         ("gettext" ,gettext-minimal)
+         ("libtool" ,libtool)
+         ("makeinfo" ,texinfo)
+         ("pkg-config" ,pkg-config)))
+      (home-page "https://www.gnu.org/software/libjit/")
+      (synopsis "Just-In-Time compilation library")
+      (description
+       "GNU libjit is a library that provides generic Just-In-Time compiler
 functionality independent of any particular bytecode, language, or
 runtime")
-    (license license:lgpl2.1+))))
+      (license license:lgpl2.1+))))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.