GNU bug report logs - #35789
[PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35789 in the body.
You can then email your comments to 35789 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
To: guix-patches <at> gnu.org
Cc: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue
Date: Sat, 18 May 2019 13:32:29 +0430

* gnu/packages/lxqt.scm (lxqt-session): change lxqt-rc.xml permission to
755 after initial copy to user directory.
---
 gnu/packages/lxqt.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index d91efe715d..94d47bc862 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -827,6 +827,14 @@ allows for launching applications or shutting down the system.")
                (("DESTINATION \"\\$\\{LXQT_ETC_XDG_DIR\\}")
                 "DESTINATION \"etc/xdg"))
              #t))
+         (add-after 'unpack 'patch-openbox-permission
+           (lambda _
+             (substitute* "startlxqt.in"
+               (("cp \"\\$LXQT_DEFAULT_OPENBOX_CONFIG\" \"\\$XDG_CONFIG_HOME/openbox\"")
+                 (string-append "cp \"$LXQT_DEFAULT_OPENBOX_CONFIG\" \"$XDG_CONFIG_HOME/openbox\"\n"
+                                "        # fix openbox permission issue\n"
+                                "        chmod -R 755 \"$XDG_CONFIG_HOME/openbox\"")))
+             #t))
          (add-after 'unpack 'patch-translations-dir
            (lambda* (#:key outputs #:allow-other-keys)
              (substitute* '("lxqt-config-session/CMakeLists.txt"
-- 
2.19.0

Message #8 received at 35789 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: 35789 <at> debbugs.gnu.org
Subject: lxqt-rc.xml permission issue 
Date: Sat, 18 May 2019 14:52:53 +0430

Hi Guix, 

Based on issue that I submitted before 
( http://lists.gnu.org/archive/html/help-guix/2019-05/msg00372.html ) ,
lxqt-session copies an openbox related file (lxqt-rc.xml) to user's home directory, 
since this file permissions are set as readonly in `gnu/store`, users are unable to 
modify this file using openbox settings GUI, for this I submitted following patch to 
set proper permessions to `lxqt-rc.xml` file after initial copy to user's home 
directory. 

Message #11 received at 35789 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Cc: 35789 <at> debbugs.gnu.org
Subject: Re: [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission
 issue
Date: Tue, 21 May 2019 16:30:10 +0200

Hello,

Reza Alizadeh Majd <r.majd <at> pantherx.org> skribis:

> * gnu/packages/lxqt.scm (lxqt-session): change lxqt-rc.xml permission to
> 755 after initial copy to user directory.

[...]

> +             (substitute* "startlxqt.in"
> +               (("cp \"\\$LXQT_DEFAULT_OPENBOX_CONFIG\" \"\\$XDG_CONFIG_HOME/openbox\"")
> +                 (string-append "cp \"$LXQT_DEFAULT_OPENBOX_CONFIG\" \"$XDG_CONFIG_HOME/openbox\"\n"
> +                                "        # fix openbox permission issue\n"
> +                                "        chmod -R 755 \"$XDG_CONFIG_HOME/openbox\"")))

That will make every file executable.

What about just:

  chmod u+w "$XDG_CONFIG_HOME/openbox"/*

?

One last thing: could you provide the explanation you gave in just one
or two lines of comment right above this ‘substitute*’ expression?

Thank you,
Ludo’.

Message #14 received at 35789 <at> debbugs.gnu.org (full text, mbox):

From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
To: 35789 <at> debbugs.gnu.org
Cc: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue
Date: Tue, 21 May 2019 22:37:51 +0430

* gnu/packages/lxqt.scm (lxqt-session): add write permission to
lxqt-rc.xml file after initial copy to user directory
---
 gnu/packages/lxqt.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index d91efe715d..e69f29ed1c 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -827,6 +827,15 @@ allows for launching applications or shutting down the system.")
                (("DESTINATION \"\\$\\{LXQT_ETC_XDG_DIR\\}")
                 "DESTINATION \"etc/xdg"))
              #t))
+         ;; add write permission to lxqt-rc.xml file which is stored as read-only in store
+         (add-after 'unpack 'patch-openbox-permission
+           (lambda _
+             (substitute* "startlxqt.in"
+               (("cp \"\\$LXQT_DEFAULT_OPENBOX_CONFIG\" \"\\$XDG_CONFIG_HOME/openbox\"")
+                 (string-append "cp \"$LXQT_DEFAULT_OPENBOX_CONFIG\" \"$XDG_CONFIG_HOME/openbox\"\n"
+                                "        # fix openbox permission issue\n"
+                                "        chmod u+w  \"$XDG_CONFIG_HOME/openbox\"/*")))
+             #t))
          (add-after 'unpack 'patch-translations-dir
            (lambda* (#:key outputs #:allow-other-keys)
              (substitute* '("lxqt-config-session/CMakeLists.txt"
-- 
2.19.0

Message #17 received at 35789 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35789 <at> debbugs.gnu.org
Subject: Re: [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue
Date: Tue, 21 May 2019 22:53:38 +0430

Hi, 

>   chmod u+w "$XDG_CONFIG_HOME/openbox"/*

you're right, setting the write permission to lxqt-rc.xml is preferred.

I also add a comment line before permission modification phase and amend 
my last commit. 


Best, 
Reza

Message #22 received at 35789-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Cc: 35789-done <at> debbugs.gnu.org
Subject: Re: [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission
 issue
Date: Fri, 24 May 2019 17:54:31 +0200

Reza Alizadeh Majd <r.majd <at> pantherx.org> skribis:

> * gnu/packages/lxqt.scm (lxqt-session): add write permission to
> lxqt-rc.xml file after initial copy to user directory

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.