GNU bug report logs - #35807
27.0.50; Typo in function name `w32--os-descriptiono'

Previous Next

Package: emacs;

Reported by: Miciah Dashiel Butler Masters <miciah.masters <at> gmail.com>

Date: Mon, 20 May 2019 12:31:02 UTC

Severity: normal

Tags: fixed

Found in version 27.0.50

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35807 in the body.
You can then email your comments to 35807 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#35807; Package emacs. (Mon, 20 May 2019 12:31:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Miciah Dashiel Butler Masters <miciah.masters <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 20 May 2019 12:31:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Miciah Dashiel Butler Masters <miciah.masters <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Typo in function name `w32--os-descriptiono'
Date: Mon, 20 May 2019 08:30:28 -0400

While scanning recent changes to the GNU Emacs master branch, I
noticed that http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/w32-fns.el?id=54f5d678dccdf7b6a60579c6048e8cf87c81c4ae
introduced what appears to be a typo:

 ;;;; System name and version for emacsbug.el

-(defun w32--os-description ()
+(declare-function w32-version "w32-win" ())
+(declare-function w32-read-registry "w32fns" (root key name))
+
+(defun w32--os-descriptiono ()
   "Return a string describing the underlying OS and its version."
   (let* ((w32ver (car (w32-version)))
          (w9x-p (< w32ver 5))

Grepping the Emacs codebase turns up 1 use of `w32--os-description'
(in `report-emacs-bug--os-description') and 0 uses of
`w32--os-descriptiono'.

I believe `w32--os-descriptiono' should be changed back to
`w32--os-description'.

--
Miciah Dashiel Butler Masters <miciah.masters <at> gmail.com>
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#35807; Package emacs. (Mon, 20 May 2019 12:36:01 GMT) Full text and rfc822 format available.

Message #8 received at 35807 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Miciah Dashiel Butler Masters <miciah.masters <at> gmail.com>
Cc: 35807 <at> debbugs.gnu.org
Subject: Re: bug#35807: 27.0.50; Typo in function name `w32--os-descriptiono'
Date: Mon, 20 May 2019 14:35:08 +0200

Miciah Dashiel Butler Masters <miciah.masters <at> gmail.com> writes:

> I believe `w32--os-descriptiono' should be changed back to
> `w32--os-description'.

Yup.  I've now changed the function name back -- thanks for catching this.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 20 May 2019 12:36:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 27.1, send any further explanations to 35807 <at> debbugs.gnu.org and Miciah Dashiel Butler Masters <miciah.masters <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 20 May 2019 12:36:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 18 Jun 2019 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 306 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.