GNU bug report logs - #35854
[PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35854 in the body.
You can then email your comments to 35854 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
To: guix-patches <at> gnu.org
Cc: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: [PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.
Date: Wed, 22 May 2019 11:57:16 +0430

* gnu/packages/lxqt.scm (lxqt-panel): move `kwindowsystem` from `inputs`
to `propagated-inputs`
---
 gnu/packages/lxqt.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index d91efe715d..a03a93e5c5 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2018, 2019 Meiyo Peng <meiyo <at> riseup.net>
 ;;; Copyright © 2018 Ricardo Wurmus <rekado <at> elephly.net>
+;;; Copyright © 2019 Reza Alizadeh Majd <r.majd <at> pantherx.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -559,7 +560,6 @@ of other programs.")
     (inputs
      `(("alsa-lib" ,alsa-lib)
        ("kguiaddons" ,kguiaddons)
-       ("kwindowsystem" ,kwindowsystem)
        ("libdbusmenu-qt" ,libdbusmenu-qt)
        ("liblxqt" ,liblxqt)
        ("libqtxdg" ,libqtxdg)
@@ -582,6 +582,8 @@ of other programs.")
      `(("pkg-config" ,pkg-config)
        ("lxqt-build-tools" ,lxqt-build-tools)
        ("qttools" ,qttools)))
+    (propagated-inputs
+      `(("kwindowsystem" ,kwindowsystem)))
     (arguments
      '(#:tests? #f                      ; no tests
        #:phases
-- 
2.19.0

Message #8 received at 35854 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: 35854 <at> debbugs.gnu.org
Subject: Re: [PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.
Date: Wed, 22 May 2019 12:33:37 +0430

list of opened applications wouldn't show in lxqt-panel's taskbar plugin, 
since `kwindowsystem` is responsible for that, moving this library from 
`inputs` to `propagated-inputs` fixed this issue. 

Message #13 received at 35854-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Cc: 35854-done <at> debbugs.gnu.org
Subject: Re: [bug#35854] [PATCH] lxqt: lxqt-panel: fix taskbar plugin's
 application list issue.
Date: Fri, 24 May 2019 18:05:03 +0200

[Message part 1 (text/plain, inline)]

Reza Alizadeh Majd <r.majd <at> pantherx.org> skribis:

> * gnu/packages/lxqt.scm (lxqt-panel): move `kwindowsystem` from `inputs`
> to `propagated-inputs`

Applied, but I added a comment based on your message (see below).  In
general, ‘propagated-inputs’ should be used only when strictly
necessary, so when we use them, it’s important to add comments
explaining why we do so.

Thanks for the patch!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index c3b25e5417..a8699b3d09 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -583,7 +583,9 @@ of other programs.")
        ("lxqt-build-tools" ,lxqt-build-tools)
        ("qttools" ,qttools)))
     (propagated-inputs
-      `(("kwindowsystem" ,kwindowsystem)))
+     ;; Propagating KWINDOWSYSTEM so that the list of opened applications
+     ;; shows up in lxqt-panel's taskbar plugin.
+     `(("kwindowsystem" ,kwindowsystem)))
     (arguments
      '(#:tests? #f                      ; no tests
        #:phases

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.