GNU bug report logs - #35859
[PATCH] hackage import: Setup.hs generation and revision support

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35859 in the body.
You can then email your comments to 35859 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] hackage import: Setup.hs generation and revision support
Date: Wed, 22 May 2019 22:11:50 +0200

[Message part 1 (text/plain, inline)]

These patches are on top of

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35812 (fix cabal tests)
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35846 (braced properties)

- substitute missing Setup.hs and remove manual per-package workarounds
- handle hackage metadata revisions

I believe the code works, but some may not be the most idiomatic scheme
code. Particularly around building the quoted argument list and returning
a pair of cabal data and hash.

[0001-gnu-ghc-easy-plot-remove-superfluous-Setup.hs-rename.patch (application/octet-stream, attachment)]

[0002-guix-haskell-build-system-correct-haddock-phase-docu.patch (application/octet-stream, attachment)]

[0003-guix-haskell-build-system-generate-Setup.hs-if-not-e.patch (application/octet-stream, attachment)]

[0004-gnu-haskell-leave-Setup.hs-generation-to-build-syste.patch (application/octet-stream, attachment)]

[0005-guix-import-hackage-handle-hackage-revisions.patch (application/octet-stream, attachment)]

Message #8 received at 35859 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: 35859 <at> debbugs.gnu.org
Subject: line ending fix
Date: Thu, 23 May 2019 10:50:51 +0200

[Message part 1 (text/plain, inline)]

Updated patch to deal with CRLF line endings when computing cabal hash.

[0005-guix-import-hackage-handle-hackage-revisions.patch (application/octet-stream, attachment)]

Message #11 received at 35859 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: 35859 <at> debbugs.gnu.org
Subject: fixed patch set, including test fixes
Date: Thu, 23 May 2019 15:27:04 +0200

[Message part 1 (text/plain, inline)]

The previous version of this patch caused some test failures due
to conflict with the hackage-fetch mocking in tests/hackage.scm.

This set reworks the tests to not mock, and incorporates updated
versions of the previous patch sets

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35812
 (fix cabal tests)

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35846
 (braced properties)

[0001-tests-fix-cabal-tests-to-test-and-pass.patch (application/octet-stream, attachment)]

[0002-tests-hackage-test-multiline-cabal-description.patch (application/octet-stream, attachment)]

[0003-guix-import-cabal-parse-braced-description-propertie.patch (application/octet-stream, attachment)]

[0004-tests-hackage-avoid-mock-and-extract-test-data.patch (application/octet-stream, attachment)]

[0005-gnu-ghc-easy-plot-remove-superfluous-Setup.hs-rename.patch (application/octet-stream, attachment)]

[0006-guix-haskell-build-system-correct-haddock-phase-docu.patch (application/octet-stream, attachment)]

[0007-guix-haskell-build-system-generate-Setup.hs-if-not-e.patch (application/octet-stream, attachment)]

[0008-gnu-haskell-leave-Setup.hs-generation-to-build-syste.patch (application/octet-stream, attachment)]

[0009-guix-import-hackage-handle-hackage-revisions.patch (application/octet-stream, attachment)]

[0010-guix-import-hackage-log-when-we-start-with-a-file.patch (application/octet-stream, attachment)]

Message #16 received at 35859 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: 35859 <at> debbugs.gnu.org
Subject: fixes bug in patch 0003
Date: Fri, 24 May 2019 16:56:30 +0200

[Message part 1 (text/plain, inline)]

Patch 0003 introduced a bug where descriptions with backslash characters were no longer parsed.
This is an updated version.

[0003-guix-import-cabal-parse-braced-description-propertie.patch (application/octet-stream, attachment)]

Message #19 received at 35859 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: 35859 <at> debbugs.gnu.org
Subject: improves output in patch 0010
Date: Fri, 24 May 2019 16:58:57 +0200

[Message part 1 (text/plain, inline)]

Patch 0010 adds a logging statement to hackage import.
This is an updated version that provides better output considering
optional cabal reading from standard input.

[0010-guix-import-hackage-log-when-we-start-with-a-file.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.