GNU bug report logs - #35873
Add atomic window support to Gnus

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35873 in the body.
You can then email your comments to 35873 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: Add atomic window support to Gnus
Date: Thu, 23 May 2019 13:45:13 -0700

[Message part 1 (text/plain, inline)]

The attached patch adds atomic window support with a new customization
option, `gnus-use-atomic-windows', defaulting to nil. If t, a
multi-window Gnus layout will be treated as a single window when other
code pops up buffers. Ie, your completions buffer won't end up squished
between the summary and article buffers.

I'm pretty sure I've done the elisp manual cross reference incorrectly.

Thanks,
Eric




Gnus v5.13
GNU Emacs 27.0.50 (build 15, x86_64-pc-linux-gnu, GTK+ Version 3.24.8)
 of 2019-05-23
200 news.gmane.org InterNetNews NNRP server INN 2.6.1 ready (posting ok)
100 Legal commands
  ARTICLE [message-ID|number]
  AUTHINFO USER name|PASS password|SASL mechanism [initial-response]|GENERIC program [argument ...]
  BODY [message-ID|number]
  CAPABILITIES [keyword]
  COMPRESS DEFLATE
  DATE
  GROUP newsgroup
  HDR header [message-ID|range]
  HEAD [message-ID|number]
  HELP
  IHAVE message-ID
  LAST
  LIST [ACTIVE [wildmat]|ACTIVE.TIMES [wildmat]|COUNTS [wildmat]|DISTRIB.PATS|DISTRIBUTIONS|HEADERS [MSGID|RANGE]|MODERATORS|MOTD|NEWSGROUPS [wildmat]|OVERVIEW.FMT|SUBSCRIPTIONS [wildmat]]
  LISTGROUP [newsgroup [range]]
  MODE READER
  NEWGROUPS [yy]yymmdd hhmmss [GMT]
  NEWNEWS wildmat [yy]yymmdd hhmmss [GMT]
  NEXT
  OVER [range]
  POST
  QUIT
  STARTTLS
  STAT [message-ID|number]
  XGTITLE [wildmat]
  XHDR header [message-ID|range]
  XOVER [range]
  XPAT header message-ID|range pattern [pattern ...]
Report problems to <usenet <at> blaine.gmane.org>.
.
382 Begin TLS negotiation now
100 Legal commands
  ARTICLE [message-ID|number]
  AUTHINFO USER name|PASS password|SASL mechanism [initial-response]|GENERIC program [argument ...]
  BODY [message-ID|number]
  CAPABILITIES [keyword]
  COMPRESS DEFLATE
  DATE
  GROUP newsgroup
  HDR header [message-ID|range]
  HEAD [message-ID|number]
  HELP
  IHAVE message-ID
  LAST
  LIST [ACTIVE [wildmat]|ACTIVE.TIMES [wildmat]|COUNTS [wildmat]|DISTRIB.PATS|DISTRIBUTIONS|HEADERS [MSGID|RANGE]|MODERATORS|MOTD|NEWSGROUPS [wildmat]|OVERVIEW.FMT|SUBSCRIPTIONS [wildmat]]
  LISTGROUP [newsgroup [range]]
  MODE READER
  NEWGROUPS [yy]yymmdd hhmmss [GMT]
  NEWNEWS wildmat [yy]yymmdd hhmmss [GMT]
  NEXT
  OVER [range]
  POST
  QUIT
  STARTTLS
  STAT [message-ID|number]
  XGTITLE [wildmat]
  XHDR header [message-ID|range]
  XOVER [range]
  XPAT header message-ID|range pattern [pattern ...]
Report problems to <usenet <at> blaine.gmane.org>.
.

[0001-Add-atomic-window-support-to-Gnus.patch (text/x-patch, attachment)]

Message #8 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Fri, 21 Jun 2019 05:10:33 -0400

severity 35873 wishlist
tags 35873 + patch
quit

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> The attached patch adds atomic window support with a new customization
> option, `gnus-use-atomic-windows', defaulting to nil. If t, a
> multi-window Gnus layout will be treated as a single window when other
> code pops up buffers. Ie, your completions buffer won't end up squished
> between the summary and article buffers.
>
> I'm pretty sure I've done the elisp manual cross reference incorrectly.

> +windows (@pxref{Atomic Windows, , Atomic Windows, elisp}).

I believe the correct form would be:

    (@pxref{Atomic Windows,,, elisp, The Emacs Lisp Reference Manual})

That is, no need to repeat the topic title, as it's the same as the node
name.  But the printed manual name is needed as the last argument.  See
(info "(texinfo) Four and Five Arguments"), and grep for xref.*elisp in
doc/ for similar examples.

I guess the code part of the patch is alright, but I'm not too familiar
with how atomic windows work.

Message #15 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Fri, 21 Jun 2019 08:11:14 -0700

Noam Postavsky <npostavs <at> gmail.com> writes:

> severity 35873 wishlist
> tags 35873 + patch
> quit
>
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> The attached patch adds atomic window support with a new customization
>> option, `gnus-use-atomic-windows', defaulting to nil. If t, a
>> multi-window Gnus layout will be treated as a single window when other
>> code pops up buffers. Ie, your completions buffer won't end up squished
>> between the summary and article buffers.
>>
>> I'm pretty sure I've done the elisp manual cross reference incorrectly.
>
>> +windows (@pxref{Atomic Windows, , Atomic Windows, elisp}).
>
> I believe the correct form would be:
>
>     (@pxref{Atomic Windows,,, elisp, The Emacs Lisp Reference Manual})
>
> That is, no need to repeat the topic title, as it's the same as the node
> name.  But the printed manual name is needed as the last argument.  See
> (info "(texinfo) Four and Five Arguments"), and grep for xref.*elisp in
> doc/ for similar examples.

Okay, thanks -- I'd read the texinfo manual but found that part fairly
confusing.

> I guess the code part of the patch is alright, but I'm not too familiar
> with how atomic windows work.

I've since had a back-and-forth with Martin about messing more with
window management in Gnus, and am hoping to get a little farther with
that. (Or maybe I should Just Say No to mission creep, and try to get
this patch in...)

Message #18 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Sat, 22 Jun 2019 13:55:05 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> The attached patch adds atomic window support with a new customization
> option, `gnus-use-atomic-windows', defaulting to nil. If t, a
> multi-window Gnus layout will be treated as a single window when other
> code pops up buffers. Ie, your completions buffer won't end up squished
> between the summary and article buffers.

I'm not familiar with the atomic window stuff at all -- I don't use
pop-up windows and all the newfangled stuff kids today use -- but the
feature sounds sensible to me, so go ahead and apply (unless you wanted
to do this in another way, which you alluded to in a subsequent
message)...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Sat, 22 Jun 2019 09:41:44 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> The attached patch adds atomic window support with a new customization
>> option, `gnus-use-atomic-windows', defaulting to nil. If t, a
>> multi-window Gnus layout will be treated as a single window when other
>> code pops up buffers. Ie, your completions buffer won't end up squished
>> between the summary and article buffers.
>
> I'm not familiar with the atomic window stuff at all -- I don't use
> pop-up windows and all the newfangled stuff kids today use -- but the
> feature sounds sensible to me, so go ahead and apply (unless you wanted
> to do this in another way, which you alluded to in a subsequent
> message)...

Well, but even *Completion* buffers are pop-up buffers... Maybe helm
users, in particular, would be bothered by this.

I do want to pursue the other avenue a bit, but if that doesn't work out
or looks like too much effort, I'll push this.

Thanks,
Eric

Message #24 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Mon, 16 Sep 2019 23:05:14 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> I do want to pursue the other avenue a bit, but if that doesn't work out
> or looks like too much effort, I'll push this.

That was twelve weeks ago -- has there been any further progress here,
or should this bug report be closed?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #27 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Tue, 17 Sep 2019 06:42:20 +0800

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> I do want to pursue the other avenue a bit, but if that doesn't work out
>> or looks like too much effort, I'll push this.
>
> That was twelve weeks ago -- has there been any further progress here,
> or should this bug report be closed?

The "other avenue" hasn't gone anywhere, at least not for now, so I
would still like to push this. It's fairly self-contained, and seems to
do the right thing. I'm getting on a plane in a bit, but when I've
settled a bit I'll look at the patch again and push.

Eric

Message #30 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Tue, 17 Sep 2019 00:43:06 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> The "other avenue" hasn't gone anywhere, at least not for now, so I
> would still like to push this. It's fairly self-contained, and seems to
> do the right thing. I'm getting on a plane in a bit, but when I've
> settled a bit I'll look at the patch again and push.

Sounds good.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #33 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Thu, 19 Sep 2019 10:21:38 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> The "other avenue" hasn't gone anywhere, at least not for now, so I
>> would still like to push this. It's fairly self-contained, and seems to
>> do the right thing. I'm getting on a plane in a bit, but when I've
>> settled a bit I'll look at the patch again and push.
>
> Sounds good.  :-)

I updated the patch with Martin's suggestion, and am back to running
this daily. One thing I noticed is that (in this case in my Gnorb
package) running `delete-other-windows' from a Gnus window will now
result in one of these:

delete-other-windows: Root of atomic window is root window of its frame

That error is expected with atomic windows. I can change Gnorb to not
use `delete-other-windows' (it shouldn't be using that anyway), but I
wonder if that's likely to cause an unacceptable amount of friction with
other packages/user code. (While noting that this behavior is off by
default.)

WDYT?

Message #36 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>,
 Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Fri, 20 Sep 2019 10:13:21 +0200

> I updated the patch with Martin's suggestion, and am back to running
> this daily. One thing I noticed is that (in this case in my Gnorb
> package) running `delete-other-windows' from a Gnus window will now
> result in one of these:
>
> delete-other-windows: Root of atomic window is root window of its frame
>
> That error is expected with atomic windows. I can change Gnorb to not
> use `delete-other-windows' (it shouldn't be using that anyway), but I
> wonder if that's likely to cause an unacceptable amount of friction with
> other packages/user code. (While noting that this behavior is off by
> default.)

You can also specify a function in the 'delete-other-windows'
parameter of any window involved.  One that dissolves atomicity, for
example.

martin

Message #39 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Fri, 20 Sep 2019 11:12:36 -0700

martin rudalics <rudalics <at> gmx.at> writes:

>> I updated the patch with Martin's suggestion, and am back to running
>> this daily. One thing I noticed is that (in this case in my Gnorb
>> package) running `delete-other-windows' from a Gnus window will now
>> result in one of these:
>>
>> delete-other-windows: Root of atomic window is root window of its frame
>>
>> That error is expected with atomic windows. I can change Gnorb to not
>> use `delete-other-windows' (it shouldn't be using that anyway), but I
>> wonder if that's likely to cause an unacceptable amount of friction with
>> other packages/user code. (While noting that this behavior is off by
>> default.)
>
> You can also specify a function in the 'delete-other-windows'
> parameter of any window involved.  One that dissolves atomicity, for
> example.

Oh, excellent! I don't think I'll actually use that yet -- I'll fix my
own package not to call `delete-other-windows', then ask folks to enable
this feature and watch out for the error, and hopefully bug reports will
show how `delete-other-windows' might be being used in the wild. Then we
can look at how best to implement the d-o-w parameter for Gnus windows.

Thanks,
Eric

Message #42 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Fri, 20 Sep 2019 12:28:05 -0700

[Message part 1 (text/plain, inline)]

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> martin rudalics <rudalics <at> gmx.at> writes:
>
>>> I updated the patch with Martin's suggestion, and am back to running
>>> this daily. One thing I noticed is that (in this case in my Gnorb
>>> package) running `delete-other-windows' from a Gnus window will now
>>> result in one of these:
>>>
>>> delete-other-windows: Root of atomic window is root window of its frame
>>>
>>> That error is expected with atomic windows. I can change Gnorb to not
>>> use `delete-other-windows' (it shouldn't be using that anyway), but I
>>> wonder if that's likely to cause an unacceptable amount of friction with
>>> other packages/user code. (While noting that this behavior is off by
>>> default.)
>>
>> You can also specify a function in the 'delete-other-windows'
>> parameter of any window involved.  One that dissolves atomicity, for
>> example.
>
> Oh, excellent! I don't think I'll actually use that yet -- I'll fix my
> own package not to call `delete-other-windows', then ask folks to enable
> this feature and watch out for the error, and hopefully bug reports will
> show how `delete-other-windows' might be being used in the wild. Then we
> can look at how best to implement the d-o-w parameter for Gnus windows.

There's the patch as it stands. I'll push in a bit if there's no objection.

[0001-New-option-for-making-Gnus-window-layouts-atomic.patch (text/x-patch, attachment)]

Message #45 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: martin rudalics <rudalics <at> gmx.at>, 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Fri, 20 Sep 2019 22:19:12 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> There's the patch as it stands. I'll push in a bit if there's no objection.

I've never used the atomic window stuff, so I'm probably not a good
judge here, but it looked logical to me.  It should have a NEWS entry,
though.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #48 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Fri, 20 Sep 2019 13:41:34 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> There's the patch as it stands. I'll push in a bit if there's no objection.
>
> I've never used the atomic window stuff, so I'm probably not a good
> judge here, but it looked logical to me.  It should have a NEWS entry,
> though.

Ah, I was wondering about that. I'll add that as well, then push.

Thanks,
Eric

Message #51 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: martin rudalics <rudalics <at> gmx.at>, 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Fri, 20 Sep 2019 13:49:23 -0700

On 09/20/19 22:19 PM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> There's the patch as it stands. I'll push in a bit if there's no objection.
>
> I've never used the atomic window stuff, so I'm probably not a good
> judge here, but it looked logical to me.  It should have a NEWS entry,
> though.

Okay, I've added a NEWS entry, and also a :version tag to the new
option. Hopefully we're good to go.

Message #54 received at 35873 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 35873 <at> debbugs.gnu.org
Subject: Re: bug#35873: Add atomic window support to Gnus
Date: Sat, 28 Sep 2019 20:00:46 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Ah, I was wondering about that. I'll add that as well, then push.

This is now on the trunk, so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.