GNU bug report logs - #35890
[PATCH 3/4] gnu: python-hdf4: Update to 0.9.2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35890 in the body.
You can then email your comments to 35890 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2.
Date: Fri, 24 May 2019 19:14:26 -0500

[0003-gnu-python-hdf4-Update-to-0.9.2.patch (text/x-patch, inline)]

From fb102715cd2b809e4d963b8f71df54bbad06c369 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg <at> posteo.net>
Date: Fri, 24 May 2019 19:10:33 -0500
Subject: [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2.

* gnu/packages/python-xyz.scm (python-hdf4): Update to 0.9.2.
---
 gnu/packages/python-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index a58b788ca1..54cc0c2b27 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -370,14 +370,14 @@ and verifies that it matches the intended target hostname.")
 (define-public python-hdf4
   (package
    (name "python-hdf4")
-   (version "0.9")
+   (version "0.9.2")
    (source
     (origin
       (method url-fetch)
       (uri (pypi-uri name version))
       (sha256
        (base32
-        "1hjiyrxvxk9817qyqky3nar4y3fs4z8wxz0n884zzb5wi6skrjks"))))
+        "00sxppysk3w620g1jdskjzkybvpf8dkpzjfj3wlw5khpzw1g0hq5"))))
    (build-system python-build-system)
    (native-inputs `(("nose" ,python-nose)))
    (propagated-inputs `(("numpy" ,python-numpy)))
-- 
2.21.0

Message #8 received at 35890 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: 35890 <at> debbugs.gnu.org
Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
Date: Fri, 24 May 2019 19:27:19 -0500

[0004-gnu-python-hdf4-Remove-check-phase-argument.patch (text/x-patch, inline)]

From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg <at> posteo.net>
Date: Fri, 24 May 2019 19:11:00 -0500
Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.

* gnu/packages/python-xyz.scm (python-hdf4): Update to .
---
 gnu/packages/python-xyz.scm | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 54cc0c2b27..43287d212e 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -385,21 +385,6 @@ and verifies that it matches the intended target hostname.")
     `(("hdf4" ,hdf4)
       ("libjpeg" ,libjpeg)
       ("zlib" ,zlib)))
-   (arguments
-    `(#:phases
-      (modify-phases %standard-phases
-        (replace 'check
-          (lambda _
-            ;; The 'runexamples' script sets PYTHONPATH to CWD, then goes
-            ;; on to import numpy. Somehow this works on their CI system.
-            ;; Let's just manage PYTHONPATH here instead.
-            (substitute* "runexamples.sh"
-              (("export PYTHONPATH=.*") ""))
-            (setenv "PYTHONPATH"
-                    (string-append (getcwd) ":"
-                                   (getenv "PYTHONPATH")))
-            (invoke "./runexamples.sh")
-            (invoke "nosetests" "-v"))))))
    (home-page "https://github.com/fhs/python-hdf4")
    (synopsis "Python interface to the NCSA HDF4 library")
    (description
-- 
2.21.0

Message #11 received at 35890 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Brett Gilio <brettg <at> posteo.net>, 35890 <at> debbugs.gnu.org
Subject: Re: [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase
 argument.
Date: Sun, 26 May 2019 10:28:04 +0200

[Message part 1 (text/plain, inline)]

Brett Gilio <brettg <at> posteo.net> writes:

> From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg <at> posteo.net>
> Date: Fri, 24 May 2019 19:11:00 -0500
> Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
>
> * gnu/packages/python-xyz.scm (python-hdf4): Update to .
> ---
>  gnu/packages/python-xyz.scm | 15 ---------------
>  1 file changed, 15 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 54cc0c2b27..43287d212e 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -385,21 +385,6 @@ and verifies that it matches the intended target hostname.")
>      `(("hdf4" ,hdf4)
>        ("libjpeg" ,libjpeg)
>        ("zlib" ,zlib)))
> -   (arguments
> -    `(#:phases
> -      (modify-phases %standard-phases
> -        (replace 'check
> -          (lambda _
> -            ;; The 'runexamples' script sets PYTHONPATH to CWD, then goes
> -            ;; on to import numpy. Somehow this works on their CI system.
> -            ;; Let's just manage PYTHONPATH here instead.
> -            (substitute* "runexamples.sh"
> -              (("export PYTHONPATH=.*") ""))
> -            (setenv "PYTHONPATH"
> -                    (string-append (getcwd) ":"
> -                                   (getenv "PYTHONPATH")))
> -            (invoke "./runexamples.sh")
> -            (invoke "nosetests" "-v"))))))
>     (home-page "https://github.com/fhs/python-hdf4")
>     (synopsis "Python interface to the NCSA HDF4 library")
>     (description

While this makes the build succeed, the 'check' phase is now moot.  It
appears to simply build the library for a second time, and then prints
'Ran 0 tests in N seconds...'.

Can you look into what happened to the tests between version 0.9.0 and
0.9.2?

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 35890 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Brett Gilio <brettg <at> posteo.net>
Cc: 35890 <at> debbugs.gnu.org
Subject: Re: [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase
 argument.
Date: Sun, 26 May 2019 12:53:17 +0200

Brett Gilio <brettg <at> posteo.net> writes:

> From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg <at> posteo.net>
> Date: Fri, 24 May 2019 19:11:00 -0500
> Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
>
> * gnu/packages/python-xyz.scm (python-hdf4): Update to .

I guess you’re using the yasnippets for Emacs :)

It’s fine to do this in the same commit as the upgrade, but as Marius
wrote the tests should actually be run.

-- 
Ricardo

Message #17 received at 35890 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brett Gilio <brettg <at> posteo.net>,
Cc: 35890 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase
 argument.
Date: Tue, 02 Jul 2019 17:22:18 +0200

Hello Brett,

Marius Bakke <mbakke <at> fastmail.com> skribis:

> Brett Gilio <brettg <at> posteo.net> writes:
>
>> From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
>> From: Brett Gilio <brettg <at> posteo.net>
>> Date: Fri, 24 May 2019 19:11:00 -0500
>> Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
>>
>> * gnu/packages/python-xyz.scm (python-hdf4): Update to .
>> ---
>>  gnu/packages/python-xyz.scm | 15 ---------------
>>  1 file changed, 15 deletions(-)
>>
>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
>> index 54cc0c2b27..43287d212e 100644
>> --- a/gnu/packages/python-xyz.scm
>> +++ b/gnu/packages/python-xyz.scm
>> @@ -385,21 +385,6 @@ and verifies that it matches the intended target hostname.")
>>      `(("hdf4" ,hdf4)
>>        ("libjpeg" ,libjpeg)
>>        ("zlib" ,zlib)))
>> -   (arguments
>> -    `(#:phases
>> -      (modify-phases %standard-phases
>> -        (replace 'check
>> -          (lambda _
>> -            ;; The 'runexamples' script sets PYTHONPATH to CWD, then goes
>> -            ;; on to import numpy. Somehow this works on their CI system.
>> -            ;; Let's just manage PYTHONPATH here instead.
>> -            (substitute* "runexamples.sh"
>> -              (("export PYTHONPATH=.*") ""))
>> -            (setenv "PYTHONPATH"
>> -                    (string-append (getcwd) ":"
>> -                                   (getenv "PYTHONPATH")))
>> -            (invoke "./runexamples.sh")
>> -            (invoke "nosetests" "-v"))))))
>>     (home-page "https://github.com/fhs/python-hdf4")
>>     (synopsis "Python interface to the NCSA HDF4 library")
>>     (description
>
> While this makes the build succeed, the 'check' phase is now moot.  It
> appears to simply build the library for a second time, and then prints
> 'Ran 0 tests in N seconds...'.
>
> Can you look into what happened to the tests between version 0.9.0 and
> 0.9.2?

Any update on this?

Ludo’.

Message #22 received at 35890-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35890-done <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>,
 Brett Gilio <brettg <at> posteo.net>
Subject: Re: bug#35890: [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2.
Date: Fri, 15 Jul 2022 23:57:08 -0400

Hi,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello Brett,
>
> Marius Bakke <mbakke <at> fastmail.com> skribis:
>
>> Brett Gilio <brettg <at> posteo.net> writes:
>>
>>> From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
>>> From: Brett Gilio <brettg <at> posteo.net>
>>> Date: Fri, 24 May 2019 19:11:00 -0500
>>> Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
>>>
>>> * gnu/packages/python-xyz.scm (python-hdf4): Update to .
>>> ---
>>>  gnu/packages/python-xyz.scm | 15 ---------------
>>>  1 file changed, 15 deletions(-)
>>>
>>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
>>> index 54cc0c2b27..43287d212e 100644
>>> --- a/gnu/packages/python-xyz.scm
>>> +++ b/gnu/packages/python-xyz.scm
>>> @@ -385,21 +385,6 @@ and verifies that it matches the intended target hostname.")
>>>      `(("hdf4" ,hdf4)
>>>        ("libjpeg" ,libjpeg)
>>>        ("zlib" ,zlib)))
>>> -   (arguments
>>> -    `(#:phases
>>> -      (modify-phases %standard-phases
>>> -        (replace 'check
>>> -          (lambda _
>>> -            ;; The 'runexamples' script sets PYTHONPATH to CWD, then goes
>>> -            ;; on to import numpy. Somehow this works on their CI system.
>>> -            ;; Let's just manage PYTHONPATH here instead.
>>> -            (substitute* "runexamples.sh"
>>> -              (("export PYTHONPATH=.*") ""))
>>> -            (setenv "PYTHONPATH"
>>> -                    (string-append (getcwd) ":"
>>> -                                   (getenv "PYTHONPATH")))
>>> -            (invoke "./runexamples.sh")
>>> -            (invoke "nosetests" "-v"))))))
>>>     (home-page "https://github.com/fhs/python-hdf4")
>>>     (synopsis "Python interface to the NCSA HDF4 library")
>>>     (description
>>
>> While this makes the build succeed, the 'check' phase is now moot.  It
>> appears to simply build the library for a second time, and then prints
>> 'Ran 0 tests in N seconds...'.
>>
>> Can you look into what happened to the tests between version 0.9.0 and
>> 0.9.2?
>
> Any update on this?

No update in 3 years; closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.