GNU bug report logs - #35907
[PATCH] guix import hackage: update list of ghc-included packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35907 in the body.
You can then email your comments to 35907 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: guix-patches <at> gnu.org
Cc: Robert Vollmert <rob <at> vllmrt.net>
Subject: [PATCH] guix import hackage: update list of ghc-included packages
Date: Sat, 25 May 2019 22:11:02 +0200

Update the list of excepted dependencies for current ghc-8.4,
based on the release notes at
https://downloads.haskell.org/~ghc/8.4.3/docs/html/users_guide/8.4.3-notes.html

Particularly, this adds `text` to the list, which is a dependency
of `parsec` which was already on the list before, causing build
failures with updated versions of the `text` package.

* guix/import/hackage.scm (ghc-standard-libraries): Update list.
---
 guix/import/hackage.scm | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
index c97b16197f..bc72f21bf3 100644
--- a/guix/import/hackage.scm
+++ b/guix/import/hackage.scm
@@ -52,34 +52,35 @@
             hackage-package?))
 
 (define ghc-standard-libraries
-  ;; List of libraries distributed with ghc (7.10.2). We include GHC itself as
-  ;; some packages list it.
-  '("array"
+  ;; List of libraries distributed with ghc (8.4.3).
+  ;; https://downloads.haskell.org/~ghc/8.4.3/docs/html/users_guide/8.4.3-notes.html
+  '("ghc"
+    "cabal" ;; in the output of `ghc-pkg list` Cabal is uppercased, but
+            ;; hackage-name->package-name takes this into account.
+    "win32" ;; similarly uppercased
+    "array"
     "base"
-    "bin-package-db"
     "binary"
     "bytestring"
-    "cabal" ;; in the output of `ghc-pkg list` Cabal is uppercased, but
-            ;; hackage-name->package-name takes this into account.
     "containers"
     "deepseq"
     "directory"
     "filepath"
-    "ghc"
+    "ghc-boot"
+    "ghc-compact"
     "ghc-prim"
+    "ghci"
     "haskeline"
-    "hoopl"
     "hpc"
     "integer-gmp"
-    "pretty"
+    "mtl"
+    "parsec"
     "process"
-    "rts"
     "template-haskell"
-    "terminfo"
+    "text"
     "time"
     "transformers"
     "unix"
-    "win32"
     "xhtml"))
 
 (define package-name-prefix "ghc-")
-- 
2.21.0

Message #8 received at 35907 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: 35907 <at> debbugs.gnu.org
Subject: note
Date: Tue, 28 May 2019 15:39:45 +0200

Note that I’m not sure it’s actually a good idea to exclude (all of) these packages
from the dependencies: They’re mostly bundled with ghc because they are used in the
ghc build. As such, it might well be that future ghc versions switch out e.g.
“bytestring” for some alternate data structure, which would then require changes to
all package definitions that currently silently depend on “bytestring”.

Should I include a patch to remove the explicitly packaged `ghc-text` and other
packages of this type?

Message #11 received at 35907 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Robert Vollmert <rob <at> vllmrt.net>
Cc: 35907 <at> debbugs.gnu.org
Subject: Re: [bug#35907] note
Date: Sat, 01 Jun 2019 06:16:52 +0200

Hi Robert,

> Note that I’m not sure it’s actually a good idea to exclude (all of) these packages
> from the dependencies: They’re mostly bundled with ghc because they are used in the
> ghc build. As such, it might well be that future ghc versions switch out e.g.
> “bytestring” for some alternate data structure, which would then require changes to
> all package definitions that currently silently depend on “bytestring”.

While this is correct, we cannot seem to remove them from the
environment when building packages.  If we allow these packages to be
added as inputs and these packages are at different versions from what
GHC provides we get into trouble.

This happened in the past, unfortunately, and it’s hard to debug.

> Should I include a patch to remove the explicitly packaged `ghc-text` and other
> packages of this type?

Yes, I think this would be good.

Thank you for working on this!

--
Ricardo

Message #16 received at 35907-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Robert Vollmert <rob <at> vllmrt.net>
Cc: 35907-done <at> debbugs.gnu.org
Subject: Re: [bug#35907] [PATCH] guix import hackage: update list of
 ghc-included packages
Date: Sat, 01 Jun 2019 06:24:10 +0200

Hi Robert,

> Update the list of excepted dependencies for current ghc-8.4,
> based on the release notes at
> https://downloads.haskell.org/~ghc/8.4.3/docs/html/users_guide/8.4.3-notes.html
>
> Particularly, this adds `text` to the list, which is a dependency
> of `parsec` which was already on the list before, causing build
> failures with updated versions of the `text` package.
>
> * guix/import/hackage.scm (ghc-standard-libraries): Update list.

I made a minor change to the commit message (it’s hard to get this
right) and pushed this change to the master branch with commit
1cc12357a6.

Thank you!

--
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.