GNU bug report logs - #35928
[PATCH] gnu: Add osmctools

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35928 in the body.
You can then email your comments to 35928 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Guillaume LE VAILLANT <glv <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add osmctools
Date: Mon, 27 May 2019 17:05:16 +0200

* gnu/packages/geo.scm (osmctools): New public variable.
---
 gnu/packages/geo.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
index 94f2cf0cfb..a18677fc49 100644
--- a/gnu/packages/geo.scm
+++ b/gnu/packages/geo.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2018 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2018 Joshua Sierles, Nextjournal <joshua <at> nextjournal.com>
 ;;; Copyright © 2018 Julien Lepiller <julien <at> lepiller.eu>
+;;; Copyright © 2019 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -36,6 +37,7 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
@@ -840,3 +842,30 @@ map, geocoding with Nominatim, or general analysis.")
 the texture and density of features is visible at every zoom level, instead of
 dropping features at lower levels.")
     (license license:bsd-2)))
+
+(define-public osmctools
+  (package
+    (name "osmctools")
+    (version "0.9")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://gitlab.com/osm-c-tools/osmctools")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1m8d3r1q1v05pkr8k9czrmb4xjszw6hvgsf3kn9pf0v14gpn4r8f"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)))
+    (inputs
+     `(("zlib" ,zlib)))
+    (home-page "https://gitlab.com/osm-c-tools/osmctools")
+    (synopsis "Tools to convert, filter and update OpenStreetMap data files")
+    (description "This project contains a few simple tools which are used in
+the OpenStreetMap project. They can be used to convert, filter and update
+OpenStreetMap data files.")
+    (license license:agpl3)))
-- 
2.21.0

Message #10 received at 35928-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Guillaume LE VAILLANT <glv <at> posteo.net>
Cc: 35928-done <at> debbugs.gnu.org
Subject: Re: [bug#35928] [PATCH] gnu: Add osmctools
Date: Mon, 27 May 2019 14:37:00 -0400

[Message part 1 (text/plain, inline)]

On Mon, May 27, 2019 at 05:05:16PM +0200, Guillaume LE VAILLANT wrote:
> * gnu/packages/geo.scm (osmctools): New public variable.

Thanks!

Pushed as ed72a133dbba02cd1d49a19e0a6391ce9384840e with the following
changes:

> +    (description "This project contains a few simple tools which are used in
> +the OpenStreetMap project. They can be used to convert, filter and update
> +OpenStreetMap data files.")

`guix environment guix -- ./pre-inst-env guix lint osmctools` complained
about a minor formatting issue in the description:

"gnu/packages/geo.scm:868:17: osmctools <at> 0.9: sentences in description should be followed by two spaces; possible infraction at 84"

Also, I removed the word "simple" in accordance with our guidelines
about synopses and descriptions [0] — specifically the part about using
"marketing phrases". It's a minor nitpick but I was already editing the
description... :)

Thank you very much for your contribution!

[0]
https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.