GNU bug report logs - #35944
[PATCH] gnu: packages: haskell: happy: Disable tests

Previous Next

Package: guix-patches;

Reported by: Robert Vollmert <rob <at> vllmrt.net>

Date: Tue, 28 May 2019 12:42:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35944 in the body.
You can then email your comments to 35944 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#35944; Package guix-patches. (Tue, 28 May 2019 12:42:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Robert Vollmert <rob <at> vllmrt.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 28 May 2019 12:42:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: guix-patches <at> gnu.org
Cc: Robert Vollmert <rob <at> vllmrt.net>
Subject: [PATCH] gnu: packages: haskell: happy: Disable tests
Date: Tue, 28 May 2019 14:41:01 +0200
Tests fail reliably for me on a system with 2GB of available RAM, in
`issue93.a.hs` and `issue93.n.hs`.

* gnu/packages/haskell.scm (ghc-happy): Disable tests
---
 gnu/packages/haskell.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 33c9c6484d..7ef32537c8 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -1325,6 +1325,8 @@ postfix notation.  For more information on stack based languages, see
         (base32
          "138xpxdb7x62lpmgmb6b3v3vgdqqvqn4273jaap3mjmc2gla709y"))))
     (build-system haskell-build-system)
+    (arguments
+      `(#:tests? #f)) ; Test require excessive amounts of memory
     (home-page "https://hackage.haskell.org/package/happy")
     (synopsis "Parser generator for Haskell")
     (description "Happy is a parser generator for Haskell.  Given a grammar
-- 
2.20.1 (Apple Git-117)





Information forwarded to guix-patches <at> gnu.org:
bug#35944; Package guix-patches. (Sat, 01 Jun 2019 12:56:01 GMT) Full text and rfc822 format available.

Message #8 received at 35944 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Robert Vollmert <rob <at> vllmrt.net>
Cc: 35944 <at> debbugs.gnu.org
Subject: Re: [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests
Date: Sat, 01 Jun 2019 14:55:15 +0200
Robert Vollmert <rob <at> vllmrt.net> skribis:

> Tests fail reliably for me on a system with 2GB of available RAM, in
> `issue93.a.hs` and `issue93.n.hs`.

They fail because they run out of memory?

What would it take to skip just these two tests instead of skipping all
the tests?

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#35944; Package guix-patches. (Sat, 01 Jun 2019 14:41:01 GMT) Full text and rfc822 format available.

Message #11 received at 35944 <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35944 <at> debbugs.gnu.org
Subject: Re: [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests
Date: Sat, 1 Jun 2019 16:40:31 +0200

> On 1. Jun 2019, at 14:56, Robert Vollmert <rob <at> vllmrt.net> wrote:
>> On 1. Jun 2019, at 14:55, Ludovic Courtès <ludo <at> gnu.org> wrote:
>> They fail because they run out of memory?
> 
> Indeed, the OOM killer strikes.
> 
>> What would it take to skip just these two tests instead of skipping all
>> the tests?
> 
> I’ll look into it.

Below is a patch that does that. I’m now running into similar issues when
compiling ghc-scientific; should OOM test failures at 2G of memory generally
be considered worth fixing? As an alternative, would it be feasible to
implement a --skip-tests flag for guix build?

From 7b7029d99df7df2ccdbfb4026edd91daa2a5763e Mon Sep 17 00:00:00 2001
From: Robert Vollmert <rob <at> vllmrt.net>
Date: Tue, 28 May 2019 21:10:24 +0200
Subject: [PATCH] gnu: ghc-happy: Skip memory-hungry tests.

Tests fail reliably for me on a system with 2GB of available RAM, in
`issue93.a.hs` and `issue93.n.hs`.

* gnu/packages/haskell.scm (ghc-happy): Skip test "issue93".
---
 gnu/packages/haskell.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 33c9c6484d..be9ab00bfd 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -1325,6 +1325,14 @@ postfix notation.  For more information on stack based languages, see
         (base32
          "138xpxdb7x62lpmgmb6b3v3vgdqqvqn4273jaap3mjmc2gla709y"))))
     (build-system haskell-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'skip-test-issue93
+           (lambda _
+             (substitute* "tests/Makefile"
+               ((" issue93.y ") " "))
+             #t)))))
     (home-page "https://hackage.haskell.org/package/happy")
     (synopsis "Parser generator for Haskell")
     (description "Happy is a parser generator for Haskell.  Given a grammar
-- 
2.20.1 (Apple Git-117)





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sat, 01 Jun 2019 21:31:01 GMT) Full text and rfc822 format available.

Notification sent to Robert Vollmert <rob <at> vllmrt.net>:
bug acknowledged by developer. (Sat, 01 Jun 2019 21:31:02 GMT) Full text and rfc822 format available.

Message #16 received at 35944-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Robert Vollmert <rob <at> vllmrt.net>
Cc: 35944-done <at> debbugs.gnu.org
Subject: Re: [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests
Date: Sat, 01 Jun 2019 23:30:27 +0200
Hi,

Robert Vollmert <rob <at> vllmrt.net> skribis:

> Below is a patch that does that. I’m now running into similar issues when
> compiling ghc-scientific; should OOM test failures at 2G of memory generally
> be considered worth fixing?

I’d say yes, as long as we’re just talking about a small fraction of the
GHC packages.

> As an alternative, would it be feasible to implement a --skip-tests
> flag for guix build?

That would amount to building a different derivation, so that’s not
really a solution.

> From 7b7029d99df7df2ccdbfb4026edd91daa2a5763e Mon Sep 17 00:00:00 2001
> From: Robert Vollmert <rob <at> vllmrt.net>
> Date: Tue, 28 May 2019 21:10:24 +0200
> Subject: [PATCH] gnu: ghc-happy: Skip memory-hungry tests.
>
> Tests fail reliably for me on a system with 2GB of available RAM, in
> `issue93.a.hs` and `issue93.n.hs`.
>
> * gnu/packages/haskell.scm (ghc-happy): Skip test "issue93".

I copied the explanation as a comment and applied.

Thanks!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 30 Jun 2019 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 273 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.