GNU bug report logs - #35970
[PATCH] gnu: Add qview.

Previous Next

Package: guix-patches;

Reported by: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Date: Tue, 28 May 2019 22:52:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35970 in the body.
You can then email your comments to 35970 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#35970; Package guix-patches. (Tue, 28 May 2019 22:52:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 28 May 2019 22:52:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: [PATCH] gnu: Add qview.
Date: Wed, 29 May 2019 00:51:05 +0200
* gnu/packages/image-viewers.scm (qview): New variable.
---
 gnu/packages/image-viewers.scm | 48 ++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 82b44a4900..8dee417cdb 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2017 nee <nee-git <at> hidamari.blue>
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2018, 2019 Ricardo Wurmus <rekado <at> elephly.net>
+;;; Copyright © 2019 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -429,3 +430,50 @@ imaging.  It supports several HDR and LDR image formats, and it can:
 a comic and manga reader.  It supports a variety of container formats
 including CBZ, CB7, CBT, LHA.")
     (license license:gpl2+)))
+
+(define-public qview
+  (package
+    (name "qview")
+    (version "2.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/jurplel/qView.git")
+                    (commit version)))
+              (sha256
+               (base32
+                "1s29hz44rb5dwzq8d4i4bfg77dr0v3ywpvidpa6xzg7hnnv3mhi5"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda _
+             (invoke "qmake")))
+         ;; Installation process hard-codes "/usr/bin", possibly
+         ;; prefixed.
+         (add-after 'configure 'fix-install-directory
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* "Makefile"
+                 (("\\$\\(INSTALL_ROOT\\)/usr") out))
+               #t)))
+         ;; Don't phone home or show "Checking for updates..." in the
+         ;; About menu.
+         (add-before 'build 'disable-auto-update
+           (lambda _
+             (substitute* "src/qvaboutdialog.cpp"
+               (("ui->updateLabel->setText\\(updateText\\);") "")
+               (("requestUpdates\\(\\);") ""))
+             #t)))))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qtsvg" ,qtsvg)
+       ("qtimageformats" ,qtimageformats)))
+    (home-page "https://interversehq.com/qview/")
+    (synopsis "Practical and minimal image viewer")
+    (description "qView is a Qt image viewer designed with visually
+minimalism and usability in mind.  Its features include animated GIF
+controls, file history, rotation/mirroring, and multithreaded
+preloading.")
+    (license license:gpl3+)))
-- 
2.21.0





Information forwarded to guix-patches <at> gnu.org:
bug#35970; Package guix-patches. (Sat, 01 Jun 2019 13:07:02 GMT) Full text and rfc822 format available.

Message #8 received at 35970 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 35970 <at> debbugs.gnu.org
Subject: Re: [bug#35970] [PATCH] gnu: Add qview.
Date: Sat, 01 Jun 2019 15:06:30 +0200
Salut,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

> * gnu/packages/image-viewers.scm (qview): New variable.

[...]

> +    (synopsis "Practical and minimal image viewer")
                  ^~~~~~~~~

Did you mean “convenient”?  :-)
(It surely is practical too, but the same could be said of all the image
viewers we have.)

Otherwise LGTM!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#35970; Package guix-patches. (Sat, 01 Jun 2019 20:54:01 GMT) Full text and rfc822 format available.

Message #11 received at 35970 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35970 <at> debbugs.gnu.org
Subject: Re: [bug#35970] [PATCH] gnu: Add qview.
Date: Sat, 01 Jun 2019 22:52:54 +0200
Hello,

Thank you for the review.

Ludovic Courtès <ludo <at> gnu.org> writes:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:
>
>> * gnu/packages/image-viewers.scm (qview): New variable.
>
> [...]
>
>> +    (synopsis "Practical and minimal image viewer")
>                   ^~~~~~~~~
>
> Did you mean “convenient”?  :-)
> (It surely is practical too, but the same could be said of all the image
> viewers we have.)

OK. Bikeshedding time :)

I used the words from the developers themselves
<https://github.com/jurplel/qView>, so I didn't mean anything in
particular. 

However, AFAIU, there is a difference between practical and convenient:
the latter suggests some ease of use that the former doesn't. For
example, the `find' utility is practical, but not what I would call
convenient.

Now, I don't have a strong opinion about it. I just wanted to be
faithful to the developers' words.

Bikeshedding time's over.

So, "Practical" or "convenient", or something different, like:

  "Fully-featured yet unobtrusive image viewer"


Regards,

-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#35970; Package guix-patches. (Sat, 01 Jun 2019 21:54:03 GMT) Full text and rfc822 format available.

Message #14 received at 35970 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 35970 <at> debbugs.gnu.org
Subject: Re: [bug#35970] [PATCH] gnu: Add qview.
Date: Sat, 01 Jun 2019 23:53:29 +0200
Hi!

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

> However, AFAIU, there is a difference between practical and convenient:
> the latter suggests some ease of use that the former doesn't. For
> example, the `find' utility is practical, but not what I would call
> convenient.

Yes, that’s what I meant.

I commented because I was quite sure “convenient” was meant and because
“practical” is a false friend in French, but it’s no big deal.

So please push with your preferred wording!  :-)

Ludo’.




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Wed, 05 Jun 2019 21:46:02 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
bug acknowledged by developer. (Wed, 05 Jun 2019 21:46:02 GMT) Full text and rfc822 format available.

Message #19 received at 35970-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35970-done <at> debbugs.gnu.org
Subject: Re: [bug#35970] [PATCH] gnu: Add qview.
Date: Wed, 05 Jun 2019 23:45:02 +0200
Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> I commented because I was quite sure “convenient” was meant and because
> “practical” is a false friend in French, but it’s no big deal.
>
> So please push with your preferred wording!  :-)

Fair enough. I used "convenient" and pushed the commit.

Thank you.

Regards,

-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 04 Jul 2019 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 269 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.