GNU bug report logs - #35977
[PATCH 45/47] gnu: Add python-strict-rfc3339.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35977 in the body.
You can then email your comments to 35977 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "h.nasajpour" <h.nasajpour <at> pantherx.org>
To: guix-patches <at> gnu.org
Cc: "h.nasajpour" <h.nasajpour <at> pantherx.org>
Subject: [PATCH 45/47] gnu: Add python-strict-rfc3339.
Date: Wed, 29 May 2019 05:06:21 +0430

* gnu/packages/time.scm (python-strict-rfc3339): New variable
---
 gnu/packages/time.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/time.scm b/gnu/packages/time.scm
index 1363843b31..9e23ffae14 100644
--- a/gnu/packages/time.scm
+++ b/gnu/packages/time.scm
@@ -440,3 +440,21 @@ datetime type.")
 modifies the @code{time}, @code{gettimeofday} and @code{clock_gettime} system
 calls.")
     (license gpl2)))
+
+(define-public python-strict-rfc3339
+  (package
+    (name "python-strict-rfc3339")
+    (version "0.7")
+    (source (origin
+      (method url-fetch)
+      (uri (pypi-uri "strict-rfc3339" version))
+      (sha256 (base32 "0xqjbsn0g1h88rayh5yrpdagq60zfwrfs3yvk6rmgby3vyz1gbaw"))))
+    (build-system python-build-system)
+    (arguments
+      `(
+        #:tests? #f
+        ))
+    (home-page "https://github.com/danielrichman/strict-rfc3339")
+    (synopsis "Strict, simple, lightweight RFC3339 functions.")
+    (description "Convert unix timestamps to and from RFC3339.")
+    (license license:gpl3+)))
-- 
2.17.1

Message #8 received at 35977 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: "h.nasajpour" <h.nasajpour <at> pantherx.org>
Cc: 35977 <at> debbugs.gnu.org
Subject: Re: [bug#35977] [PATCH 45/47] gnu: Add python-strict-rfc3339.
Date: Tue, 10 Dec 2019 00:47:47 -0600

"h.nasajpour" <h.nasajpour <at> pantherx.org> writes:

> * gnu/packages/time.scm (python-strict-rfc3339): New variable
> ---
>  gnu/packages/time.scm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/time.scm b/gnu/packages/time.scm
> index 1363843b31..9e23ffae14 100644
> --- a/gnu/packages/time.scm
> +++ b/gnu/packages/time.scm
> @@ -440,3 +440,21 @@ datetime type.")
>  modifies the @code{time}, @code{gettimeofday} and @code{clock_gettime} system
>  calls.")
>      (license gpl2)))
> +
> +(define-public python-strict-rfc3339
> +  (package
> +    (name "python-strict-rfc3339")
> +    (version "0.7")
> +    (source (origin
> +      (method url-fetch)
> +      (uri (pypi-uri "strict-rfc3339" version))
> +      (sha256 (base32 "0xqjbsn0g1h88rayh5yrpdagq60zfwrfs3yvk6rmgby3vyz1gbaw"))))
> +    (build-system python-build-system)
> +    (arguments
> +      `(
> +        #:tests? #f
> +        ))
> +    (home-page "https://github.com/danielrichman/strict-rfc3339")
> +    (synopsis "Strict, simple, lightweight RFC3339 functions.")
> +    (description "Convert unix timestamps to and from RFC3339.")
> +    (license license:gpl3+)))

Hi,

Again, we are needing some revisions before this package is ready to be
merged. Spare my brevity, but here is a list.

1. The commit message does not follow our style guide.
2. The indentation for the hash is incorrect. See surrounding packages
for an idea of how to do this.
3. Parens should not go on lines by themselves.
4. Disabled tests should either be disabled with reason, but only if
they fail for reasons we can not control.
5. Synopsis/Description does not follow our style guide.

As before, if you need help please do let me know :).

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

Message #13 received at 35977-done <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: 35977-done <at> debbugs.gnu.org 
Cc: "h.nasajpour" <h.nasajpour <at> pantherx.org>, Brett Gilio <brettg <at> posteo.net>
Subject: Re: bug#35977: [PATCH 45/47] gnu: Add python-strict-rfc3339.
Date: Tue, 20 Jun 2023 23:22:30 +0200

This package can be found in guix master. Closing.
- Jelle

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.