GNU bug report logs - #36023
[PATCH] linux-boot: Fix e2fsck warning.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36023 in the body.
You can then email your comments to 36023 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] linux-boot: Fix e2fsck warning.
Date: Fri, 31 May 2019 13:27:35 +0200

* gnu/build/linux-boot.scm (boot-system): Fix e2fsck warning.
---
 gnu/build/linux-boot.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/build/linux-boot.scm b/gnu/build/linux-boot.scm
index a35d18ad7c..03f2ea245c 100644
--- a/gnu/build/linux-boot.scm
+++ b/gnu/build/linux-boot.scm
@@ -517,6 +517,8 @@ upon error."
          (unless (pre-mount)
            (error "pre-mount actions failed")))
 
+       (setenv "EXT2FS_NO_MTAB_OK" "1")
+
        (if root
            ;; The "--root=SPEC" kernel command-line option always provides a
            ;; string, but the string can represent a device, a UUID, or a
@@ -533,6 +535,8 @@ upon error."
        (for-each mount-file-system
                  (remove root-mount-point? mounts))
 
+       (setenv "EXT2FS_NO_MTAB_OK" #f)
+
        (if to-load
            (begin
              (switch-root "/root")

Message #8 received at 36023 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 36023 <at> debbugs.gnu.org
Subject: Re: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning.
Date: Sat, 01 Jun 2019 15:13:58 +0200

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> * gnu/build/linux-boot.scm (boot-system): Fix e2fsck warning.

Oooh, thanks for fixing this one.  LGTM!

Ludo’.

Message #13 received at 36023-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36023-done <at> debbugs.gnu.org
Subject: Re: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning.
Date: Mon, 3 Jun 2019 18:09:50 +0200

[Message part 1 (text/plain, inline)]

Thanks for the review!

Pushed it to guix master as commit aa901521e4e5625dd8a63e67a64be2f562ca61c7.

[Message part 2 (application/pgp-signature, inline)]

Message #16 received at 36023 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Danny Milosavljevic <dannym <at> scratchpost.org>, 36023 <at> debbugs.gnu.org
Subject: Re: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning.
Date: Mon, 3 Jun 2019 18:17:14 +0200

On 5/31/19 1:27 PM, Danny Milosavljevic wrote:
> +       (setenv "EXT2FS_NO_MTAB_OK" "1")
> +
[...]
> +       (setenv "EXT2FS_NO_MTAB_OK" #f)
> +

Maybe it would be nice to have them constintly using either "0" and "1"
or #t and #f :)

Message #19 received at 36023 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 36023 <at> debbugs.gnu.org
Subject: Re: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning.
Date: Mon, 3 Jun 2019 18:53:41 +0200

[Message part 1 (text/plain, inline)]

Hi Jonathan,

On Mon, 3 Jun 2019 18:17:14 +0200
Jonathan Brielmaier <jonathan.brielmaier <at> web.de> wrote:

> On 5/31/19 1:27 PM, Danny Milosavljevic wrote:
> > +       (setenv "EXT2FS_NO_MTAB_OK" "1")
> > +  
> [...]
> > +       (setenv "EXT2FS_NO_MTAB_OK" #f)
> > +  
> 
> Maybe it would be nice to have them constintly using either "0" and "1"
> or #t and #f :)

Well, the UNIX environment interface and/or Guile's interface to it doesn't
work that way.  The UNIX environment is a string array.

e2fsck uses if(getenv("EXT2FS_NO_MTAB_OK")) to read the value of the entry
with the key "EXT2FS_NO_MTAB_OK".

So we can set the environment entry to any value we want and e2fsck's "if"
condition will evaluate to true.

And in order to remove it from the environment again, we call setenv with
#f.

We could also call unsetenv instead, I guess.  Should we?

[Message part 2 (application/pgp-signature, inline)]

Message #22 received at 36023 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 36023 <at> debbugs.gnu.org
Subject: Re: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning.
Date: Mon, 3 Jun 2019 19:01:39 +0200

On 6/3/19 6:53 PM, Danny Milosavljevic wrote:
> Hi Jonathan,
>
> On Mon, 3 Jun 2019 18:17:14 +0200
> Jonathan Brielmaier <jonathan.brielmaier <at> web.de> wrote:
>
>> On 5/31/19 1:27 PM, Danny Milosavljevic wrote:
>>> +       (setenv "EXT2FS_NO_MTAB_OK" "1")
>>> +
>> [...]
>>> +       (setenv "EXT2FS_NO_MTAB_OK" #f)
>>> +
>>
>> Maybe it would be nice to have them constintly using either "0" and "1"
>> or #t and #f :)
>
> Well, the UNIX environment interface and/or Guile's interface to it doesn't
> work that way.  The UNIX environment is a string array.
>
> e2fsck uses if(getenv("EXT2FS_NO_MTAB_OK")) to read the value of the entry
> with the key "EXT2FS_NO_MTAB_OK".
>
> So we can set the environment entry to any value we want and e2fsck's "if"
> condition will evaluate to true.
>
> And in order to remove it from the environment again, we call setenv with
> #f.
>
> We could also call unsetenv instead, I guess.  Should we?

Ah, oke. Thanks for the explanation. I think we can leave it as it is...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.