GNU bug report logs - #36050
[PATCH] gnu: Add emacs-xterm-color

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36050 in the body.
You can then email your comments to 36050 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Frederickson <jonathan <at> terracrypt.net>
To: guix-patches <at> gnu.org
Cc: Jonathan Frederickson <jonathan <at> terracrypt.net>
Subject: [PATCH] gnu: Add emacs-xterm-color
Date: Sat,  1 Jun 2019 22:59:56 -0400

* gnu/packages/emacs-xyz.scm: (emacs-xterm-color) new variable.
---
 gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9199b45e40..70dd9e599b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15620,3 +15620,21 @@ verb commands which would are normally destructive (such as deletion) are
 provided.  Those alternative commands are and bound by default to their
 corresponding Evil keys.")
       (license license:expat))))
+
+(define-public emacs-xterm-color
+  (package
+    (name "emacs-xterm-color")
+    (version "20190519.1243")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://melpa.org/packages/xterm-color-"
+                    version
+                    ".el"))
+              (sha256
+               (base32 "0cdl8cpqv3x23y4vpfib4kjncy9xslvka04gpszdnasf7av5g8g7"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/atomontage/xterm-color")
+    (synopsis "ANSI & xterm-256 color text property translator for Emacs")
+    (description "@code{xterm-color.el} is an ANSI control sequence to text-property translator")
+    (license license:bsd-2)))
-- 
2.21.0

Message #8 received at 36050 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jonathan Frederickson <jonathan <at> terracrypt.net>
Cc: 36050 <at> debbugs.gnu.org
Subject: Re: [bug#36050] [PATCH] gnu: Add emacs-xterm-color
Date: Wed, 05 Jun 2019 17:27:02 +0200

Hi Jonathan,

Jonathan Frederickson <jonathan <at> terracrypt.net> skribis:

> * gnu/packages/emacs-xyz.scm: (emacs-xterm-color) new variable.

[...]

> +              (uri (string-append
> +                    "https://melpa.org/packages/xterm-color-"
> +                    version
> +                    ".el"))

melpa.org URLs are not stable: files get modified in place.  For that
reason, we usually refer directly to upstream VCS repositories.

Could you modify the patch accordingly?

> +    (synopsis "ANSI & xterm-256 color text property translator for Emacs")
> +    (description "@code{xterm-color.el} is an ANSI control sequence to text-property translator")

Please add a period at the end of the sentence.  :-)

Thank you,
Ludo’.

Message #11 received at 36050 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Frederickson <jonathan <at> terracrypt.net>
To: 36050 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Jonathan Frederickson <jonathan <at> terracrypt.net>
Subject: [PATCH] gnu: Add emacs-xterm-color
Date: Thu,  6 Jun 2019 23:40:00 -0400

* gnu/packages/emacs-xyz.scm: (emacs-xterm-color) new variable.
---
 gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9199b45e40..3224883969 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15620,4 +15620,23 @@ verb commands which would are normally destructive (such as deletion) are
 provided.  Those alternative commands are and bound by default to their
 corresponding Evil keys.")
       (license license:expat))))
+
+(define-public emacs-xterm-color
+  (let ((commit "a452ab38a7cfae97078062ff8885b5d74fd1e5a6")
+        (version "1.8")
+        (revision "1"))
+    (package
+      (name "emacs-xterm-color")
+      (version (git-version version revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/atomontage/xterm-color.git")
+                      (commit commit)))
+                (sha256
+                 (base32 "02kpajb993yshhjhsizpfcbrcndyzkf4dqfipifhxxng50dhp95i"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/atomontage/xterm-color")
+      (synopsis "ANSI & xterm-256 color text property translator for Emacs")
+      (description "@code{xterm-color.el} is an ANSI control sequence to text-property translator.")
+      (license license:bsd-2))))
-- 

Here's a revised version - I saw there were a few different
conventions for packages with git sources, but I figured using both a
numeric version for the version I intended and a git hash for
stability would be desirable.

Message #16 received at 36050-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jonathan Frederickson <jonathan <at> terracrypt.net>
Cc: 36050-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add emacs-xterm-color
Date: Fri, 07 Jun 2019 09:30:41 +0200

Hi,

Jonathan Frederickson <jonathan <at> terracrypt.net> skribis:

> * gnu/packages/emacs-xyz.scm: (emacs-xterm-color) new variable.

Applied, thanks!

I followed up with a commit to address ‘guix lint’ warnings.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.