GNU bug report logs - #36061
Error when byte compiling

unarchive 36061

From: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
To: bug-hyperbole <at> gnu.org
Subject: Error when byte compiling
Date: Sun, 02 Jun 2019 16:46:18 -0500

I am attempting to package Hyperbole for GNU Guix using its 
provided emacs-build-system.  As part of the default packaging 
steps, Hyperbole's Emacs Lisp code is byte compiled.  This step is 
failing for me with the following error:

> Compiling 
> /gnu/store/334qz3xsnfx2alz4gii2s6vgw4762ixa-emacs-hyperbole-7.0.3/share/emacs/site-lisp/guix.d/hyperbole-7.0.3/hact.el...
>
> In end of data:
> hact.el:377:1:Warning: the following functions are not known to 
> be defined:
>     hypb:indirect-function, hypb:emacs-byte-code-p, hattr:get, 
>     hbut:is-p
> Compiling 
> /gnu/store/334qz3xsnfx2alz4gii2s6vgw4762ixa-emacs-hyperbole-7.0.3/share/emacs/site-lisp/guix.d/hyperbole-7.0.3/hactypes.el...
> Symbol’s function definition is void: hyperbole-toggle-messaging

I can see where hyperbole-toggle-message is defined and marked for 
autoloading in hyperbole.el.  My best guess is that the problem is 
caused by the order in which the files are being byte compiled, 
but I would appreciate analysis from someone who is familiar with 
Hyperbole's source.

--
Joseph LaFreniere

From: Robert Weiner <rswgnu <at> gmail.com>
To: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
Cc: 36061 <at> debbugs.gnu.org
Subject: Re: bug#36061: Error when byte compiling
Date: Tue, 4 Jun 2019 01:21:51 -0400

Have to look at this.  There are some complex ordering dependencies but they are supposed to be handled by the existing file requirements.

Is the failure repeatable every time?

> On Jun 2, 2019, at 5:46 PM, LaFreniere, Joseph <joseph <at> lafreniere.xyz> wrote:
> 
> I am attempting to package Hyperbole for GNU Guix using its provided emacs-build-system.  As part of the default packaging steps, Hyperbole's Emacs Lisp code is byte compiled.  This step is failing for me with the following error:
> 
>> Compiling /gnu/store/334qz3xsnfx2alz4gii2s6vgw4762ixa-emacs-hyperbole-7.0.3/share/emacs/site-lisp/guix.d/hyperbole-7.0.3/hact.el...
>> 
>> In end of data:
>> hact.el:377:1:Warning: the following functions are not known to be defined:
>>    hypb:indirect-function, hypb:emacs-byte-code-p, hattr:get,     hbut:is-p
>> Compiling /gnu/store/334qz3xsnfx2alz4gii2s6vgw4762ixa-emacs-hyperbole-7.0.3/share/emacs/site-lisp/guix.d/hyperbole-7.0.3/hactypes.el...
>> Symbol’s function definition is void: hyperbole-toggle-messaging
> 
> I can see where hyperbole-toggle-message is defined and marked for autoloading in hyperbole.el.  My best guess is that the problem is caused by the order in which the files are being byte compiled, but I would appreciate analysis from someone who is familiar with Hyperbole's source.
> 
> --
> Joseph LaFreniere
> 
> 
> 
> _______________________________________________
> Bug-hyperbole mailing list
> Bug-hyperbole <at> gnu.org
> https://lists.gnu.org/mailman/listinfo/bug-hyperbole

From: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
To: Robert Weiner <rswgnu <at> gmail.com>
Cc: 36061 <at> debbugs.gnu.org
Subject: Re: bug#36061: Error when byte compiling
Date: Wed, 05 Jun 2019 01:32:18 -0500

[Message part 1 (text/plain, inline)]
Robert Weiner <rswgnu <at> gmail.com> writes:
> Is the failure repeatable every time?

Yes, the failure is repeatable and occurs with every build attempt 
of 7.0.3, which is the only version I have attempted to package. 
My WIP patch is attached.

> There are some complex ordering dependencies but they are 
> supposed to be handled by the existing file requirements.

Yes, I would have thought that the file requirements would suffice 
to resolve compilation order.

Reading through Guix's source code (namely 
guix/build/emacs-utils.scm), it seems that emacs-build-system 
compiles packages by invoking Emacs with the following arguments:
--quick --batch --eval="(progn (setq byte-compile-debug t) 
 (byte-recompile-directory (file-name-as-directory 
 \"$path_to_hyperbole\") 0 1))"

--
Joseph LaFreniere

[emacs-hyperbole.patch (text/x-patch, attachment)]
From: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
To: Robert Weiner <rswgnu <at> gmail.com>
Cc: 36061 <at> debbugs.gnu.org
Subject: Re: bug#36061: Error when byte compiling
Date: Sat, 13 Jul 2019 10:35:43 -0500

[Message part 1 (text/plain, inline)]
I have attached a working patch to successfully build Hyperbole in 
Guix 1.0.1.

The notable changes are in the patch files my patch adds:
- The definition of hyperbole-toggle-messaging is moved to 
 hsettings.el, which seems to be the only place in the Hyperbole 
 repo where that function is called.  This avoids the build error 
 I initially reported.
- hyperb:check-dir-user fails during Guix's build process;  for 
 now, I have simply removed that check from the initialization 
 steps.

Now that Hyperbole is successfully building, I will start using it 
and report any bugs I encounter here.  Are there specific 
ramifications to either of these changes that you would recommend 
I look for?

--
Joseph LaFreniere

[0001-gnu-Add-emacs-hyperble.patch (text/x-patch, attachment)]
From: Robert Weiner <rswgnu <at> gmail.com>
To: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
Cc: 36061 <at> debbugs.gnu.org
Subject: Re: bug#36061: Error when byte compiling
Date: Sat, 13 Jul 2019 16:12:35 -0400

Help me understand.  Why di you need to use Guix with Hyperbole rather than simply installing it from Elpa via the Emacs package manager.  Are you trying to create some form of distribution?

Happy it is running for you.  I just want to understand what the broader utility of this might be.

-- Bob

> On Jul 13, 2019, at 11:35 AM, LaFreniere, Joseph <joseph <at> lafreniere.xyz> wrote:
> 
> I have attached a working patch to successfully build Hyperbole in Guix 1.0.1.
> 
> The notable changes are in the patch files my patch adds:
> - The definition of hyperbole-toggle-messaging is moved to  hsettings.el, which seems to be the only place in the Hyperbole  repo where that function is called.  This avoids the build error  I initially reported.
> - hyperb:check-dir-user fails during Guix's build process;  for  now, I have simply removed that check from the initialization  steps.
> 
> Now that Hyperbole is successfully building, I will start using it and report any bugs I encounter here.  Are there specific ramifications to either of these changes that you would recommend I look for?
> 
> --
> Joseph LaFreniere
> <0001-gnu-Add-emacs-hyperble.patch>

GNU bug report logs - #36061 Error when byte compiling

GNU bug report logs - #36061
Error when byte compiling