GNU bug report logs - #36106
[PATCH] guix: git-download: Remove explicit import.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36106 in the body.
You can then email your comments to 36106 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Vollmert <rob <at> vllmrt.net>
To: guix-patches <at> gnu.org
Cc: Robert Vollmert <rob <at> vllmrt.net>
Subject: [PATCH] guix: git-download: Remove explicit import.
Date: Wed,  5 Jun 2019 20:56:14 +0200

With guile-git version 0.2, repository-working-directory is no
longer private.

* guix/git-download.scm (git-file-list): Refer to public
repository-working-directory.
---
 guix/git-download.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/guix/git-download.scm b/guix/git-download.scm
index 6cf267d6c8..f904d11c25 100644
--- a/guix/git-download.scm
+++ b/guix/git-download.scm
@@ -185,9 +185,7 @@ are relative to DIRECTORY, which is not necessarily the root of the checkout."
          (directory  (string-append (canonicalize-path directory) "/"))
          (dot-git    (repository-discover directory))
          (repository (repository-open dot-git))
-         ;; XXX: This procedure is mistakenly private in Guile-Git 0.1.0.
-         (workdir    ((@@ (git repository) repository-working-directory)
-                      repository))
+         (workdir    (repository-working-directory repository))
          (head       (repository-head repository))
          (oid        (reference-target head))
          (commit     (commit-lookup repository oid))
-- 
2.20.1 (Apple Git-117)

Message #10 received at 36106-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Robert Vollmert <rob <at> vllmrt.net>
Cc: 36106-done <at> debbugs.gnu.org
Subject: Re: [bug#36106] [PATCH] guix: git-download: Remove explicit import.
Date: Thu, 06 Jun 2019 17:43:21 +0200

Hi,

Robert Vollmert <rob <at> vllmrt.net> skribis:

> With guile-git version 0.2, repository-working-directory is no
> longer private.
>
> * guix/git-download.scm (git-file-list): Refer to public
> repository-working-directory.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.