Received: (at 36135) by debbugs.gnu.org; 12 Jun 2019 09:30:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 12 05:30:54 2019 Received: from localhost ([127.0.0.1]:60719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hazao-0004GH-43 for submit <at> debbugs.gnu.org; Wed, 12 Jun 2019 05:30:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1hazam-0004G1-5P for 36135 <at> debbugs.gnu.org; Wed, 12 Jun 2019 05:30:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>) id 1hazaU-0003Q1-KP; Wed, 12 Jun 2019 05:30:37 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42376 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <ludo@HIDDEN>) id 1hazaA-0004ZG-PI; Wed, 12 Jun 2019 05:30:26 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Tobias Geerinckx-Rice <me@HIDDEN> Subject: Re: bug#36135: installer wifi password prompt References: <20190608151502.5d22d7e8@HIDDEN> <87zhmr984t.fsf@HIDDEN> <87r2836dnn.fsf@nckx> <87k1dt5df2.fsf@HIDDEN> <87ef41qd88.fsf@nckx> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 Prairial an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 12 Jun 2019 11:30:11 +0200 In-Reply-To: <87ef41qd88.fsf@nckx> (Tobias Geerinckx-Rice's message of "Tue, 11 Jun 2019 00:36:55 +0200") Message-ID: <87wohrxiak.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36135 Cc: 36135 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi Tobias, Tobias Geerinckx-Rice <me@HIDDEN> skribis: > Ludovic Court=C3=A8s wrote: >> No argument here! The patch referred to a keyword argument that >> does >> not exist, which is why I=E2=80=99m indeed suggesting more testing. Simp= ly >> looking at the compiler warnings would have raised a flag. > > There were no warnings and the code itself runs fine (believe me, I've > run it way too often already -_-') because this was written on top of > #36132. Oh, my bad! I hadn=E2=80=99t seen <https://issues.guix.gnu.org/issue/36132= >. I=E2=80=99ll take a look. Ludo=E2=80=99.
bug-guix@HIDDEN:bug#36135; Package guix.
Full text available.Received: (at 36135) by debbugs.gnu.org; 10 Jun 2019 22:37:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 10 18:37:04 2019 Received: from localhost ([127.0.0.1]:57615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1haSuW-0007aR-EE for submit <at> debbugs.gnu.org; Mon, 10 Jun 2019 18:37:04 -0400 Received: from tobias.gr ([80.241.217.52]:54184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1haSuT-0007Zz-Ns for 36135 <at> debbugs.gnu.org; Mon, 10 Jun 2019 18:37:03 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 32795a18; Mon, 10 Jun 2019 22:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@HIDDEN; bh=VCJPxyDhuJCtigvLzXNYG7 u2wNPuYUKkSbswkV4Sb+Q=; b=EdjE0Hzx4y8YXPNXOMfjeutTuQJ0dVvjn+1+2d f4p3BLyuzhRw3H/IgAVPKzpWAqu+I33UVNTeXjoLMqJ9BeNgN0V9qaJYAFCRcqf8 KamJcj9VuXxN29yMc4xNhIlzswxKq5ycvh8gsMRJE/h/t6OkvuMtBZVyz5Zvk8b0 BxErnyBDfVasQB4VHiwTTzw/XFWB86BZOpghM4B35RmnQCybkqbUcYhNfu5NwPJQ SymDsvXpHKPSn0TxgCsOh3/FGV6q5vVVLkSv+WRk5Ieocf92HtY3W0Hl19c/nZ+O X9g9cv8OuNpejI9FtZRA6xT5CGHIVaYPWTNRbnMA0zPkzMCA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id a19dd452 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 10 Jun 2019 22:36:56 +0000 (UTC) From: Tobias Geerinckx-Rice <me@HIDDEN> To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN> Subject: Re: bug#36135: installer wifi password prompt References: <20190608151502.5d22d7e8@HIDDEN> <87zhmr984t.fsf@HIDDEN> <87r2836dnn.fsf@nckx> <87k1dt5df2.fsf@HIDDEN> In-reply-to: <87k1dt5df2.fsf@HIDDEN> Date: Tue, 11 Jun 2019 00:36:55 +0200 Message-ID: <87ef41qd88.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36135 Cc: 36135 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hah, Ludovic Court=C3=A8s wrote: > No argument here! The patch referred to a keyword argument that=20 > does > not exist, which is why I=E2=80=99m indeed suggesting more testing.=20 > Simply > looking at the compiler warnings would have raised a flag. There were no warnings and the code itself runs fine (believe me,=20 I've run it way too often already -_-') because this was written=20 on top of #36132. I guess I was optimistic about its speedy acceptance. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXP7bhwAKCRANsP+IT1Vt ebgpAQCY3+QNPoEbpTEVOqUCqjyOm2NCq6eBbAMv8Goj2dD6wwD/Y9Gvd9b7pC7q N51MMpiKiN8WfLoUJ1x2GPjX2uxaQwo= =tn2R -----END PGP SIGNATURE----- --=-=-=--
bug-guix@HIDDEN:bug#36135; Package guix.
Full text available.Received: (at 36135) by debbugs.gnu.org; 10 Jun 2019 21:38:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 10 17:38:49 2019 Received: from localhost ([127.0.0.1]:57569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1haS08-0006E5-Oa for submit <at> debbugs.gnu.org; Mon, 10 Jun 2019 17:38:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1haS07-0006Dk-CK for 36135 <at> debbugs.gnu.org; Mon, 10 Jun 2019 17:38:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>) id 1haRzv-0007bO-1A; Mon, 10 Jun 2019 17:38:36 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33890 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <ludo@HIDDEN>) id 1haRzn-0001PT-Kh; Mon, 10 Jun 2019 17:38:32 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Tobias Geerinckx-Rice <me@HIDDEN> Subject: Re: bug#36135: installer wifi password prompt References: <20190608151502.5d22d7e8@HIDDEN> <87zhmr984t.fsf@HIDDEN> <87r2836dnn.fsf@nckx> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Prairial an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 10 Jun 2019 23:38:25 +0200 In-Reply-To: <87r2836dnn.fsf@nckx> (Tobias Geerinckx-Rice's message of "Sat, 08 Jun 2019 22:11:08 +0200") Message-ID: <87k1dt5df2.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36135 Cc: Julien Lepiller <julien@HIDDEN>, 36135 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi! Tobias Geerinckx-Rice <me@HIDDEN> skribis: > Ludovic Court=C3=A8s wrote: >> Tobias Geerinckx-Rice <me@HIDDEN> skribis: >> >>> * gnu/installer/newt/wifi.scm (run-wifi-password-page): >>> Add an #:INPUT-SHOW-CHECKBOX? to the input page. >> >> [...] >> >>> + #:input-show-checkbox? #t)) >> >> It=E2=80=99s called #:input-hide-checkbox? AFAICS. > > Yes. See the other patches in this ad-hoc =E2=80=98series=E2=80=99. OK. >> You can double-check that it builds without warnings with: >> >> guix system vm -v2 gnu/system/install.scm > > Sure, I guess, but could you explain the point of doing so? > Reproducibility by others? I don't think patches like these should be > pushed with such light testing, and I don't see how this can be tested > in a VM. No argument here! The patch referred to a keyword argument that does not exist, which is why I=E2=80=99m indeed suggesting more testing. Simply looking at the compiler warnings would have raised a flag. Ludo=E2=80=99.
bug-guix@HIDDEN:bug#36135; Package guix.
Full text available.Received: (at 36135) by debbugs.gnu.org; 8 Jun 2019 20:11:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 08 16:11:16 2019 Received: from localhost ([127.0.0.1]:53759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hZhgK-0002Yp-Fo for submit <at> debbugs.gnu.org; Sat, 08 Jun 2019 16:11:16 -0400 Received: from tobias.gr ([80.241.217.52]:47032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1hZhgG-0002Yc-In for 36135 <at> debbugs.gnu.org; Sat, 08 Jun 2019 16:11:15 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 001d9876; Sat, 8 Jun 2019 20:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@HIDDEN; bh=xDJjufjkS6FggMBIYvbya/ 9CeRxmZcFm5eoEJpKsSuM=; b=Qg3sI36bTBpKyxB0QTUiXCLHmZ/ZEFzOuDStCP 7IoJ4dal1sXUgNCrVXNGRSCaKy/qy+kwTJmfMDuk9vW4WkzZkteMHRIPgVbvDzSe Qzp6ylwnDCBQk4VskWj5bChpFkwHMoxxWXeNQfpbXK8buzszQsZ0V5GssgRtO8bN xpI/WQkxLHoU7DLzCjQxL822wsGw4U9Dx3w1ULRxx7bRqdIwIRbJiYwGLQDJSc0A KQHTuQghFUGmlpOb3yxX3NuibQnvY9DBrjJAtuxqk0kBqqaKJ8a34b84RvOrHOOY HEIM0YhuLm7espsw4hLf5Hr0+fvx7PZgHUrcc3RDrLGkF6Nw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id f88f05fe (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 8 Jun 2019 20:11:09 +0000 (UTC) From: Tobias Geerinckx-Rice <me@HIDDEN> To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN> Subject: Re: bug#36135: installer wifi password prompt References: <20190608151502.5d22d7e8@HIDDEN> <87zhmr984t.fsf@HIDDEN> In-reply-to: <87zhmr984t.fsf@HIDDEN> Date: Sat, 08 Jun 2019 22:11:08 +0200 Message-ID: <87r2836dnn.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36135 Cc: Julien Lepiller <julien@HIDDEN>, 36135 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Ludo', Ludovic Court=C3=A8s wrote: > Tobias Geerinckx-Rice <me@HIDDEN> skribis: > >> * gnu/installer/newt/wifi.scm (run-wifi-password-page): >> Add an #:INPUT-SHOW-CHECKBOX? to the input page. > > [...] > >> + #:input-show-checkbox? #t)) > > It=E2=80=99s called #:input-hide-checkbox? AFAICS. Yes. See the other patches in this ad-hoc =E2=80=98series=E2=80=99. > You can double-check that it builds without warnings with: > > guix system vm -v2 gnu/system/install.scm Sure, I guess, but could you explain the point of doing so?=20 Reproducibility by others? I don't think patches like these=20 should be pushed with such light testing, and I don't see how this=20 can be tested in a VM. Hence the dusty Dell Latitude mentioned earlier ;-) It smells funny. > Please add a =E2=80=9CPartly fixes =E2=80=A6=E2=80=9D line. This fixes b= oth the=20 > password length > and the password visibility issues since =E2=80=98run-input-page=E2=80=99= will=20 > now use > FLAG-SCROLL. Yah, I didn't merge the bugs for that reason, and because I'm=20 still trying to fix more bugs (well, mainly waiting for dd while=20 doing other stuff, since this can't be tested in a VM=E2=80=A6) Thanks! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXPwWXAAKCRANsP+IT1Vt eXsUAP99+t4EyPH6H4WiHpJwnTdj6eLPsFvrJedJBAthSCBbjgEA2yiMUOPt6TQ1 agEKsQ6v/ZIwCTG8WEpvBhFqQ9SA8QE= =wdD/ -----END PGP SIGNATURE----- --=-=-=--
bug-guix@HIDDEN:bug#36135; Package guix.
Full text available.Ludovic Courtès <ludo@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 36135) by debbugs.gnu.org; 8 Jun 2019 19:42:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 08 15:42:22 2019 Received: from localhost ([127.0.0.1]:53737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hZhEM-00064B-8Y for submit <at> debbugs.gnu.org; Sat, 08 Jun 2019 15:42:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1hZhEJ-00063v-FD for 36135 <at> debbugs.gnu.org; Sat, 08 Jun 2019 15:42:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>) id 1hZhED-0000su-Mx; Sat, 08 Jun 2019 15:42:13 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52448 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <ludo@HIDDEN>) id 1hZhED-00008Q-6N; Sat, 08 Jun 2019 15:42:13 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Julien Lepiller <julien@HIDDEN> Subject: Re: bug#36135: installer wifi password prompt References: <20190608151502.5d22d7e8@HIDDEN> Date: Sat, 08 Jun 2019 21:42:10 +0200 In-Reply-To: <20190608151502.5d22d7e8@HIDDEN> (Julien Lepiller's message of "Sat, 8 Jun 2019 15:15:02 +0200") Message-ID: <87zhmr984t.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36135 Cc: 36135 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hello, Julien Lepiller <julien@HIDDEN> skribis: > * The wifi screen doesn't automatically scan for wifi network, it would > be nice if it did it when you first get to that screen. > * The password prompt is not hidden, it's a simple text prompt. > * The password prompt was not large enough for my password, so I was > unable to connect. I had to use connmanctl from another tty to > connect. > * Even if already connected (outside of the installer), we still have to > choose a network. The connected network is marked with a '*' so the > code should be able to access that information, I think. Tobias Geerinckx-Rice <me@HIDDEN> skribis: > * gnu/installer/newt/wifi.scm (run-wifi-password-page): > Add an #:INPUT-SHOW-CHECKBOX? to the input page. [...] > + #:input-show-checkbox? #t)) It=E2=80=99s called #:input-hide-checkbox? AFAICS. You can double-check that it builds without warnings with: guix system vm -v2 gnu/system/install.scm Please add a =E2=80=9CPartly fixes =E2=80=A6=E2=80=9D line. This fixes bot= h the password length and the password visibility issues since =E2=80=98run-input-page=E2=80=99 w= ill now use FLAG-SCROLL. Thanks! Ludo=E2=80=99.
bug-guix@HIDDEN:bug#36135; Package guix.
Full text available.Received: (at 36135) by debbugs.gnu.org; 8 Jun 2019 15:43:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 08 11:43:58 2019 Received: from localhost ([127.0.0.1]:53544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hZdVd-00044h-W7 for submit <at> debbugs.gnu.org; Sat, 08 Jun 2019 11:43:58 -0400 Received: from tobias.gr ([80.241.217.52]:46686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1hZdVY-00044L-VM; Sat, 08 Jun 2019 11:43:54 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id a8d4d18b; Sat, 8 Jun 2019 15:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=2018; i=me@HIDDEN; bh=9N62+RIC/ /pq7VU3NVuO7L6CxCCWn1Hu9b1Zw96+sIg=; b=Vhsz4ok6lXMOcLX4m5jO4b1XX FE5aVegb/rx6p8kxaoAe29wkG1O00EcBjX/prAMEBj6Y7h2MzpWweRGqWOhGVW1+ p5gZru14K+i64hTMwBUmStkvQ7YGY82SofMc34tlDcmdXddkyWeINBpVPlhhkpjA tjJ/DgKk3rSwjTkWAxbNjI/AOrsjFLLFmt4FS/s6ci6pRJBIOHO/oRX5Jcwnlq6f xj9KN3nxJmtYpbF9nUAzGMnfgsEbbcO1n0oor76GpkpKPwgjV9V9KvBheyfF1a5u bqjHz2k06oH6KDPslcrHACA3wUddz+6v0q1NgU0EiVe74TSPT0MMBVllCiN6A== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 18315f9c (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 8 Jun 2019 15:43:46 +0000 (UTC) From: Tobias Geerinckx-Rice <me@HIDDEN> To: 36132 <at> debbugs.gnu.org Subject: [PATCH 3/2] installer: Hide the Wi-Fi passphrase by default. Date: Sat, 8 Jun 2019 17:43:38 +0200 Message-Id: <20190608154338.8064-1-me@HIDDEN> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36135 Cc: 36135 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) * gnu/installer/newt/wifi.scm (run-wifi-password-page): Add an #:INPUT-SHOW-CHECKBOX? to the input page. --- Guix, This adds a ‘[ ] Show’ checkbox to the newt installer's Wi-Fi passphrase input field, which has also been requested at least twice now. Most recently here[0]. Kind regards, T G-R [0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36135 gnu/installer/newt/wifi.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/installer/newt/wifi.scm b/gnu/installer/newt/wifi.scm index 1cb2ef2df3..040e013293 100644 --- a/gnu/installer/newt/wifi.scm +++ b/gnu/installer/newt/wifi.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@HIDDEN> ;;; Copyright © 2019 Meiyo Peng <meiyo@HIDDEN> +;;; Copyright © 2019 Tobias Geerinckx-Rice <me@HIDDEN> ;;; ;;; This file is part of GNU Guix. ;;; @@ -88,7 +89,8 @@ nmc_wifi_strength_bars." (define (run-wifi-password-page) "Run a page prompting user for a password and return it." (run-input-page (G_ "Please enter the wifi password.") - (G_ "Password required"))) + (G_ "Password required") + #:input-show-checkbox? #t)) (define (run-wrong-password-page service-name) "Run a page to inform user of a wrong password input." -- 2.21.0
bug-guix@HIDDEN:bug#36135; Package guix.
Full text available.Received: (at submit) by debbugs.gnu.org; 8 Jun 2019 13:15:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 08 09:15:44 2019 Received: from localhost ([127.0.0.1]:53009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hZbCC-0006tH-A5 for submit <at> debbugs.gnu.org; Sat, 08 Jun 2019 09:15:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:49970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <julien@HIDDEN>) id 1hZbCA-0006t9-9U for submit <at> debbugs.gnu.org; Sat, 08 Jun 2019 09:15:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53474) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from <julien@HIDDEN>) id 1hZbC9-0005X5-Db for bug-guix@HIDDEN; Sat, 08 Jun 2019 09:15:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <julien@HIDDEN>) id 1hZbC2-0001TY-9U for bug-guix@HIDDEN; Sat, 08 Jun 2019 09:15:37 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:52442) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <julien@HIDDEN>) id 1hZbBr-0001Dc-KM for bug-guix@HIDDEN; Sat, 08 Jun 2019 09:15:27 -0400 Received: from tachikoma.lepiller.eu (89-92-10-229.hfc.dyn.abo.bbox.fr [89.92.10.229]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 7d57c749 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <bug-guix@HIDDEN>; Sat, 8 Jun 2019 13:15:17 +0000 (UTC) Date: Sat, 8 Jun 2019 15:15:02 +0200 From: Julien Lepiller <julien@HIDDEN> To: bug-guix@HIDDEN Subject: installer wifi password prompt Message-ID: <20190608151502.5d22d7e8@HIDDEN> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:5884:8208::1 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi, i just installed a new Guix System and had to use wifi for connecting to the internet. Unfortunately, I found a few bugs with the wifi screen: * The wifi screen doesn't automatically scan for wifi network, it would be nice if it did it when you first get to that screen. * The password prompt is not hidden, it's a simple text prompt. * The password prompt was not large enough for my password, so I was unable to connect. I had to use connmanctl from another tty to connect. * Even if already connected (outside of the installer), we still have to choose a network. The connected network is marked with a '*' so the code should be able to access that information, I think. Thank you!
Julien Lepiller <julien@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#36135; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.