GNU bug report logs - #36146
[PATCH 0/4] Add various Emacs packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36146 in the body.
You can then email your comments to 36146 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/4] Add various Emacs packages
Date: Sun, 09 Jun 2019 14:07:52 +0000

This patch series adds emacs-elfeed-org, emacs-restart-emacs, emacs-mixed-pitch, and emacs-solaire-mode.
-- 
Alex Griffin

Message #8 received at 36146 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 36146 <at> debbugs.gnu.org
Subject: [PATCH 1/4] gnu: Add emacs-elfeed-org.
Date: Sun, 09 Jun 2019 14:09:49 +0000

[Message part 1 (text/plain, inline)]

This patch adds emacs-elfeed-org, an Emacs package that lets you manage your Elfeed subscriptions in Org-mode.
-- 
Alex Griffin

[0001-gnu-Add-emacs-elfeed-org.patch (text/x-patch, attachment)]

Message #11 received at 36146 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 36146 <at> debbugs.gnu.org
Subject: [PATCH 2/4] gnu: Add emacs-restart-emacs.
Date: Sun, 09 Jun 2019 14:10:56 +0000

[Message part 1 (text/plain, inline)]

This patch adds emacs-restart-emacs, an Emacs package that provides a command to restart Emacs.
-- 
Alex Griffin

[0002-gnu-Add-emacs-restart-emacs.patch (text/x-patch, attachment)]

Message #14 received at 36146 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 36146 <at> debbugs.gnu.org
Subject: [PATCH 3/4] gnu: Add emacs-mixed-pitch.
Date: Sun, 09 Jun 2019 14:12:19 +0000

[Message part 1 (text/plain, inline)]

This patch adds emacs-mixed-pitch, an Emacs package that enables mixing variable- and fixed-pitch fonts in the same buffer.
-- 
Alex Griffin

[0003-gnu-Add-emacs-mixed-pitch.patch (text/x-patch, attachment)]

Message #17 received at 36146 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 36146 <at> debbugs.gnu.org
Subject: [PATCH 4/4] gnu: Add emacs-solaire-mode.
Date: Sun, 09 Jun 2019 14:13:27 +0000

[Message part 1 (text/plain, inline)]

This patch adds emacs-solaire-mode, an Emacs package that gives a different background color to file-visiting buffers.
-- 
Alex Griffin

[0004-gnu-Add-emacs-solaire-mode.patch (text/x-patch, attachment)]

Message #20 received at 36146 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 36146 <at> debbugs.gnu.org
Subject: Re: [bug#36146] [PATCH 0/4] Add various Emacs packages
Date: Tue, 11 Jun 2019 00:02:41 +0300

[Message part 1 (text/plain, inline)]

Hello Alex,

Thank you for this patch series.

"Alex Griffin" <a <at> ajgrf.com> writes:

> This patch series adds emacs-elfeed-org, emacs-restart-emacs,
> emacs-mixed-pitch, and emacs-solaire-mode.

melpa.org URLs are not stable: files get modified in place.  For that
reason, we usually refer directly to upstream VCS repositories.  Could
you modify the patch accordingly?

Also running tests for ‘emacs-elfeed-org’ would be a great improvement.

‘emacs-mixed-pitch’ probably has a typo in synopsis - “Mix variable-”.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 36146 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: "Oleg Pykhalov" <go.wigust <at> gmail.com>
Cc: 36146 <at> debbugs.gnu.org
Subject: Re: [bug#36146] [PATCH 0/4] Add various Emacs packages
Date: Mon, 10 Jun 2019 23:58:54 +0000

On Mon, Jun 10, 2019, at 9:03 PM, Oleg Pykhalov wrote:
> melpa.org URLs are not stable: files get modified in place.  For that
> reason, we usually refer directly to upstream VCS repositories.  Could
> you modify the patch accordingly?

I didn't know that, I'll get right on it.

> Also running tests for ‘emacs-elfeed-org’ would be a great improvement.

Elfeed-org uses Cask for testing, just like a great many other Emacs packages. As far as I can tell, though, it hasn't been packaged for Guix yet.

> ‘emacs-mixed-pitch’ probably has a typo in synopsis - “Mix variable-”.

No typo. A phrase like "variable- and mixed-pitch" is correct and commonly understood to be short for "variable-pitch and mixed-pitch".

-- 
Alex Griffin

Message #26 received at 36146 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: "Oleg Pykhalov" <go.wigust <at> gmail.com>
Cc: 36146 <at> debbugs.gnu.org
Subject: Re: [bug#36146] [PATCH 0/4] Add various Emacs packages
Date: Tue, 11 Jun 2019 00:31:24 +0000

[Message part 1 (text/plain, inline)]

I've attached an updated patch series that uses git references instead of melpa urls.
-- 
Alex Griffin

[0001-gnu-Add-emacs-elfeed-org.patch (text/x-patch, attachment)]

[0002-gnu-Add-emacs-restart-emacs.patch (text/x-patch, attachment)]

[0003-gnu-Add-emacs-mixed-pitch.patch (text/x-patch, attachment)]

[0004-gnu-Add-emacs-solaire-mode.patch (text/x-patch, attachment)]

Message #31 received at 36146-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 36146-done <at> debbugs.gnu.org
Subject: Re: [bug#36146] [PATCH 0/4] Add various Emacs packages
Date: Thu, 13 Jun 2019 23:43:41 +0300

[Message part 1 (text/plain, inline)]

"Alex Griffin" <a <at> ajgrf.com> writes:

> I've attached an updated patch series that uses git references instead
> of melpa urls.

Thank you.

>> Also running tests for ‘emacs-elfeed-org’ would be a great improvement.
> 
> Elfeed-org uses Cask for testing, just like a great many other Emacs
> packages. As far as I can tell, though, it hasn't been packaged for
> Guix yet.

Cask is used only for installation of different Emacs versions. I added
a required ‘xtest’ package and found in ‘Makefile’ that tests suite
could be run by calling ‘ert-runner’ with “-L org-mode/lisp” arguments.

Also changed version to 0.1 because no upstream doesn't have a release.

Pushed all patches to master.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.