GNU bug report logs - #36186
26.2.90; texinfmt: @uref{can't use @@ in its operand}

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36186 in the body.
You can then email your comments to 36186 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.2.90; texinfmt: @uref{can't use @@ in its operand}
Date: Thu, 13 Jun 2019 08:17:38 +0900

[Message part 1 (text/plain, inline)]

Hi,

Here are two recipes:

(with-temp-buffer
  (insert "@setfilename test.info\n"
	  "@uref{https://www.example.com/, @@home page}\n")
  (texinfo-format-buffer))

(with-temp-buffer
  (insert "@setfilename test.info\n"
	  "@uref{mailto:foo@@example.com}")
  (texinfo-format-buffer))

The cause of both the errors is that the `texinfo-format-uref'
function moves point to the beginning of its formatted text,
texinfmt tries to format it again, and "@" (formatted "@@") is
treated as a command.

I'm not quite sure if there are things that should be formatted
again, but if it is not, it is unnecessary to go to the beginning
(a patch below).  Otherwise, the function must not format "@@" to
"@".

Thanks.
Regards,

[Message part 2 (text/x-patch, inline)]

--- texinfmt.el~	2019-04-05 04:42:06.053686300 +0000
+++ texinfmt.el	2019-06-12 23:13:53.063255400 +0000
@@ -1294,4 +1294,3 @@
         (insert  (nth 1 args) " (" (nth 0 args) ")")
-      (insert "`" (nth 0 args) "'"))
-    (goto-char texinfo-command-start)))
+      (insert "`" (nth 0 args) "'"))))
 

Message #8 received at 36186 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 36186 <at> debbugs.gnu.org
Subject: Re: bug#36186: 26.2.90; texinfmt: @uref{can't use @@ in its operand}
Date: Tue, 09 Jul 2019 04:03:05 +0200

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> (with-temp-buffer
>   (insert "@setfilename test.info\n"
> 	  "@uref{mailto:foo@@example.com}")
>   (texinfo-format-buffer))
>
> The cause of both the errors is that the `texinfo-format-uref'
> function moves point to the beginning of its formatted text,
> texinfmt tries to format it again, and "@" (formatted "@@") is
> treated as a command.

Makes sense.  I've now applied your patch to the trunk and checked that
the .info files are generated without any warnings.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.