GNU bug report logs - #36212
[PATCH] make undo less enthusiastic

Previous Next

Package: emacs;

Reported by: Alex Branham <alex.branham <at> gmail.com>

Date: Fri, 14 Jun 2019 18:22:01 UTC

Severity: wishlist

Tags: patch

Done: Alex Branham <alex.branham <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36212 in the body.
You can then email your comments to 36212 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#36212; Package emacs. (Fri, 14 Jun 2019 18:22:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alex Branham <alex.branham <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 14 Jun 2019 18:22:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] make undo less enthusiastic
Date: Fri, 14 Jun 2019 13:21:11 -0500
[Message part 1 (text/plain, inline)]
This is really minor, but I find it annoying that undo is so
enthusiastic in its messaging. This patch removes the exclamation mark,
which makes undo's messaging more similar to other functions messaging
(e.g. C-g, C-SPC, etc).

Alex

[0001-lisp-simple.el-undo-Make-message-less-enthusiastic.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36212; Package emacs. (Sat, 15 Jun 2019 09:48:02 GMT) Full text and rfc822 format available.

Message #8 received at 36212 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: 36212 <at> debbugs.gnu.org, alex.branham <at> gmail.com
Subject: Re: [PATCH] make undo less enthusiastic
Date: Sat, 15 Jun 2019 11:47:43 +0200
To show my support and appreciation for your attention to detail, please let me propose that the exclamation point be replaced by a full stop.





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#36212; Package emacs. (Fri, 21 Jun 2019 08:55:01 GMT) Full text and rfc822 format available.

Message #11 received at 36212 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 36212 <at> debbugs.gnu.org,
 Mattias Engdegård <mattiase <at> acm.org>
Subject: Re: bug#36212: [PATCH] make undo less enthusiastic
Date: Fri, 21 Jun 2019 04:54:24 -0400
severity 36212 wishlist
quit

Alex Branham <alex.branham <at> gmail.com> writes:

> This is really minor, but I find it annoying that undo is so
> enthusiastic in its messaging. This patch removes the exclamation mark,
> which makes undo's messaging more similar to other functions messaging
> (e.g. C-g, C-SPC, etc).

Mattias Engdegård <mattiase <at> acm.org> writes:

> To show my support and appreciation for your attention to detail,
> please let me propose that the exclamation point be replaced by a full
> stop.

Alex is right that no punctuation at all is more consistent with
existing messages though.  How about we just go with that for now, and
put off the bike-shedding over punctuation policy for another time.




Severity set to 'wishlist' from 'normal' Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 21 Jun 2019 08:55:02 GMT) Full text and rfc822 format available.

Reply sent to Alex Branham <alex.branham <at> gmail.com>:
You have taken responsibility. (Fri, 28 Jun 2019 00:59:02 GMT) Full text and rfc822 format available.

Notification sent to Alex Branham <alex.branham <at> gmail.com>:
bug acknowledged by developer. (Fri, 28 Jun 2019 00:59:02 GMT) Full text and rfc822 format available.

Message #18 received at 36212-done <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Mattias Engdegård <mattiase <at> acm.org>,
 36212-done <at> debbugs.gnu.org
Subject: Re: bug#36212: [PATCH] make undo less enthusiastic
Date: Thu, 27 Jun 2019 19:58:43 -0500
On Fri 21 Jun 2019 at 03:54, Noam Postavsky <npostavs <at> gmail.com> wrote:

> Alex is right that no punctuation at all is more consistent with
> existing messages though.  How about we just go with that for now, and
> put off the bike-shedding over punctuation policy for another time.

Since no one seemed to hate this, I applied the patch as
cb182ce6f8d2fa6e1509252fecc2b0e504e36d63 on the master branch (Emacs
27.1).

Alex




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 26 Jul 2019 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 247 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.