GNU bug report logs - #36213
[PATCH 0/4] Add pulseaudio-dlna

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36213 in the body.
You can then email your comments to 36213 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/4] Add pulseaudio-dlna
Date: Fri, 14 Jun 2019 19:21:17 +0000

This patch series adds pulseaudio-dlna, which lets you stream audio to Chromecast and DLNA devices (like Sonos speakers).

-- 
Alex Griffin

Message #8 received at 36213 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 36213 <at> debbugs.gnu.org
Subject: [PATCH 1/4] gnu: Add python-notify2, python2-notify2.
Date: Fri, 14 Jun 2019 19:22:59 +0000

[Message part 1 (text/plain, inline)]

attached

-- 
Alex Griffin

[0001-gnu-Add-python-notify2-python2-notify2.patch (text/x-patch, attachment)]

Message #11 received at 36213 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 36213 <at> debbugs.gnu.org
Subject: [PATCH 2/4] gnu: Add python-pyroute2, python2-pyroute2.
Date: Fri, 14 Jun 2019 19:23:29 +0000

[Message part 1 (text/plain, inline)]

attached

-- 
Alex Griffin

[0002-gnu-Add-python-pyroute2-python2-pyroute2.patch (text/x-patch, attachment)]

Message #14 received at 36213 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 36213 <at> debbugs.gnu.org
Subject: [PATCH 3/4] gnu: Add python2-zeroconf.
Date: Fri, 14 Jun 2019 19:27:15 +0000

[Message part 1 (text/plain, inline)]

This patch packages the last version of the zeroconf package to support python 2. That's also why I didn't package it for python 3, because it would be a substantially different package.

-- 
Alex Griffin

[0003-gnu-Add-python2-zeroconf.patch (text/x-patch, attachment)]

Message #17 received at 36213 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 36213 <at> debbugs.gnu.org
Subject: [PATCH 4/4] gnu: Add pulseaudio-dlna.
Date: Fri, 14 Jun 2019 19:28:16 +0000

[Message part 1 (text/plain, inline)]

This patch adds pulseaudio-dlna, which lets you stream audio to Chromecast and DLNA devices (like Sonos speakers).

-- 
Alex Griffin

[0004-gnu-Add-pulseaudio-dlna.patch (text/x-patch, attachment)]

Message #20 received at 36213 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 36213 <at> debbugs.gnu.org
Subject: Re: [bug#36213] [PATCH 4/4] gnu: Add pulseaudio-dlna.
Date: Tue, 02 Jul 2019 17:54:37 +0200

Hi Alex,

Overall this patch set LGTM.  I have two questions:

"Alex Griffin" <a <at> ajgrf.com> skribis:

> +(define-public pulseaudio-dlna
> +  (let ((commit "4472928dd23f274193f14289f59daec411023ab0")
> +        (revision "1"))

Could you explain why you chose this commit rather than the latest
release?

> +      (arguments `(#:python ,python-2))

Can it run on Python 3?

Since Python 2 is approaching EOL, we’re trying to avoid adding more
Python 2 packages.  If we could remove ‘python2-’ packages from this
patch series, that’d be great; if not, so be it!

Thanks,
Ludo’.

Message #23 received at 36213 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36213 <at> debbugs.gnu.org
Subject: Re: [bug#36213] [PATCH 4/4] gnu: Add pulseaudio-dlna.
Date: Tue, 02 Jul 2019 16:01:27 +0000

Hi Ludo,

On Tue, Jul 2, 2019, at 3:54 PM, Ludovic Courtès wrote:
> > +(define-public pulseaudio-dlna
> > +  (let ((commit "4472928dd23f274193f14289f59daec411023ab0")
> > +        (revision "1"))
> 
> Could you explain why you chose this commit rather than the latest
> release?

Honestly, I just noticed that Debian was building from git. I assumed they had a good reason, so I didn't even try the latest release from 2016.

> > +      (arguments `(#:python ,python-2))
> 
> Can it run on Python 3?
> 
> Since Python 2 is approaching EOL, we’re trying to avoid adding more
> Python 2 packages.  If we could remove ‘python2-’ packages from this
> patch series, that’d be great; if not, so be it!

No, it doesn't run on Python 3. It's actually unmaintained right now, but I'm not aware of any other free software projects that provide the same functionality.

-- 
Alex Griffin

Message #28 received at 36213-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 36213-done <at> debbugs.gnu.org
Subject: Re: [bug#36213] [PATCH 4/4] gnu: Add pulseaudio-dlna.
Date: Thu, 04 Jul 2019 18:07:05 +0200

Hi,

"Alex Griffin" <a <at> ajgrf.com> skribis:

> On Tue, Jul 2, 2019, at 3:54 PM, Ludovic Courtès wrote:
>> > +(define-public pulseaudio-dlna
>> > +  (let ((commit "4472928dd23f274193f14289f59daec411023ab0")
>> > +        (revision "1"))
>> 
>> Could you explain why you chose this commit rather than the latest
>> release?
>
> Honestly, I just noticed that Debian was building from git. I assumed they had a good reason, so I didn't even try the latest release from 2016.

OK.  There have been quite a few commits since that 2016 release, so it
probably makes sense to use the latest one.

>> > +      (arguments `(#:python ,python-2))
>> 
>> Can it run on Python 3?
>> 
>> Since Python 2 is approaching EOL, we’re trying to avoid adding more
>> Python 2 packages.  If we could remove ‘python2-’ packages from this
>> patch series, that’d be great; if not, so be it!
>
> No, it doesn't run on Python 3. It's actually unmaintained right now, but I'm not aware of any other free software projects that provide the same functionality.

OK.

I took the liberty to add some of what you wrote as comments in the
code and pushed the whole series.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.