GNU bug report logs - #36230
[PATCH] Add emacs-multi-term

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36230 in the body.
You can then email your comments to 36230 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Add emacs-multi-term
Date: Sat, 15 Jun 2019 20:34:30 +0000

[Message part 1 (text/plain, inline)]

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-multi-term.patch (text/x-patch, attachment)]

Message #8 received at 36230 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
Cc: 36230 <at> debbugs.gnu.org
Subject: Re: [bug#36230] [PATCH] Add emacs-multi-term
Date: Tue, 18 Jun 2019 16:59:16 +0200

Hello,

Baptiste Strazzulla <bstrazzull <at> hotmail.fr> skribis:

> From 3118853b54988c68828c5e7e266d4959151b64cf Mon Sep 17 00:00:00 2001
> From: Zzull <bstrazzull <at> hotmail.fr>
> Date: Sat, 15 Jun 2019 22:32:19 +0200
> Subject: [PATCH] gnu: Add emacs-multi-term
>
> * gnu/packages/emacs-xyz.scm (emacs-multi-term): New variable

[...]

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; FIXME: `patch-el-files' crashes with the following error:
> +         ;; unable to locate "zsh".

Then I think you should add zsh as an input, such that ‘patch-el-files’
can modify the .el file to refer to zsh by its absolute file name.

> +    (description
> +     "By default, term.el provides a great terminal emulator in Emacs.  But it
> +lacks the following:

Could you replace this description by one that says what
emacs-multi-term is/does, rather than what term.el doesn’t do well?  :-)

See
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.

Thank you!

Ludo’.

Message #11 received at 36230 <at> debbugs.gnu.org (full text, mbox):

From: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
To: "36230 <at> debbugs.gnu.org" <36230 <at> debbugs.gnu.org>
Subject: Fw: [bug#36230] [PATCH] Add emacs-multi-term
Date: Sun, 23 Jun 2019 18:35:10 +0000

[Message part 1 (text/plain, inline)]

Second attempt. I hope everything is at it's right place this time.

Regards


________________________________________
From: Ludovic Courtès <ludo <at> gnu.org>
Sent: Tuesday, June 18, 2019 2:59 PM
To: Baptiste Strazzulla
Cc: 36230 <at> debbugs.gnu.org
Subject: Re: [bug#36230] [PATCH] Add emacs-multi-term

Hello,

Baptiste Strazzulla <bstrazzull <at> hotmail.fr> skribis:

> From 3118853b54988c68828c5e7e266d4959151b64cf Mon Sep 17 00:00:00 2001
> From: Zzull <bstrazzull <at> hotmail.fr>
> Date: Sat, 15 Jun 2019 22:32:19 +0200
> Subject: [PATCH] gnu: Add emacs-multi-term
>
> * gnu/packages/emacs-xyz.scm (emacs-multi-term): New variable

[...]

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; FIXME: `patch-el-files' crashes with the following error:
> +         ;; unable to locate "zsh".

Then I think you should add zsh as an input, such that ‘patch-el-files’
can modify the .el file to refer to zsh by its absolute file name.

> +    (description
> +     "By default, term.el provides a great terminal emulator in Emacs.  But it
> +lacks the following:

Could you replace this description by one that says what
emacs-multi-term is/does, rather than what term.el doesn’t do well?  :-)

See
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.

Thank you!

Ludo’.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-multi-term.patch (text/x-patch, attachment)]

Message #14 received at 36230 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
Cc: "36230 <at> debbugs.gnu.org" <36230 <at> debbugs.gnu.org>
Subject: Re: [bug#36230] Fw: [bug#36230] [PATCH] Add emacs-multi-term
Date: Mon, 24 Jun 2019 17:49:30 +0200

[Message part 1 (text/plain, inline)]

Hello,

Baptiste Strazzulla <bstrazzull <at> hotmail.fr> skribis:

> Second attempt. I hope everything is at it's right place this time.

I made the changes below to address issues that ‘guix lint’ reported.

However, we’re out of luck because
<https://github.com/emacsorphanage/multi-term> is now 404.  Do you know
what the new URL is?

Thanks in advance,
Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ecd9518646..ca3d64bd43 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -16096,19 +16096,19 @@ acting like notes that are made @emph{in} the document.")
                (base32
                 "1bn6zx931vz2fa72ab999r33bxv8brn3cqmalvq25x7s4z3q1lyi"))))
     (build-system emacs-build-system)
-    (propagated-inputs `(("zsh" ,zsh)))
+    (inputs `(("zsh" ,zsh)))
     (home-page "https://github.com/emacsorphanage/multi-term")
     (synopsis "Manage multiple terminal buffers in Emacs")
     (description
-     "This package enhances @{term.el} with the following features:
+     "This package enhances @code{term.el} with the following features:
 
 @enumerate
 @item Functions to switch between multiple terminal buffers
-@item List of keys to be intercepted by @{emacs-multi-term} instead of by the
+@item List of keys to be intercepted by @code{emacs-multi-term} instead of by the
 underlying terminal
 @item Kills the unused buffer left after exiting the terminal
 @item Kills the running sub-processes along with the terminal when killing the
 it forcibly
-@item Dedicated window for debugging program
+@item Dedicated window for debugging program.
 @end enumerate")
     (license license:gpl3+)))

Message #17 received at 36230 <at> debbugs.gnu.org (full text, mbox):

From: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
To: "36230 <at> debbugs.gnu.org" <36230 <at> debbugs.gnu.org>
Subject: [PATCH] Add emacs-multi-term
Date: Tue, 25 Jun 2019 08:53:36 +0000

[Message part 1 (text/plain, inline)]

It's actually a good news because it seems that its original author adopted it again: https://github.com/manateelazycat/multi-term

He didn't make a release yet though. I'll update the guix definition later in the week. Sorry for the missed lint

[Message part 2 (text/html, inline)]

Message #20 received at 36230 <at> debbugs.gnu.org (full text, mbox):

From: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
To: "36230 <at> debbugs.gnu.org" <36230 <at> debbugs.gnu.org>
Subject: [PATCH] Add emacs-multi-term
Date: Sun, 30 Jun 2019 11:38:34 +0000

[Message part 1 (text/plain, inline)]

And here is the third attempt. I changed the URL of the repository and pinned the only existing commit there.

On the side, I `./pre-inst-env guix lint emacs-multi-term` the previous patch that you had to correct because I remembered doing it before posting and as it turned out, nothing came out. There doesn't seem to be any additional options I should give to `guix lint` so I don't understand exactly why you had a more rigorous linting than mine. Do you have an idea?

Regards

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-multi-term.patch (text/x-patch, attachment)]

Message #25 received at 36230-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
Cc: "36230 <at> debbugs.gnu.org" <36230-done <at> debbugs.gnu.org>
Subject: Re: [bug#36230] [PATCH] Add emacs-multi-term
Date: Tue, 02 Jul 2019 17:58:17 +0200

Hi,

Baptiste Strazzulla <bstrazzull <at> hotmail.fr> skribis:

> On the side, I `./pre-inst-env guix lint emacs-multi-term` the previous patch that you had to correct because I remembered doing it before posting and as it turned out, nothing came out. There doesn't seem to be any additional options I should give to `guix lint` so I don't understand exactly why you had a more rigorous linting than mine. Do you have an idea?

We should both get the same ‘guix lint’ output.  :-)

> From 9b8804a8fed18f77d72bb58113c823e3b29d7073 Mon Sep 17 00:00:00 2001
> From: Zzull <bstrazzull <at> hotmail.fr>
> Date: Sat, 15 Jun 2019 22:32:19 +0200
> Subject: [PATCH] gnu: Add emacs-multi-term
>
> * gnu/packages/emacs-xyz.scm (emacs-multi-term): New variable

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.