GNU bug report logs - #36235
26.1; reftex-toc-rename-label prompt incorrect

Previous Next

Package: auctex;

Reported by: Ryan Kavanagh <rak <at> debian.org>

Date: Sat, 15 Jun 2019 22:28:02 UTC

Severity: normal

Tags: patch

Found in version 26.1

Done: Arash Esbati <arash <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36235 in the body.
You can then email your comments to 36235 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-auctex <at> gnu.org:
bug#36235; Package auctex. (Sat, 15 Jun 2019 22:28:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ryan Kavanagh <rak <at> debian.org>:
New bug report received and forwarded. Copy sent to bug-auctex <at> gnu.org. (Sat, 15 Jun 2019 22:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Kavanagh <rak <at> debian.org>
To: submit <at> debbugs.gnu.org
Subject: 26.1; reftex-toc-rename-label prompt incorrect
Date: Sat, 15 Jun 2019 18:26:59 -0400
[Message part 1 (text/plain, inline)]
Package: auctex
Tags: patch

The reftex-toc-rename-label function is used to rename labels from the
TOC buffer. When the proposed new label already exists, the function
warns the user of this fact and asks the user to confirm their intent.

Unfortunately, it uses the wrong label name in the prompt: it warns the
user that the old label already exists instead of warning the user that
their proposed label already exists

Please see attached for a patch fixing this issue.

Emacs  : GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version
3.24.4) of 2019-02-03, modified by Debian
Package: 26.1

current state:
==============
(setq
 window-system 'x
 reftex-plug-into-AUCTeX t
 )
-- 
|)|/  Ryan Kavanagh      | GPG: 4E46 9519 ED67 7734 268F
|\|\  https://rak.ac     |      BD95 8F7B F8FC 4A11 C97A
[reftex-toc.el.diff (text/x-diff, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-auctex <at> gnu.org:
bug#36235; Package auctex. (Mon, 11 Oct 2021 14:08:02 GMT) Full text and rfc822 format available.

Message #8 received at 36235 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Ryan Kavanagh <rak <at> debian.org>
Cc: 36235 <at> debbugs.gnu.org
Subject: Re: bug#36235: 26.1; reftex-toc-rename-label prompt incorrect
Date: Mon, 11 Oct 2021 16:01:25 +0200
Hi Ryan,

Ryan Kavanagh <rak <at> debian.org> writes:

> The reftex-toc-rename-label function is used to rename labels from the
> TOC buffer. When the proposed new label already exists, the function
> warns the user of this fact and asks the user to confirm their intent.
>
> Unfortunately, it uses the wrong label name in the prompt: it warns
> the user that the old label already exists instead of warning the user
> that their proposed label already exists
>
> Please see attached for a patch fixing this issue.

Thank you for this bug report and the suggested fix.  I submitted your
change (plus another minor issue) to Emacs repo and it will be fixed in
Emacs 28.1[1].  My apologies that this issue took so long :-(

Best, Arash

Footnotes:
[1]  http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-28&id=915e044d60dfde0953327cb9cbfe8bb0f69e5dd4




bug closed, send any further explanations to 36235 <at> debbugs.gnu.org and Ryan Kavanagh <rak <at> debian.org> Request was from Arash Esbati <arash <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 11 Oct 2021 14:08:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 09 Nov 2021 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 141 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.