GNU bug report logs - #36247
[PATCH] Handle 'code' tag in shr.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36247 in the body.
You can then email your comments to 36247 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicholas Drozd <nicholasdrozd <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Handle 'code' tag in shr.el
Date: Sun, 16 Jun 2019 10:11:37 -0500

* lisp/net/shr.el: Add 'code' tag handling.

* etc/NEWS: Announce change in shr behavior.
---
 etc/NEWS        | 2 ++
 lisp/net/shr.el | 6 +++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/etc/NEWS b/etc/NEWS
index 723f0a0fb0..5b1191467a 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -916,6 +916,8 @@ This attribute is meant to tell screen readers to
ignore a tag.
 ---
 *** 'shr-tag-ol' now respects the ordered list 'start' attribute.

+*** 'code' tag is now handled.
+
 ** Htmlfontify

 *** The functions 'hfy-color', 'hfy-color-vals' and
diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index a014c56948..7fdb3212d4 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1401,10 +1401,14 @@ shr-tag-strong
 (defun shr-tag-u (dom)
   (shr-fontize-dom dom 'underline))

-(defun shr-tag-tt (dom)
+(defun shr-tag-code (dom)
   (let ((shr-current-font 'default))
     (shr-generic dom)))

+(defun shr-tag-tt (dom)
+  ;; The `tt' tag is deprecated in favor of `code'.
+  (shr-tag-code dom))
+
 (defun shr-tag-ins (cont)
   (let* ((start (point))
          (color "green")

Message #8 received at 36247 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Nicholas Drozd <nicholasdrozd <at> gmail.com>
Cc: 36247 <at> debbugs.gnu.org
Subject: Re: bug#36247: [PATCH] Handle 'code' tag in shr.el
Date: Sat, 22 Jun 2019 13:47:17 +0200

Nicholas Drozd <nicholasdrozd <at> gmail.com> writes:

> * lisp/net/shr.el: Add 'code' tag handling.
>
> * etc/NEWS: Announce change in shr behavior.

Looks good, but the patch has been mangled by Gmail and doesn't apply.
Can you resend with the patch in an attachment?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 36247 <at> debbugs.gnu.org (full text, mbox):

From: Nicholas Drozd <nicholasdrozd <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 36247 <at> debbugs.gnu.org
Subject: Re: bug#36247: [PATCH] Handle 'code' tag in shr.el
Date: Sat, 22 Jun 2019 12:06:24 -0500

[Message part 1 (text/plain, inline)]

Btw Lars, Eww is one of the "but can your editor do this" features I
use to show off Emacs to non-users.

On Sat, Jun 22, 2019 at 6:47 AM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
>
> Nicholas Drozd <nicholasdrozd <at> gmail.com> writes:
>
> > * lisp/net/shr.el: Add 'code' tag handling.
> >
> > * etc/NEWS: Announce change in shr behavior.
>
> Looks good, but the patch has been mangled by Gmail and doesn't apply.
> Can you resend with the patch in an attachment?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

[0001-Handle-code-tag-in-shr.el.patch (text/x-patch, attachment)]

Message #14 received at 36247 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Nicholas Drozd <nicholasdrozd <at> gmail.com>
Cc: 36247 <at> debbugs.gnu.org
Subject: Re: bug#36247: [PATCH] Handle 'code' tag in shr.el
Date: Sun, 23 Jun 2019 14:20:03 +0200

Nicholas Drozd <nicholasdrozd <at> gmail.com> writes:

> Btw Lars, Eww is one of the "but can your editor do this" features I
> use to show off Emacs to non-users.

:-)

Thanks for the patch; now applied to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.