GNU bug report logs - #36326
[PATCH] Add Haskell packages.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36326 in the body.
You can then email your comments to 36326 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add Haskell packages.
Date: Fri, 21 Jun 2019 20:51:51 +0200

[Message part 1 (text/plain, inline)]

See attached.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ghc-validity.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-path-io.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-path.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-genvalidity-property.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-genvalidity.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-descriptive.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-exactprint.patch (text/x-patch, attachment)]

Message #8 received at 36326 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: 36326 <at> debbugs.gnu.org
Subject: [PATCH] Add Haskell packages.
Date: Sun, 23 Jun 2019 00:49:20 +0200

[Message part 1 (text/plain, inline)]

Hi,

OK, I've linted and added another package. Please ignore my last email.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ghc-validity.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-path-io.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-path.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-genvalidity-property.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-genvalidity.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-descriptive.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-exactprint.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-hindent.patch (text/x-patch, attachment)]

Message #11 received at 36326 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: 36326 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add Haskell packages.
Date: Wed, 26 Jun 2019 18:09:05 +0200

[Message part 1 (text/plain, inline)]

Sorry, I didn't see the entirety of the lint result when I last wrote. I've
fixed everything up. The linter should choke on ghc-hindent, which is fine
since it's an upstream problem with the latest release (the .cabal file has
improper indentation).

On Sun, Jun 23, 2019 at 12:49 AM Brian Leung <bkleung89 <at> gmail.com> wrote:

> Hi,
>
> OK, I've linted and added another package. Please ignore my last email.
>

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ghc-validity.patch (text/x-patch, attachment)]

[0003-gnu-Add-ghc-genvalidity-property.patch (text/x-patch, attachment)]

[0002-gnu-Add-ghc-genvalidity.patch (text/x-patch, attachment)]

[0004-gnu-Add-ghc-path.patch (text/x-patch, attachment)]

[0005-gnu-Add-ghc-path-io.patch (text/x-patch, attachment)]

[0006-gnu-Add-ghc-descriptive.patch (text/x-patch, attachment)]

[0008-gnu-Add-ghc-hindent.patch (text/x-patch, attachment)]

[0007-gnu-Add-ghc-exactprint.patch (text/x-patch, attachment)]

Message #14 received at 36326 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: 36326 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add Haskell packages.
Date: Fri, 12 Jul 2019 02:37:36 +0200

[Message part 1 (text/plain, inline)]

Friendly ping.

On Wed, Jun 26, 2019 at 6:09 PM Brian Leung <bkleung89 <at> gmail.com> wrote:

> Sorry, I didn't see the entirety of the lint result when I last wrote.
> I've fixed everything up. The linter should choke on ghc-hindent, which is
> fine since it's an upstream problem with the latest release (the .cabal
> file has improper indentation).
>
> On Sun, Jun 23, 2019 at 12:49 AM Brian Leung <bkleung89 <at> gmail.com> wrote:
>
>> Hi,
>>
>> OK, I've linted and added another package. Please ignore my last email.
>>
>

[Message part 2 (text/html, inline)]

Message #17 received at 36326 <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 36326 <at> debbugs.gnu.org
Subject: Re: [bug#36326] [PATCH] Add Haskell packages.
Date: Wed, 17 Jul 2019 10:21:50 -0400

Hi Brian,

Brian Leung <bkleung89 <at> gmail.com> writes:

> Friendly ping.

I looked over the patches and they look pretty good in general.  There’s
just one little thing, which I realize is a little annoying.  We try to
follow the Stackage LTS versions of packages where possible, as they are
chosen carefully to work together and with our version of GHC (8.4.3).
Right now, we are on Stackge LTS 12.14.  Could you please go over these
patches and downgrade them to their Stackage LTS 12.14 versions (which
can be found at <https://www.stackage.org/lts-12.14>)?  You can also
import directly from Stackage, using (for example):

    guix import stackage --lts-version=12.14 validity

That may be the fastest way to fix up the packages.  I would do this,
but you’re in a better position to judge whether the packages still do
what you intended them to do, since I imagine you have a use-case in
mind.  :)

Thanks!


-- Tim

Message #22 received at 36326-done <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 36326-done <at> debbugs.gnu.org
Subject: Re: [bug#36326] [PATCH] Add Haskell packages.
Date: Fri, 19 Jul 2019 23:16:30 -0400

Hi Brian,

Brian Leung <bkleung89 <at> gmail.com> writes:

> Hi Tim,
>
> OK, please see attached for the updated patches.

Pushed!

I had to make a few changes.  Mostly I shortened long lines, but there
were two larger changes:

  1. It looks like you forgot to downgrade “ghc-exactprint” to the LTS
     version (0.5.6.1).  Luckily, it was just a matter of changing the
     version and hash.

  2. There was something fishy about the synopsis and description of
     “ghc-microlens-ghc”.  It looks to me that they were in fact
     describing “ghc-microlens-platform”.  I ended up changing them a
     fair bit.

Thanks for the packages!


-- Tim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.