GNU bug report logs - #36327
Incompatible Redefinition of fill-paragraph

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36327 in the body.
You can then email your comments to 36327 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Keith Waclena <keith <at> lib.uchicago.edu>
To: bug-hyperbole <at> gnu.org
Subject: Incompatible Redefinition of fill-paragraph
Date: Fri, 21 Jun 2019 17:10:03 -0500

I use:  Editor:      GNU Emacs 26.2 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)

        Hyperbole:   7.0.3
        Sys Type:    x86_64-pc-linux-gnu
        OS Type:     gnu/linux
        Window Sys:  x
        News Reader: Gnus v5.13

In hyperbole's kfill.el the function fill-paragraph is redefined:

    ;;; Redefine this built-in function.

    (defun fill-paragraph (arg &optional skip-prefix-remove)

But this redefinition is incompatible with the original:

    fill-paragraph is an interactive compiled Lisp function in ‘fill.el’.

    It is bound to M-q.

    (fill-paragraph &optional JUSTIFY REGION)

This causes some of my code to blow up because I call fill-paragraph
with no arg:

    Debugger entered--Lisp error: (wrong-number-of-arguments #f(compiled-function (arg &optional skip-prefix-remove) (interactive "*P") #<bytecode 0x272a81d>) 0)
      fill-paragraph()
      boilerplate(filename)
      ...

Unfortunately this means I have to disable hyperbole... :-(


--
Keith Waclena / Arch Linux / OCaml / M-x / ATKQJ / 🚲 / 🍳 / YASD / gc'e'a' / \clef treble
http://www.lib.uchicago.edu/keith/    gpg 5DA89C7DECA0D55A
n.p.: All Night Long (South San Gabriel)

Message #8 received at 36327 <at> debbugs.gnu.org (full text, mbox):

From: Robert Weiner <rswgnu <at> gmail.com>
To: keith <at> lib.uchicago.edu
Cc: 36327 <at> debbugs.gnu.org
Subject: Re: bug#36327: Incompatible Redefinition of fill-paragraph
Date: Sat, 22 Jun 2019 08:54:48 -0400

Thanks for pointing this out.  That code had not been updated in a long time with changes in Emacs filling routines.  This is resolved for the next release of Hyperbole by making the argument optional and changing to use the fill-paragraph-function variable rather than replacing the fill-paragraph function.  We will let you know when a test release is available.

Message #11 received at 36327 <at> debbugs.gnu.org (full text, mbox):

From: Keith Waclena <keith <at> lib.uchicago.edu>
To: Robert Weiner <rswgnu <at> gmail.com>
Cc: 36327 <at> debbugs.gnu.org
Subject: Re: bug#36327: Incompatible Redefinition of fill-paragraph
Date: Sat, 22 Jun 2019 16:34:04 -0500

Robert Weiner <rswgnu <at> gmail.com> writes:

> Thanks for pointing this out.  That code had not been updated in a
> long time with changes in Emacs filling routines.  This is resolved
> for the next release of Hyperbole by making the argument optional and
> changing to use the fill-paragraph-function variable rather than
> replacing the fill-paragraph function.  We will let you know when a
> test release is available.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.