GNU bug report logs - #36406
[PATCH] gnu: Add bitcoin-abc.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36406 in the body.
You can then email your comments to 36406 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add bitcoin-abc.
Date: Thu, 27 Jun 2019 22:11:52 +0200

[Message part 1 (text/plain, inline)]

I verified with the hash found here 
https://download.bitcoinabc.org/0.19.8/linux/bitcoin-abc-0.19-linux-res.yml

I have not tested this with downloading the chain neither have I made 
any transactions.

Warning: if you start it without specifying a datadir then it defaults 
to ~/.bitcoin like bitcoin-core.

-- 
Cheers Swedebugia

[0001-gnu-Add-bitcoin-abc.patch (text/x-patch, attachment)]

Message #8 received at 36406 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: swedebugia <swedebugia <at> riseup.net>
Cc: 36406 <at> debbugs.gnu.org
Subject: Re: [bug#36406] [PATCH] gnu: Add bitcoin-abc.
Date: Wed, 03 Jul 2019 00:39:13 +0200

Hi swedebugia,

swedebugia <swedebugia <at> riseup.net> skribis:

>>From 1ce83b0ceabac0260f6a9dc43d4df1cc75236aa7 Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia <at> riseup.net>
> Date: Thu, 27 Jun 2019 22:06:33 +0200
> Subject: [PATCH] gnu: Add bitcoin-abc.
>
> * gnu/packages/finance.scm (bitcoin-abc): New variable.

[...]

> +(define-public bitcoin-abc
> +  ;; This is a fork of bitcoin-core and identical to upstream.
> +  (package
> +    (name "bitcoin-abc")

Since everything except ‘source’ is identical, I think we should write
it as:

  (package
    (inherit bitcoin-core)
    …)

> +    (synopsis "Bitcoin ABC peer-to-peer full node for the Bitcoin Cash protocol")
> +    (description
> +     "Bitcoin Cash is a digital currency that enables instant payments to anyone
> +anywhere in the world.  It uses peer-to-peer technology to operate without
> +central authority: managing transactions and issuing money are carried out
> +collectively by the network.  Bitcoin ABC is the reference implementation
> +of the Bitcoin Cash protocol.  This package provides the Bitcoin Cash command
> +line client and a client based on Qt. This is a fork of bitcoin-core.")

Could you make the description a bit more specific to Bitcoin ABC?
Otherwise it’s hard to tell how it differs from bitcoin-core.

Thanks in advance!

Ludo’.

Message #13 received at 36406 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36406 <at> debbugs.gnu.org
Subject: Re: [bug#36406] [PATCHv2] gnu: Add bitcoin-abc.
Date: Thu, 1 Aug 2019 22:43:58 +0200

[Message part 1 (text/plain, inline)]

On 2019-07-03 00:39, Ludovic Courtès wrote:
> Hi swedebugia,
>
> swedebugia <swedebugia <at> riseup.net> skribis:
>
>> >From 1ce83b0ceabac0260f6a9dc43d4df1cc75236aa7 Mon Sep 17 00:00:00 2001
>> From: swedebugia <swedebugia <at> riseup.net>
>> Date: Thu, 27 Jun 2019 22:06:33 +0200
>> Subject: [PATCH] gnu: Add bitcoin-abc.
>>
>> * gnu/packages/finance.scm (bitcoin-abc): New variable.
> [...]
>
>> +(define-public bitcoin-abc
>> +  ;; This is a fork of bitcoin-core and identical to upstream.
>> +  (package
>> +    (name "bitcoin-abc")
> Since everything except ‘source’ is identical, I think we should write
> it as:
>
>    (package
>      (inherit bitcoin-core)
>      …)
>
>> +    (synopsis "Bitcoin ABC peer-to-peer full node for the Bitcoin Cash protocol")
>> +    (description
>> +     "Bitcoin Cash is a digital currency that enables instant payments to anyone
>> +anywhere in the world.  It uses peer-to-peer technology to operate without
>> +central authority: managing transactions and issuing money are carried out
>> +collectively by the network.  Bitcoin ABC is the reference implementation
>> +of the Bitcoin Cash protocol.  This package provides the Bitcoin Cash command
>> +line client and a client based on Qt. This is a fork of bitcoin-core.")
> Could you make the description a bit more specific to Bitcoin ABC?
> Otherwise it’s hard to tell how it differs from bitcoin-core.

Ok, updated patch attached.

-- 
Cheers Swedebugia

[0001-gnu-Add-bitcoin-abc.patch (text/x-patch, attachment)]

Message #18 received at 36406-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: swedebugia <swedebugia <at> riseup.net>
Cc: 36406-done <at> debbugs.gnu.org
Subject: Re: [bug#36406] [PATCHv2] gnu: Add bitcoin-abc.
Date: Thu, 22 Aug 2019 17:41:33 +0200

[Message part 1 (text/plain, inline)]

Hi!

swedebugia <swedebugia <at> riseup.net> skribis:

> From 5ecc8f90ed89f41ca1e4e1fa5372cf6da114adaf Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia <at> riseup.net>
> Date: Thu, 1 Aug 2019 22:31:42 +0200
> Subject: [PATCH] gnu: Add bitcoin-abc.
>
> * gnu/packages/finance.scm (bitcoin-abc): New variable.

I addressed two tiny issues reported by ‘guix lint’ (see below) and
applied.

Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 1ea583abe3..377cb3a405 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1118,14 +1118,14 @@ Trezor wallet.")
     (name "bitcoin-abc")
     (version "0.19.8")
     (source (origin
-             (method url-fetch)
-             (uri
-              (string-append "https://download.bitcoinabc.org/" version "/linux/src/bitcoin-abc-"
-                              version ".tar.gz"))
-             (sha256
-              (base32
-               "0ndvkxv5m8346bdhfqzgdiz1k9wyjycj05jp7daf9pml3cw79sz5"))))
-    (home-page "https://bitcoinabc.org/")
+              (method url-fetch)
+              (uri (string-append "https://download.bitcoinabc.org/"
+                                  version "/linux/src/bitcoin-abc-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "0ndvkxv5m8346bdhfqzgdiz1k9wyjycj05jp7daf9pml3cw79sz5"))))
+    (home-page "https://www.bitcoinabc.org/")
     (synopsis "Bitcoin ABC peer-to-peer full node for the Bitcoin Cash protocol")
     (description
      "Bitcoin Cash brings sound money to the world, fulfilling the original

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.