GNU bug report logs - #36409
[PATCH] gnu: Add beets-bandcamp.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36409 in the body.
You can then email your comments to 36409 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add beets-bandcamp.
Date: Thu, 27 Jun 2019 20:41:05 -0400

[Message part 1 (text/plain, inline)]

* gnu/packages/music.scm (beets-bandcamp): New variable.
---
 gnu/packages/music.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index ca9cbd3343..fd8898a706 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -21,6 +21,7 @@
 ;;; Copyright © 2018 Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
 ;;; Copyright © 2019 Gabriel Hondet <gabrielhondet <at> gmail.com>
 ;;; Copyright © 2019 Timotej Lazar <timotej.lazar <at> araneo.si>
+;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -129,6 +130,7 @@
   #:use-module (gnu packages tcl)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages tex)
+  #:use-module (gnu packages time)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages video)
@@ -2816,6 +2818,32 @@ metadata as it goes using the MusicBrainz database.  Then it provides a variety
 of tools for manipulating and accessing your music.")
     (license license:expat)))
 
+(define-public beets-bandcamp
+  (package
+    (name "beets-bandcamp")
+    (version "0.1.3")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "beets-bandcamp" version))
+              (sha256
+               (base32
+                "04awg0zdhhg5h510fc1p3qkvr2l1qm6nf85hlr9z8im8a7xlka0i"))))
+    (build-system python-build-system)
+    (arguments '(#:tests? #f)) ; there are no tests
+    (propagated-inputs
+     `(("beets" ,beets)
+       ("python-isodate" ,python-isodate)))
+    (inputs
+     `(("python-six" ,python-six)
+       ("python-requests" ,python-requests)
+       ("python-beautifulsoup4" ,python-beautifulsoup4)))
+    (home-page "https://github.com/unrblt/beets-bandcamp")
+    (synopsis "Bandcamp plugin for beets")
+    (description "Plugin for beets to automatically obtain tag data from
+https://bandcamp.com/.  The plugin is also capable of getting lyrics for songs
+and album art using the beets FetchArt plugin.")
+    (license license:gpl2)))
+
 (define-public milkytracker
   (package
     (name "milkytracker")
-- 
2.22.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: Re: [bug#36409] [PATCH] gnu: Add beets-bandcamp.
Date: Fri, 28 Jun 2019 07:00:47 +0200

On 2019-06-28 02:41, Jakob L. Kreuze wrote:
> * gnu/packages/music.scm (beets-bandcamp): New variable.
> ---
>   gnu/packages/music.scm | 28 ++++++++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index ca9cbd3343..fd8898a706 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -21,6 +21,7 @@
>   ;;; Copyright © 2018 Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
>   ;;; Copyright © 2019 Gabriel Hondet <gabrielhondet <at> gmail.com>
>   ;;; Copyright © 2019 Timotej Lazar <timotej.lazar <at> araneo.si>
> +;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
>   ;;;
>   ;;; This file is part of GNU Guix.
>   ;;;
> @@ -129,6 +130,7 @@
>     #:use-module (gnu packages tcl)
>     #:use-module (gnu packages texinfo)
>     #:use-module (gnu packages tex)
> +  #:use-module (gnu packages time)
>     #:use-module (gnu packages tls)
>     #:use-module (gnu packages version-control)
>     #:use-module (gnu packages video)
> @@ -2816,6 +2818,32 @@ metadata as it goes using the MusicBrainz database.  Then it provides a variety
>   of tools for manipulating and accessing your music.")
>       (license license:expat)))
>   
> +(define-public beets-bandcamp
> +  (package
> +    (name "beets-bandcamp")
> +    (version "0.1.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "beets-bandcamp" version))
> +              (sha256
> +               (base32
> +                "04awg0zdhhg5h510fc1p3qkvr2l1qm6nf85hlr9z8im8a7xlka0i"))))
> +    (build-system python-build-system)
> +    (arguments '(#:tests? #f)) ; there are no tests
> +    (propagated-inputs
> +     `(("beets" ,beets)
> +       ("python-isodate" ,python-isodate)))
> +    (inputs
> +     `(("python-six" ,python-six)
> +       ("python-requests" ,python-requests)
> +       ("python-beautifulsoup4" ,python-beautifulsoup4)))
> +    (home-page "https://github.com/unrblt/beets-bandcamp")
> +    (synopsis "Bandcamp plugin for beets")
> +    (description "Plugin for beets to automatically obtain tag data from
> +https://bandcamp.com/.  The plugin is also capable of getting lyrics for songs
> +and album art using the beets FetchArt plugin.")
> +    (license license:gpl2)))
> +
>   (define-public milkytracker
>     (package
>       (name "milkytracker")
> 

LGTM. It is reproducible.

-- 
Cheers Swedebugia

Message #13 received at 36409-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 36409-done <at> debbugs.gnu.org
Subject: Re: [bug#36409] [PATCH] gnu: Add beets-bandcamp.
Date: Fri, 28 Jun 2019 14:25:18 +0200

[Message part 1 (text/plain, inline)]

Jakob,

Pushed with minor cosmetic adjustments as 
4ee2cce327ce839f471fb28a095fe7299ed822af.

Jakob L. Kreuze wrote:
> +    (description "Plugin for beets to automatically obtain tag 
> data from
> +https://bandcamp.com/.  The plugin is also capable of getting 
> lyrics for songs
> +and album art using the beets FetchArt plugin.")

Thank you for (presumably) taking the time to write a better 
description than upstream's.

I've tweaked it only slightly (mainly starting with a full 
sentence & adding @uref for the URL), promise.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 36409 <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: 36409 <at> debbugs.gnu.org
Cc: me <at> tobias.gr
Subject: Re: bug#36409: [PATCH] gnu: Add beets-bandcamp.
Date: Fri, 28 Jun 2019 09:42:39 -0400

[Message part 1 (text/plain, inline)]

Hi Tobias,

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> Thank you for (presumably) taking the time to write a better
> description than upstream's.

Yeah, I didn't think upstream's description fit the guidelines in the
manual's "Synopses and Descriptions" section.

> I've tweaked it only slightly (mainly starting with a full sentence &
> adding @uref for the URL), promise.

Much appreciated, thank you :]

Regards,
Jakob

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.