GNU bug report logs - #36410
[PATCH] gnu: Add screenfetch.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36410 in the body.
You can then email your comments to 36410 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add screenfetch.
Date: Thu, 27 Jun 2019 20:42:14 -0400

[Message part 1 (text/plain, inline)]

* gnu/packages/admin.scm (screenfetch): New variable.
---
 gnu/packages/admin.scm | 47 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 3d8c247f57..b920d564e5 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -25,6 +25,7 @@
 ;;; Copyright © 2018 Pierre Neidhardt <mail <at> ambrevar.xyz>
 ;;; Copyright © 2019 Brett Gilio <brettg <at> posteo.net>
 ;;; Copyright © 2019 Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
+;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -55,6 +56,7 @@
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
+  #:use-module (gnu packages algebra)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages check)
@@ -2651,6 +2653,51 @@ used in screenshots to show other users what operating system or distribution
 you are running, what theme or icon set you are using, etc.")
     (license license:expat)))
 
+(define-public screenfetch
+  ;; first commit supporting current GuixSD
+  (let ((commit "e3ec82dd464e81e4d10bef218b3016e3044c766c"))
+    (package
+      (name "screenfetch")
+      (version (string-append "3.8.0" "-" (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/KittyKatt/screenFetch")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1lzs1l5xgj9mn4b59lhkfgqnyiivf8svd1iwjabzrax90rdmxfwj"))))
+      (build-system trivial-build-system)
+      (arguments
+       `(#:modules ((guix build utils))
+         #:builder
+         (begin
+           (use-modules (guix build utils))
+           (let ((source (assoc-ref %build-inputs "source")))
+             (mkdir-p (string-append %output "/bin/"))
+             (mkdir-p (string-append %output "/man/man1/"))
+             (copy-file (string-append source "/screenfetch-dev")
+                        (string-append %output "/bin/screenfetch"))
+             (copy-file (string-append source "/screenfetch.1")
+                        (string-append %output "/man/man1/screenfetch.1"))
+             (substitute* (string-append %output "/bin/screenfetch")
+               (("/usr/bin/env bash")
+                (string-append (assoc-ref %build-inputs "bash")
+                               "/bin/bash")))))))
+      (propagated-inputs
+       `(("bash" ,bash)
+         ("bc" ,bc)
+         ("scrot" ,scrot)
+         ("xdpyinfo" ,xdpyinfo)
+         ("xprop" ,xprop)))
+      (home-page "https://github.com/KittyKatt/screenFetch")
+      (synopsis "System information script")
+      (description "Bash screenshot information tool which can be used to
+generate those nifty terminal theme information and ASCII distribution logos in
+everyone's screenshots nowadays.")
+      (license license:gpl3))))
+
 (define-public nnn
   (package
     (name "nnn")
-- 
2.22.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: Re: [bug#36410] [PATCH] gnu: Add screenfetch.
Date: Fri, 28 Jun 2019 07:15:28 +0200

On 2019-06-28 02:42, Jakob L. Kreuze wrote:
> * gnu/packages/admin.scm (screenfetch): New variable.
> ---
>   gnu/packages/admin.scm | 47 ++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 47 insertions(+)
> 
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 3d8c247f57..b920d564e5 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -25,6 +25,7 @@
>   ;;; Copyright © 2018 Pierre Neidhardt <mail <at> ambrevar.xyz>
>   ;;; Copyright © 2019 Brett Gilio <brettg <at> posteo.net>
>   ;;; Copyright © 2019 Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
> +;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
>   ;;;
>   ;;; This file is part of GNU Guix.
>   ;;;
> @@ -55,6 +56,7 @@
>     #:use-module (guix build-system python)
>     #:use-module (guix build-system trivial)
>     #:use-module (gnu packages)
> +  #:use-module (gnu packages algebra)
>     #:use-module (gnu packages base)
>     #:use-module (gnu packages bash)
>     #:use-module (gnu packages check)
> @@ -2651,6 +2653,51 @@ used in screenshots to show other users what operating system or distribution
>   you are running, what theme or icon set you are using, etc.")
>       (license license:expat)))
>   
> +(define-public screenfetch
> +  ;; first commit supporting current GuixSD
> +  (let ((commit "e3ec82dd464e81e4d10bef218b3016e3044c766c"))
> +    (package
> +      (name "screenfetch")
> +      (version (string-append "3.8.0" "-" (string-take commit 7)))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/KittyKatt/screenFetch")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1lzs1l5xgj9mn4b59lhkfgqnyiivf8svd1iwjabzrax90rdmxfwj"))))
> +      (build-system trivial-build-system)
> +      (arguments
> +       `(#:modules ((guix build utils))
> +         #:builder
> +         (begin
> +           (use-modules (guix build utils))
> +           (let ((source (assoc-ref %build-inputs "source")))
> +             (mkdir-p (string-append %output "/bin/"))
> +             (mkdir-p (string-append %output "/man/man1/"))
> +             (copy-file (string-append source "/screenfetch-dev")
> +                        (string-append %output "/bin/screenfetch"))
> +             (copy-file (string-append source "/screenfetch.1")
> +                        (string-append %output "/man/man1/screenfetch.1"))
> +             (substitute* (string-append %output "/bin/screenfetch")
> +               (("/usr/bin/env bash")
> +                (string-append (assoc-ref %build-inputs "bash")
> +                               "/bin/bash")))))))
> +      (propagated-inputs
> +       `(("bash" ,bash)
> +         ("bc" ,bc)
> +         ("scrot" ,scrot)
> +         ("xdpyinfo" ,xdpyinfo)
> +         ("xprop" ,xprop)))
> +      (home-page "https://github.com/KittyKatt/screenFetch")
> +      (synopsis "System information script")
> +      (description "Bash screenshot information tool which can be used to
> +generate those nifty terminal theme information and ASCII distribution logos in
> +everyone's screenshots nowadays.")
> +      (license license:gpl3))))

gpl3+

Could you ask upstream to release a version we can track?

Otherwise LGTM.

-- 
Cheers Swedebugia

Message #11 received at 36410 <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: swedebugia <swedebugia <at> riseup.net>
Cc: 36410 <at> debbugs.gnu.org
Subject: Re: [bug#36410] [PATCH] gnu: Add screenfetch.
Date: Fri, 28 Jun 2019 10:00:27 -0400

[Message part 1 (text/plain, inline)]

swedebugia <swedebugia <at> riseup.net> writes:

> gpl3+

Thanks, missed that.

> Could you ask upstream to release a version we can track?

Will do. The last release was over two years ago, so I think v3.9.0 is
well overdue :]

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 36410 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: "Jakob L. Kreuze" <zerodaysfordays <at> sdf.lonestar.org>
Cc: 36410 <at> debbugs.gnu.org
Subject: Re: [bug#36410] [PATCH] gnu: Add screenfetch.
Date: Tue, 2 Jul 2019 10:18:50 +0300

[Message part 1 (text/plain, inline)]

On Thu, Jun 27, 2019 at 08:42:14PM -0400, Jakob L. Kreuze wrote:
> * gnu/packages/admin.scm (screenfetch): New variable.
> ---
>  gnu/packages/admin.scm | 47 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 3d8c247f57..b920d564e5 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -25,6 +25,7 @@
>  ;;; Copyright © 2018 Pierre Neidhardt <mail <at> ambrevar.xyz>
>  ;;; Copyright © 2019 Brett Gilio <brettg <at> posteo.net>
>  ;;; Copyright © 2019 Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
> +;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays <at> sdf.lonestar.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -55,6 +56,7 @@
>    #:use-module (guix build-system python)
>    #:use-module (guix build-system trivial)
>    #:use-module (gnu packages)
> +  #:use-module (gnu packages algebra)
>    #:use-module (gnu packages base)
>    #:use-module (gnu packages bash)
>    #:use-module (gnu packages check)
> @@ -2651,6 +2653,51 @@ used in screenshots to show other users what operating system or distribution
>  you are running, what theme or icon set you are using, etc.")
>      (license license:expat)))
>  
> +(define-public screenfetch
> +  ;; first commit supporting current GuixSD
> +  (let ((commit "e3ec82dd464e81e4d10bef218b3016e3044c766c"))
> +    (package
> +      (name "screenfetch")
> +      (version (string-append "3.8.0" "-" (string-take commit 7)))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/KittyKatt/screenFetch")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1lzs1l5xgj9mn4b59lhkfgqnyiivf8svd1iwjabzrax90rdmxfwj"))))
> +      (build-system trivial-build-system)
> +      (arguments
> +       `(#:modules ((guix build utils))
> +         #:builder
> +         (begin
> +           (use-modules (guix build utils))
> +           (let ((source (assoc-ref %build-inputs "source")))
> +             (mkdir-p (string-append %output "/bin/"))
> +             (mkdir-p (string-append %output "/man/man1/"))
> +             (copy-file (string-append source "/screenfetch-dev")
> +                        (string-append %output "/bin/screenfetch"))
> +             (copy-file (string-append source "/screenfetch.1")
> +                        (string-append %output "/man/man1/screenfetch.1"))

If 'install-file' works here then the above 6 lines can be 2, something
like:
(install-file (string-append source "/screenfetch.1")
              (string-append %output "/man/man1/"))

> +             (substitute* (string-append %output "/bin/screenfetch")
> +               (("/usr/bin/env bash")
> +                (string-append (assoc-ref %build-inputs "bash")
> +                               "/bin/bash")))))))

you can use the patch-shebang function here, should help a bit.

> +      (propagated-inputs
> +       `(("bash" ,bash)
> +         ("bc" ,bc)
> +         ("scrot" ,scrot)
> +         ("xdpyinfo" ,xdpyinfo)
> +         ("xprop" ,xprop)))

Ideally these should wrap the binary rather than being propagated.

> +      (home-page "https://github.com/KittyKatt/screenFetch")
> +      (synopsis "System information script")
> +      (description "Bash screenshot information tool which can be used to
> +generate those nifty terminal theme information and ASCII distribution logos in
> +everyone's screenshots nowadays.")
> +      (license license:gpl3))))
> +
>  (define-public nnn
>    (package
>      (name "nnn")
> -- 
> 2.22.0
> 



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 36410 <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 36410 <at> debbugs.gnu.org
Subject: Re: [bug#36410] [PATCH] gnu: Add screenfetch.
Date: Tue, 02 Jul 2019 12:07:31 -0400

[Message part 1 (text/plain, inline)]

Hi Efraim,

Efraim Flashner <efraim <at> flashner.co.il> writes:

> If 'install-file' works here then the above 6 lines can be 2, something
> like:
> (install-file (string-append source "/screenfetch.1")
>               (string-append %output "/man/man1/"))

That's certainly much clearer. Would it make sense to do the same for
'screenfetch-dev', renaming the file after copying it with
'install-file'? Or, should a '#:rename' keyword be added to
'install-file', perhaps? I don't know if it would be a useful pattern or
not, but it's an easy addition and I'd be happy to submit a separate
patch if there's any interest.

> you can use the patch-shebang function here, should help a bit.

Thanks, that seems to be just one of many hidden gems in '(guix build
utils)'. I should really skim through that whole file at some point,
these procedures would definitely make packaging much easier.

> Ideally these should wrap the binary rather than being propagated.

I'm a bit unsure as to what you mean. Should I patch the screenfetch
script to use absolute paths for the binaries of these inputs? I.e.
patch 'bc' to '/gnu/store/...-bc-1.07.1/bin/bc'?

Regards,
Jakob

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 36410 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: "Jakob L. Kreuze" <zerodaysfordays <at> sdf.lonestar.org>
Cc: 36410 <at> debbugs.gnu.org
Subject: Re: [bug#36410] [PATCH] gnu: Add screenfetch.
Date: Thu, 5 Sep 2019 15:06:20 +0300

[Message part 1 (text/plain, inline)]

I'm sorry, this one fell through the cracks and I forgot about it.

On Tue, Jul 02, 2019 at 12:07:31PM -0400, Jakob L. Kreuze wrote:
> Hi Efraim,
> 
> Efraim Flashner <efraim <at> flashner.co.il> writes:
> 
> > If 'install-file' works here then the above 6 lines can be 2, something
> > like:
> > (install-file (string-append source "/screenfetch.1")
> >               (string-append %output "/man/man1/"))
> 
> That's certainly much clearer. Would it make sense to do the same for
> 'screenfetch-dev', renaming the file after copying it with
> 'install-file'? Or, should a '#:rename' keyword be added to
> 'install-file', perhaps? I don't know if it would be a useful pattern or
> not, but it's an easy addition and I'd be happy to submit a separate
> patch if there's any interest.
> 

I think since we want to rename it anyway I wouldn't bother with
'install-file' for screenfetch-dev.

> > you can use the patch-shebang function here, should help a bit.
> 
> Thanks, that seems to be just one of many hidden gems in '(guix build
> utils)'. I should really skim through that whole file at some point,
> these procedures would definitely make packaging much easier.
> 
> > Ideally these should wrap the binary rather than being propagated.
> 
> I'm a bit unsure as to what you mean. Should I patch the screenfetch
> script to use absolute paths for the binaries of these inputs? I.e.
> patch 'bc' to '/gnu/store/...-bc-1.07.1/bin/bc'?

I found an example of what I was thinking of in (gnu packages
dictionaries), with translate-shell. The function itself is called
'wrap-program'.

Can you send an updated patch?

thanks


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 36410-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: "Jakob L. Kreuze" <zerodaysfordays <at> sdf.lonestar.org>
Cc: 36410-done <at> debbugs.gnu.org
Subject: Re: [bug#36410] [PATCH] gnu: Add screenfetch.
Date: Mon, 23 Sep 2019 19:08:05 +0300

[Message part 1 (text/plain, inline)]

Pushed with some changes

 +                                    ?  efraim <at> E5400
 ??                                  ?I  OS: GuixSD
  ??I?   I??N              ???    ????   Kernel: x86_64 Linux 5.2.13-gnu
   ?III7???????          ??????7III?Z    Uptime: 1d 8h 40m
     OI77$?????         ?????7IIII       Packages: 12629
           ?????        ????             Shell: bash 4.4.23
            ???ID      ????              Disk: 44G / 110G (41%)
             IIII     +????              CPU: Pentium Dual-Core E5400 @ 2x 1.318GHz
             IIIII    ????               GPU: Intel Corporation 4 Series Chipset Integrated Graphics Controller (rev 03)
              IIII   ?????               RAM: 483MiB / 1959MiB
              IIIII  ????
               II77 ????$
               7777+????
                77++???$
                N?+????



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 36410-done <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 36410-done <at> debbugs.gnu.org
Subject: Re: [bug#36410] [PATCH] gnu: Add screenfetch.
Date: Sat, 28 Sep 2019 16:48:26 -0400

[Message part 1 (text/plain, inline)]

Efraim Flashner <efraim <at> flashner.co.il> writes:

> Pushed with some changes
>
>  +                                    ?  efraim <at> E5400
>  ??                                  ?I  OS: GuixSD
>   ??I?   I??N              ???    ????   Kernel: x86_64 Linux 5.2.13-gnu
>    ?III7???????          ??????7III?Z    Uptime: 1d 8h 40m
>      OI77$?????         ?????7IIII       Packages: 12629
>            ?????        ????             Shell: bash 4.4.23
>             ???ID      ????              Disk: 44G / 110G (41%)
>              IIII     +????              CPU: Pentium Dual-Core E5400 @ 2x 1.318GHz
>              IIIII    ????               GPU: Intel Corporation 4 Series Chipset Integrated Graphics Controller (rev 03)
>               IIII   ?????               RAM: 483MiB / 1959MiB
>               IIIII  ????
>                II77 ????$
>                7777+????
>                 77++???$
>                 N?+????

Heh, guess this one spent a little too long on my backlog. Thanks for
taking care of that!

Regards,
Jakob

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 36410-done <at> debbugs.gnu.org (full text, mbox):

From: zerodaysfordays <at> sdf.lonestar.org (Jakob L. Kreuze)
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 36410-done <at> debbugs.gnu.org
Subject: Re: [bug#36410] [PATCH] gnu: Add screenfetch.
Date: Sat, 05 Oct 2019 04:19:49 -0400

[Message part 1 (text/plain, inline)]

Efraim Flashner <efraim <at> flashner.co.il> writes:

> Pushed with some changes
>
>  +                                    ?  efraim <at> E5400
>  ??                                  ?I  OS: GuixSD
>   ??I?   I??N              ???    ????   Kernel: x86_64 Linux 5.2.13-gnu
>    ?III7???????          ??????7III?Z    Uptime: 1d 8h 40m
>      OI77$?????         ?????7IIII       Packages: 12629
>            ?????        ????             Shell: bash 4.4.23
>             ???ID      ????              Disk: 44G / 110G (41%)
>              IIII     +????              CPU: Pentium Dual-Core E5400 @ 2x 1.318GHz
>              IIIII    ????               GPU: Intel Corporation 4 Series Chipset Integrated Graphics Controller (rev 03)
>               IIII   ?????               RAM: 483MiB / 1959MiB
>               IIIII  ????
>                II77 ????$
>                7777+????
>                 77++???$
>                 N?+????

Just an FYI that we've finally got a release [1] tagged with proper
GuixSD support.

[1]: https://github.com/KittyKatt/screenFetch/releases/tag/v3.9.0

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.