GNU bug report logs - #36433
gnus-read-ephemeral-bug-group does not handle errors, leaving temporary files behind

Previous Next

Packages: gnus, emacs;

Reported by: Tim Landscheidt <tim <at> tim-landscheidt.de>

Date: Sat, 29 Jun 2019 12:58:01 UTC

Severity: normal

Tags: fixed, patch

Found in version 5.13

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36433 in the body.
You can then email your comments to 36433 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#36433; Package emacs,gnus. (Sat, 29 Jun 2019 12:58:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tim Landscheidt <tim <at> tim-landscheidt.de>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org. (Sat, 29 Jun 2019 12:58:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tim Landscheidt <tim <at> tim-landscheidt.de>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: gnus-read-ephemeral-bug-group does not handle errors,
 leaving temporary files behind
Date: Sat, 29 Jun 2019 12:57:47 +0000
With Emacs 26.1, M-x gnus-read-ephemeral-bug-group RET
foobar RET gives "gnus-list-of-unread-articles: Group
nndoc+ephemeral:bug#0 couldn’t be activated", while leaving
a temporary file with the contents:

| <HTML>
| <HEAD><TITLE>Error</TITLE></HEAD>
| <BODY>
| An error occurred.
| Error was: No bug number
| </BODY></HTML>

behind in /tmp.

This also happens with gnus-read-ephemeral-emacs-bug-group
and gnus-read-ephemeral-debian-bug-group.

For GNU bugs, fixing this might be made easier by updating
debbugs.gnu.org as it currently returns 200 OK for non-ex-
isting bugs:

| [tim <at> passepartout ~]$ curl -is 'https://debbugs.gnu.org/cgi/bugreport.cgi?bug=foobar;mboxmaint=yes;mboxstat=yes' | head -1
| HTTP/1.1 200 OK
| [tim <at> passepartout ~]$

while bugs.debian.org gives a status code that can be used
for diagnostics:

| [tim <at> passepartout ~]$ curl -is 'https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=595256;mboxmaint=yes;mboxstat=yes' | head -1
| HTTP/1.1 200 OK
| [tim <at> passepartout ~]$ curl -is 'https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=4711;mboxmaint=yes;mboxstat=yes' | head -1
| HTTP/1.1 404 Not Found
| [tim <at> passepartout ~]$




Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#36433; Package emacs,gnus. (Sun, 30 Jun 2019 02:48:01 GMT) Full text and rfc822 format available.

Message #8 received at 36433 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Tim Landscheidt <tim <at> tim-landscheidt.de>
Cc: 36433 <at> debbugs.gnu.org
Subject: Re: bug#36433: gnus-read-ephemeral-bug-group does not handle errors,
 leaving temporary files behind
Date: Sun, 30 Jun 2019 03:47:02 +0100
[Message part 1 (text/plain, inline)]
tags 36433 + patch
quit

[0001-Improve-Gnus-ephemeral-bug-group-browsing.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
Tim Landscheidt <tim <at> tim-landscheidt.de> writes:

> With Emacs 26.1, M-x gnus-read-ephemeral-bug-group RET
> foobar RET gives "gnus-list-of-unread-articles: Group
> nndoc+ephemeral:bug#0 couldn’t be activated", while leaving
> a temporary file with the contents:
>
> | <HTML>
> | <HEAD><TITLE>Error</TITLE></HEAD>
> | <BODY>
> | An error occurred.
> | Error was: No bug number
> | </BODY></HTML>
>
> behind in /tmp.
>
> This also happens with gnus-read-ephemeral-emacs-bug-group
> and gnus-read-ephemeral-debian-bug-group.

The attached patch fixes this for Emacs 27.  It also improves the
reading and handling of multiple string/numeric bug IDs, which is
currently quite brittle, and extends some of the relevant documentation.
WDYT?

> For GNU bugs, fixing this might be made easier by updating
> debbugs.gnu.org as it currently returns 200 OK for non-ex-
> isting bugs:
>
> | [tim <at> passepartout ~]$ curl -is 'https://debbugs.gnu.org/cgi/bugreport.cgi?bug=foobar;mboxmaint=yes;mboxstat=yes' | head -1
> | HTTP/1.1 200 OK
> | [tim <at> passepartout ~]$
>
> while bugs.debian.org gives a status code that can be used
> for diagnostics:
>
> | [tim <at> passepartout ~]$ curl -is 'https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=595256;mboxmaint=yes;mboxstat=yes' | head -1
> | HTTP/1.1 200 OK
> | [tim <at> passepartout ~]$ curl -is 'https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=4711;mboxmaint=yes;mboxstat=yes' | head -1
> | HTTP/1.1 404 Not Found
> | [tim <at> passepartout ~]$

I think the attached patch is as good as gnus-read-ephemeral-bug-group
can do for now, without fixing several known deficiencies of the url.el
library and debbugs.gnu.org instance (each of which deserves its own bug
ticket if it doesn't already have one).

Thanks,

-- 
Basil

Added tag(s) patch. Request was from "Basil L. Contovounesios" <contovob <at> tcd.ie> to control <at> debbugs.gnu.org. (Sun, 30 Jun 2019 02:48:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#36433; Package emacs,gnus. (Sat, 06 Jul 2019 14:34:01 GMT) Full text and rfc822 format available.

Message #13 received at 36433 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 36433 <at> debbugs.gnu.org, Tim Landscheidt <tim <at> tim-landscheidt.de>
Subject: Re: bug#36433: gnus-read-ephemeral-bug-group does not handle errors,
 leaving temporary files behind
Date: Sat, 06 Jul 2019 16:33:16 +0200
"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> The attached patch fixes this for Emacs 27.  It also improves the
> reading and handling of multiple string/numeric bug IDs, which is
> currently quite brittle, and extends some of the relevant documentation.
> WDYT?

Looks good to me, and it works fine, so I've applied it to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 06 Jul 2019 14:34:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.1, send any further explanations to 36433 <at> debbugs.gnu.org and Tim Landscheidt <tim <at> tim-landscheidt.de> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 06 Jul 2019 14:34:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 04 Aug 2019 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 266 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.