GNU bug report logs - #36440
[PATCH] Add FreeCAD

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36440 in the body.
You can then email your comments to 36440 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add FreeCAD
Date: Sun, 30 Jun 2019 02:39:52 +0000

[Message part 1 (text/plain, inline)]

Hi all,

I've done linting, and indentation checks.  There are still some issues
with licenses that I've marked and I don't know where to put the changes
that I've included in llvm.scm.  Also I discovered some non-determinism in
the build of freecad just now. I thought it would be good to share my work,
though. It's been long enough.

- John

[Message part 2 (text/html, inline)]

[0001-gnu-Add-FreeCAD.patch (text/x-patch, attachment)]

Message #8 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Tue, 2 Jul 2019 09:06:42 +0200

[Message part 1 (text/plain, inline)]

On Sun, 30 Jun 2019 02:39:52 +0000
John Soo <jsoo1 <at> asu.edu> wrote:

> Hi all,
> 
> I've done linting, and indentation checks.  There are still some
> issues with licenses that I've marked and I don't know where to put
> the changes that I've included in llvm.scm.  Also I discovered some
> non-determinism in the build of freecad just now. I thought it would
> be good to share my work, though. It's been long enough.
> 
> - John

Hi John,

thank you very much for working on FreeCAD! And thanks for sharing this
work even if it is not 100% polished.

The first thing I noticed is that you packed everything into one
commit. Could you please split it up in one commit per added/modified
package? That's the usual way Guix expects commits, and it would make
the reviewing easier, you can concentrate on each package as a reviewer
and you better see the dependency structure right away.

Thanks,

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: 36440 <at> debbugs.gnu.org
Subject: Fwd: [bug#36440] [PATCH] Add FreeCAD
Date: Mon, 8 Jul 2019 01:17:43 +0000

[Message part 1 (text/plain, inline)]

Hi Bjorn,

Thanks for taking a look. Here are the patches with one package in each.

- John

[Message part 2 (text/html, inline)]

[0001-gnu-Add-coin3D.patch (application/x-patch, attachment)]

[0003-gnu-Add-llvm-toolchain-6.patch (application/x-patch, attachment)]

[0004-gnu-Add-python-shiboken-2.patch (application/x-patch, attachment)]

[0005-gnu-Add-python-pyside-2-libcxx-headers.patch (application/x-patch, attachment)]

[0006-gnu-Add-python-pyside-2.patch (application/x-patch, attachment)]

[0007-gnu-Add-python-pyside-2-tools.patch (application/x-patch, attachment)]

[0008-gnu-Add-libspnav.patch (application/x-patch, attachment)]

[0009-gnu-Add-libarea.patch (application/x-patch, attachment)]

[0010-gnu-Add-libmedfile.patch (application/x-patch, attachment)]

[0011-gnu-Add-freecad.patch (application/x-patch, attachment)]

[0002-gnu-Add-soqt.patch (application/x-patch, attachment)]

Message #14 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Wed, 10 Jul 2019 14:02:38 +0000

[Message part 1 (text/plain, inline)]

Updated patches with rebase on master.

- John

On Mon, Jul 8, 2019 at 1:17 AM John Soo <jsoo1 <at> asu.edu> wrote:

> Hi Bjorn,
>
> Thanks for taking a look. Here are the patches with one package in each.
>
> - John
>
>

[Message part 2 (text/html, inline)]

[0002-gnu-Add-soqt.patch (text/x-patch, attachment)]

[0005-gnu-Add-python-pyside-2-libcxx-headers.patch (text/x-patch, attachment)]

[0001-gnu-Add-coin3D.patch (text/x-patch, attachment)]

[0004-gnu-Add-python-shiboken-2.patch (text/x-patch, attachment)]

[0003-gnu-Add-llvm-toolchain-6.patch (text/x-patch, attachment)]

[0006-gnu-Add-python-pyside-2.patch (text/x-patch, attachment)]

[0008-gnu-Add-libspnav.patch (text/x-patch, attachment)]

[0009-gnu-Add-libarea.patch (text/x-patch, attachment)]

[0007-gnu-Add-python-pyside-2-tools.patch (text/x-patch, attachment)]

[0010-gnu-Add-libmedfile.patch (text/x-patch, attachment)]

[0011-gnu-Add-freecad.patch (text/x-patch, attachment)]

Message #17 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 36440 <at> debbugs.gnu.org
Subject: [PATCH] Add FreeCAD
Date: Fri, 19 Jul 2019 22:40:50 +0200

Is there a reason why you build every package from a commit of the
master branch instead of using the stable releases? I think at least
FreeCAD releases often enough, in the mean time the released version 0.18.3.

Do you have the patches also in some public git repo (Github, Gitlab etc.)?

~Jonathan

Message #20 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: jonathan.brielmaier <at> web.de, 36440 <at> debbugs.gnu.org
Subject: Source commit, minor version difference, channel
Date: Mon, 22 Jul 2019 13:41:08 +0000

[Message part 1 (text/plain, inline)]

Hi Jonathon,

I have based freecad on the commit for the release tag for version 0.18.2
(0.18.3 was released after my patches were submitted).  I looked at the
commit for 0.18.3 and I don't see why I couldn't use that one. I just need
to find the time to do the work.  As for a working version you can see my
prior work in the channel at https://github.com/jsoo1/guix-channel on
commit 9fd2815ed08317d27e174ca460e0d0a2be058aa7.

Thanks for your review!

- John

9fd2815ed08317d27e174ca460e0d0a2be058aa7

9fd2815ed08317d27e174ca460e0d0a2be058aa7

[Message part 2 (text/html, inline)]

Message #23 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Mon, 22 Jul 2019 16:11:20 +0200

[Message part 1 (text/plain, inline)]

On Sun, 30 Jun 2019 02:39:52 +0000
John Soo <jsoo1 <at> asu.edu> wrote:

> Hi all,
> 
> I've done linting, and indentation checks.  There are still some
> issues with licenses that I've marked and I don't know where to put
> the changes that I've included in llvm.scm.  Also I discovered some
> non-determinism in the build of freecad just now. I thought it would
> be good to share my work, though. It's been long enough.
> 
> - John

Hi John,

this is not a easy "guix import" package. Thanks for looking into this.

Here are some remarks from my side:

Commit-log: You have a summary line, but missing this:

* gnu/package/...scm (freecad): New variable.

This holds for all packages. See the manual
(https://guix.gnu.org/manual/en/guix.html#Submitting-Patches) and other
commits as reference. You might like to work with magit and yasnippets
to automate this.

Add a copyright line for yourself to all files you touched.

For the dependencies, you often used commits from the git/hg repository
instead of a released version. Was there specific reason for that? If
so, please add a comment on why you need this specific version.

For some (all), I found out that a proper release was only created
after you submitted/edited your patch. Maybe you can give it a try with
the released versions?

I wanted to give it a try for myself but failed: I could not build
qtwebkit locally, and no substitutes are available. I don't want to
hold back my comments any longer, so I postponed trying it out.

Also, I wanted to compare with the AppPack provided by FreeCAD, but I
wasn't able to extract it: I did not want to do it on my machine
directly, because you use the AppPack executable to extract it! And it
did not work in a Guix-VM, probably due to some "standard" library
paths being expected.

We should fix this package and then suggest them using Guix or at least
"guix pack" for really relocatable BLOBs :-)

coin3D:

There are two binaries in the source repository:


./cfg/csubst.exe
./cfg/wrapmsvc.exe

Also the .hg directory is included.

Could you please remove them with "snippets"?

You can search for "snippet" to find examples for that.

I did it like that:

+       (modules '((guix build utils)))
+       (snippet
+        '(begin
+           (delete-file-recursively ".hg")
+           (for-each delete-file
+                     '("cfg/csubst.exe"
+                       "cfg/wrapmsvc.exe"))
+           #t))))


soqt:

Same snippets apply here too.

soqt: There is a 1.6.0-package available since some hours.
Would you like to use this?

Also, they say it is superseeded by Quarter. Would it be possible/better
to use this one? Is there anything known from FreeCAD side?

llvm-toolchain-6: I haven't looked into that yet.

pyside2/shiboken:

There are two Qt-bindings for Python: PyQt and PySide2. As we have PyQt
already in 
gnu/packages/qt.scm, I think it would make sense to move Pyside2 and
its binding generator Shiboken into that package instead of
python-xyz.scm.


PySide2/Qt version:

We currently have 5.11.3 in Guix. 5.12 is the current LTS available and
5.13 is also out since June.

The PySide homepage (https://wiki.qt.io/Qt_for_Python) says:

<quote>
The module was released mid June 2018 as a Technical Preview
(supporting Qt 5.11), and it was officially released without the
Technical Preview tag, in December 2018 for Qt 5.12. 
</quote>

What does it mean if we use it still with 5.11? Or do we need to update
to 5.12 first?

I wonder if we need the dependency on qtwebkit or if we can get rid of this, but I haven't investigated yet.

medfile: Is there a specific reason you chose 3.x, instead of the
available 4.0.0? If you, could you add a comment of why?

License is GPLv3+

libarea: Also licensed under GPL v3 (files under "pocket" directory).

freecad: Can you use the releasted sources instead of the git-version?

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #26 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 John Soo <jsoo1 <at> asu.edu>
Cc: 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Mon, 22 Jul 2019 19:57:16 +0200

Thanks Björn for having a look here :)

On 7/22/19 4:11 PM, Björn Höfling wrote:> I wanted to give it a try for
myself but failed: I could not build
> qtwebkit locally, and no substitutes are available. I don't want to
> hold back my comments any longer, so I postponed trying it out.

qtwebkit seems to fail on master as well and it needs long to build, so
I can't do it locally on my laptop:
http://ci.guix.gnu.org/build/1488065/details

> I wonder if we need the dependency on qtwebkit or if we can get rid of this, but I haven't investigated yet.

I think we need it as openSUSE and Debian have a build require on
qtwebkit-devel and it's noted at their wiki:
https://www.freecadweb.org/wiki/CompileOnUnix#Getting_the_dependencies

Message #29 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Tue, 23 Jul 2019 16:25:53 +0000

[Message part 1 (text/plain, inline)]

Hi Bjorn, Jonathon, and everyone,

FreeCAD was certainly not easy to package. I spent actually several months
just working on the pyside2 dependencies and I still do not have a working
build of Pivy from coin.  It is only thanks to the help of the upstream
maintainers that this package is even close to working.  I have attached
updated patches and my responses to Bjorn's notes below. Thanks for your
review!

As to QTWebKit - I do not know why it is a dependency. It may not be a hard
requirement. If you comment it out, I think the configure phase may
succeed. I included it for completion only.

* FreeCAD Notes

** DONE Add commit message details and copyright lines

** Coin3D

*** DONE Delete blobs

*** hg-fetch deletes .hg dirs (and all submodules' .hg dirs)

** SoQT vs. Quarter

*** Not interchangeable as far as I know.

*** FreeCAD requires SoQT specifically during configure.

** Pyside2

*** Does all of pyside2 belong in qt.scm? - there are three packages:
Shiboken2, Pyside2, and Pyside2-Tools

*** QT version compatibility

**** The pyside2 project has branches for the newest version with
compatibility with older QT versions (I am using the 5.11.3 compat branch)

 - That is also why I am using a git commit for the Pyside2 packages
 - https://code.qt.io/cgit/pyside/pyside-setup.git/
 - Pyside dependencies were by far the most challenging, and I had to track
some issues (of which, some are not resolved)

** libmedfile

*** Reason for old version is that what was released when I started

*** 4.0.0 requires hdf5 >= 1.10.2

**** HDF5 has some dependents:

guix refresh --list-dependent hdf5 Building the following 11 packages would
ensure 23 dependent packages are rebuilt:
r-ioniser <at> 2.8.0 r-scone <at> 1.8.0 r-lumi <at> 2.36.0 r-yarn <at> 1.10.0
r-illuminahumanmethylationepicmanifest <at> 0.3.0 r-scdd <at> 1.8.0 pigx <at> 0.0.3
r-pore <at> 0.24 r-yamss <at> 1.10.0 r-xcms <at> 3.6.1 r-msnid <at> 1.18.0

**** HDF5 patches need updates when HDF5 updated to 1.10.5

*** DONE Change license to gpl3+

** libarea License questions and source locations:

**** I am using the source from github: https://github.com/Heeks/libarea

 - Should I use some other source? The google archive is unavailable.
 - I cannot find any license information in the github repository.

**** DONE Change to gpl3+

** Using releases over hg/git downloads (please advise)

1. Pyside2 packages - Done for compatibility reasons
2. Coin3D and SoQt - I don't think there are releases of these aside from
the bitbucket repository.
3. LLVM propagated packages (llvm-toolchain and pyside-libcxx-headers)
 - I am not sure these are the best way to accomplish the goal anyways.
 - Not sure where to find the right sources for llvm-toolchain-6 and the
pyside-libcxx-headers.
4. libarea - Seems like libarea is actually close to not even having source
available anymore, let alone a release
5. libspnav - Confused as to the best source to use here. If there is a
release or better version, I can update.
6. FreeCAD
 - I can use the releases if they exist. I do not think they have source
tarballs available.
 - I was packaging during a lot of active development of FreeCAD

Thank you for your review and advice.

- John

On Mon, Jul 22, 2019 at 5:57 PM Jonathan Brielmaier <
jonathan.brielmaier <at> web.de> wrote:

> Thanks Björn for having a look here :)
>
> On 7/22/19 4:11 PM, Björn Höfling wrote:> I wanted to give it a try for
> myself but failed: I could not build
> > qtwebkit locally, and no substitutes are available. I don't want to
> > hold back my comments any longer, so I postponed trying it out.
>
> qtwebkit seems to fail on master as well and it needs long to build, so
> I can't do it locally on my laptop:
> http://ci.guix.gnu.org/build/1488065/details
>
> > I wonder if we need the dependency on qtwebkit or if we can get rid of
> this, but I haven't investigated yet.
>
> I think we need it as openSUSE and Debian have a build require on
> qtwebkit-devel and it's noted at their wiki:
> https://www.freecadweb.org/wiki/CompileOnUnix#Getting_the_dependencies
>

[Message part 2 (text/html, inline)]

[0001-gnu-Add-coin3D.patch (text/x-patch, attachment)]

[0005-gnu-Add-python-pyside-2-libcxx-headers.patch (text/x-patch, attachment)]

[0004-gnu-Add-python-shiboken-2.patch (text/x-patch, attachment)]

[0002-gnu-Add-soqt.patch (text/x-patch, attachment)]

[0003-gnu-Add-llvm-toolchain-6.patch (text/x-patch, attachment)]

[0007-gnu-Add-python-pyside-2-tools.patch (text/x-patch, attachment)]

[0006-gnu-Add-python-pyside-2.patch (text/x-patch, attachment)]

[0008-gnu-Add-libspnav.patch (text/x-patch, attachment)]

[0009-gnu-Add-libarea.patch (text/x-patch, attachment)]

[0010-gnu-Add-libmedfile.patch (text/x-patch, attachment)]

[0011-gnu-Add-freecad.patch (text/x-patch, attachment)]

Message #32 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Tue, 23 Jul 2019 16:29:31 +0000

[Message part 1 (text/plain, inline)]

Hi all,

I forgot to add some patches to start updating HDF5 with breaking builds.
It seems like the patches will need an update to start.

- John


On Tue, Jul 23, 2019 at 4:25 PM John Soo <jsoo1 <at> asu.edu> wrote:

> Hi Bjorn, Jonathon, and everyone,
>
> FreeCAD was certainly not easy to package. I spent actually several months
> just working on the pyside2 dependencies and I still do not have a working
> build of Pivy from coin.  It is only thanks to the help of the upstream
> maintainers that this package is even close to working.  I have attached
> updated patches and my responses to Bjorn's notes below. Thanks for your
> review!
>
> As to QTWebKit - I do not know why it is a dependency. It may not be a
> hard requirement. If you comment it out, I think the configure phase may
> succeed. I included it for completion only.
>
> * FreeCAD Notes
>
> ** DONE Add commit message details and copyright lines
>
> ** Coin3D
>
> *** DONE Delete blobs
>
> *** hg-fetch deletes .hg dirs (and all submodules' .hg dirs)
>
> ** SoQT vs. Quarter
>
> *** Not interchangeable as far as I know.
>
> *** FreeCAD requires SoQT specifically during configure.
>
> ** Pyside2
>
> *** Does all of pyside2 belong in qt.scm? - there are three packages:
> Shiboken2, Pyside2, and Pyside2-Tools
>
> *** QT version compatibility
>
> **** The pyside2 project has branches for the newest version with
> compatibility with older QT versions (I am using the 5.11.3 compat branch)
>
>  - That is also why I am using a git commit for the Pyside2 packages
>  - https://code.qt.io/cgit/pyside/pyside-setup.git/
>  - Pyside dependencies were by far the most challenging, and I had to
> track some issues (of which, some are not resolved)
>
> ** libmedfile
>
> *** Reason for old version is that what was released when I started
>
> *** 4.0.0 requires hdf5 >= 1.10.2
>
> **** HDF5 has some dependents:
>
> guix refresh --list-dependent hdf5 Building the following 11 packages
> would ensure 23 dependent packages are rebuilt:
> r-ioniser <at> 2.8.0 r-scone <at> 1.8.0 r-lumi <at> 2.36.0 r-yarn <at> 1.10.0
> r-illuminahumanmethylationepicmanifest <at> 0.3.0 r-scdd <at> 1.8.0 pigx <at> 0.0.3
> r-pore <at> 0.24 r-yamss <at> 1.10.0 r-xcms <at> 3.6.1 r-msnid <at> 1.18.0
>
> **** HDF5 patches need updates when HDF5 updated to 1.10.5
>
> *** DONE Change license to gpl3+
>
> ** libarea License questions and source locations:
>
> **** I am using the source from github: https://github.com/Heeks/libarea
>
>  - Should I use some other source? The google archive is unavailable.
>  - I cannot find any license information in the github repository.
>
> **** DONE Change to gpl3+
>
> ** Using releases over hg/git downloads (please advise)
>
> 1. Pyside2 packages - Done for compatibility reasons
> 2. Coin3D and SoQt - I don't think there are releases of these aside from
> the bitbucket repository.
> 3. LLVM propagated packages (llvm-toolchain and pyside-libcxx-headers)
>  - I am not sure these are the best way to accomplish the goal anyways.
>  - Not sure where to find the right sources for llvm-toolchain-6 and the
> pyside-libcxx-headers.
> 4. libarea - Seems like libarea is actually close to not even having
> source available anymore, let alone a release
> 5. libspnav - Confused as to the best source to use here. If there is a
> release or better version, I can update.
> 6. FreeCAD
>  - I can use the releases if they exist. I do not think they have source
> tarballs available.
>  - I was packaging during a lot of active development of FreeCAD
>
> Thank you for your review and advice.
>
> - John
>
> On Mon, Jul 22, 2019 at 5:57 PM Jonathan Brielmaier <
> jonathan.brielmaier <at> web.de> wrote:
>
>> Thanks Björn for having a look here :)
>>
>> On 7/22/19 4:11 PM, Björn Höfling wrote:> I wanted to give it a try for
>> myself but failed: I could not build
>> > qtwebkit locally, and no substitutes are available. I don't want to
>> > hold back my comments any longer, so I postponed trying it out.
>>
>> qtwebkit seems to fail on master as well and it needs long to build, so
>> I can't do it locally on my laptop:
>> http://ci.guix.gnu.org/build/1488065/details
>>
>> > I wonder if we need the dependency on qtwebkit or if we can get rid of
>> this, but I haven't investigated yet.
>>
>> I think we need it as openSUSE and Debian have a build require on
>> qtwebkit-devel and it's noted at their wiki:
>> https://www.freecadweb.org/wiki/CompileOnUnix#Getting_the_dependencies
>>
>

[Message part 2 (text/html, inline)]

[0001-gnu-hdf5-Update-to-1.10.5.patch (text/x-patch, attachment)]

[0002-gnu-libmedfile-Update-to-4.0.0.patch (text/x-patch, attachment)]

Message #35 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: John Soo <jsoo1 <at> asu.edu>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Wed, 24 Jul 2019 09:52:32 +0200

I didn't build all the packages, because it failed to apply them on top
of current master. Did you rebased it on current master?

I only comment where I "know" something...

On 7/23/19 6:25 PM, John Soo wrote:
> ** Coin3D
>
> *** DONE Delete blobs
>
> *** hg-fetch deletes .hg dirs (and all submodules' .hg dirs)

- Usually the (arguments) section is right after the (build-system...)
but this is more optical :P
- Wikipedia uses https://bitbucket.org/Coin3D/coin/src but I think the
link to their wiki https://bitbucket.org/Coin3D/coin/wiki/Home is even
better :)

> ** SoQT vs. Quarter
>
> *** Not interchangeable as far as I know.
>
> *** FreeCAD requires SoQT specifically during configure.

Do we really need SoQT? Neither openSUSE
https://build.opensuse.org/package/show/science/FreeCAD nor ArchLinux
https://aur.archlinux.org/packages/freecad/ depending on SoQT

> ** Pyside2
>
> *** Does all of pyside2 belong in qt.scm? - there are three packages:
> Shiboken2, Pyside2, and Pyside2-Tools

qt.scm does already include python and python-xyz, so from this side
it's not a problem. If pyside* would be used by non QT projects, which
also doesn't depend on QT it would be good to have it in python-xyz
module, but I don't think that is the case. So leave them in qt.scm :)

python-shiboken-2
Maybe leave a comment that it's a source inside of pyside-setup, because
the first repo I found was this :)
https://code.qt.io/cgit/pyside/shiboken.git/

pyside-2-tools:
- Maybe elaborate a bit more in the description, I have no idead what
"lupdate, rcc and uic" is :P
- Is there a reason why we don't run the tests?

python-pyside-2:
- No newlines in the description after a sentence, just two whitespaces :)

> ** libmedfile

- description: What is a MED file?

> *** Reason for old version is that what was released when I started
>
> *** 4.0.0 requires hdf5 >= 1.10.2
>
> **** HDF5 has some dependents:
>
> guix refresh --list-dependent hdf5 Building the following 11 packages would
> ensure 23 dependent packages are rebuilt:
> r-ioniser <at> 2.8.0 r-scone <at> 1.8.0 r-lumi <at> 2.36.0 r-yarn <at> 1.10.0
> r-illuminahumanmethylationepicmanifest <at> 0.3.0 r-scdd <at> 1.8.0 pigx <at> 0.0.3
> r-pore <at> 0.24 r-yamss <at> 1.10.0 r-xcms <at> 3.6.1 r-msnid <at> 1.18.0

20 rebuilds is not a problem.

> **** HDF5 patches need updates when HDF5 updated to 1.10.5

So they don't apply anymore at the moment?

> ** Using releases over hg/git downloads (please advise)
>
> 1. Pyside2 packages - Done for compatibility reasons
> 2. Coin3D and SoQt - I don't think there are releases of these aside from
> the bitbucket repository.

https://bitbucket.org/Coin3D/coin/downloads/

> 3. LLVM propagated packages (llvm-toolchain and pyside-libcxx-headers)
>  - I am not sure these are the best way to accomplish the goal anyways.
>  - Not sure where to find the right sources for llvm-toolchain-6 and the
> pyside-libcxx-headers.
> 4. libarea - Seems like libarea is actually close to not even having source
> available anymore, let alone a release
> 5. libspnav - Confused as to the best source to use here. If there is a
> release or better version, I can update.

This one:
https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/libspnav#n13

> 6. FreeCAD
>  - I can use the releases if they exist. I do not think they have source
> tarballs available.
>  - I was packaging during a lot of active development of FreeCAD
>
> Thank you for your review and advice.

That's it from me at the moment. Strong work! Keep it up :)
~Jonathan

Message #38 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Wed, 24 Jul 2019 12:46:40 -0700

Hi Jonathon,

Thanks for your comments. I was able to apply the patches over current master this morning after a fetch. There are some dependencies between the patches. The only thing I can think of is to make sure you apply them in order. I’ll take a look and adjust to the rest of your comments in the next day or so.

Thanks again.

- John

> On Jul 24, 2019, at 12:52 AM, Jonathan Brielmaier <jonathan.brielmaier <at> web.de> wrote:
> 
> I didn't build all the packages, because it failed to apply them on top
> of current master. Did you rebased it on current master?
> 
> I only comment where I "know" something...
> 
>> On 7/23/19 6:25 PM, John Soo wrote:
>> ** Coin3D
>> 
>> *** DONE Delete blobs
>> 
>> *** hg-fetch deletes .hg dirs (and all submodules' .hg dirs)
> 
> - Usually the (arguments) section is right after the (build-system...)
> but this is more optical :P
> - Wikipedia uses https://bitbucket.org/Coin3D/coin/src but I think the
> link to their wiki https://bitbucket.org/Coin3D/coin/wiki/Home is even
> better :)
> 
>> ** SoQT vs. Quarter
>> 
>> *** Not interchangeable as far as I know.
>> 
>> *** FreeCAD requires SoQT specifically during configure.
> 
> Do we really need SoQT? Neither openSUSE
> https://build.opensuse.org/package/show/science/FreeCAD nor ArchLinux
> https://aur.archlinux.org/packages/freecad/ depending on SoQT
> 
>> ** Pyside2
>> 
>> *** Does all of pyside2 belong in qt.scm? - there are three packages:
>> Shiboken2, Pyside2, and Pyside2-Tools
> 
> qt.scm does already include python and python-xyz, so from this side
> it's not a problem. If pyside* would be used by non QT projects, which
> also doesn't depend on QT it would be good to have it in python-xyz
> module, but I don't think that is the case. So leave them in qt.scm :)
> 
> python-shiboken-2
> Maybe leave a comment that it's a source inside of pyside-setup, because
> the first repo I found was this :)
> https://code.qt.io/cgit/pyside/shiboken.git/
> 
> pyside-2-tools:
> - Maybe elaborate a bit more in the description, I have no idead what
> "lupdate, rcc and uic" is :P
> - Is there a reason why we don't run the tests?
> 
> python-pyside-2:
> - No newlines in the description after a sentence, just two whitespaces :)
> 
>> ** libmedfile
> 
> - description: What is a MED file?
> 
>> *** Reason for old version is that what was released when I started
>> 
>> *** 4.0.0 requires hdf5 >= 1.10.2
>> 
>> **** HDF5 has some dependents:
>> 
>> guix refresh --list-dependent hdf5 Building the following 11 packages would
>> ensure 23 dependent packages are rebuilt:
>> r-ioniser <at> 2.8.0 r-scone <at> 1.8.0 r-lumi <at> 2.36.0 r-yarn <at> 1.10.0
>> r-illuminahumanmethylationepicmanifest <at> 0.3.0 r-scdd <at> 1.8.0 pigx <at> 0.0.3
>> r-pore <at> 0.24 r-yamss <at> 1.10.0 r-xcms <at> 3.6.1 r-msnid <at> 1.18.0
> 
> 20 rebuilds is not a problem.
> 
>> **** HDF5 patches need updates when HDF5 updated to 1.10.5
> 
> So they don't apply anymore at the moment?
> 
>> ** Using releases over hg/git downloads (please advise)
>> 
>> 1. Pyside2 packages - Done for compatibility reasons
>> 2. Coin3D and SoQt - I don't think there are releases of these aside from
>> the bitbucket repository.
> 
> https://bitbucket.org/Coin3D/coin/downloads/
> 
>> 3. LLVM propagated packages (llvm-toolchain and pyside-libcxx-headers)
>> - I am not sure these are the best way to accomplish the goal anyways.
>> - Not sure where to find the right sources for llvm-toolchain-6 and the
>> pyside-libcxx-headers.
>> 4. libarea - Seems like libarea is actually close to not even having source
>> available anymore, let alone a release
>> 5. libspnav - Confused as to the best source to use here. If there is a
>> release or better version, I can update.
> 
> This one:
> https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/libspnav#n13
> 
>> 6. FreeCAD
>> - I can use the releases if they exist. I do not think they have source
>> tarballs available.
>> - I was packaging during a lot of active development of FreeCAD
>> 
>> Thank you for your review and advice.
> 
> That's it from me at the moment. Strong work! Keep it up :)
> ~Jonathan

Message #41 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 36440 <at> debbugs.gnu.org, Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Wed, 24 Jul 2019 23:51:36 +0200

John Soo <jsoo1 <at> asu.edu> writes:

> *** 4.0.0 requires hdf5 >= 1.10.2
>
> **** HDF5 has some dependents:
>
> guix refresh --list-dependent hdf5 Building the following 11 packages would
> ensure 23 dependent packages are rebuilt:
> r-ioniser <at> 2.8.0 r-scone <at> 1.8.0 r-lumi <at> 2.36.0 r-yarn <at> 1.10.0
> r-illuminahumanmethylationepicmanifest <at> 0.3.0 r-scdd <at> 1.8.0 pigx <at> 0.0.3
> r-pore <at> 0.24 r-yamss <at> 1.10.0 r-xcms <at> 3.6.1 r-msnid <at> 1.18.0
>
> **** HDF5 patches need updates when HDF5 updated to 1.10.5

We do have a later version of HDF5: hdf5-1.10, that’s version 1.10.4.
Is this enough?

-- 
Ricardo

Message #44 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 36440 <at> debbugs.gnu.org, Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Wed, 24 Jul 2019 23:59:30 +0200

Hi John,

> I forgot to add some patches to start updating HDF5 with breaking builds.
> It seems like the patches will need an update to start.

This is probably not needed as we have the hdf5-1.10 variable, which
provides version 1.10.4.

-- 
Ricardo

Message #47 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: Paul Garlick <pgarlick <at> tourbillion-technology.com>
To: 36440 <at> debbugs.gnu.org
Subject: [PATCH] Add FreeCAD
Date: Tue, 30 Jul 2019 13:24:33 +0100

Hi John, Hi Guix,

Marvellous progress in packaging FreeCAD for Guix!

One of the dependencies is OpenCASCADE.  You may wish to switch the
opencascade-oce input to opencascade-occt, which is now available.  See
commit 37dc29200c44adc0474476b8df46ed44e8a1d41a.  The occt version is
more up-to-date than the oce version.

Best regards,

Paul.

Message #50 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Paul Garlick <pgarlick <at> tourbillion-technology.com>,
 John Soo <jsoo1 <at> asu.edu>
Cc: 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Mon, 02 Sep 2019 15:23:12 +0200

Hi John & all,

Paul Garlick <pgarlick <at> tourbillion-technology.com> skribis:

> Marvellous progress in packaging FreeCAD for Guix!
>
> One of the dependencies is OpenCASCADE.  You may wish to switch the
> opencascade-oce input to opencascade-occt, which is now available.  See
> commit 37dc29200c44adc0474476b8df46ed44e8a1d41a.  The occt version is
> more up-to-date than the oce version.

John, did you have a chance to look into that?  We’d rather not let the
patch gather too much dust.  :-)

Thanks,
Ludo’.

Message #53 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36440 <at> debbugs.gnu.org, Paul Garlick <pgarlick <at> tourbillion-technology.com>
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Mon, 2 Sep 2019 06:33:36 -0700

Hi!

Yes I’m sorry these patches are rather stale. I rebased them recently and addressed most of these issues. I got stuck working on the test questions. I will send what I have shortly. 

- John

> On Sep 2, 2019, at 6:23 AM, Ludovic Courtès <ludo <at> gnu.org> wrote:
> 
> Hi John & all,
> 
> Paul Garlick <pgarlick <at> tourbillion-technology.com> skribis:
> 
>> Marvellous progress in packaging FreeCAD for Guix!
>> 
>> One of the dependencies is OpenCASCADE.  You may wish to switch the
>> opencascade-oce input to opencascade-occt, which is now available.  See
>> commit 37dc29200c44adc0474476b8df46ed44e8a1d41a.  The occt version is
>> more up-to-date than the oce version.
> 
> John, did you have a chance to look into that?  We’d rather not let the
> patch gather too much dust.  :-)
> 
> Thanks,
> Ludo’.

Message #56 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36440 <at> debbugs.gnu.org, Paul Garlick <pgarlick <at> tourbillion-technology.com>
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Tue, 3 Sep 2019 05:22:50 +0000

[Message part 1 (text/plain, inline)]

Hi Ludo, Jonathon, Bjorn, RIcardo, Paul  and everyone,


* Paul:
> One of the dependencies is OpenCASCADE.  You may wish to switch the
> opencascade-oce input to opencascade-occt, which is now available.  See
> commit 37dc29200c44adc0474476b8df46ed44e8a1d41a.  The occt version is
> more up-to-date than the oce version.

I just tried building opencascade-occt and there was a failure in the test
suite: https://paste.debian.net/1098482/
I did replace opencascade-oce with occt in the hopes that it will have
better support in the future.
There is also the issue of the bundled (though heavily patched) SMESH
library. If I get some time soon, I can take another look at unbundling it.

* Bjorn and Jonathon, about qtwebkit:
> qtwebkit seems to fail on master as well and it needs long to build, so
> I can't do it locally on my laptop:
> It also seems that qtwebkit is failing to build in some cases for me now.
> http://ci.guix.gnu.org/build/1488065/details

I found qtwebkit failing for me, too, so I was unable to build freecad with
the most recent patches. The dependencies build ok though.

* Ricardo:
> We do have a later version of HDF5: hdf5-1.10, that’s version 1.10.4.
> Is this enough?

Yes it is, I used hdf5-1.10 for libmedfile.

> Do we really need SoQT?

I removed SoQT and freecad build properly before qtwebkit failed.

* Bjorn:
> medfile: Is there a specific reason you chose 3.x, instead of the
> available 4.0.0? If you, could you add a comment of why?

I was using what amounted to the pre-release of v4. I replaced with the
release version now that it is out.

> License is GPLv3+

I changed the license.

>libarea: Also licensed under GPL v3 (files under "pocket" directory).

I added this license instead

* Johnathon:
> - Maybe elaborate a bit more in the description, I have no idead what
> "lupdate, rcc and uic" is :P

I am sorry, I looked through the documentation and I don't know what they
are.

> - Is there a reason why we don't run the tests?

I recently tried to run the tests for all of the pyside tools (shiboken2,
pyside2, and pyside2-tools).
All fail to find libcxx files. I did not have a lot of time to work on it,
but I was successful in just using the official libcxx <at> 6.X without tests.
Strangely the issue only happens when building the tests.  I have added
FIXME where appropriate.
Previously I had a hand-rolled package strictly for the pyside2 toolchain
which I removed.

> - No newlines in the description after a sentence, just two whitespaces :)

Thank you, I fill-paragraphed.

> - description: What is a MED file?

I added much more detail from the salome-platform Med documentation.

> https://bitbucket.org/Coin3D/coin/downloads/
> ...
> This one:
>
https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/libspnav#n13

I used the releases for coin3D and libspnav. I am worried now about coin3D
because bitbucket is going to drop support for mercurial repos next year.


* Some further notes:
There are now several optional qt modules that are not correctly found when
building pyside2.
I am not sure if this is a bug with pyside or our packages.  The package
builds properly and freecad runs, though (supposing opencascade-occt will
work).

All the patches are rebased to a pretty recent master (just a day or so
ago). Thanks for all your help!

- John

[Message part 2 (text/html, inline)]

[0001-gnu-Add-coin3D.patch (text/x-patch, attachment)]

[0002-gnu-Add-llvm-toolchain-6.patch (text/x-patch, attachment)]

[0004-gnu-Add-libcxx-6.patch (text/x-patch, attachment)]

[0005-gnu-Add-python-pyside-2.patch (text/x-patch, attachment)]

[0003-gnu-Add-python-shiboken-2.patch (text/x-patch, attachment)]

[0006-gnu-Add-python-pyside-2-tools.patch (text/x-patch, attachment)]

[0008-gnu-Add-libarea.patch (text/x-patch, attachment)]

[0009-gnu-Add-libmedfile.patch (text/x-patch, attachment)]

[0010-gnu-Add-freecad.patch (text/x-patch, attachment)]

[0007-gnu-Add-libspnav.patch (text/x-patch, attachment)]

Message #59 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 36440 <at> debbugs.gnu.org, Paul Garlick <pgarlick <at> tourbillion-technology.com>
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Tue, 3 Sep 2019 15:10:49 +0000

[Message part 1 (text/plain, inline)]

Hi all,

One quick update.  I fixed the freecad patch which included a bad change
and rebased on master of today.
QtWebKit succeeded this time and with opencascade-oce freecad builds and
runs.
Switching to opencascade-occt does not build. It fails with `ld: cannot
find -lXmu` when building the PartDesigner module.

Thanks again,

John

On Tue, Sep 3, 2019 at 5:22 AM John Soo <jsoo1 <at> asu.edu> wrote:

> Hi Ludo, Jonathon, Bjorn, RIcardo, Paul  and everyone,
>
>
> * Paul:
> > One of the dependencies is OpenCASCADE.  You may wish to switch the
> > opencascade-oce input to opencascade-occt, which is now available.  See
> > commit 37dc29200c44adc0474476b8df46ed44e8a1d41a.  The occt version is
> > more up-to-date than the oce version.
>
> I just tried building opencascade-occt and there was a failure in the test
> suite: https://paste.debian.net/1098482/
> I did replace opencascade-oce with occt in the hopes that it will have
> better support in the future.
> There is also the issue of the bundled (though heavily patched) SMESH
> library. If I get some time soon, I can take another look at unbundling it.
>
> * Bjorn and Jonathon, about qtwebkit:
> > qtwebkit seems to fail on master as well and it needs long to build, so
> > I can't do it locally on my laptop:
> > It also seems that qtwebkit is failing to build in some cases for me now.
> > http://ci.guix.gnu.org/build/1488065/details
>
> I found qtwebkit failing for me, too, so I was unable to build freecad
> with the most recent patches. The dependencies build ok though.
>
> * Ricardo:
> > We do have a later version of HDF5: hdf5-1.10, that’s version 1.10.4.
> > Is this enough?
>
> Yes it is, I used hdf5-1.10 for libmedfile.
>
> > Do we really need SoQT?
>
> I removed SoQT and freecad build properly before qtwebkit failed.
>
> * Bjorn:
> > medfile: Is there a specific reason you chose 3.x, instead of the
> > available 4.0.0? If you, could you add a comment of why?
>
> I was using what amounted to the pre-release of v4. I replaced with the
> release version now that it is out.
>
> > License is GPLv3+
>
> I changed the license.
>
> >libarea: Also licensed under GPL v3 (files under "pocket" directory).
>
> I added this license instead
>
> * Johnathon:
> > - Maybe elaborate a bit more in the description, I have no idead what
> > "lupdate, rcc and uic" is :P
>
> I am sorry, I looked through the documentation and I don't know what they
> are.
>
> > - Is there a reason why we don't run the tests?
>
> I recently tried to run the tests for all of the pyside tools (shiboken2,
> pyside2, and pyside2-tools).
> All fail to find libcxx files. I did not have a lot of time to work on it,
> but I was successful in just using the official libcxx <at> 6.X without tests.
> Strangely the issue only happens when building the tests.  I have added
> FIXME where appropriate.
> Previously I had a hand-rolled package strictly for the pyside2 toolchain
> which I removed.
>
> > - No newlines in the description after a sentence, just two whitespaces
> :)
>
> Thank you, I fill-paragraphed.
>
> > - description: What is a MED file?
>
> I added much more detail from the salome-platform Med documentation.
>
> > https://bitbucket.org/Coin3D/coin/downloads/
> > ...
> > This one:
> >
> https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/libspnav#n13
>
> I used the releases for coin3D and libspnav. I am worried now about coin3D
> because bitbucket is going to drop support for mercurial repos next year.
>
>
> * Some further notes:
> There are now several optional qt modules that are not correctly found
> when building pyside2.
> I am not sure if this is a bug with pyside or our packages.  The package
> builds properly and freecad runs, though (supposing opencascade-occt will
> work).
>
> All the patches are rebased to a pretty recent master (just a day or so
> ago). Thanks for all your help!
>
> - John
>
>
>
>
>
>
>
>

[Message part 2 (text/html, inline)]

[0001-gnu-Add-coin3D.patch (text/x-patch, attachment)]

[0002-gnu-Add-llvm-toolchain-6.patch (text/x-patch, attachment)]

[0005-gnu-Add-python-pyside-2.patch (text/x-patch, attachment)]

[0004-gnu-Add-libcxx-6.patch (text/x-patch, attachment)]

[0003-gnu-Add-python-shiboken-2.patch (text/x-patch, attachment)]

[0006-gnu-Add-python-pyside-2-tools.patch (text/x-patch, attachment)]

[0008-gnu-Add-libarea.patch (text/x-patch, attachment)]

[0009-gnu-Add-libmedfile.patch (text/x-patch, attachment)]

[0010-gnu-Add-freecad.patch (text/x-patch, attachment)]

[0007-gnu-Add-libspnav.patch (text/x-patch, attachment)]

Message #62 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: Paul Garlick <pgarlick <at> tourbillion-technology.com>
To: John Soo <jsoo1 <at> asu.edu>, Ludovic Courtès <ludo <at> gnu.org>
Cc: 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Tue, 03 Sep 2019 20:45:33 +0100

Hi John,

> Switching to opencascade-occt does not build. It fails with `ld:
> cannot find -lXmu` when building the PartDesigner module.

libxmu is one of the opencascade-occt dependencies.  It might make
sense to propagate this input in the opencascade-occt package
definition.

Could you test whether FreeCAD builds successfully with a libxmu input?
There may be other dependencies that need to be propagated too.

Best regards,

Paul.

Message #65 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Paul Garlick <pgarlick <at> tourbillion-technology.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Wed, 4 Sep 2019 05:44:06 +0000

[Message part 1 (text/plain, inline)]

Hi Paul and everyone,

I added libxmu and libxi as inputs and that gets progress. I am not sure
whether we want to propagate them from opencascade-occt though. I can see
either way working well.

Now there is this error when building:

/tmp/guix-build-freecad-0.18.3.drv-0/source/src/Mod/Import/App/ImportOCAF.cpp:100:30:
fatal error: tbb/parallel_for.h: No such file or directory compilation
terminated.
make[2]: *** [src/Mod/Import/App/CMakeFiles/Import.dir/build.make:114:
src/Mod/Import/App/CMakeFiles/Import.dir/ImportOCAF.cpp.o] Error 1

Thanks again,

John


On Tue, Sep 3, 2019 at 7:45 PM Paul Garlick <
pgarlick <at> tourbillion-technology.com> wrote:

> Hi John,
>
> > Switching to opencascade-occt does not build. It fails with `ld:
> > cannot find -lXmu` when building the PartDesigner module.
>
> libxmu is one of the opencascade-occt dependencies.  It might make
> sense to propagate this input in the opencascade-occt package
> definition.
>
> Could you test whether FreeCAD builds successfully with a libxmu input?
> There may be other dependencies that need to be propagated too.
>
> Best regards,
>
> Paul.
>
>

[Message part 2 (text/html, inline)]

[0001-gnu-Add-coin3D.patch (text/x-patch, attachment)]

[0002-gnu-Add-llvm-toolchain-6.patch (text/x-patch, attachment)]

[0003-gnu-Add-python-shiboken-2.patch (text/x-patch, attachment)]

[0005-gnu-Add-python-pyside-2.patch (text/x-patch, attachment)]

[0004-gnu-Add-libcxx-6.patch (text/x-patch, attachment)]

[0007-gnu-Add-libspnav.patch (text/x-patch, attachment)]

[0006-gnu-Add-python-pyside-2-tools.patch (text/x-patch, attachment)]

[0008-gnu-Add-libarea.patch (text/x-patch, attachment)]

[0009-gnu-Add-libmedfile.patch (text/x-patch, attachment)]

[0010-gnu-Add-freecad.patch (text/x-patch, attachment)]

Message #68 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Paul Garlick <pgarlick <at> tourbillion-technology.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Wed, 4 Sep 2019 05:47:47 +0000

[Message part 1 (text/plain, inline)]

Oh wait, that's tbb, i will try with tbb as an input and report back.

On Wed, Sep 4, 2019 at 5:44 AM John Soo <jsoo1 <at> asu.edu> wrote:

> Hi Paul and everyone,
>
> I added libxmu and libxi as inputs and that gets progress. I am not sure
> whether we want to propagate them from opencascade-occt though. I can see
> either way working well.
>
> Now there is this error when building:
>
>
> /tmp/guix-build-freecad-0.18.3.drv-0/source/src/Mod/Import/App/ImportOCAF.cpp:100:30:
> fatal error: tbb/parallel_for.h: No such file or directory compilation
> terminated.
> make[2]: *** [src/Mod/Import/App/CMakeFiles/Import.dir/build.make:114:
> src/Mod/Import/App/CMakeFiles/Import.dir/ImportOCAF.cpp.o] Error 1
>
> Thanks again,
>
> John
>
>
> On Tue, Sep 3, 2019 at 7:45 PM Paul Garlick <
> pgarlick <at> tourbillion-technology.com> wrote:
>
>> Hi John,
>>
>> > Switching to opencascade-occt does not build. It fails with `ld:
>> > cannot find -lXmu` when building the PartDesigner module.
>>
>> libxmu is one of the opencascade-occt dependencies.  It might make
>> sense to propagate this input in the opencascade-occt package
>> definition.
>>
>> Could you test whether FreeCAD builds successfully with a libxmu input?
>> There may be other dependencies that need to be propagated too.
>>
>> Best regards,
>>
>> Paul.
>>
>>

[Message part 2 (text/html, inline)]

Message #71 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Paul Garlick <pgarlick <at> tourbillion-technology.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Wed, 4 Sep 2019 06:47:32 +0000

[Message part 1 (text/plain, inline)]

Ok FreeCAD now builds successfully with opencascade-occt!

What else is required to get this in?

Thanks everyone!

- John



On Wed, Sep 4, 2019 at 5:47 AM John Soo <jsoo1 <at> asu.edu> wrote:

> Oh wait, that's tbb, i will try with tbb as an input and report back.
>
> On Wed, Sep 4, 2019 at 5:44 AM John Soo <jsoo1 <at> asu.edu> wrote:
>
>> Hi Paul and everyone,
>>
>> I added libxmu and libxi as inputs and that gets progress. I am not sure
>> whether we want to propagate them from opencascade-occt though. I can see
>> either way working well.
>>
>> Now there is this error when building:
>>
>>
>> /tmp/guix-build-freecad-0.18.3.drv-0/source/src/Mod/Import/App/ImportOCAF.cpp:100:30:
>> fatal error: tbb/parallel_for.h: No such file or directory compilation
>> terminated.
>> make[2]: *** [src/Mod/Import/App/CMakeFiles/Import.dir/build.make:114:
>> src/Mod/Import/App/CMakeFiles/Import.dir/ImportOCAF.cpp.o] Error 1
>>
>> Thanks again,
>>
>> John
>>
>>
>> On Tue, Sep 3, 2019 at 7:45 PM Paul Garlick <
>> pgarlick <at> tourbillion-technology.com> wrote:
>>
>>> Hi John,
>>>
>>> > Switching to opencascade-occt does not build. It fails with `ld:
>>> > cannot find -lXmu` when building the PartDesigner module.
>>>
>>> libxmu is one of the opencascade-occt dependencies.  It might make
>>> sense to propagate this input in the opencascade-occt package
>>> definition.
>>>
>>> Could you test whether FreeCAD builds successfully with a libxmu input?
>>> There may be other dependencies that need to be propagated too.
>>>
>>> Best regards,
>>>
>>> Paul.
>>>
>>>

[Message part 2 (text/html, inline)]

[0001-gnu-Add-coin3D.patch (text/x-patch, attachment)]

[0002-gnu-Add-llvm-toolchain-6.patch (text/x-patch, attachment)]

[0003-gnu-Add-python-shiboken-2.patch (text/x-patch, attachment)]

[0004-gnu-Add-libcxx-6.patch (text/x-patch, attachment)]

[0005-gnu-Add-python-pyside-2.patch (text/x-patch, attachment)]

[0006-gnu-Add-python-pyside-2-tools.patch (text/x-patch, attachment)]

[0007-gnu-Add-libspnav.patch (text/x-patch, attachment)]

[0008-gnu-Add-libarea.patch (text/x-patch, attachment)]

[0009-gnu-Add-libmedfile.patch (text/x-patch, attachment)]

[0010-gnu-Add-freecad.patch (text/x-patch, attachment)]

Message #74 received at 36440 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Paul Garlick <pgarlick <at> tourbillion-technology.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 36440 <at> debbugs.gnu.org
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Wed, 11 Sep 2019 14:19:19 +0000

[Message part 1 (text/plain, inline)]

Hi all,

I rebased the patches on master. Thanks again!

- John

[Message part 2 (text/html, inline)]

[0001-gnu-Add-coin3D.patch (text/x-patch, attachment)]

[0003-gnu-Add-python-shiboken-2.patch (text/x-patch, attachment)]

[0002-gnu-Add-llvm-toolchain-6.patch (text/x-patch, attachment)]

[0005-gnu-Add-python-pyside-2.patch (text/x-patch, attachment)]

[0004-gnu-Add-libcxx-6.patch (text/x-patch, attachment)]

[0007-gnu-Add-libspnav.patch (text/x-patch, attachment)]

[0006-gnu-Add-python-pyside-2-tools.patch (text/x-patch, attachment)]

[0008-gnu-Add-libarea.patch (text/x-patch, attachment)]

[0010-gnu-Add-freecad.patch (text/x-patch, attachment)]

[0009-gnu-Add-libmedfile.patch (text/x-patch, attachment)]

Message #79 received at 36440-done <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 36440-done <at> debbugs.gnu.org,
 Paul Garlick <pgarlick <at> tourbillion-technology.com>
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Sun, 22 Sep 2019 09:09:18 +0200

[Message part 1 (text/plain, inline)]

On Wed, 11 Sep 2019 14:19:19 +0000
John Soo <jsoo1 <at> asu.edu> wrote:

> Hi all,
> 
> I rebased the patches on master. Thanks again!
> 
> - John

Hi John,

thanks for the efford you put into FreeCAD.

I pushed this as:

4cd9de6068f439c52f6874f00ec608c41156d095

with these changes:

I dropped the "llvm-toolchain-6" package, which is just a union-package
and instead used llvm-6 and clang-6 as inputs (Thanks to Ludo for
pointing at this).

libcxx-6: Left the description as inherited, added the speciality for
pyside2 as a comment.

libspnav: The linter had an issue with the sourceforge-sources? Then I
went directly to the github sources via git-fetch.

FreeCAD: Commented out the dependency on qtwebkit: It takes soo long to
compile and substitutes are rarely available.

Double-Checked licenses and fixed the ;;Help-comments on licenses field.

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #82 received at 36440-done <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 36440-done <at> debbugs.gnu.org,
 Paul Garlick <pgarlick <at> tourbillion-technology.com>
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Sun, 22 Sep 2019 16:00:36 +0000

[Message part 1 (text/plain, inline)]

Hi Bjorn!

Thank you so much!  Whew what a journey.

I am glad that the union package of llvm and clang could be separated. When
I was working on the package in the very beginning pyside2 would not build
without clang and llvm living in the same parent directory.

I did just run the program and it does not look like it is functioning the
way it should. With the last patchset I submitted, it did work properly. I
will investigate...

Thanks again, it's been a real pleasure working with you.

- John

[Message part 2 (text/html, inline)]

Message #85 received at 36440-done <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 36440-done <at> debbugs.gnu.org,
 Paul Garlick <pgarlick <at> tourbillion-technology.com>
Subject: Re: [bug#36440] [PATCH] Add FreeCAD
Date: Sun, 22 Sep 2019 19:50:03 +0200

[Message part 1 (text/plain, inline)]

Hi John,

On Sun, 22 Sep 2019 16:00:36 +0000
John Soo <jsoo1 <at> asu.edu> wrote:

> Thank you so much!  Whew what a journey.

I'm glad you went through that :-) I also wanted to do it in the first
place but then gave up because it was a bit hard and I had no longer
the priority to do so.

> I did just run the program and it does not look like it is
> functioning the way it should. With the last patchset I submitted, it
> did work properly. I will investigate...

what is not functioning at your side?

I started the program and it works for me (though I'm not yet familiar
with it, so I cannot say how exactly it SHOULD work :-)), otherwise I
wouldn't have pushed it.

What I can see is a red text on the Console:

No module named 'WebGui'

But that's of cause because I commented out the webkit. I still hope
this is more-or-less fine, otherwise we need to turn that on again.

What I noticed is that the binary is called "FreeCAD" and not
"freecad", that confused me first. I think that can be fixed with some
phase, but I couldn't quickly figure that out and I really didn't want
to postpone this any more.

Otherwise the first screen looks quite blank. But that's just a matter
of going through the menus:

View->Workbench->Part, etc. In that way, I was able to construct a
cylinder. Now I can no longer, but I think that's just because I forget
how to do it and I have to go through the tutorial again.

I also saw that Cuirass did not build it for x86 due to a dependency
problem, without saying what exactly went wrong:

https://ci.guix.gnu.org/build/1739605/details
https://ci.guix.gnu.org/build/1739601/details

For non-x86 it is even worse, some tests failed for some dependencies.
 
> Thanks again, it's been a real pleasure working with you.

Same for me.

Björn

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.