GNU bug report logs - #36446
[PATCH] Add grisbi

Previous Next

Package: guix-patches;

Reported by: Tanguy Le Carrour <tanguy <at> bioneland.org>

Date: Sun, 30 Jun 2019 15:45:02 UTC

Severity: normal

Tags: patch

Done: Timothy Sample <samplet <at> ngyro.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36446 in the body.
You can then email your comments to 36446 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#36446; Package guix-patches. (Sun, 30 Jun 2019 15:45:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tanguy Le Carrour <tanguy <at> bioneland.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 30 Jun 2019 15:45:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add grisbi
Date: Sun, 30 Jun 2019 13:54:45 +0200
---
 gnu/packages/finance.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index e1a1e8ab6f..d3e12c2618 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2018 Adriano Peluso <catonano <at> gmail.com>
 ;;; Copyright © 2018, 2019 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2018 Arun Isaac <arunisaac <at> systemreboot.net>
+;;; Copyright © 2019 Tanguy Le Carrour <tanguy <at> bioneland.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -35,6 +36,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system python)
+  #:use-module (guix build-system glib-or-gtk)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
   #:use-module (gnu packages boost)
@@ -45,9 +47,12 @@
   #:use-module (gnu packages dns)
   #:use-module (gnu packages emacs)
   #:use-module (gnu packages dbm)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages graphviz)
   #:use-module (gnu packages groff)
+  #:use-module (gnu packages gtk)
   #:use-module (gnu packages libedit)
   #:use-module (gnu packages libevent)
   #:use-module (gnu packages libunwind)
@@ -1028,3 +1033,38 @@ Its features are:
 @item get account amount.
 @end itemize")
     (license license:agpl3+)))
+
+(define-public grisbi
+  (package
+    (name "grisbi")
+    (version "1.2.2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append
+               "mirror://sourceforge/grisbi/grisbi%20stable/1.2.x"
+               "/" version "/grisbi-" version ".tar.bz2"))
+        (sha256
+          (base32
+            "1piiyyxjsjbw9gcqydvknzxmmfgh8kdqal12ywrxyxih2afwnvbw"))))
+    (build-system glib-or-gtk-build-system)
+    (arguments
+     `(#:configure-flags (list "--without-ofx")))
+    (propagated-inputs
+     `(("dconf" ,dconf)))
+    (native-inputs
+      `(("glib" ,glib "bin")             ; glib-compile-schemas
+        ("pkg-config" ,pkg-config)
+        ("intltool" ,intltool)))
+    (inputs
+      `(("gtk+" ,gtk+)
+        ("libgsf" ,libgsf)))
+    (synopsis "Personnal accounting application")
+    (description "Grisbi is an application written by French developers,
+so it perfectly respects French accounting rules.  Grisbi can manage
+multiple accounts, currencies and users.  It manages third party,
+expenditure and receipt categories, budgetary lines, financial years,
+budget estimates, bankcard management and other information that make Grisbi
+adapted for associations.")
+    (home-page "http://grisbi.org")
+    (license license:gpl2+)))
-- 
2.21.0






Information forwarded to guix-patches <at> gnu.org:
bug#36446; Package guix-patches. (Tue, 02 Jul 2019 09:34:01 GMT) Full text and rfc822 format available.

Message #8 received at 36446 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Tanguy Le Carrour <tanguy <at> bioneland.org>
Cc: 36446 <at> debbugs.gnu.org
Subject: Re: [bug#36446] [PATCH] Add grisbi
Date: Tue, 2 Jul 2019 12:33:17 +0300
[Message part 1 (text/plain, inline)]
I haven't checked the package, but one thing stood out to me:

On Sun, Jun 30, 2019 at 01:54:45PM +0200, Tanguy Le Carrour wrote:
> ---
> +    (version "1.2.2")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +               "mirror://sourceforge/grisbi/grisbi%20stable/1.2.x"

1.2.x could instead be:
(verion-major+minor version) ".x"

> +               "/" version "/grisbi-" version ".tar.bz2"))
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#36446; Package guix-patches. (Wed, 03 Jul 2019 12:40:02 GMT) Full text and rfc822 format available.

Message #11 received at 36446 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 36446 <at> debbugs.gnu.org
Subject: Re: [bug#36446] [PATCH] Add grisbi
Date: Wed, 3 Jul 2019 09:00:11 +0200
Le 07/02, Efraim Flashner a écrit :
> I haven't checked the package, but one thing stood out to me:
> 
> On Sun, Jun 30, 2019 at 01:54:45PM +0200, Tanguy Le Carrour wrote:
> > ---
> > +    (version "1.2.2")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (string-append
> > +               "mirror://sourceforge/grisbi/grisbi%20stable/1.2.x"
> 
> 1.2.x could instead be:
> (verion-major+minor version) ".x"

Thanks for the tip! I didn't know about this one, but it makes perfect
sense!
Am I supposed to update my patch and re-submit it? (sorry, newbie! ^_^')

-- 
Tanguy




Information forwarded to guix-patches <at> gnu.org:
bug#36446; Package guix-patches. (Sun, 07 Jul 2019 15:41:01 GMT) Full text and rfc822 format available.

Message #14 received at 36446 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 36446 <at> debbugs.gnu.org
Subject: Re: [bug#36446] [PATCH] Add grisbi
Date: Sun, 7 Jul 2019 17:40:44 +0200
Thanks again for reading it. Here is the updated (and rebased) version.

---
 gnu/packages/finance.scm | 41 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 550354b650..c0a56f5180 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2018, 2019 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2018 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2019 Guillaume Le Vaillant <glv <at> posteo.net>
+;;; Copyright © 2019 Tanguy Le Carrour <tanguy <at> bioneland.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -36,6 +37,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system python)
+  #:use-module (guix build-system glib-or-gtk)
+  #:use-module (guix utils)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
   #:use-module (gnu packages boost)
@@ -47,9 +49,12 @@
   #:use-module (gnu packages dns)
   #:use-module (gnu packages emacs)
   #:use-module (gnu packages dbm)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages glib)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages graphviz)
   #:use-module (gnu packages groff)
+  #:use-module (gnu packages gtk)
   #:use-module (gnu packages libedit)
   #:use-module (gnu packages libevent)
   #:use-module (gnu packages libunwind)
@@ -1050,3 +1055,39 @@ Its features are:
 @item get account amount.
 @end itemize")
     (license license:agpl3+)))
+
+(define-public grisbi
+  (package
+    (name "grisbi")
+    (version "1.2.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://sourceforge/grisbi/grisbi%20stable"
+             "/" (version-major+minor version) ".x"
+             "/" version "/grisbi-" version ".tar.bz2"))
+       (sha256
+        (base32
+         "1piiyyxjsjbw9gcqydvknzxmmfgh8kdqal12ywrxyxih2afwnvbw"))))
+    (build-system glib-or-gtk-build-system)
+    (arguments
+     `(#:configure-flags (list "--without-ofx")))
+    (propagated-inputs
+     `(("dconf" ,dconf)))
+    (native-inputs
+     `(("glib" ,glib "bin")             ; glib-compile-schemas
+       ("pkg-config" ,pkg-config)
+       ("intltool" ,intltool)))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("libgsf" ,libgsf)))
+    (synopsis "Personnal accounting application")
+    (description "Grisbi is an application written by French developers,
+so it perfectly respects French accounting rules.  Grisbi can manage
+multiple accounts, currencies and users.  It manages third party,
+expenditure and receipt categories, budgetary lines, financial years,
+budget estimates, bankcard management and other information that make Grisbi
+adapted for associations.")
+    (home-page "http://grisbi.org")
+    (license license:gpl2+)))
-- 
2.22.0


-- 
Tanguy




Reply sent to Timothy Sample <samplet <at> ngyro.com>:
You have taken responsibility. (Fri, 12 Jul 2019 16:28:01 GMT) Full text and rfc822 format available.

Notification sent to Tanguy Le Carrour <tanguy <at> bioneland.org>:
bug acknowledged by developer. (Fri, 12 Jul 2019 16:28:02 GMT) Full text and rfc822 format available.

Message #19 received at 36446-done <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: Tanguy Le Carrour <tanguy <at> bioneland.org>
Cc: 36446-done <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#36446] [PATCH] Add grisbi
Date: Fri, 12 Jul 2019 12:26:53 -0400
Hi Tanguy,

Tanguy Le Carrour <tanguy <at> bioneland.org> writes:

> Thanks again for reading it. Here is the updated (and rebased) version.

With the minor changes to the synopsis and description that I mentioned
before, I pushed this as 90bb244f29cacba8a098c07cd7c19a77d16f6cfb.

Thanks!

(As a note for the future, please be sure your patches apply.  I had to
fix the boundaries on one of the hunks.)


-- Tim




Information forwarded to guix-patches <at> gnu.org:
bug#36446; Package guix-patches. (Mon, 15 Jul 2019 06:56:01 GMT) Full text and rfc822 format available.

Message #22 received at 36446-done <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: Timothy Sample <samplet <at> ngyro.com>
Cc: 36446-done <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#36446] [PATCH] Add grisbi
Date: Mon, 15 Jul 2019 08:55:37 +0200
Hi Timothy,

Le 07/12, Timothy Sample a écrit :
> Tanguy Le Carrour <tanguy <at> bioneland.org> writes:
> With the minor changes to the synopsis and description that I mentioned
> before, I pushed this as 90bb244f29cacba8a098c07cd7c19a77d16f6cfb.

Thank you so much for that!

> (As a note for the future, please be sure your patches apply.  I had to
> fix the boundaries on one of the hunks.)

I'm really sorry to hear that! I'll do my best next time not to give you
extra work!

Best regards!

-- 
Tanguy




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 12 Aug 2019 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 257 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.