GNU bug report logs - #36485
[PATCH] Improve some menus with separators and better wording

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 36485 in the body.
You can then email your comments to 36485 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Improve some menus with separators and better wording
Date: Wed, 3 Jul 2019 09:17:42 +0200

[Message part 1 (text/plain, inline)]

Just a small patch to add menu separators to some menus that are
missing them.

Also fix a typo and improves the wording in the help-mode-menu, and
remove a duplicate entry in the eww menu.

Thanks,
Stefan Kangas

[0001-Improve-some-menus-with-separators-and-better-wordin.patch (application/octet-stream, attachment)]

Message #8 received at 36485 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 36485 <at> debbugs.gnu.org
Subject: Re: bug#36485: [PATCH] Improve some menus with separators and better
 wording
Date: Wed, 03 Jul 2019 13:40:29 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Wed, 3 Jul 2019 09:17:42 +0200
> 
> Just a small patch to add menu separators to some menus that are
> missing them.

What were the criteria for determining that a separator is missing in
a particular place?

Adding separators makes the menus longer, which could be a problem,
especially on TTY frames with a small number of lines (like 24).  So
we need to add them judiciously.

>      ["Previous Topic" help-go-back
> -     :help "Go back to previous topic in this help buffer"]
> +     :help "Go back to previously visited topic"]
>      ["Next Topic" help-go-forward
> -     :help "Go back to next topic in this help buffer"]
> +     :help "Go back to next visited topic"]

These changes lose information, because there could be more than on
Info buffer in an Emacs session.  Any particular reason you thought we
should remove the "this help buffer" part?

>      (easy-menu-define nil map ""
>        '("Eww"
> -	["Exit" quit-window t]
>  	["Close browser" quit-window t]

Why did you want to remove the "Exit" item?

Thanks.

Message #11 received at 36485 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36485 <at> debbugs.gnu.org, Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#36485: [PATCH] Improve some menus with separators and better
 wording
Date: Thu, 04 Jul 2019 23:14:56 +0300

>> Just a small patch to add menu separators to some menus that are
>> missing them.
>
> What were the criteria for determining that a separator is missing in
> a particular place?
>
> Adding separators makes the menus longer, which could be a problem,
> especially on TTY frames with a small number of lines (like 24).  So
> we need to add them judiciously.

Rather than adding separators we could try to group parts of the menus
into submenus.

Message #14 received at 36485 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 36485 <at> debbugs.gnu.org
Subject: Re: bug#36485: [PATCH] Improve some menus with separators and better
 wording
Date: Fri, 13 Sep 2019 20:57:24 +0200

tags 36485 + fixed
close 36485 27.1
close

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Kangas <stefan <at> marxist.se>
>> Date: Wed, 3 Jul 2019 09:17:42 +0200
>>
>> Just a small patch to add menu separators to some menus that are
>> missing them.
>
> What were the criteria for determining that a separator is missing in
> a particular place?
>
> Adding separators makes the menus longer, which could be a problem,
> especially on TTY frames with a small number of lines (like 24).  So
> we need to add them judiciously.

Thanks for reviewing the change.  Looking back at the suggestion, my
criteria were admittedly pretty ad hoc, and I had completely forgotten
about the menu on the console.

Taking another look now, I think the only important change here is a
typo which I fixed in commit 224534ab8d.

With that, I'm closing this bug report.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.