GNU bug report logs - #36526
26.2; Open diff at current location (feature request with suggested code)

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Campbell Barton <ideasman42@HIDDEN>; dated Sat, 6 Jul 2019 13:09:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Removed tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 17 Nov 2020 21:03:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 17 16:03:10 2020
Received: from localhost ([127.0.0.1]:33112 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kf885-0008Nu-Qm
	for submit <at> debbugs.gnu.org; Tue, 17 Nov 2020 16:03:10 -0500
Received: from mail-ed1-f45.google.com ([209.85.208.45]:41279)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1kf883-0008NU-5D
 for 36526 <at> debbugs.gnu.org; Tue, 17 Nov 2020 16:03:08 -0500
Received: by mail-ed1-f45.google.com with SMTP id t9so23971996edq.8
 for <36526 <at> debbugs.gnu.org>; Tue, 17 Nov 2020 13:03:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=WruHredCX4aT0gtIzwbFfyyV7nQZXke0EU+z+b55o/s=;
 b=JEwLdQ1ysk1yyHpVqf7j/DX3eO2JzVg0+KyX92ooCkqqrdEtB4DP83A8lPoVXRo+7N
 mYt8ISiNQcQymRRjJZ7GsXrOx2fOsfRIyJr6n6Fym1mQFtVQLBByjmnE0a8yvr8icMMf
 W6sLOjpstAhaKr+Pc3JsVqr5+udkEfwXQcDQNDzVHKmJj536SSSU1oMSOphn6+kS4U02
 ItGiPx3rwnm90Yd+XWjbvUFExhHQnYi6rxHJfXAohYD9OIgc/t2Ky///XRijGuOIs2pT
 zxGa/iSICMGeI5cXvafA4e5qCzZuEAcEU8hRr7Fiuqy33KgLLxHc7a06LzAzb7nRCjbP
 YVqA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
 :date:user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=WruHredCX4aT0gtIzwbFfyyV7nQZXke0EU+z+b55o/s=;
 b=L0fMnpSa5AkNSIie/fa6AnR6ZTv9UHC/yYWG4lnDD311ySAQB/7aVFxOPG9wGreVlo
 uPgozoBceiTbZK0yAzOw3kyXKetsMVnEfLLU+AvUuUnGQIg9341jiZYrnggwcF85nTfU
 7Jxt19P3/LFq7DcMXlhmim7kR6psjGWZ4Apl//CHgyaIRhqiF+HcmRAMSwqcJffKWkgv
 6q7gib3uFtH/2/8ER3lj6UmcamKd1oovT3v5UZWp6JF08Fkl9Y+yqItEx/KgLuhvdhdp
 E9c5qIGnSw9NwOPnsxMI+UUzcsOCbiHnKbS1Nd2qpUi/yAXpqHeZSymGBEUZjFWYMwjw
 TAeg==
X-Gm-Message-State: AOAM531YRv0YQ1S6blTXmd/QleNk1kExPdgTO+SKR9uBlBFKWepGZyzF
 8iPRSbEXfQ+adAVtkwQAusd4mS64zO97UQ==
X-Google-Smtp-Source: ABdhPJy2hGR5Bj/rUxW/uXI7PsOL+g/r5o298Wqr3H1JuBsXOGX876WkR9SpbX4i7btaiHnwkTUF7w==
X-Received: by 2002:aa7:d3cc:: with SMTP id o12mr23126010edr.36.1605646981143; 
 Tue, 17 Nov 2020 13:03:01 -0800 (PST)
Received: from [192.168.0.4] ([66.205.71.3])
 by smtp.googlemail.com with ESMTPSA id h23sm12377163edv.69.2020.11.17.13.02.59
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 17 Nov 2020 13:03:00 -0800 (PST)
Subject: Re: bug#36526: Previous work on this subject
To: Juri Linkov <juri@HIDDEN>
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <596a40818c2b43fa9f645315e308ee5a@HIDDEN> <87blfx0zwn.fsf@HIDDEN>
 <bcb7f076-a6c7-cb6e-dfa3-bc705437a2ab@HIDDEN>
 <87wnyl6jr5.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <2a515b46-e2d5-4e41-6144-b11f4fc799e1@HIDDEN>
Date: Tue, 17 Nov 2020 23:02:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <87wnyl6jr5.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 36526
Cc: "Herring, Davis" <herring@HIDDEN>,
 "36526 <at> debbugs.gnu.org" <36526 <at> debbugs.gnu.org>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

On 17.11.2020 00:04, Juri Linkov wrote:
>>> Thanks, this is the most advanced implementation among several others.
>>> I tried it, and it does everything needed, and the code is quite compact.
>>> So I recommend to install this useful feature from the patches above.
>>
>> Could someone outline briefly how it compares to the implementation in
>> 'diff-hl-diff-skip-to'?
> 
> Improvements:
> 1. support context diffs;

IIUC that part is concentrated in the patch #1. So it should be possible 
to swap out patch #2 for the impl in diff-hl-diff-skip-to. *If* that is 
a good idea.

> 2. support multiple files in the same patch (e.g. by C-x v D);

Interesting. Personally, it's a context where I wouldn't expect this new 
behavior (when invoking the repo-wide diff, I expect to see a full 
overview and be able to page through it without calling 
beginning-of-buffer first). But to be fair, I haven't tried it in 
practice yet.

So if the implementation is smart enough and you like both aspects of 
the new behavior, don't mind me. Looking forward to seeing it in action.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 16 Nov 2020 22:05:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 16 17:05:16 2020
Received: from localhost ([127.0.0.1]:57579 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kemce-0007Pn-EU
	for submit <at> debbugs.gnu.org; Mon, 16 Nov 2020 17:05:16 -0500
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:33461)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1kemcb-0007PY-JO
 for 36526 <at> debbugs.gnu.org; Mon, 16 Nov 2020 17:05:15 -0500
X-Originating-IP: 91.129.97.46
Received: from mail.gandi.net (m91-129-97-46.cust.tele2.ee [91.129.97.46])
 (Authenticated sender: juri@HIDDEN)
 by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B02D8E0003;
 Mon, 16 Nov 2020 22:05:05 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#36526: Previous work on this subject
Organization: LINKOV.NET
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <596a40818c2b43fa9f645315e308ee5a@HIDDEN>
 <87blfx0zwn.fsf@HIDDEN>
 <bcb7f076-a6c7-cb6e-dfa3-bc705437a2ab@HIDDEN>
Date: Tue, 17 Nov 2020 00:04:46 +0200
In-Reply-To: <bcb7f076-a6c7-cb6e-dfa3-bc705437a2ab@HIDDEN> (Dmitry Gutov's
 message of "Mon, 16 Nov 2020 23:29:23 +0200")
Message-ID: <87wnyl6jr5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36526
Cc: "Herring, Davis" <herring@HIDDEN>,
 "36526 <at> debbugs.gnu.org" <36526 <at> debbugs.gnu.org>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

>> Thanks, this is the most advanced implementation among several others.
>> I tried it, and it does everything needed, and the code is quite compact.
>> So I recommend to install this useful feature from the patches above.
>
> Could someone outline briefly how it compares to the implementation in
> 'diff-hl-diff-skip-to'?

Improvements:
1. support context diffs;
2. support multiple files in the same patch (e.g. by C-x v D);




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 16 Nov 2020 21:29:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 16 16:29:34 2020
Received: from localhost ([127.0.0.1]:57534 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kem46-0004O9-3N
	for submit <at> debbugs.gnu.org; Mon, 16 Nov 2020 16:29:34 -0500
Received: from mail-ej1-f52.google.com ([209.85.218.52]:35250)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1kem44-0004Nv-3H
 for 36526 <at> debbugs.gnu.org; Mon, 16 Nov 2020 16:29:33 -0500
Received: by mail-ej1-f52.google.com with SMTP id f23so26550261ejk.2
 for <36526 <at> debbugs.gnu.org>; Mon, 16 Nov 2020 13:29:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=3UcCdCTIp1JqfjZnIdVbdrV+9odETyERcHL210AyLe0=;
 b=myWdl6x9DdGd9LCw27i88Wo3Y1tFxdKLzUuhz0PmRhonCaJPYwTOB9V5qxfo60GRD5
 Q1zfEaph+fY07Poa/nRNDy22h0VHqjCSPt82q8Xqfj+P8PQkrZ5z40nQQTNk0upgCEtK
 rM1cBCb/1CUJWB8Q0tEG2ak33rxUUW4FTtpvgBCTDX23ce+CCwlDTU+keLImNrMP+4p5
 qyqjV7G+SJpyVEqh/Sjh2+jPUooSwfnaXfYdT/OyAYH9wzJdNI9wrjW9YPGuGzQsaQNe
 F9jo/p+LaKPhntIxwbjbxb1qP9UcUjfHb7KLoIvvf9/m3ebq4aUGuovkVmHLbZJLkXxB
 QTSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
 :date:user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=3UcCdCTIp1JqfjZnIdVbdrV+9odETyERcHL210AyLe0=;
 b=atULb8hLYTRJsNfmqSLf3PLjIUyT1TC13rzMFBlPGiZF/RUwh6tWyikqWZyDimRySH
 VswTOPkBMKNgkuH7D/bsJN7PMlfdMJi6R1DOBbcityfx05QOnxUBDGEeb+sb+14pQ5mC
 tTO2yGSEjHUmqxPDm3dCJx6aPsATkHlie2XZNk/kX2lFnOYizdR7D/Xxf1enpfvZ0tbJ
 t7IbM8FnPxwKGju2CEk//3Ue+W2oChOyHyr9tTqTEf8eZugZICLFricXTQFDHd5U4Hn5
 I/ED9CVmR5KDm+xivNO6+gl400WTvXY5bkwHEkvNkcDsz30+fSZSSOQ2qbbxF4+kFXNY
 aMoQ==
X-Gm-Message-State: AOAM532lLyQhkWK/oWe25J8Wc+NTNY/0UhJcikfJ3sYRL1pNLMA7Z7qi
 9YvO8njmGvG9NiUTONptsm1ruICFUIS6LQ==
X-Google-Smtp-Source: ABdhPJzO8+oephcY8nmGlm5qXrkOSTCmCI6BAuU9p/wFZNYmzPgQ5rhFKldtteOruNauoE+wwrY7zQ==
X-Received: by 2002:a17:906:9414:: with SMTP id
 q20mr15932711ejx.384.1605562165964; 
 Mon, 16 Nov 2020 13:29:25 -0800 (PST)
Received: from [192.168.0.4] ([66.205.71.3])
 by smtp.googlemail.com with ESMTPSA id l25sm11378154eds.65.2020.11.16.13.29.24
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 16 Nov 2020 13:29:25 -0800 (PST)
Subject: Re: bug#36526: Previous work on this subject
To: Juri Linkov <juri@HIDDEN>, "Herring, Davis" <herring@HIDDEN>
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <596a40818c2b43fa9f645315e308ee5a@HIDDEN> <87blfx0zwn.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <bcb7f076-a6c7-cb6e-dfa3-bc705437a2ab@HIDDEN>
Date: Mon, 16 Nov 2020 23:29:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <87blfx0zwn.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 36526
Cc: "36526 <at> debbugs.gnu.org" <36526 <at> debbugs.gnu.org>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

On 16.11.2020 23:12, Juri Linkov wrote:
> Thanks, this is the most advanced implementation among several others.
> I tried it, and it does everything needed, and the code is quite compact.
> So I recommend to install this useful feature from the patches above.

Could someone outline briefly how it compares to the implementation in 
'diff-hl-diff-skip-to'?

If nothing else, that one seems shorter.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 16 Nov 2020 21:16:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 16 16:16:00 2020
Received: from localhost ([127.0.0.1]:57526 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kelqy-00043H-JR
	for submit <at> debbugs.gnu.org; Mon, 16 Nov 2020 16:16:00 -0500
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:37211)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1kelqv-000431-HD
 for 36526 <at> debbugs.gnu.org; Mon, 16 Nov 2020 16:16:00 -0500
X-Originating-IP: 91.129.97.46
Received: from mail.gandi.net (m91-129-97-46.cust.tele2.ee [91.129.97.46])
 (Authenticated sender: juri@HIDDEN)
 by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 91FDA1BF203;
 Mon, 16 Nov 2020 21:15:49 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: "Herring, Davis" <herring@HIDDEN>
Subject: Re: bug#36526: Previous work on this subject
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <596a40818c2b43fa9f645315e308ee5a@HIDDEN>
Date: Mon, 16 Nov 2020 23:12:24 +0200
In-Reply-To: <596a40818c2b43fa9f645315e308ee5a@HIDDEN> (Davis Herring's
 message of "Sat, 17 Oct 2020 06:00:53 +0000")
Message-ID: <87blfx0zwn.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 36526
Cc: "36526 <at> debbugs.gnu.org" <36526 <at> debbugs.gnu.org>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> [Please CC me; I'm subscribed to devel, not bugs.
> Also, hopefully DMARC doesn't mess anyone up here.]
>
> I wrote a version of this feature before; at the time, the list wasn't
> convinced of the motivation, but there seems to be some more interest
> since.  The patch still applies and works; I'd be glad to update it
> further for inclusion.
>
> https://lists.gnu.org/archive/html/emacs-devel/2016-02/msg01066.html

Thanks, this is the most advanced implementation among several others.
I tried it, and it does everything needed, and the code is quite compact.
So I recommend to install this useful feature from the patches above.

PS: I noticed some minor issues that could be improved afterwards.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 17 Oct 2020 06:01:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 17 02:01:03 2020
Received: from localhost ([127.0.0.1]:33076 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kTfH4-000308-NY
	for submit <at> debbugs.gnu.org; Sat, 17 Oct 2020 02:01:02 -0400
Received: from proofpoint8.lanl.gov ([204.121.3.47]:43526)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <herring@HIDDEN>) id 1kTfH1-0002zR-Sb
 for 36526 <at> debbugs.gnu.org; Sat, 17 Oct 2020 02:01:00 -0400
Received: from pps.filterd (proofpoint8.lanl.gov [127.0.0.1])
 by proofpoint8.lanl.gov (8.16.0.22/8.16.0.22) with SMTP id 09H5qVW3093443
 for <36526 <at> debbugs.gnu.org>; Sat, 17 Oct 2020 00:00:53 -0600
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lanl.gov;
 h=from : to : subject :
 date : message-id : content-type : content-transfer-encoding :
 mime-version; s=lanl; bh=tIgqgilwA07d73rbg3wlEaxXBGqoZlltAlam9GhSnQM=;
 b=VwrowAH+97Ak7unxK9TRdV6v9fu5L56gEY+DtpqzAGjrGMok0ODhksFX/RxTEBiFFfXQ
 87+7KKJLkhIhs+UmN+K/H0sszYKieYiKB1uqaPNefLJoTfgCxEmSyCEJfs9saqkKTG5Z
 aYpekVAoMFq1/CUOhXy+9yoWOE6hwDQi00tbDK1Pp3ooiS5gPwfFRzrFMx2dcsozWEXq
 ULMaH5i8hxr4WrqVoOCC4DGv65EBgXGIQlYHvXKokfurRN9EQsEGstuaewnwDzPmASjv
 rLnpQjzG8s16oYQjXkeiQy44J+ja/urItZMIfiNypKogF6BB0n19DADc/W7nDsaDxgd4 Ag== 
Received: from mailrelay2.lanl.gov (mailrelay2.lanl.gov [128.165.4.103])
 by proofpoint8.lanl.gov with ESMTP id 347fc61ukr-1
 for <36526 <at> debbugs.gnu.org>; Sat, 17 Oct 2020 00:00:53 -0600
Received: from localhost (localhost [127.0.0.1])
 by mailrelay2.lanl.gov (Postfix) with ESMTP id 8D0E2100A709
 for <36526 <at> debbugs.gnu.org>; Sat, 17 Oct 2020 00:00:53 -0600 (MDT)
X-NIE-2-Virus-Scanner: amavisd-new at mailrelay2.lanl.gov
Received: from EXG16-P-MBX08.win.lanl.gov (exg16-p-mbx08.win.lanl.gov
 [128.165.106.188])
 by mailrelay2.lanl.gov (Postfix) with ESMTP id 7C227100A6FE
 for <36526 <at> debbugs.gnu.org>; Sat, 17 Oct 2020 00:00:53 -0600 (MDT)
Received: from EXG16-P-MBX03.win.lanl.gov (128.165.106.183) by
 EXG16-P-MBX08.win.lanl.gov (128.165.106.188) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2106.2; Sat, 17 Oct 2020 00:00:53 -0600
Received: from EXG16-P-MBX03.win.lanl.gov ([fe80::e860:13d9:aa1e:3730]) by
 EXG16-P-MBX03.win.lanl.gov ([fe80::e860:13d9:aa1e:3730%2]) with mapi id
 15.01.2106.003; Sat, 17 Oct 2020 00:00:53 -0600
From: "Herring, Davis" <herring@HIDDEN>
To: "36526 <at> debbugs.gnu.org" <36526 <at> debbugs.gnu.org>
Subject: Previous work on this subject
Thread-Topic: Previous work on this subject
Thread-Index: AQHWpEnxrlW29XWtHkGBBkVAXk2+YQ==
Date: Sat, 17 Oct 2020 06:00:53 +0000
Message-ID: <596a40818c2b43fa9f645315e308ee5a@HIDDEN>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [128.165.106.203]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687
 definitions=2020-10-17_03:2020-10-16,
 2020-10-17 signatures=0
X-Proofpoint-Spam-Reason: safe
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 36526
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

[Please CC me; I'm subscribed to devel, not bugs.  Also, hopefully DMARC do=
esn't mess anyone up here.]

I wrote a version of this feature before; at the time, the list wasn't conv=
inced of the motivation, but there seems to be some more interest since.  T=
he patch still applies and works; I'd be glad to update it further for incl=
usion.

https://lists.gnu.org/archive/html/emacs-devel/2016-02/msg01066.html

Davis=




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.
Removed tag(s) patch. Request was from Lars Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 15 Aug 2020 13:13:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 15 09:13:02 2020
Received: from localhost ([127.0.0.1]:54431 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1k6vza-00036d-2A
	for submit <at> debbugs.gnu.org; Sat, 15 Aug 2020 09:13:02 -0400
Received: from quimby.gnus.org ([95.216.78.240]:53812)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1k6vzX-000362-2a
 for 36526 <at> debbugs.gnu.org; Sat, 15 Aug 2020 09:13:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=DCSsUAWiaPFv9vp36sP1g/5nxNjAln+3H3B78FTqCMI=; b=vVwCj7odBhuk3DOWifyiek1DnG
 1WdUH7RCd6DegYqyWKce54uO9PC8qf16kc/oAags+g4thZql4JSpqx8MrlpUtPjifwxME41ZERYVK
 iXpIoyDqHY/7PqUn/HdML6JRm+wTCx6U5jojUwpgHeevHZ3P/YcHD4cxyztuodWPx860=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
 by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1k6vzN-0007pi-6r; Sat, 15 Aug 2020 15:12:51 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Campbell Barton <ideasman42@HIDDEN>
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
 <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
 <875zk3t7ji.fsf@HIDDEN>
 <d280700425f27faa160ea920360a5fca26123061.camel@HIDDEN>
X-Now-Playing: Mega Bog's _Dolphine_: "For The Old World"
Date: Sat, 15 Aug 2020 15:12:47 +0200
In-Reply-To: <d280700425f27faa160ea920360a5fca26123061.camel@HIDDEN>
 (Campbell Barton's message of "Fri, 27 Dec 2019 19:18:15 +1100")
Message-ID: <874kp4xdbk.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  Campbell Barton <ideasman42@HIDDEN> writes: > If there
 is interest, I'm happy to create a patch and other steps > needed to have
 in added into emacs. Campbell,
 have you had a chance to look at Dmitry's suggestion?
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36526
Cc: Stefan Kangas <stefan@HIDDEN>, 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Campbell Barton <ideasman42@HIDDEN> writes:

> If there is interest, I'm happy to create a patch and other steps
> needed to have in added into emacs.  

Campbell, have you had a chance to look at Dmitry's suggestion?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 10 Aug 2020 10:52:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 10 06:52:54 2020
Received: from localhost ([127.0.0.1]:34608 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1k55QE-0007Oy-A2
	for submit <at> debbugs.gnu.org; Mon, 10 Aug 2020 06:52:54 -0400
Received: from mail-ej1-f52.google.com ([209.85.218.52]:34515)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1k55QC-0007Oe-Bi
 for 36526 <at> debbugs.gnu.org; Mon, 10 Aug 2020 06:52:52 -0400
Received: by mail-ej1-f52.google.com with SMTP id o23so8890091ejr.1
 for <36526 <at> debbugs.gnu.org>; Mon, 10 Aug 2020 03:52:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=pcguhSCot5/aqmmrG6KQVbGUnUfQSoMEMxunWVP+/+Q=;
 b=WacADur5KmRFTXv1/IRoO2mKh+/XN/KopVsZULH4+f1HBq5JhiQx9HZq6mYwMPNdkZ
 rbQJ+NQgZvnleBda2zTSmtkrqD0TGsx21U1Dpze+FZZXHQJw39zMaA9ontJVb6IPgz/Q
 yEvuuP0zzLjl9qzI8cuaMEGOihWNnPJ89erut2mJxwm0F3PyUi4GQzq/bCGKDl1A7fyg
 gQggJJcY5ablEy4jR0rQ2Z2INCwmzkw8t6S9sD8rjIdcrWisWINiAXnElPn+BkRL56gB
 NXsIQr1Uq1ltrCuk4odCEnkdzxGZ9vTXvzVvVI0ZUZ+ttqbsezldCeOY8eMnCBvoWYhJ
 4h5A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
 :date:user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=pcguhSCot5/aqmmrG6KQVbGUnUfQSoMEMxunWVP+/+Q=;
 b=q/3oyzJCsNeM/3cKPxaqhiAfl/ElUwiy579zB+2u7ROWuyEAx7RutFxEAtqIv0v4eG
 B7m6wM6Aos6ogB7W6ou4GH2JM0xZS3tdv/gAmxyXPeRrKXL5Vxg7ymF5up+G12lDy7ZG
 Icfq8Nzj4ACyunRcSJp9ZSqSZWqRNnlLWTs4LK4lT5AB3KGEnbJgr81nmu9DSlrf0Ej5
 c5UPZeQv0jFUD1cyoBR23qFvmXCdBEK9LhhSa8F8T8fgMZ9fKx+l7m+fJyYxdPZg8/As
 3rSikYamTc6cBfejTE+fgylbR8n2jv5BKocTH2Ln8Qp085n1/RJQgWgtTVv5c9eCjRkW
 Ze1A==
X-Gm-Message-State: AOAM532cQm2xAo6bIHe3UYURAjottkyAoTMSwyh8rLkurFvUJ9t/gA2B
 P9prp7Btp2nmwBxjS0Y+Fo2smkSP
X-Google-Smtp-Source: ABdhPJw7fUKeT8Yuo9XhFqohfFw05udkSwSMyeeZ8o6XcwiudkyxOsE47ckHn3YQdgEaj18/qDJuOw==
X-Received: by 2002:a17:906:82c1:: with SMTP id
 a1mr20922405ejy.172.1597056766402; 
 Mon, 10 Aug 2020 03:52:46 -0700 (PDT)
Received: from [192.168.0.3] ([66.205.73.129])
 by smtp.googlemail.com with ESMTPSA id z17sm12239180edi.19.2020.08.10.03.52.44
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 10 Aug 2020 03:52:45 -0700 (PDT)
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
To: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
 <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
 <875zk3t7ji.fsf@HIDDEN>
 <d280700425f27faa160ea920360a5fca26123061.camel@HIDDEN>
 <875zhdh342.fsf@HIDDEN> <c58a57d2-6821-0783-3975-307c3f071a50@HIDDEN>
 <875z9rbog0.fsf@HIDDEN> <86c3f587-094f-eab9-7b09-525a72e74880@HIDDEN>
 <87h7ta93ye.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <e05624ea-6d6b-5ee9-d7ba-899d2efb5455@HIDDEN>
Date: Mon, 10 Aug 2020 13:52:43 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <87h7ta93ye.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36526
Cc: Stefan Kangas <stefan@HIDDEN>, Campbell Barton <ideasman42@HIDDEN>,
 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 10.08.2020 13:43, Lars Ingebrigtsen wrote:
> I haven't tried it -- you seemed to object to adding the patch in
> question saying you had a simpler solution.  Then adding that simpler
> solution to Emacs would be a better idea, but you didn't?

There was no patch.

There was a code dump, which I countered with an alternative, tidier 
code dump. Since no discussion continued from that, I see no point in 
doing the work myself.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 10 Aug 2020 10:43:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 10 06:43:18 2020
Received: from localhost ([127.0.0.1]:34567 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1k55Gw-0004si-OI
	for submit <at> debbugs.gnu.org; Mon, 10 Aug 2020 06:43:18 -0400
Received: from quimby.gnus.org ([95.216.78.240]:46042)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1k55Gu-0004sI-Gb
 for 36526 <at> debbugs.gnu.org; Mon, 10 Aug 2020 06:43:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=7/dusN6HsWkHSQee/tcAOThFPHdU0jzHGZyOSzQsXVs=; b=oBgV+HemNFmf9UQjM3c2G3AZNl
 sK15V5zFfTlVdywAem10RlJUDIrRzQlUJk3t/qQiFr05iEU40V+u52cx2tZnbwsnfdSw6UaR+S+SH
 Ab+mzqSINvuLIzd7WXvZc+9FOIJOmbR2nopEzx0s2XMIbTZjyFiOY4r7+tA0NGZGuUuk=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
 by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1k55Gk-0002w6-OD; Mon, 10 Aug 2020 12:43:09 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
 <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
 <875zk3t7ji.fsf@HIDDEN>
 <d280700425f27faa160ea920360a5fca26123061.camel@HIDDEN>
 <875zhdh342.fsf@HIDDEN>
 <c58a57d2-6821-0783-3975-307c3f071a50@HIDDEN>
 <875z9rbog0.fsf@HIDDEN>
 <86c3f587-094f-eab9-7b09-525a72e74880@HIDDEN>
Date: Mon, 10 Aug 2020 12:43:05 +0200
In-Reply-To: <86c3f587-094f-eab9-7b09-525a72e74880@HIDDEN> (Dmitry Gutov's
 message of "Mon, 10 Aug 2020 00:08:45 +0300")
Message-ID: <87h7ta93ye.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Dmitry Gutov <dgutov@HIDDEN> writes: > On 09.08.2020 22:37,
 Lars Ingebrigtsen wrote: > >> And Dmitry, did you look at moving this feature
 to the core? > > How would I look at it? I didn't even get a confirmation
 that it > satisfies the r [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36526
Cc: Stefan Kangas <stefan@HIDDEN>, Campbell Barton <ideasman42@HIDDEN>,
 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Dmitry Gutov <dgutov@HIDDEN> writes:

> On 09.08.2020 22:37, Lars Ingebrigtsen wrote:
>
>> And Dmitry, did you look at moving this feature to the core?
>
> How would I look at it? I didn't even get a confirmation that it
> satisfies the requested functionality.
>
> But adding it to the core should be easy enough (basically, just copy
> the functions, 40 lines total; with a rename, of course).
>
> If you tried it, and you like it, please feel free to.

I haven't tried it -- you seemed to object to adding the patch in
question saying you had a simpler solution.  Then adding that simpler
solution to Emacs would be a better idea, but you didn't?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 9 Aug 2020 21:08:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 09 17:08:55 2020
Received: from localhost ([127.0.0.1]:33617 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1k4sYp-0000io-J7
	for submit <at> debbugs.gnu.org; Sun, 09 Aug 2020 17:08:55 -0400
Received: from mail-ej1-f43.google.com ([209.85.218.43]:45359)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1k4sYo-0000ia-7k
 for 36526 <at> debbugs.gnu.org; Sun, 09 Aug 2020 17:08:54 -0400
Received: by mail-ej1-f43.google.com with SMTP id c16so7401586ejx.12
 for <36526 <at> debbugs.gnu.org>; Sun, 09 Aug 2020 14:08:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=h8R3xVKli1k/rDLls8xSqgokCQgejjqh8C5Q6ydm0Co=;
 b=dNvjhCHPxL9ovPDxMOdpDTY8u7n1RrtuzwrFaOjE71zIEvb1LJDlrhoMqenMCEWCII
 gRl2ngBu86jUb+C6EuInaU36wgHoTgoG0QkO3dqHKHGG+X4dQKP23/AxH7FPksoZfS30
 6iQkoJybz+puLF6a1c9CWEtYiC+8krZI8/j51h1ZGGXMF5EGHRB2gYiu65a87gvSVfZ4
 /jFo7v7NVCHma27YeeunotCNMUSqHi2z/ooJM3yRcoU9PkrA6rXxhPyrLXFw6yzhhGyB
 yRxWEz8+hxBp7v7/yav/br4u27UfrMMoPLhF/v1jiMCNCPpa4f2j4H3vXn3JA5/Hopwq
 VP5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
 :date:user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=h8R3xVKli1k/rDLls8xSqgokCQgejjqh8C5Q6ydm0Co=;
 b=kDycMxjqHd78KSXhJAtniSCfbHJMSXegjXrMHGp411XBQJ/1GKj/NZ2Lox8WSr6kJW
 hTyVHo9yrDGzBNTRjmxRIg6sb8f845eGljZq/mD8HI9cXb1xrbFhL9hgCv6ZgeZmS2yj
 74HT3PNO5yt+f6QaxRYC/1NjXlMvSLTPAHuNHQ6L5TaHs0WSUyDjiQtye0gRe0DRiFiZ
 Sh3dowZk6IUKX2LORcASilk6LyHTU61wlB8XLysGF+kahITcgfkSB5aL3MO0cC2T3JZT
 offrXuCbLR+cPXqjuFwNFGqBsO7jPXcXNYV6r9u9ZjXytsnMiV2mzzX2Cu3L/aEh7Fki
 Qiyw==
X-Gm-Message-State: AOAM533R5JKehUfGWANOGoIIZGkFc/U0nhqiBcxYD9rjGWt1zMizTa/5
 WD97mVceNTgM5rSW3Sr16pMa79fp
X-Google-Smtp-Source: ABdhPJwPC64hTMTQEXkERaoCA+BdJ6VH+VvbfPiOaWpr1q1CcYge0kDBaOIuOQ41bybG+QSZlSe47w==
X-Received: by 2002:a17:906:ce39:: with SMTP id
 sd25mr19586733ejb.80.1597007328061; 
 Sun, 09 Aug 2020 14:08:48 -0700 (PDT)
Received: from [192.168.0.3] ([66.205.73.129])
 by smtp.googlemail.com with ESMTPSA id w7sm11202175ejy.4.2020.08.09.14.08.46
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 09 Aug 2020 14:08:47 -0700 (PDT)
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
To: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
 <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
 <875zk3t7ji.fsf@HIDDEN>
 <d280700425f27faa160ea920360a5fca26123061.camel@HIDDEN>
 <875zhdh342.fsf@HIDDEN> <c58a57d2-6821-0783-3975-307c3f071a50@HIDDEN>
 <875z9rbog0.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <86c3f587-094f-eab9-7b09-525a72e74880@HIDDEN>
Date: Mon, 10 Aug 2020 00:08:45 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <875z9rbog0.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: -1.5 (-)
X-Debbugs-Envelope-To: 36526
Cc: Stefan Kangas <stefan@HIDDEN>, Campbell Barton <ideasman42@HIDDEN>,
 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.5 (--)

On 09.08.2020 22:37, Lars Ingebrigtsen wrote:

> And Dmitry, did you look at moving this feature to the core?

How would I look at it? I didn't even get a confirmation that it 
satisfies the requested functionality.

But adding it to the core should be easy enough (basically, just copy 
the functions, 40 lines total; with a rename, of course).

If you tried it, and you like it, please feel free to.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 9 Aug 2020 19:37:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 09 15:37:49 2020
Received: from localhost ([127.0.0.1]:33503 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1k4r8e-000658-V3
	for submit <at> debbugs.gnu.org; Sun, 09 Aug 2020 15:37:49 -0400
Received: from quimby.gnus.org ([95.216.78.240]:39314)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1k4r8c-00064q-Kd
 for 36526 <at> debbugs.gnu.org; Sun, 09 Aug 2020 15:37:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=mTu2H3ifygsXkz2I7JutUo32KKkmA+SWzz6VZc8r2NE=; b=vYHDrh3u4/2kQ+9aI0vowEPuEV
 4MkBnRcCQFJutoQBrgNi/BTk8riml0xLFeO0m+ihsG6HTf/QVVBu7Vh3+eJSTXdUC9Jbto1sZ/kf3
 DCdeBvCQUkAKDV1FaA5bbDPJJQN7HWVI0sQTWqjTnaSFfartPoA0h19ejf6YviFB7piQ=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
 by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1k4r8S-0002sj-RP; Sun, 09 Aug 2020 21:37:39 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
 <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
 <875zk3t7ji.fsf@HIDDEN>
 <d280700425f27faa160ea920360a5fca26123061.camel@HIDDEN>
 <875zhdh342.fsf@HIDDEN>
 <c58a57d2-6821-0783-3975-307c3f071a50@HIDDEN>
Date: Sun, 09 Aug 2020 21:37:35 +0200
In-Reply-To: <c58a57d2-6821-0783-3975-307c3f071a50@HIDDEN> (Dmitry Gutov's
 message of "Thu, 16 Jan 2020 01:50:34 +0300")
Message-ID: <875z9rbog0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Dmitry Gutov <dgutov@HIDDEN> writes: > On 15.01.2020 5:20,
 Stefan Kangas wrote: >> I've watched your video,
 and I think it looks interesting.
 I would >> think it useful enough to include, and it certainly helps that
 you >> are willing to do the work to get it done. Unfortunately, [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36526
Cc: Stefan Kangas <stefan@HIDDEN>, Campbell Barton <ideasman42@HIDDEN>,
 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Dmitry Gutov <dgutov@HIDDEN> writes:

> On 15.01.2020 5:20, Stefan Kangas wrote:

>> I've watched your video, and I think it looks interesting.  I would
>> think it useful enough to include, and it certainly helps that you
>> are willing to do the work to get it done.  Unfortunately, I'm not a
>> heavy vc user, so I don't feel fully qualified to comment on this use
>> case.  Could someone else please take a look at this proposal and
>> give Campbell a more informed reply?
>
> Speaking of the "open diff at point" feature, it's very reminiscent of
> the feature in a package of mine: 
> https://github.com/dgutov/diff-hl/blob/fb9eb1cd3c4c6ed24b93de1a7cfb369d2983be74/diff-hl.el#L373-L404
>
> And the implementation is much shorter there. So far, I don't
> understand why.
>
> I would be happy to facilitate moving this feature to the core, but
> for obvious reasons (chiefly ease of review) I'd prefer to to be based
> off my own code. Or to see a good explanation why it's not a good
> choice.
>
> If the implementation in the package above doesn't cut it for some
> reasons, similarly I'd prefer to see a patch against that code rather 
> than a full reimplementation. If feasible, of course.

I had a look at the copyright assignment list, and I couldn't find
Campbell there.  Campbell, didn't anybody send you copyright assignment
papers?

And Dmitry, did you look at moving this feature to the core?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 15 Jan 2020 22:50:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 15 17:50:44 2020
Received: from localhost ([127.0.0.1]:36460 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1irrUp-0006h0-PX
	for submit <at> debbugs.gnu.org; Wed, 15 Jan 2020 17:50:44 -0500
Received: from mail-lj1-f178.google.com ([209.85.208.178]:34579)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1irrUo-0006gn-53
 for 36526 <at> debbugs.gnu.org; Wed, 15 Jan 2020 17:50:43 -0500
Received: by mail-lj1-f178.google.com with SMTP id z22so20433515ljg.1
 for <36526 <at> debbugs.gnu.org>; Wed, 15 Jan 2020 14:50:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=k+ArKV9h8rKRbi9dRukRROBbXnMk7kKaQneftydkRsQ=;
 b=UB3iUg6fCG1ivAtRETuNP3O6l5JyOac3n8zIETlfDctBxrdg2/ZOoVeEwEeRM19ycX
 ZyuhkCeBjFKtYNbTGbZqcW4SNjiswuLE8xAqiBbq5PxtsUvmqi5oxETXIZGbkbHFyUcT
 EFl7ENoGY6w0DcEmrETjUg3iji7h2/rcE/go0xFJJP1/hwl9bd0cQX3a09/iC74RvP1c
 A4v4gCx4uKx4HSoegCQ2ugaKQOiAevVhkgqAbqVO6LFwHWP2xicZY3nUryyegwSVj63j
 Y19u2m5pvYWG1WzGrVqnhqg0GZ/JhE3lLU2op94jYkUzSWB6grao9FD/Tn/on74Vey1L
 7xSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:subject:to:cc:references:from:message-id
 :date:user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=k+ArKV9h8rKRbi9dRukRROBbXnMk7kKaQneftydkRsQ=;
 b=NSVLGBbndAL0aNurGqw+OMyVV9Dy1oLsX2oF2UtzgsAihTNzq7OCWTu1sPZI/M0bGv
 Ot8L8CLOQ++/y4uAHNu1Zh4xtLem+fkEW3qkRAcp0ZLCRxyGlPgoYpNNwaZWgF52E+ef
 QiTmxAAvuO5GSHrcgp0q1a30zp/hMmB+pO/lDL6E9j0NJ9mKRwLbcSC9aTJOB/6oJrkW
 F2n6aLKa2BEQaS/z57FSJwHyCCac7bjkktNwdtw1tTF9kvtj46aIWnF0f6snFqJvJuLC
 vZceCd56VIDQswhIUyRxQXB2Se5gCwQfTWVq+SjnrVgVs1wrv0o1K2OL7XhsvDaY35Ux
 z92Q==
X-Gm-Message-State: APjAAAVT3Jh7p1KFs0O7c0Hry+HiqL0LWjs4lLNhzQGV8nDL6DbwlVjM
 59bDLqe8maGRe3OiP8GizoF+jgeZ2Y0=
X-Google-Smtp-Source: APXvYqwBRsk9gBtwcs8ziCD5l6G0CHr26an77Bq+6BBa9RRGkJclBwsAvgSN5WL1E0HzkQ8KkM9U4Q==
X-Received: by 2002:a2e:880c:: with SMTP id x12mr408533ljh.44.1579128635660;
 Wed, 15 Jan 2020 14:50:35 -0800 (PST)
Received: from [192.168.1.142] ([178.252.127.239])
 by smtp.googlemail.com with ESMTPSA id s22sm9974643ljm.41.2020.01.15.14.50.34
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 15 Jan 2020 14:50:34 -0800 (PST)
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
To: Stefan Kangas <stefan@HIDDEN>, Campbell Barton <ideasman42@HIDDEN>
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
 <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
 <875zk3t7ji.fsf@HIDDEN>
 <d280700425f27faa160ea920360a5fca26123061.camel@HIDDEN>
 <875zhdh342.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
Message-ID: <c58a57d2-6821-0783-3975-307c3f071a50@HIDDEN>
Date: Thu, 16 Jan 2020 01:50:34 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <875zhdh342.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  On 15.01.2020 5:20, Stefan Kangas wrote: > I've watched your
 video, and I think it looks interesting. I would > think it useful enough
 to include, and it certainly helps that you are > willing to do t [...] 
 Content analysis details:   (2.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
 mail domains are different
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (raaahh[at]gmail.com)
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [209.85.208.178 listed in list.dnswl.org]
 1.5 RCVD_IN_SORBS_WEB      RBL: SORBS: sender is an abusable web server
 [178.252.127.239 listed in dnsbl.sorbs.net]
 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
 EnvelopeFrom freemail headers are different
X-Debbugs-Envelope-To: 36526
Cc: 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

On 15.01.2020 5:20, Stefan Kangas wrote:
> I've watched your video, and I think it looks interesting.  I would
> think it useful enough to include, and it certainly helps that you are
> willing to do the work to get it done.
> 
> Unfortunately, I'm not a heavy vc user, so I don't feel fully
> qualified to comment on this use case.
> 
> Could someone else please take a look at this proposal and give
> Campbell a more informed reply?

Speaking of the "open diff at point" feature, it's very reminiscent of 
the feature in a package of mine: 
https://github.com/dgutov/diff-hl/blob/fb9eb1cd3c4c6ed24b93de1a7cfb369d2983be74/diff-hl.el#L373-L404

And the implementation is much shorter there. So far, I don't understand 
why.

I would be happy to facilitate moving this feature to the core, but for 
obvious reasons (chiefly ease of review) I'd prefer to to be based off 
my own code. Or to see a good explanation why it's not a good choice.

If the implementation in the package above doesn't cut it for some 
reasons, similarly I'd prefer to see a patch against that code rather 
than a full reimplementation. If feasible, of course.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 15 Jan 2020 02:20:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 14 21:20:56 2020
Received: from localhost ([127.0.0.1]:34026 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1irYIh-0005Z8-QC
	for submit <at> debbugs.gnu.org; Tue, 14 Jan 2020 21:20:56 -0500
Received: from ted.gofardesign.uk ([67.225.143.91]:51520)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefan@HIDDEN>) id 1irYIf-0005Yo-Qg
 for 36526 <at> debbugs.gnu.org; Tue, 14 Jan 2020 21:20:54 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; 
 s=default;
 h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=XLDm32Q+lPKPVVu/NqMY9BcOFCtGsXFTIjeN8Xi6AA4=; b=igDSTBuPl6rPeD33RlzVivAMLV
 IpLf6diITJiIJ/ETVZPnCkQsi4EuRQiI8XlNl1GKBRwO8todJB1LhtwMvP7W5q8gxf8Tb4GnOpZx7
 drDp23N4TrC6686vZpX+cDtT9izGIjXAQxhEt0LbQBmwIuk/hbS3QpYNug2G0+lj4bpcSSiZgDsM5
 cr/6H9Nl9ztP8a9M5wHG/haAjThuFLbTo3R77D1s/wl1SqPpabT8dS2x5ZPUzVW0Rm/LXPESrfbm/
 f1ufNy1Af9VoZgq+AhVtHmasj9hHKkTdDVg7WFEhxDms/2DkP8rEeeIqXbBtEM9Zk8RqM1G4V4SNg
 iNUMSDyw==;
Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:45698
 helo=localhost)
 by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 (Exim 4.92) (envelope-from <stefan@HIDDEN>)
 id 1irYIZ-001fmX-H1; Tue, 14 Jan 2020 21:20:47 -0500
From: Stefan Kangas <stefan@HIDDEN>
To: Campbell Barton <ideasman42@HIDDEN>
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
In-Reply-To: <d280700425f27faa160ea920360a5fca26123061.camel@HIDDEN>
 (Campbell Barton's message of "Fri, 27 Dec 2019 19:18:15 +1100")
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
 <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
 <875zk3t7ji.fsf@HIDDEN>
 <d280700425f27faa160ea920360a5fca26123061.camel@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
Date: Wed, 15 Jan 2020 03:20:45 +0100
Message-ID: <875zhdh342.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-AntiAbuse: This header was added to track abuse,
 please include it with any abuse report
X-AntiAbuse: Primary Hostname - ted.gofardesign.uk
X-AntiAbuse: Original Domain - debbugs.gnu.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - marxist.se
X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id:
 stefan@HIDDEN
X-Authenticated-Sender: ted.gofardesign.uk: stefan@HIDDEN
X-Source: 
X-Source-Args: 
X-Source-Dir: 
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36526
Cc: 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Campbell Barton <ideasman42@HIDDEN> writes:

> Hi Stefan,
>
> I've updated the Q&A to include the code and a utility function to use
> it:
>
> https://emacs.stackexchange.com/a/51439/2418
>
> Try binding "vc-root-diff-fullscreen-and-jump-to-point" from a key in a
> git repository with local edits, this will open the diff at (or close
> to) the location being edited.
>
> Included example video, showing how this is useful:
>
> https://youtu.be/hbD8WrtWfEg

Campbell Barton <ideasman42@HIDDEN> writes:

> Hi Stefan, my last post didn't get a response so I assumed there wasn't
> much interest here.
>
> I've since made this a package, however a reply on reddit suggests I
> try to get this into emacs source.
>
> If there is interest, I'm happy to create a patch and other steps
> needed to have in added into emacs.  
>
> https://www.reddit.com/r/emacs/comments/efu71g/announce_diffatpoint_now_available_in_melpa/fc4s4im?utm_source=share&utm_medium=web2x

Hi Campbell,

Sorry for the late reply, and thank you for your continued efforts in
pushing for this feature.

I've watched your video, and I think it looks interesting.  I would
think it useful enough to include, and it certainly helps that you are
willing to do the work to get it done.

Unfortunately, I'm not a heavy vc user, so I don't feel fully
qualified to comment on this use case.

Could someone else please take a look at this proposal and give
Campbell a more informed reply?

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 27 Dec 2019 08:25:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 27 03:25:04 2019
Received: from localhost ([127.0.0.1]:56480 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ikkvg-0004uF-Kb
	for submit <at> debbugs.gnu.org; Fri, 27 Dec 2019 03:25:04 -0500
Received: from mail-pf1-f178.google.com ([209.85.210.178]:42187)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ideasman42@HIDDEN>) id 1ikkve-0004ta-Uc
 for 36526 <at> debbugs.gnu.org; Fri, 27 Dec 2019 03:25:03 -0500
Received: by mail-pf1-f178.google.com with SMTP id 4so14414872pfz.9
 for <36526 <at> debbugs.gnu.org>; Fri, 27 Dec 2019 00:25:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :user-agent:mime-version:content-transfer-encoding;
 bh=2xzsO00dcIDNlzlGo/Aa1MZxxl3MCkoRga62gDEc/yU=;
 b=KUdB09Uk7xylbffApUr42XMtfvhR4DDDy2xl8HbYssX8PRpnkpzQxGCu+cvd4AB+Om
 vrDPwY6NIWMjAyY9BGNxk7GEVm6qdd0FGt3pjPXbAXuRKhmJn3L6D823L5z6vFWJUyv0
 xlvtY4PD8GBUfe5lRPdS1jdgaZtwpIaF8x+ebAtOuwDBske784sBEyjI8uq8zxGAh0Mg
 PB9lCWRPXem/RA8SZjbZhg0QYAUUJSEd4RkoAZDyTYBO3tQCEmFJoAX7KFO0s1wFO/Ku
 UnjyvYVEabz/JeGbRGg7NkK6351DwQjRu1BWXrD6VBB62npjiQNMX+AQcfeAcwhAvorV
 DkSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=2xzsO00dcIDNlzlGo/Aa1MZxxl3MCkoRga62gDEc/yU=;
 b=WcmkLnGUIhgQh5+U0OU0tdepnvJwOE8D5T26fqMFESjEmmPcCPIh/JV+U/AaWmYcA8
 3QSLGOYNqnHjyJ8nXud6CrwQ6ktu4MFearhH0m1HIy5vrNUHmuBSgAbZm9VgKzFMrl+s
 vQF7ojFwallQLFJN3hXp8vkeh6NX6tZRP/50eoc+YJVbl3krsKU5ExL+JQHkUG8NZLhT
 cpxLR42xlpcsh3F2wjf2k2RUoEY9Zzud0dBClIG+0nO3lzKArUyT6LMICyi06XmJEV1B
 q+/hY4epDzqDfx7mHnXK3t6npHJrlA2WEpcDk0rAn42NWERmt3LEKO0VhJT7q5t83Xzu
 Zg1A==
X-Gm-Message-State: APjAAAVOWhP+t5A/MfZynZswoEtFI7Obt3bfKUmV612IGivdKQunnosj
 mPI4z0luwhHo3ehWAc8U299TZa3E
X-Google-Smtp-Source: APXvYqwU/QLLHdOZav3IPZknp738R9nYtHF7ZaJ1e9gmGU7ppXIHILwAx5rcFEot/r66O7c/5JUKeg==
X-Received: by 2002:a62:7a43:: with SMTP id v64mr39296011pfc.243.1577435096980; 
 Fri, 27 Dec 2019 00:24:56 -0800 (PST)
Received: from thinkpad ([1.152.255.30])
 by smtp.gmail.com with ESMTPSA id a12sm35617916pga.11.2019.12.27.00.24.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 Dec 2019 00:24:56 -0800 (PST)
Message-ID: <d280700425f27faa160ea920360a5fca26123061.camel@HIDDEN>
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
From: Campbell Barton <ideasman42@HIDDEN>
To: Stefan Kangas <stefan@HIDDEN>
Date: Fri, 27 Dec 2019 19:18:15 +1100
In-Reply-To: <875zk3t7ji.fsf@HIDDEN>
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
 <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
 <875zk3t7ji.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 36526
Cc: 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

On Sat, 2019-11-02 at 02:02 +0100, Stefan Kangas wrote:
> Stefan Kangas <stefan@HIDDEN> writes:
> 
> > > Would someone be able to check the code and see if it's going in
> > > the
> > > right direction?
> > 
> > OK, but see below.
> > 
> > > > > This is a feature suggestion which I've written example code
> > > > > for
> > > > > 
> > > > > `vc-root-diff` (or a new function), could jump to the closest
> > > > > line.
> > > > > 
> > > > > This is useful since you move to the context of the current
> > > > > line.
> > 
> > I'm not sure I understand what this code is supposed to do or how
> > to
> > use it. Could you please give a recipe for how to test it?
> 
> Hi Campbell,
> 
> Just to follow up on this, could you please provide instructions for
> how to test your patch?
> 
> Thanks in advance.
> 
> Best regards,
> Stefan Kangas

Hi Stefan, my last post didn't get a response so I assumed there wasn't
much interest here.

I've since made this a package, however a reply on reddit suggests I
try to get this into emacs source.

If there is interest, I'm happy to create a patch and other steps
needed to have in added into emacs.  

https://www.reddit.com/r/emacs/comments/efu71g/announce_diffatpoint_now_available_in_melpa/fc4s4im?utm_source=share&utm_medium=web2x





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.
Added tag(s) patch. Request was from Stefan Kangas <stefan@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 6 Nov 2019 11:15:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 06 06:15:31 2019
Received: from localhost ([127.0.0.1]:39518 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iSJHf-0006um-8b
	for submit <at> debbugs.gnu.org; Wed, 06 Nov 2019 06:15:31 -0500
Received: from mail-pl1-f181.google.com ([209.85.214.181]:42200)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ideasman42@HIDDEN>) id 1iSJHe-0006uW-8p
 for 36526 <at> debbugs.gnu.org; Wed, 06 Nov 2019 06:15:30 -0500
Received: by mail-pl1-f181.google.com with SMTP id j12so9317112plt.9
 for <36526 <at> debbugs.gnu.org>; Wed, 06 Nov 2019 03:15:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :user-agent:mime-version:content-transfer-encoding;
 bh=3/5mQgrWCPmlaGAhXgZXTmGazxbt71YjtiGoPRp7vE4=;
 b=LqX7IzAs25jhllvEXvkdY/a9HtKUwAqxzA6t7FJiw0wObIVAnoVjwMBIfdNg+TCV5H
 lL996lZedIQ4YsG26FlUMj61qkj79tGsp4s9HM6F97pCgiUX3GPMhzur3dWXNAt22kBf
 8O+Cyen9wzubvSV8UyKkw51awTlwkk6CH2tzfLCed+GVretWQxuAhF7eKnGNs0KWhEbO
 IF6KhDF3eWEMqXLrsJ6oKlyfeaPjKPXLScRRRWaIPWmCiLx2iaY4iSqfOP7yu4da+VL/
 YuNymk3RuwyikmZFsTYgGe7/PFIWKEVBTpWScJCLjaX3FGnHUXlxPPeKS8CY9k6rbhC9
 L/BA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:user-agent:mime-version:content-transfer-encoding;
 bh=3/5mQgrWCPmlaGAhXgZXTmGazxbt71YjtiGoPRp7vE4=;
 b=MWoxtw9UcNNp8DNwjI0E3Q2UqNXyEX7V1/8mWDoBhxn6iSScnZSqvvKW33PBMoYCrZ
 JsWEk4Ko1s7enlVXuyoxfpgvoDptpdahbCRSpD3uc572OIxEcr3ZvddmVwR1kYTGCHbM
 eQuvJny3444gQGckN5tftAM3VwaFPocw7rJqlxQ8qaYRVsLgNrSG8GYSa+VTx9IQ80aU
 rgP9eqdyGtPCqxw5vghBBjBthKRlGHN33h6xXH7XWzO6FZCPDTbna+3tPDmauj3F2SNs
 SC1AblHrZVofKuFc6PnRb5ypwFKKkzo/G3VNs1Q5jrmXPvtvVmpn6kXDTsJfYx/raTk3
 tQaA==
X-Gm-Message-State: APjAAAX8AvmZvqHeAgjAP11MzWtDlqQQ4eN+Cw3BHX3WYgfL1xIFCsAm
 jvkNFXAIaTZeQvw53Ph9sq17xnr/pDk=
X-Google-Smtp-Source: APXvYqxrn204WgjRSMFFea9x+Uwrt+gWG5JU/p5BECBtmJbxxdo95T3k4rTNN8ZM/vTUCOPOYrya3Q==
X-Received: by 2002:a17:902:788d:: with SMTP id
 q13mr2103398pll.41.1573038923394; 
 Wed, 06 Nov 2019 03:15:23 -0800 (PST)
Received: from austpc (ppp118-209-113-225.bras1.mel11.internode.on.net.
 [118.209.113.225])
 by smtp.gmail.com with ESMTPSA id q13sm2849392pjq.0.2019.11.06.03.15.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 06 Nov 2019 03:15:22 -0800 (PST)
Message-ID: <d262115750bad51fd94d27fff594c5d52967649c.camel@HIDDEN>
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
From: Campbell Barton <ideasman42@HIDDEN>
To: Stefan Kangas <stefan@HIDDEN>
Date: Wed, 06 Nov 2019 22:15:19 +1100
In-Reply-To: <875zk3t7ji.fsf@HIDDEN>
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
 <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
 <875zk3t7ji.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 36526
Cc: 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

On Sat, 2019-11-02 at 02:02 +0100, Stefan Kangas wrote:
> Stefan Kangas <stefan@HIDDEN> writes:
> 
> >> Would someone be able to check the code and see if it's going in
> the
> >> right direction?
> >
> > OK, but see below.
> >
> >> >> This is a feature suggestion which I've written example code
> for
> >> >>
> >> >> `vc-root-diff` (or a new function), could jump to the closest
> line.
> >> >>
> >> >> This is useful since you move to the context of the current
> line.
> >
> > I'm not sure I understand what this code is supposed to do or how
> to
> > use it. Could you please give a recipe for how to test it?
> 
> Hi Campbell,
> 
> Just to follow up on this, could you please provide instructions for
> how to test your patch?
> 
> Thanks in advance.
> 
> Best regards,
> Stefan Kangas


Hi Stefan,

I've updated the Q&A to include the code and a utility function to use
it:

https://emacs.stackexchange.com/a/51439/2418

Try binding "vc-root-diff-fullscreen-and-jump-to-point" from a key in a
git repository with local edits, this will open the diff at (or close
to) the location being edited.

Included example video, showing how this is useful:

https://youtu.be/hbD8WrtWfEg





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 2 Nov 2019 01:02:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 01 21:02:19 2019
Received: from localhost ([127.0.0.1]:57691 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iQho3-0004gN-11
	for submit <at> debbugs.gnu.org; Fri, 01 Nov 2019 21:02:19 -0400
Received: from host.gofardesign.uk ([208.79.239.190]:49971)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefan@HIDDEN>) id 1iQho1-0004aO-8S
 for 36526 <at> debbugs.gnu.org; Fri, 01 Nov 2019 21:02:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; 
 s=default;
 h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=1MAnpDVEhDMCfcMM6Vjw8R3NowI5yLBvqMNymn1muek=; b=XK/x0O0KUwa+C6ZttrSs3gYqYO
 0ljzZxFSS/i7ZrDbWLNnsyWckqVSB39yWqmVeTWPq1xJDYjTmnwZ07TIo++zqfVNj6urRhiW8crTz
 FGQIwT0o5dgzb4LJsD2hoG3Db6bCjpFr94B8VaJusU9g5Fu0ejjnlJYbyxlsVWpMHsi4=;
Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:52410
 helo=localhost)
 by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 (Exim 4.92) (envelope-from <stefan@HIDDEN>)
 id 1iQhnv-0006rZ-EK; Fri, 01 Nov 2019 20:02:11 -0500
From: Stefan Kangas <stefan@HIDDEN>
To: Cambell Barton <ideasman42@HIDDEN>
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
In-Reply-To: <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
 (Stefan Kangas's message of "Sun, 15 Sep 2019 16:52:18 +0200")
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
 <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Date: Sat, 02 Nov 2019 02:02:09 +0100
Message-ID: <875zk3t7ji.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-OutGoing-Spam-Status: No, score=-1.0
X-AntiAbuse: This header was added to track abuse,
 please include it with any abuse report
X-AntiAbuse: Primary Hostname - host.gofardesign.uk
X-AntiAbuse: Original Domain - debbugs.gnu.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - marxist.se
X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id:
 stefan@HIDDEN
X-Authenticated-Sender: host.gofardesign.uk: stefan@HIDDEN
X-Source: 
X-Source-Args: 
X-Source-Dir: 
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 36526
Cc: 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Kangas <stefan@HIDDEN> writes:

>> Would someone be able to check the code and see if it's going in the
>> right direction?
>
> OK, but see below.
>
>> >> This is a feature suggestion which I've written example code for
>> >>
>> >> `vc-root-diff` (or a new function), could jump to the closest line.
>> >>
>> >> This is useful since you move to the context of the current line.
>
> I'm not sure I understand what this code is supposed to do or how to
> use it. Could you please give a recipe for how to test it?

Hi Campbell,

Just to follow up on this, could you please provide instructions for
how to test your patch?

Thanks in advance.

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.
Added tag(s) moreinfo. Request was from Stefan Kangas <stefan@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 15 Sep 2019 14:52:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 15 10:52:38 2019
Received: from localhost ([127.0.0.1]:48594 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i9VtG-0003AT-Cw
	for submit <at> debbugs.gnu.org; Sun, 15 Sep 2019 10:52:38 -0400
Received: from mail-pf1-f180.google.com ([209.85.210.180]:37658)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1i9VtD-0003AF-CP
 for 36526 <at> debbugs.gnu.org; Sun, 15 Sep 2019 10:52:36 -0400
Received: by mail-pf1-f180.google.com with SMTP id y5so18202843pfo.4
 for <36526 <at> debbugs.gnu.org>; Sun, 15 Sep 2019 07:52:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=f5bgzRR3zY07SrkhC3TPojFXANQ7sEN84zOT/OgT4WE=;
 b=cJTNLmvgmR6bEsqWfWvzqRlRdZaAYIOpLqlgSY7Cg6I8dGNxHc0eazceCtn2FqX3Vj
 zkcIu55pkJG7lm8hSz/gy1oZeiqeRJ0PP9UkbREv42M+G7BRUvuzGByEmqo0KpmQhkPU
 zkrF6LnXzMkAH0HZeGJ/2ab6jAmN+0PfNy6dyJr6PwVr5s/GwXtCGsrPyLncwU6Ri4eO
 6yCtND9V4wbieZYme7ozJb7WxbahZYzyJWWezbUOOInQIeiKS/m7NTdm6D4Jn+UCeIem
 +AI2K+i3CLXfSsVSCKWDxNVCX7+G40GlZ+SvGLy6K9bLB6bcpIuFYGwrF4xaWFnj6/Mo
 +Bvg==
X-Gm-Message-State: APjAAAWqKvKHinIrAuSvFSrjpYyR5kbZ4LnDd+x0t5BTvvfEklpBd+vB
 /cA8pJt+oVfID2bQLK7G21yHwbDtmAPQ4J0s9/g=
X-Google-Smtp-Source: APXvYqxc7N1LRCYMD+gjrYa41c3gHpLKg14PyRxUXXF1daV5uFuoQjRHtkDxJd3BznAk5vGiCGdiYYQT9CMaTdrmqW4=
X-Received: by 2002:a62:15c7:: with SMTP id 190mr65606864pfv.107.1568559149415; 
 Sun, 15 Sep 2019 07:52:29 -0700 (PDT)
MIME-Version: 1.0
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
 <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
In-Reply-To: <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
From: Stefan Kangas <stefan@HIDDEN>
Date: Sun, 15 Sep 2019 16:52:18 +0200
Message-ID: <CADwFkmm8=34bDsjD_EW+0MZZwFGCQjgib4WP-eCWgXeX0eFraA@HIDDEN>
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
To: Cambell Barton <ideasman42@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 36526
Cc: 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Cambell Barton <ideasman42@HIDDEN> writes:

> Hi Stefan, I don't mind doing the copyright assignment.

Excellent.

> Would someone be able to check the code and see if it's going in the
> right direction?

OK, but see below.

> >> This is a feature suggestion which I've written example code for
> >>
> >> `vc-root-diff` (or a new function), could jump to the closest line.
> >>
> >> This is useful since you move to the context of the current line.

I'm not sure I understand what this code is supposed to do or how to
use it. Could you please give a recipe for how to test it?

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 13 Sep 2019 19:29:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 13 15:29:32 2019
Received: from localhost ([127.0.0.1]:45619 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i8rG8-0003P3-Dn
	for submit <at> debbugs.gnu.org; Fri, 13 Sep 2019 15:29:32 -0400
Received: from mail-pg1-f178.google.com ([209.85.215.178]:37717)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ideasman42@HIDDEN>) id 1i8rG6-0003Ok-6B
 for 36526 <at> debbugs.gnu.org; Fri, 13 Sep 2019 15:29:31 -0400
Received: by mail-pg1-f178.google.com with SMTP id c17so7990057pgg.4
 for <36526 <at> debbugs.gnu.org>; Fri, 13 Sep 2019 12:29:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=Xc6zzzKEv1bxRapOpzLqdxDx5N5PSMb5fuu43lYA0q0=;
 b=SN5FvzYVzLiLUotJ6HO4kShdy2S8GT/2JXVH2wpuT7QcOJo0vjmefUrzchndotpe7w
 lYedxm2TPTW+l5D4/rrr/5hnTYiflhJdPRzL//YtA+jQTaHlumngU/QOt32Ulvv/iVSh
 RsO5+Ugd04EYghcq8dND9+EVVcaBa4Tn+Lo6AreJuZY1DhMM+/1iOmqjVpKxq7J3FOiF
 cDlBVeKL+2/+4oXCT/CUbynQTWPGkyubgQG/xA4bwMhqkG3Ky0ljc/Qfn3u4+XIxjK3X
 hHTAj7kxK3rgSdfBWUsPvlSSvuUJiAQ9MK2zFybePSHkXynmQVPOzfGTmUkMBXBop5tB
 WWsw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=Xc6zzzKEv1bxRapOpzLqdxDx5N5PSMb5fuu43lYA0q0=;
 b=RQH78d3hd2ARWbAYA7VoIyyuroQRJtC/c+OseJiYv+8TRGCDr3xHJJRuGbb+vhB0uH
 l0HdzIfhcv0X00dV0zrfidqKBhICm/ZWVauuMIcnMhJPGfR2grfFVJoe8XmlfG6MQDk6
 IS+l+w0djiydPpMfImKcRy69S0FUUgQFieBpuip0w2UgPCYvYTCEbugskjBy2fJ4E9A9
 bJKwsvu4sX99GdGnPrVjRsuUtZIOyyLubUkfqFi5DY/Xsoi6ugNlc7DJDyUSpaSt31Ku
 AYNRuEo3yx9BFFpoPxNLiDFq/3CCokxeV8dO1AiKCemdUBa69cqxx/wUX2/EKghTE3lM
 EKRg==
X-Gm-Message-State: APjAAAW0FuHBhvv5ei884Zjj0bjparZml1hEdW0elLbl5GsfBgzNAV2m
 YR6MheY/ZR5Llv9oRxaJE87KSGVu9TY=
X-Google-Smtp-Source: APXvYqwVRZA8TonR7Ueq63Au9eRfi2inpjYMW5FJO6EFg+cIoYNqqR1O13UBogAIcXaDd3TcFTY0fg==
X-Received: by 2002:a63:465c:: with SMTP id v28mr1363387pgk.310.1568402964057; 
 Fri, 13 Sep 2019 12:29:24 -0700 (PDT)
Received: from [10.1.1.180] (ppp118-209-104-247.bras1.mel11.internode.on.net.
 [118.209.104.247])
 by smtp.gmail.com with ESMTPSA id w6sm57603822pfj.17.2019.09.13.12.29.22
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 13 Sep 2019 12:29:23 -0700 (PDT)
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
To: Stefan Kangas <stefan@HIDDEN>
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
 <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
From: Cambell Barton <ideasman42@HIDDEN>
Message-ID: <35d4b535-1e93-ef31-ca63-044721c1314f@HIDDEN>
Date: Sat, 14 Sep 2019 05:29:20 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.0
MIME-Version: 1.0
In-Reply-To: <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 36526
Cc: 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Hi Stefan, I don't mind doing the copyright assignment.

Would someone be able to check the code and see if it's going in the 
right direction?

I'm still not that experienced with elisp, so I'd rather not spend time 
to make a patch if the general approach isn't right.

On 2019-09-13 21:59, Stefan Kangas wrote:
> Campbell Barton <ideasman42@HIDDEN> writes:
> 
>> This is a feature suggestion which I've written example code for
>>
>> `vc-root-diff` (or a new function), could jump to the closest line.
>>
>> This is useful since you move to the context of the current line.
>>
>> I've written code that does this,
>> it would be useful if it was built into emacs.
>>
>> See: https://emacs.stackexchange.com/a/51439/2418
> 
> Thanks for the feature suggestion.
> 
> I haven't looked at your code, but if we decided to use it, it seems
> like a non-trivial change and would require you to sign copyright
> papers.  You can find more information about copyright assignment
> here:
> 
> https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html
> 
> Would you be willing to do that?
> 
> If the answer to that is yes, could you please also submit your code
> as a patch?  You can find more information on how to do that in the
> CONTRIBUTE file in the emacs repository.  That would make it easier to
> review and test your suggested changes.
> 
> Best regards,
> Stefan Kangas
> 




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at 36526 <at> debbugs.gnu.org:


Received: (at 36526) by debbugs.gnu.org; 13 Sep 2019 11:59:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 13 07:59:44 2019
Received: from localhost ([127.0.0.1]:44473 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i8kEq-00087C-6s
	for submit <at> debbugs.gnu.org; Fri, 13 Sep 2019 07:59:44 -0400
Received: from mail-pg1-f173.google.com ([209.85.215.173]:42887)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1i8kEo-00086z-7V
 for 36526 <at> debbugs.gnu.org; Fri, 13 Sep 2019 07:59:42 -0400
Received: by mail-pg1-f173.google.com with SMTP id z12so3585697pgp.9
 for <36526 <at> debbugs.gnu.org>; Fri, 13 Sep 2019 04:59:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=IS/cu65GjBmlthRCj682hwlb4zw65Qv5OGN+p8SYiSg=;
 b=BAqRs35gXMtV9M2wVceQ1ry9Ofcvx5/xES8hjAt3ofARb7NQw6NUqBz0h/KfLT18Sg
 nNcf9LdxUpAOCkWd7UJfegLi8YHh8P2vY9I4shCRZzQ1cPRmIojVmthSOTAOQvs6UXm3
 /YllCKiVUPWse5T2jiLJuIxy+5ZEzKSnBw376s92pwb2d/39quCouWeE5qpDzb/aV4MQ
 /LtABR6lMwRb8tYU2wAcJN6nLo66075eyYcV9Rfgx6DaOdObyNx0XoB6NzmeOPRkEKLL
 vLjZLjXXS0FVFZoOCOXatRweSDiboZP0ExYgUuf3l6ah24vzpCy9hsEXXgzC7WXO1rrX
 TQpQ==
X-Gm-Message-State: APjAAAXVT8587NJc5iLIxsz5HPBb1qTU9gm8qp9n8fjWHCpCMzAvaJY7
 Tx+wISx53x+C7hAbsAMo/2JpmI9TUrZBEE9lsGA=
X-Google-Smtp-Source: APXvYqyr9meya6ckOU2CYPCjc3+ZSkROFxga8kvtfDP0Fhdy75gipHQUxBTEvDKFDC5bfinncBhlLR9HBSyLj1/UFvc=
X-Received: by 2002:a63:ef4d:: with SMTP id c13mr6783377pgk.200.1568375976278; 
 Fri, 13 Sep 2019 04:59:36 -0700 (PDT)
MIME-Version: 1.0
References: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
In-Reply-To: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
From: Stefan Kangas <stefan@HIDDEN>
Date: Fri, 13 Sep 2019 13:59:25 +0200
Message-ID: <CADwFkmnHCsvpRw4hqGngojo-hBDhNBBk-jeNa1=FsqZTGTB4Kg@HIDDEN>
Subject: Re: bug#36526: 26.2; Open diff at current location (feature request
 with suggested code)
To: Campbell Barton <ideasman42@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 36526
Cc: 36526 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Campbell Barton <ideasman42@HIDDEN> writes:

> This is a feature suggestion which I've written example code for
>
> `vc-root-diff` (or a new function), could jump to the closest line.
>
> This is useful since you move to the context of the current line.
>
> I've written code that does this,
> it would be useful if it was built into emacs.
>
> See: https://emacs.stackexchange.com/a/51439/2418

Thanks for the feature suggestion.

I haven't looked at your code, but if we decided to use it, it seems
like a non-trivial change and would require you to sign copyright
papers.  You can find more information about copyright assignment
here:

https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html

Would you be willing to do that?

If the answer to that is yes, could you please also submit your code
as a patch?  You can find more information on how to do that in the
CONTRIBUTE file in the emacs repository.  That would make it easier to
review and test your suggested changes.

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 6 Jul 2019 13:08:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 06 09:08:40 2019
Received: from localhost ([127.0.0.1]:54388 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hjkQi-0006JP-Ag
	for submit <at> debbugs.gnu.org; Sat, 06 Jul 2019 09:08:40 -0400
Received: from lists.gnu.org ([209.51.188.17]:58059)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ideasman42@HIDDEN>) id 1hjkQh-0006JI-8J
 for submit <at> debbugs.gnu.org; Sat, 06 Jul 2019 09:08:39 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:50940)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <ideasman42@HIDDEN>) id 1hjkQg-0006oT-8c
 for bug-gnu-emacs@HIDDEN; Sat, 06 Jul 2019 09:08:39 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: *
X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50,
 FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,URIBL_BLOCKED autolearn=disabled
 version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ideasman42@HIDDEN>) id 1hjkQf-0000vN-CO
 for bug-gnu-emacs@HIDDEN; Sat, 06 Jul 2019 09:08:38 -0400
Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:45397)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <ideasman42@HIDDEN>)
 id 1hjkQf-0000ui-89
 for bug-gnu-emacs@HIDDEN; Sat, 06 Jul 2019 09:08:37 -0400
Received: by mail-qk1-x72f.google.com with SMTP id s22so9852696qkj.12
 for <bug-gnu-emacs@HIDDEN>; Sat, 06 Jul 2019 06:08:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to;
 bh=HQU2uLK0v66rOyp0FOCQjZOeFzbAbQu6NrhvsZH4o+Q=;
 b=VnYGUZoUz9Yqo3b82LISNYokDdtXW5kB8CiMbw+JB0JA6dbBY3oWnLighNE9j9LbF/
 lBz/ffb0mGU1z/Rmd6+s1nmxzyjtG+5pnTeKPdyUG1lGV9vpH3df85VCBut+CpQJYQXw
 qFr7t44RKpVEQFfCMTAgmxGZ668NCwBxDfUO2Uo9u6AHpFkXacNUcsyeGFzS0CTloo8Z
 LoI7mbAzy9oWQNfMSOFBSblHFZburHMGhl262XdoiCi1e4g/eaSivb2cWQsrkFwO86vz
 5Ak/AFhFog1BvFnTs0VuIPd76Gn2TfmbdT+jmX9SuVeVnblu0RAqswhl28op8PfO/z5j
 Kxtw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=HQU2uLK0v66rOyp0FOCQjZOeFzbAbQu6NrhvsZH4o+Q=;
 b=QdqdF9bIxENMg7TJ44owLmOTIN+iZhL3AgJbvWDhsyPWs1vQgP18xTNLs7U7Wc+qjB
 qbWtLs7YhiQHQh0k2wbI6ZOTU+5PA6DwCWN0/BafTJfPYww7Z5MuCLoNiUwUP+4YtB/P
 2mwimC2eX0ULSxHyVU1HufYnjuAchZh+26ekk15XLv5k0wE8asledToIqBvt5oeUlcjr
 yUrN8N4RrqF1tA75NzbRXn63JDajdn3hRGCLxpLtG3vhTNv/aiHQDnkApn1RXr1fxAi7
 8zS8DaJVj6mX09B5hv/UD2WWdw8NeE5bW3poM8sQuoGNSc/lahSjTQqLCN9BQSitXvAy
 Vlzw==
X-Gm-Message-State: APjAAAWpXs4xFPD6e81RSpc/gfe+8JK7udJUhNmr5lAQbQ9kZ8LdcYdT
 VIkp4U6XuLsAfabmf4EhgRroG3i9d1J8XcxCui2MUc/H
X-Google-Smtp-Source: APXvYqzitPSJqq18tk32LoOSFlJkoJxNFejv2b9cEiYatyPueZYGlvDNfNLT1cksEUIy9OqafjKBLj+Yaz3oHbmXrek=
X-Received: by 2002:a37:795:: with SMTP id 143mr7086997qkh.140.1562418515813; 
 Sat, 06 Jul 2019 06:08:35 -0700 (PDT)
MIME-Version: 1.0
From: Campbell Barton <ideasman42@HIDDEN>
Date: Sat, 6 Jul 2019 23:08:24 +1000
Message-ID: <CAEcf3Nw-OneSEN+tPdAybnu4erwMcuTZX9rq1+rOwdqY9SOMuw@HIDDEN>
Subject: 26.2;
 Open diff at current location (feature request with suggested code)
To: bug-gnu-emacs@HIDDEN
Content-Type: text/plain; charset="UTF-8"
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-Received-From: 2607:f8b0:4864:20::72f
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

This is a feature suggestion which I've written example code for

`vc-root-diff` (or a new function), could jump to the closest line.

This is useful since you move to the context of the current line.

I've written code that does this,
it would be useful if it was built into emacs.

See: https://emacs.stackexchange.com/a/51439/2418

In GNU Emacs 26.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.8)




Acknowledgement sent to Campbell Barton <ideasman42@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#36526; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 22 Jan 2021 18:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.